Re: Issue 1322 in reviewboard: Post-review is ignorant of many files brought in via svn merge.

2012-12-03 Thread reviewboard


Comment #2 on issue 1322 by mvanb...@gmail.com: Post-review is ignorant of  
many files brought in via svn merge.

http://code.google.com/p/reviewboard/issues/detail?id=1322

This can be fixed by running the following on all added files:
svn revert added_file
svn add added_file

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1322 in reviewboard: Post-review is ignorant of many files brought in via svn merge.

2009-09-18 Thread codesite-noreply

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1322 by josh.hamacher: Post-review is ignorant of many files  
brought in via svn merge.
http://code.google.com/p/reviewboard/issues/detail?id=1322

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0

What's the URL of the page containing the problem?
None; this is a post-review problem.

What steps will reproduce the problem?
1. Use 'svn merge' to bring in changes from a different branch to the
working copy.  In this case, the other branch should have had many files
added compared to the working copy.
2. Run 'svn status' and see how many files are opened.
3. Run 'svn diff' and see a significantly smaller number of files.
4. Since post-review only uses the output of 'svn diff', many files don't
appear as part of the review.

What is the expected output? What do you see instead?
'svn diff' (and therefore post-review) only picks up files that have
changed due to the merge; it seems to skip over files that are created
locally.  Since the addition of files is a significant change to a code
tree, I'd argue that all of the new files should be visible for review
(even if they were reviewed earlier in their original location).

What operating system are you using? What browser?
Shouldn't matter, but I have Red Hat Enterprise Linux 3 on my workstation.

Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---