Re: Issue 2116 in reviewboard: search should support the diffs themselves
Comment #3 on issue 2116 by vlov...@gmail.com: search should support the diffs themselves http://code.google.com/p/reviewboard/issues/detail?id=2116 I would love this feature too. The e-mails do not include the diffs ( would be annoying large if they did) so gmail doesn't have it indexed. Being able to search for diff content in particular would be super-useful (the rest is indexed in e-mail but we should be able to search those in reviewboard too as it's more convenient). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2116 in reviewboard: search should support the diffs themselves
Updates: Labels: Component-Search Comment #2 on issue 2116 by trowb...@gmail.com: search should support the diffs themselves http://code.google.com/p/reviewboard/issues/detail?id=2116 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2116 in reviewboard: search should support the diffs themselves
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2116 by eri...@gmail.com: search should support the diffs themselves http://code.google.com/p/reviewboard/issues/detail?id=2116 What version are you running? 1.5.2 Describe the enhancement and the motivation for it. The search feature is much less useful to me than I had hoped it would be, since it does not index the diff files associated with a review, nor the comments people have made on the reviews. In our use case we only ever have 1 diff file (we do post-commit review), so the indexing is only on the order of the number of review requests, not a multiple of the diff-iterations per review request. After spending 1.5 hours manually installing JCC, PyLucene, etc. on Ubuntu to get what I hoped would be an awesome feature, this is a bit frustrating... What operating system are you using? Ubuntu 9.04 Please provide any additional information below. Notably, searching diffs comments were 2 of the 4 requirements of the original feature request for adding search: http://code.google.com/p/reviewboard/issues/detail?id=216 Where the submitter stated: Anyway, I think it'd definitely be useful to allow searching at least: - titles - descriptions - diffs - comments I could not find any bug tracking these 2 missing search targets, so that's why this bug was filed. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2116 in reviewboard: search should support the diffs themselves
Comment #1 on issue 2116 by eri...@gmail.com: search should support the diffs themselves http://code.google.com/p/reviewboard/issues/detail?id=2116 Another note on the extent of the usefulness of the existing search feature: We use google apps for our email, and each review request generates an email that contains the items that are currently indexed by the in-built reviewboard search. So I can already do all the searching that reviewboard supports in my email itself. Plus more, since any review responses are in my email as well, so I can see those in the search. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
