Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #9 on issue 2889 by shirph...@126.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 I have the same issue, reviewboard 1.7.25, IE 8, How can i resolve it now? what the means with: Fixed in djblets master (b784ab8). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #10 on issue 2889 by shirph...@126.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 I have upgrade to Djblets 0.7.29, but the error is not resolved. Thank your help again -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #7 on issue 2889 by trowb...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Updates: Status: Fixed Comment #8 on issue 2889 by trowb...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 Fixed in djblets master (b784ab8). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #6 on issue 2889 by rajas...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 It looks like IE8 attempts to download the file when the mimetype is application/json and that is what the server is sending. There are many posts in StackOverflow around this and the answer seems to be send text/plain instead of application/json if its IE8 and everything is good. The other option is to include a X-Content-Type-Options: nosniff which instructs not to sniff the mimetype and serve the file as is. (Reference: http://security.stackexchange.com/questions/7506/using-file-extension-and-mime-type-as-output-by-file-i-b-combination-to-dete/7531#7531, Item 4 in the Defenses section in that post). Since IE is the only one to allow X-Content-Type-Options, can we include this in the WebApiResponse. I already see a block in WebApiResponse to convert mimetype to 'text/plain' if its not an ajax and there are uploads, but since this is an AJAX call, it wouldnt pass through this block ? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #4 on issue 2889 by khanh...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 Not only this happens to update diff, it happens to upload file too. Can we have an update on when will this bug be fixed? Thanks -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #5 on issue 2889 by chip...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 No idea. We dropped support for IE8 in 1.7.x, but I'd be completely open to taking patches. Older versions of IE behave in some strange ways at times when it comes to certain AJAX calls with file uploads. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #3 on issue 2889 by kevin.zh...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 Me too, after upgrading to 1.7.6, we also encounter this issue sometimes. is there any way to work around it? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2889 in reviewboard: Cannot update diff using IE8
Comment #2 on issue 2889 by trowb...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 Issue 2926 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2889 in reviewboard: Cannot update diff using IE8
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2889 by vour...@gmail.com: Cannot update diff using IE8 http://code.google.com/p/reviewboard/issues/detail?id=2889 What version are you running? 1.7.4 What's the URL of the page containing the problem? /reviewboard/r/review num/ What steps will reproduce the problem? 1. Create review, upload diff 2. Try to update diff Expected result: Diff is updated Actual result: Download file dialog appears. Looks like, IE offers to download a JSON response. Diff file is not updated in review. What operating system are you using? What browser? Windows 7, IE8. Not reproducible with Google Chrome browser and IE9/10. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
