Re: Issue 3253 in reviewboard: post-review without US locale fails

2014-02-19 Thread reviewboard


Comment #6 on issue 3253 by kenny.ma...@gmail.com: post-review without US  
locale fails

http://code.google.com/p/reviewboard/issues/detail?id=3253

Awesome. Thank you!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3253 in reviewboard: post-review without US locale fails

2014-02-18 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3253 by kenny.ma...@gmail.com: post-review without US locale fails
http://code.google.com/p/reviewboard/issues/detail?id=3253

What version are you running?
0.5.3

What's the URL of the page containing the problem?
post-review --server=SERVER --output-diff

What steps will reproduce the problem?
1. Setup system with en_CA.UTF-8 UTF-8 (no en_US.UTF-8)
2. Setup /etc/locale.conf with LANG=en_CA.UTF-8
2.1. Optionally set LANGUAGE=en_CA.UTF-8 as well
3. Attempt to post a review.

What is the expected output?
Successful post

What do you see instead?

The generated diff file was empty. This usually means no files were
modified in this change.

What operating system are you using? What browser?

Arch Linux

Please provide any additional information below.

When you add --output-diff the following is included:

--- __FILENAME__(revision perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = en_US.UTF-8,
LC_ALL = en_US.UTF-8,
LANG = en_CA.UTF-8
are supported and installed on your system.
perl: warning: Falling back to the standard locale (C).
sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
6441)

'perl -e exit' works fine. Tried with and without LANGUAGE set.

Only workaround was to add the en_US.UTF-8 locale to my system.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3253 in reviewboard: post-review without US locale fails

2014-02-18 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3253 by trowb...@gmail.com: post-review without US  
locale fails

http://code.google.com/p/reviewboard/issues/detail?id=3253

What version control system are you using?

Can you run with --debug and attach the output?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3253 in reviewboard: post-review without US locale fails

2014-02-18 Thread reviewboard


Comment #3 on issue 3253 by kenny.ma...@gmail.com: post-review without US  
locale fails

http://code.google.com/p/reviewboard/issues/detail?id=3253

Debug log attached.

I'm using git-svn (git local, svn backend). As you can see the diff is not  
actually empty, it's just not in proper diff format due to the tool not  
being able to figure out the initial revision.


Attachments:
debug.log  3.7 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3253 in reviewboard: post-review without US locale fails

2014-02-18 Thread reviewboard

Updates:
Status: Started
Owner: trowb...@gmail.com

Comment #4 on issue 3253 by trowb...@gmail.com: post-review without US  
locale fails

http://code.google.com/p/reviewboard/issues/detail?id=3253

Thanks for the info. We'll get this fixed soon.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3253 in reviewboard: post-review without US locale fails

2014-02-18 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 3253 by trowb...@gmail.com: post-review without US  
locale fails

http://code.google.com/p/reviewboard/issues/detail?id=3253

Fixed in release-0.5.x (7bf376c). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.