Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Status:
- PendingReview
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200818201859.15397.93545%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Keith Kelly]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

My employer's "get off of Python 2.7" initiative is still blocked by the 
inability of the latest publicly-available version of rbtools to work under 
Python 3.7.3.  When will a new public release finally be issued so that we can 
safely pick up the fix for this?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20191107191436.4961.15879%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

Yep, we have a mailing list where we announce all new releases (or other 
important updates). It's fairly low-traffic -- we try not to waste your time. 
https://www.reviewboard.org/mailing-lists/

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190822232856.2634.47866%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Keith Kelly]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

Awesome chipx86, thank you!  Is there a way I can be notified when the next 
release (containing this fix) is officially available?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190822002620.3380.8481%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

Fix is up for review: https://reviews.reviewboard.org/r/10666/

Dan, I'm also curious if you already applied the previous patch that was 
referenced. This is part 2 of a fix.


Status:
- Confirmed
+ PendingReview

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190821102943.3384.4853%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

(+ debug log)

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190821101914.3384.80016%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

@dan_regan, I'm interested in what issue you're seeing exactly, because the 
patch (well, a variation on the concept) _does_ fix the issue here. Can you 
provide a full backtrace?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190821101902.3380.88142%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

I'm sorry, this fell through the cracks. This will be fixed in the next 
release of RBTools, alongside other Python 3.x fixes.


Status:
- NeedInfo
+ Confirmed


Milestones:
+ Release-1.0.x


Tags:
- Priority:Medium
+ Priority:High
+ SCM:Perforce


Assigned to:
+ chipx86

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190821095509.3383.86495%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Keith Kelly]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

This issue has been tagged "NeedInfo" for a long time now.  What additional 
information is actually needed?  You should have all the information you need 
to repro this and work on fixing it.  This is blocking Python migration work at 
my company because we can't remove obsolete versions of Python from our 
engineering workstations due to `rbt` still not working correctly with the 
latest version of Python.  Please treat this issue as ultra-high priority, 
especially given the impending Python 2.7.x end-of-life date rapidly 
approaching on 1/1/2020.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190820174941.8159.23388%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Jose Angel Soler Ortiz]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

I am also getting this issue on CentOS. I am using RBTools 1.0.2, Python 
3.6.8 and p4 P4/LINUX26X86_64/2019.1/1813586 (2019/06/06). I debugged the issue 
and found out that p4 -G is generating Python dictionaries that contain byte 
literals instead of regular strings. I patched RBTools to convert all of these 
byte literals to strings before they are used, and I managed to make it work. 
The patch is just a workaround, but it's attached to this comment in case it 
can provide any insight.


Files:
- 4819_workaround.diff
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190717113349.21315.48335%40ip-10-1-54-209.ec2.internal.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New update by c0d3h4x0r
For Beanbag, Inc. > RBTools > Ticket #4819


Reply:

I'm not able to reproduce this problem.

Do you think you could trace through parse_revision_spec in 
rbtools/clients/perforce.py and see what the `revisions` list looks like and 
where it's failing to parse it correctly?


Status:
- New
+ NeedInfo

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20190508230822.32356.99568%40ip-10-1-54-209.ec2.internal.
For more options, visit https://groups.google.com/d/optout.

RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3

[Keith Kelly]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/
--

New ticket #4819 by c0d3h4x0r
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Defect


--
"rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 
under Python 3.7.3
==

# What version are you running?
RBTools==1.0.2

# What steps will reproduce the problem?
1. Locally apply the code fix I described in ticket 4818.
2. cd into the root of an existing Perforce workspace with a file opened for 
"p4 edit" under a numbered CL.
3. rbt post 


# What is the expected output? What do you see instead?

Expected: It should work.

Actual:
```
CRITICAL: Path 1802276 does not match a valid Perforce path.
```

# What operating system are you using?

Windows 10 Enterprise 64-bit

# Attach the debug out from the command.

```
>>> RBTools 1.0.2
>>> Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit 
>>> (AMD64)]
>>> Running on Windows-10-10.0.16299-SP0
>>> Home = C:\Users\kkelly\AppData\Roaming
>>> Current directory = D:\p4\depot\teams\near
>>> Command line: rbt post --debug 1802276
>>> Running: tf vc help
>>> Checking for a Bazaar repository...
>>> Unable to execute "bzr help": skipping Bazaar
>>> Checking for a ClearCase repository...
>>> Unable to execute "cleartool help": skipping ClearCase
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: not a git repository (or any of the parent directories): .git
---
>>> Checking for a Mercurial repository...
>>> Unable to execute "hg --help": skipping Mercurial
>>> Checking for a Perforce repository...
>>> Running: p4 info
>>> Running: diff --version
>>> Repository info: Path: dvp4edgepl009.tsi.lan:1666, Base path: None, 
>>> Supports changesets: True
>>> Checking for a Plastic repository...
>>> Unable to execute "cm version": skipping Plastic
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Command exited with rc 1: ['svn', '--non-interactive', 'info']
>>> Checking for a Team Foundation Server repository...
>>> Unable to execute "tf help": skipping TFS
>>> Making HTTP GET request to http://reviewboard/api/
>>> Running: p4 info
Traceback (most recent call last):
  File "c:\python37\lib\runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
  File "c:\python37\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
  File "C:\Python37\Scripts\rbt.exe__main__.py", line 9, in 
  File "c:\python37\lib\site-packages\rbtools\commands\main.py", line 120, in 
main
command.run_from_argv([RB_MAIN, command_name] + args)
  File "c:\python37\lib\site-packages\rbtools\commands__init__.py", line 725, 
in run_from_argv
exit_code = self.main(*args) or 0
  File "c:\python37\lib\site-packages\rbtools\commands\post.py", line 806, in 
main
extra_args=extra_args)
  File "c:\python37\lib\site-packages\rbtools\clients\perforce.py", line 729, 
in diff
return self._path_diff(extra_args, exclude_patterns)
  File "c:\python37\lib\site-packages\rbtools\clients\perforce.py", line 1470, 
in _path_diff
% path)
rbtools.clients.errors.SCMError: Path 1802276 does not match a valid Perforce 
path.
```

# Please provide any additional information below.

I tried upgrading my p4.exe command-line client to the latest (Rev. 
P4/NTX64/2019.1/1796703 (2019/04/30)), but that did not help.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.