Re: RBTools Ticket #4990: use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs

2023-02-07 Thread Shubha Ramani
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/
--

New update by shubhar
For Beanbag, Inc. > RBTools > Ticket #4990


Reply:

Nice. Glad you're investigating a solution via DiffX. Thank You !

Shubha

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20230207163719.30330.8621%40ip-10-1-54-209.ec2.internal.


Re: RBTools Ticket #4990: use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs

2023-02-06 Thread Christian Hammond
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/
--

New update by shubhar
For Beanbag, Inc. > RBTools > Ticket #4990


Reply:

We agree, and have begun baking in some ability to capture data like that. 
The limiting factor is that diff formats generally don't include metadata like 
this, and Perforce diffs certainly don't.

The long-term plan is to move our Perforce diff implementation over to 
[DiffX](https://diffx.org), which later Review Board 4.0.x versions support. 
That'll allow us to capture data like that in RBTools. We still need to add UI 
for this in Review Board, and we're looking at that for Review Board 6 (in 
development) or 7.


Status:
- New
+ Confirmed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20230207044118.30335.14469%40ip-10-1-54-209.ec2.internal.


RBTools Ticket #4990: use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs

2023-01-31 Thread Shubha Ramani
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/
--

New ticket #4990 by shubhar
For Beanbag, Inc. > RBTools

Status: New
Tags: Priority:Medium, Type:Enhancement


--
use p4 fstat to capture 'headType' (file type) so that it can be displayed in 
ReviewBoard diffs
==

# What version are you running?
4.0.10


# Describe the enhancement and the motivation for it.
We would like filetypes to be displayed along with the diff'd files. The 
motivation is that people often check-in files with the wrong filetypes,
which causes havoc in production.
Information here:
https://www.perforce.com/manuals/p4web/help/help_filetypes.html

# Please provide any additional information below.
https://www.perforce.com/manuals/p4web/help/help_filetypes.html

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20230131230041.9001.25311%40ip-10-1-54-209.ec2.internal.