Re: Review Board Ticket #4489: LDAP Authenticate error: need more than 1 value to unpack

2017-10-21 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4489/
--

New update by jafar
For Beanbag, Inc. > Review Board > Ticket #4489


Reply:

Fixed in release-2.5.x (d7e9803). This will ship in 2.5.17. Thanks!


Status:
- New
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4489: LDAP Authenticate error: need more than 1 value to unpack

2017-06-08 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4489/
--

New update by jafar
For Beanbag, Inc. > Review Board > Ticket #4489


Reply:

We're definitely aware of how names ought to work. Unfortunately, when we 
started Review Board, the Django included only "First name" and "Last name" 
fields. They've since made it possible to override and extend the user object, 
but because we started back then, we're locked into what we have.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board Ticket #4489: LDAP Authenticate error: need more than 1 value to unpack

2017-06-08 Thread Diego Russo
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4489/
--

New update by jafar
For Beanbag, Inc. > Review Board > Ticket #4489


Reply:

I have the same problem. The workaround was to use "Given Name Attribute" 
and "Surname Attribute" together. In the "Full Name Attribute" I configured 
"gecos" LDAP parameters: this filed could be anything 
(https://en.wikipedia.org/wiki/Gecos_field) hence it could not contains spaces. 
Make such assumption is wrong.
Moreover I suggest this good article when dealing with people's names: 
http://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4489: LDAP Authenticate error: need more than 1 value to unpack

2016-11-28 Thread Allen Heavey
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4489/
--

New ticket #4489 by jafar
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
LDAP Authenticate error: need more than 1 value to unpack
==

# What version are you running?
2.5.7


# What's the URL of the page containing the problem?
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/accounts/backends.py#L559
https://groups.google.com/forum/#!topic/reviewboard/7zrGkUg1kPI


# What steps will reproduce the problem?
1. GOTO   Authentication -> LDAP
2. SETFull Name Attribute: cn (or something like uid)
3. That's it!


# What is the expected output? What do you see instead?
Arbitrary assume fullname will contains a white space.
Wrong code:
>> first_name, last_name = full_name.split(' ', 1)

Many people, such as most asian people, they have a fullname but without space!
Example: 张三

You cannot assume your users' fullname contains white space, at least try catch 
such exception!


# What operating system are you using? What browser?
NONE

# Please provide any additional information below.
NONE

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.