Re: Review Board Ticket #4756: Empty reviews can be published

[David Trowbridge]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4756/
--

New update by shoven
For Beanbag, Inc. > Review Board > Ticket #4756


Reply:

Mostly finished. Removing EasyFix tag.


Tags:
- EasyFix

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20210118182541.9191.78904%40ip-10-1-54-209.ec2.internal.

Re: Review Board Ticket #4756: Empty reviews can be published

[Kean Weng Yap]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4756/
--

New update by shoven
For Beanbag, Inc. > Review Board > Ticket #4756


Reply:

I will try this out.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200918164428.1661.8838%40ip-10-1-54-209.ec2.internal.

Re: Review Board Ticket #4756: Empty reviews can be published

[Xiaohui Liu]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4756/
--

New update by shoven
For Beanbag, Inc. > Review Board > Ticket #4756


Reply:

I'll take a shot at this.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200117162739.23866.78710%40ip-10-1-54-209.ec2.internal.

Review Board Ticket #4756: Empty reviews can be published

[Sarah Hoven]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4756/
--

New ticket #4756 by shoven
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * empty review.png
   

 * empty review dialog.png
   



--
Empty reviews can be published
==

# What version are you running?

4.0.x

# What's the URL of the page containing the problem?

/r//

# What steps will reproduce the problem?
1. Open a review request to review
2. Click "Review" to open the review dialog
3. On the open review dialog, click "Publish Review"
4. Observe empty review published

Optional additional steps from 2. (not required, but these steps describe 
another use case where the user may add and delete comments and not realize 
they are posting an empty review):
3. Add Header text and general comment, click "Save" and "close" review dialog
4. Click "Review" to open the review dialog
5. Remove the header text and delete the general comment, click "Close"
6. Open the diff viewer and add a diff comment
7. Delete the diff comment (at this point, all comments added have been deleted)
8. In the draft review banner at the top of the screen, click "Publish Review"
9. Observe empty review published

# What is the expected output? What do you see instead?

It is expected that the review will not be allowed to be published if there are 
no comments and no other content in the review.

Instead, we see that empty reviews can be published.

# What operating system are you using? What browser?

macOS 10.13.6, Chrome Version 69


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.