Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

[Adam Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New update by a-dogg
For Beanbag, Inc. > Review Board > Ticket #4798


Reply:

So just to reiterate, the problem appears to be, RB is not fetching the 
left-hand-side file contents correctly.

RB *should be able* to fetch the left-hand-side file contents correctly. 
The files were deleted in SVN and don't exist at HEAD revision, but they do 
exist at the revision specified in the patch file.

E.g.:
```
$ svn cat $NETREPO/espresso/trunk/product-spec.json
svn: warning: W160013: File not found: revision 1887978, path 
'/espresso/trunk/product-spec.json'
svn: E29: Could not cat all targets because some targets don't exist
svn: E29: Illegal target for the requested operation

# If I download the diff from the RB, the 1st line for each file-entry 
reads like:
#"--- espresso/trunk/product-spec.json  (revision 1695130)"
# ... which tells me the left-hand-side file contents should be fetched 
from revision 1695130
$ svn cat $NETREPO/espresso/trunk/product-spec.json@1695130 | tail -5
"databases": {},
"repo_name": "DDS"
  },
  "description": "Elastic, Scalable, Performant, Reliable, Extensible, 
Stable, Speedy, and Operational"
}
```
As you can see, it *is* possible to fetch the correct left-hand-side file 
contents, given the correct revision, but for whatever reason reviewboard 
doesn't seem to be doing that - it is failing out due to the fact that the 
files no longer exist at the specified location.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20191007234208.18042.89425%40ip-10-1-54-209.ec2.internal.

Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

[Adam Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New update by a-dogg
For Beanbag, Inc. > Review Board > Ticket #4798


Reply:

We use an in-house product which runs RBTools "under the hood".

It looks like SVN recognizes the base revision - see attached screenshot.


Files:
- Screenshot from 2019-02-25 16-05-07.png
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New update by a-dogg
For Beanbag, Inc. > Review Board > Ticket #4798


Reply:

How's the diff being generated? Is this `svn diff`, RBTools, or an in-house 
product?


Status:
- New
+ NeedInfo

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location

[Adam Myers]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/
--

New ticket #4798 by a-dogg
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
"There was an error displaying this diff." for any SVN file that no longer 
exists at its former location
==

# What version are you running?
3.0.5

# What's the URL of the page containing the problem?
https://rb.corp.linkedin.com/r/1197363/diff/3/

# What steps will reproduce the problem?
1. Create a review-request for an SVN repository
2. Move or delete one or more of the files that were in the diff, in the SVN 
repository

# What is the expected output? What do you see instead?
Expect to see a diff rendered.
Instead:
```
   There was an error displaying this diff.
  
  The file '("'", ...)' could not be found in the repository

   This may be a bug in the software, a temporary outage, or an issue
   with the format of your diff.

   Please try again, and if you still have trouble,
   contact support.
```

# What operating system are you using? What browser?
N/A

# Please provide any additional information below.
The folder exists at the revision specified in the diff, as seen in `$ svn ls 
-r${REVISION}` output.

Also `svn cat ${PATH}@${REVISION}` outputs the file contents.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.