--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4937/
--
New ticket #4937 by grim
For Beanbag, Inc. > Review Board
Status: New
Tags: Priority:Medium, Type:Defect
--
Users with invalid or no email address will break emails for everyone.
==
# What version are you running?
4.0.4
# What's the URL of the page containing the problem?
It's the email notifications
# What steps will reproduce the problem?
1. As an admin change a users email address to blank
2. Do something that'll send a notification email
3. Never receive mail
4. Cry
5. Look at logs see it failed to parse
6. Disable sending email for that user
# What is the expected output? What do you see instead?
The user should be silently ignore
# What operating system are you using? What browser?
Linux chrome/firefox
# Please provide any additional information below.
Users are ending up with no email address because I have a custom auth provider
that syncs during login to an SSO (JetBrains Hub) which allows users to remove
their email address.
I will be patching the custom auth provider to fail their logins with no email,
but figured this might bite someone else as well.
--
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/reviewboard-issues/20210807064138.21494.73131%40ip-10-1-54-209.ec2.internal.