Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

[Sreenath Somarajapuram]

> On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/bower.json, line 16
> > 
> >
> > Package versiosn must be fixed.
> 
> Akhil PB wrote:
> Blob has no versions in bower. Bower itself added '*' as version.

Then we please using the commit version.


- Sreenath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150166
---


On Sept. 26, 2016, 2:32 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> ---
> 
> (Updated Sept. 26, 2016, 2:32 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
> https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  bd875ba 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 2c9609f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  14625c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  5a54d85 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  922e27e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  873fb6f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  d594c7e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  608758f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  809c1c0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  0c70ee5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  66ef1ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  fb34d51 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  33540e9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  a7ae9b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f 
> 
> Diff: https://reviews.apache.org/r/51647/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 52335: Alert unit tests failing on trunk

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52335/#review150683
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 28, 2016, 5:10 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52335/
> ---
> 
> (Updated Sept. 28, 2016, 5:10 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18477
> https://issues.apache.org/jira/browse/AMBARI-18477
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ran unit tests on tip of trunk:
> 
> Failed tests:  
> AmbariMetaInfoTest.testAlertDefinitionMerging:1928 expected:<10> but was:<11> 
>  
> AgentAlertDefinitionsTest.testLoadingAgentHostAlerts:52 expected:<1> but
> was:<2>
> 
> Tests run: 4701, Failures: 2, Errors: 0, Skipped: 37
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  4b7826e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
>  f5ce11e 
> 
> Diff: https://reviews.apache.org/r/52335/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 52335: Alert unit tests failing on trunk

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52335/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18477
https://issues.apache.org/jira/browse/AMBARI-18477


Repository: ambari


Description
---

Ran unit tests on tip of trunk:

Failed tests:  
AmbariMetaInfoTest.testAlertDefinitionMerging:1928 expected:<10> but was:<11>  
AgentAlertDefinitionsTest.testLoadingAgentHostAlerts:52 expected:<1> but
was:<2>

Tests run: 4701, Failures: 2, Errors: 0, Skipped: 37


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 4b7826e 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/AgentAlertDefinitionsTest.java
 f5ce11e 

Diff: https://reviews.apache.org/r/52335/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51814: Update sinks to read multiple collector hostnames from configs

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51814/#review150614
---




ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 332)


ams_collector_hosts in params.py resolves to such a string - 

['avijayan-ams-4.openstacklocal', 'avijayan-ams-2.openstacklocal', 
'avijayan-ams-3.openstacklocal']

This could be incompatible with this code.


- Aravindan Vijayan


On Sept. 16, 2016, 2:59 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51814/
> ---
> 
> (Updated Sept. 16, 2016, 2:59 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18362
> https://issues.apache.org/jira/browse/AMBARI-18362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update sinks to read multiple collector hostnames from configs
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  da61d83 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrAmsClient.java
>  85ea69d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  426eb42 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
>  7fadeb2 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
>  ccaa574 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  1b36e9a 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  b720ba9 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  f44ca35 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  9c16564 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  73381d9 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0d3b770 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  9082e70 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  f6531c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  4618618 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  4c111f1 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/hadoop-metrics2-accumulo.properties.j2
>  3cd535e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
>  586cd47 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  b839eb8 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  d3a9294 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/templates/flume-metrics2.properties.j2
>  b960296 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  49b684b 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2
>  e62ce9e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
>  818 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5f78a1f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2
>  88be81b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2
>  3d71867 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/hadoop-metrics2-llapdaemon.j2
>  

Re: Review Request 52304: Scope and Services need to be used for orchestration

[Nate Cole]

> On Sept. 27, 2016, 2:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java,
> >  lines 825-828
> > 
> >
> > Is this necessarily true? Suppose that there's a repository for a patch 
> > and the available services actually includes every single service.
> > 
> > Is the scope still partial?

The if-block containing this checks if it's (not) a STANDARD repo, that means 
it's for a patch.  We have to trust that the VDF is going to be correct for 
what it contains.  If it says it's a PATCH but defines all services, then so be 
it.  One would hope that if all the services are in it, the VDF would be a 
STANDARD RU/EU.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52304/#review150584
---


On Sept. 27, 2016, 12:54 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52304/
> ---
> 
> (Updated Sept. 27, 2016, 12:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18473
> https://issues.apache.org/jira/browse/AMBARI-18473
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is another addition to "getting things back" for PU.
> 
> Added a unit test, and other tests already cover the Scope and Services 
> elements.
> 
> Did NOT do a full refactor for the new abstract class; that is a separate 
> cleanup task.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  15caa69 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
>  7705c7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  2f616e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  80bb26c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
>  207b4c7 
> 
> Diff: https://reviews.apache.org/r/52304/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:43.185s
> [INFO] Finished at: Tue Sep 27 11:42:58 EDT 2016
> [INFO] Final Memory: 44M/761M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 52304: Scope and Services need to be used for orchestration

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52304/#review150584
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 (lines 825 - 828)


Is this necessarily true? Suppose that there's a repository for a patch and 
the available services actually includes every single service.

Is the scope still partial?


- Jonathan Hurley


On Sept. 27, 2016, 12:54 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52304/
> ---
> 
> (Updated Sept. 27, 2016, 12:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18473
> https://issues.apache.org/jira/browse/AMBARI-18473
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is another addition to "getting things back" for PU.
> 
> Added a unit test, and other tests already cover the Scope and Services 
> elements.
> 
> Did NOT do a full refactor for the new abstract class; that is a separate 
> cleanup task.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  15caa69 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
>  7705c7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  2f616e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  80bb26c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
>  207b4c7 
> 
> Diff: https://reviews.apache.org/r/52304/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:43.185s
> [INFO] Finished at: Tue Sep 27 11:42:58 EDT 2016
> [INFO] Final Memory: 44M/761M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

[Sid Wagle]

> On Sept. 26, 2016, 9:33 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java,
> >  line 97
> > 
> >
> > When I tried this on my cluster that was installed failed by making a 
> > jar, it did not come out of the bad state. Just want to make sure the 
> > manual testing on this was good.
> 
> Balázs Bence Sári wrote:
> I tested it by installing the cluster, then deleting the cluster version 
> from the DB, then restarting the server. The server was able to restart. 
> I don't know what other problems missing cluster versions can cause, but 
> the startup issue is fixed by this patch. Could you describe what errors you 
> saw after applying the patch?

Unfortunately, I already duid a reset so do not have exact failure but on the 
repro, could you simulate a failure via stack script? That would be a exact 
repro.

I have attached logs to the external Jira: AMBARI-18467. The attached link on 
the RB is incorrect.
If you search for UpdateActiveRepoVersionOnStartup, second to last occurence 
and look at the restart after that, it might provide some clues.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52266/#review150459
---


On Sept. 26, 2016, 6:23 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52266/
> ---
> 
> (Updated Sept. 26, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-18430
> https://issues.apache.org/jira/browse/AMBARI-18430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problems during cluster install can result in clusters without a cluster 
> version. UpdateActiveRepoVersionOnStartup.process() threw NPE in these case. 
> NPE check is added
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
>  1413c66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
>  9c54a88 
> 
> Diff: https://reviews.apache.org/r/52266/diff/
> 
> 
> Testing
> ---
> 
> - Added a new unit test
> - All unit tests in ambari-server passed
> - Did manual testing to verify (removed cluster version from the DB and 
> restarted the server)
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 52304: Scope and Services need to be used for orchestration

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52304/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-18473
https://issues.apache.org/jira/browse/AMBARI-18473


Repository: ambari


Description
---

This is another addition to "getting things back" for PU.

Added a unit test, and other tests already cover the Scope and Services 
elements.

Did NOT do a full refactor for the new abstract class; that is a separate 
cleanup task.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 15caa69 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
 7705c7d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
2f616e7 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 80bb26c 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
 207b4c7 

Diff: https://reviews.apache.org/r/52304/diff/


Testing
---

Manual.  Automated:

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 33:43.185s
[INFO] Finished at: Tue Sep 27 11:42:58 EDT 2016
[INFO] Final Memory: 44M/761M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52298/#review150572
---


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 27, 2016, 10:05 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52298/
> ---
> 
> (Updated Sept. 27, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18471
> https://issues.apache.org/jira/browse/AMBARI-18471
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix the most obvious points of the main jira. 
> 1\. Refactor this code to have individual functions for components.  
> 2\. Remove conditions for xmlConfigs, where they are not needed
> 
> The other part of the jira requires more discussion, it probably will be
> easier to do once we have a cleaner look on the code and shrink the scope of
> the issue.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  4d42861 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  a3a3a06 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 643f946 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 7b5ce18 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> dc11ba9 
>   ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py abfe756 
> 
> Diff: https://reviews.apache.org/r/52298/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52223: AMBARI-18051 - Services should be able to provide their own pre-req checks by supplying a jar file

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52223/#review150563
---




ambari-server/src/test/java/org/apache/ambari/server/sample/checks/SampleServiceCheck.java
 (line 1)


Missing license header


- Robert Levas


On Sept. 23, 2016, 3:59 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52223/
> ---
> 
> (Updated Sept. 23, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and 
> Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18051
> https://issues.apache.org/jira/browse/AMBARI-18051
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Services should be able to provide their own pre-req checks by supplying a 
> jar file.
> 
> This would allow custom services to supply their own jar files to handle 
> pre-req checks rather than forcing third party developers to make changes to 
> ambari-server code.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 5731c9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  498481d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
>  4ed345c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  7d7b618 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  cdedbb4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  30663a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> a77a22f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  8656896 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 6fda8bc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/sample/checks/SampleServiceCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  304fd5c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
>  659ae12 
> 
> Diff: https://reviews.apache.org/r/52223/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test 
> -Dtest=PreUpgradeCheckResourceProviderTest,PreUpgradeCheckServiceTest,StackManagerExtensionTest,ServiceModuleTest,StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 52281: Fix custom jdbc functionality for ambari-server setup

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52281/#review150562
---


Ship it!




Ship It!

- Dmytro Sen


On Сен. 27, 2016, 2:50 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52281/
> ---
> 
> (Updated Сен. 27, 2016, 2:50 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18469
> https://issues.apache.org/jira/browse/AMBARI-18469
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change jdbc logic for ambari-server to include correctly patch to jdbc into 
> ambari-server classpath.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py ede257f 
>   ambari-server/src/test/python/TestAmbariServer.py 5746503 
> 
> Diff: https://reviews.apache.org/r/52281/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52281: Fix custom jdbc functionality for ambari-server setup

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52281/
---

(Updated Вер. 27, 2016, 2:50 після полудня)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-18469
https://issues.apache.org/jira/browse/AMBARI-18469


Repository: ambari


Description
---

Change jdbc logic for ambari-server to include correctly patch to jdbc into 
ambari-server classpath.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py ede257f 
  ambari-server/src/test/python/TestAmbariServer.py 5746503 

Diff: https://reviews.apache.org/r/52281/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52289/#review150561
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 27, 2016, 12:09 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52289/
> ---
> 
> (Updated Sept. 27, 2016, 12:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18463
> https://issues.apache.org/jira/browse/AMBARI-18463
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing a secure cluster using Blueprints, Ambari's 
> {{/etc/ambari-server/conf/krb5JAASLogin.conf}} is not updated to reflect the 
> details of the Ambari Kerberos identity.
> 
> This was introduced by the patch for AMBARI-18406.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  a3c6fd4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  10647e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7e6a056 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52289/diff/
> 
> 
> Testing
> ---
> 
> Manualy tested with UI and BP installs
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:06:17.245s
> [INFO] Finished at: Mon Sep 26 19:52:31 EDT 2016
> [INFO] Final Memory: 67M/699M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 52282: RU/EU cannot start because ServiceCheckValidityCheck incorrectly calculates Service Checks that ran

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52282/#review150558
---


Ship it!




Ship It!

- Nate Cole


On Sept. 26, 2016, 5:53 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52282/
> ---
> 
> (Updated Sept. 26, 2016, 5:53 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-18470
> https://issues.apache.org/jira/browse/AMBARI-18470
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RU/EU PreCheck for running ServiceChecks after config changes is incorrect.
> 
> Example:
> ```
> Last Service Check should be more recent than the last configuration change 
> for the given service 
> Reason: The following service configurations have been updated and their 
> Service Checks should be run again: HIVE, SPARK, RANGER, YARN 
> Failed on: HIVE,SPARK,RANGER,YARN
> ```
> 
> 
> Root Cause:
> When the database has more than 1000 Service Checks, the EU/RU PreCheck for 
> ensuring that a Service Check has ran after any config changes to a service 
> is incorrect because it takes the first 1000 HostRoleCommand records as 
> opposed to the last page of 1000.
> 
> This is because ServiceCheckValidityCheck.java doesn't impose an ordering 
> when creating a pagination request from TaskResourceProvider.java
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  2bc22c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  8d72b96 
> 
> Diff: https://reviews.apache.org/r/52282/diff/
> 
> 
> Testing
> ---
> 
> Verified using database dump and ran unit tests in 
> ServiceCheckValidityCheckTest.java
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52289/#review150559
---


Ship it!




Ship It!

- Nate Cole


On Sept. 26, 2016, 8:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52289/
> ---
> 
> (Updated Sept. 26, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18463
> https://issues.apache.org/jira/browse/AMBARI-18463
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing a secure cluster using Blueprints, Ambari's 
> {{/etc/ambari-server/conf/krb5JAASLogin.conf}} is not updated to reflect the 
> details of the Ambari Kerberos identity.
> 
> This was introduced by the patch for AMBARI-18406.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  a3c6fd4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  10647e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7e6a056 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52289/diff/
> 
> 
> Testing
> ---
> 
> Manualy tested with UI and BP installs
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:06:17.245s
> [INFO] Finished at: Mon Sep 26 19:52:31 EDT 2016
> [INFO] Final Memory: 67M/699M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52289/#review150548
---


Ship it!




Ship It!

- Sandor Magyari


On Sept. 27, 2016, 12:09 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52289/
> ---
> 
> (Updated Sept. 27, 2016, 12:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18463
> https://issues.apache.org/jira/browse/AMBARI-18463
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing a secure cluster using Blueprints, Ambari's 
> {{/etc/ambari-server/conf/krb5JAASLogin.conf}} is not updated to reflect the 
> details of the Ambari Kerberos identity.
> 
> This was introduced by the patch for AMBARI-18406.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  a3c6fd4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  10647e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7e6a056 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52289/diff/
> 
> 
> Testing
> ---
> 
> Manualy tested with UI and BP installs
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:06:17.245s
> [INFO] Finished at: Mon Sep 26 19:52:31 EDT 2016
> [INFO] Final Memory: 67M/699M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52289/#review150547
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 26, 2016, 8:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52289/
> ---
> 
> (Updated Sept. 26, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18463
> https://issues.apache.org/jira/browse/AMBARI-18463
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing a secure cluster using Blueprints, Ambari's 
> {{/etc/ambari-server/conf/krb5JAASLogin.conf}} is not updated to reflect the 
> details of the Ambari Kerberos identity.
> 
> This was introduced by the patch for AMBARI-18406.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  a3c6fd4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  10647e8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7e6a056 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52289/diff/
> 
> 
> Testing
> ---
> 
> Manualy tested with UI and BP installs
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:06:17.245s
> [INFO] Finished at: Mon Sep 26 19:52:31 EDT 2016
> [INFO] Final Memory: 67M/699M
> [INFO] 
> 
> ```
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 52282: RU/EU cannot start because ServiceCheckValidityCheck incorrectly calculates Service Checks that ran

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52282/#review150546
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 26, 2016, 5:53 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52282/
> ---
> 
> (Updated Sept. 26, 2016, 5:53 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-18470
> https://issues.apache.org/jira/browse/AMBARI-18470
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RU/EU PreCheck for running ServiceChecks after config changes is incorrect.
> 
> Example:
> ```
> Last Service Check should be more recent than the last configuration change 
> for the given service 
> Reason: The following service configurations have been updated and their 
> Service Checks should be run again: HIVE, SPARK, RANGER, YARN 
> Failed on: HIVE,SPARK,RANGER,YARN
> ```
> 
> 
> Root Cause:
> When the database has more than 1000 Service Checks, the EU/RU PreCheck for 
> ensuring that a Service Check has ran after any config changes to a service 
> is incorrect because it takes the first 1000 HostRoleCommand records as 
> opposed to the last page of 1000.
> 
> This is because ServiceCheckValidityCheck.java doesn't impose an ordering 
> when creating a pagination request from TaskResourceProvider.java
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  2bc22c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  8d72b96 
> 
> Diff: https://reviews.apache.org/r/52282/diff/
> 
> 
> Testing
> ---
> 
> Verified using database dump and ran unit tests in 
> ServiceCheckValidityCheckTest.java
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52155/#review150545
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
 (lines 225 - 226)


This doesn't guarantee ordering of any kind - the first one which comes 
back could have an ID of 9. Since it doesn't match `m_hcsId`, this code would 
try to update it to to a value of 1 and possibly cause duplicates.

You can simply skip this whole section of updating if the 
`resultSet.getLong("id")` is non-null/non-zero. 

You can then so something like this:
`m_hcsId.set(NumberUtils.max(m_hcsId.get(), idKey)`


- Jonathan Hurley


On Sept. 27, 2016, 8:03 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52155/
> ---
> 
> (Updated Sept. 27, 2016, 8:03 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18441
> https://issues.apache.org/jira/browse/AMBARI-18441
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> My first upgrade test failed due to my environment issue. Since in real 
> production environment this failure would  occur again.
> 
> ambari upgrade to 2.1.1 and later version, if the first time failed , excute 
> ambari-server upgrade again will error duplicate key value violates unique 
> constraint "pk_hostcomponentstate".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
>  db13612 
> 
> Diff: https://reviews.apache.org/r/52155/diff/
> 
> 
> Testing
> ---
> 
> the unit test is UpgradeCatalog211Test.java: Process finished with exit code 
> 0.
> done !
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

[wang yaoxin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52155/
---

(Updated 九月 27, 2016, 12:03 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18441
https://issues.apache.org/jira/browse/AMBARI-18441


Repository: ambari


Description (updated)
---

My first upgrade test failed due to my environment issue. Since in real 
production environment this failure would  occur again.

ambari upgrade to 2.1.1 and later version, if the first time failed , excute 
ambari-server upgrade again will error duplicate key value violates unique 
constraint "pk_hostcomponentstate".


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
 db13612 

Diff: https://reviews.apache.org/r/52155/diff/


Testing
---

the unit test is UpgradeCatalog211Test.java: Process finished with exit code 0.
done !


Thanks,

wang yaoxin

Re: Review Request 52260: AMBARI-18459: Print error messages if bulkcommand section of a component includes non-existing component

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52260/#review150542
---


Ship it!




Ship It!

- Tim Thorpe


On Sept. 26, 2016, 2:26 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52260/
> ---
> 
> (Updated Sept. 26, 2016, 2:26 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18459
> https://issues.apache.org/jira/browse/AMBARI-18459
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is to provide basic error message print outs when a user defines a 
> bulkcommand section in a service's metainfo.xml where he unknowingly addes a 
> component that doesn't exist. For example, adding a component called "master" 
> to HBASE_REGIONSERVER's bulkcommand section should see the server prints out 
> an error message.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> a77a22f 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 93eeb7e 
> 
> Diff: https://reviews.apache.org/r/52260/diff/
> 
> 
> Testing
> ---
> 
> existing unit test.
> patched a trunk cluster with the change, 
> 1. modified HBase metainfo.xml at the common service level and see the error 
> messages showed up for all HDP stacks.
> 2. modified hbase metainfo.xml at both common service and HDP 2.5 level (2.5 
> level has the correct bulkcommand section), see the error messages for HDP 
> 2.0.6 up to HDP 2.4, no error in HDP 2.5 (as it has the correct bulkcommand 
> section)
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52298/
---

(Updated Sept. 27, 2016, 10:05 a.m.)


Review request for Ambari, Jayush Luniya and Vitalyi Brodetskyi.


Bugs: AMBARI-18471
https://issues.apache.org/jira/browse/AMBARI-18471


Repository: ambari


Description
---

Fix the most obvious points of the main jira. 
1\. Refactor this code to have individual functions for components.  
2\. Remove conditions for xmlConfigs, where they are not needed

The other part of the jira requires more discussion, it probably will be
easier to do once we have a cleaner look on the code and shrink the scope of
the issue.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 4d42861 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 a3a3a06 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 643f946 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
7b5ce18 
  ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
dc11ba9 
  ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py abfe756 

Diff: https://reviews.apache.org/r/52298/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52281: Fix custom jdbc functionality for ambari-server setup

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52281/#review150536
---


Ship it!




Ship It!

- Dmytro Sen


On Сен. 26, 2016, 9:40 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52281/
> ---
> 
> (Updated Сен. 26, 2016, 9:40 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18469
> https://issues.apache.org/jira/browse/AMBARI-18469
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change jdbc logic for ambari-server to include correctly patch to jdbc into 
> ambari-server classpath.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py ede257f 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py e4dfd21 
>   ambari-server/src/test/python/TestAmbariServer.py 5746503 
> 
> Diff: https://reviews.apache.org/r/52281/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52298: Refactor yarn() function in YARN service. Part 1.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52298/
---

(Updated Sept. 27, 2016, 9:13 a.m.)


Review request for Ambari, Jayush Luniya and Vitalyi Brodetskyi.


Bugs: AMBARI-18471
https://issues.apache.org/jira/browse/AMBARI-18471


Repository: ambari


Description (updated)
---

Fix the most obvious points of the main jira. 
1\. Refactor this code to have individual functions for components.  
2\. Remove conditions for xmlConfigs, where they are not needed

The other part of the jira requires more discussion, it probably will be
easier to do once we have a cleaner look on the code and shrink the scope of
the issue.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 4d42861 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 a3a3a06 

Diff: https://reviews.apache.org/r/52298/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 52298: Refactor yarn() function in YARN service. Part 1.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52298/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18471
https://issues.apache.org/jira/browse/AMBARI-18471


Repository: ambari


Description
---

Fix the most obvious points of BUG-66382:  
1\. Refactor this code to have individual functions for components.  
2\. Remove conditions for xmlConfigs, where they are not needed

The other part of the jira requires more discussion, it probably will be
easier to do once we have a cleaner look on the code and shrink the scope of
the issue.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 4d42861 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 a3a3a06 

Diff: https://reviews.apache.org/r/52298/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52264/#review150532
---


Ship it!




Ship It!

- Balázs Bence Sári


On Sept. 26, 2016, 6:07 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52264/
> ---
> 
> (Updated Sept. 26, 2016, 6:07 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18466
> https://issues.apache.org/jira/browse/AMBARI-18466
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Simple string replacement
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  2182fd1 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/metainfo.xml
>  6998efc 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  891d2c9 
> 
> Diff: https://reviews.apache.org/r/52264/diff/
> 
> 
> Testing
> ---
> 
> Manual testing: created cluster with wizard
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

[Balázs Bence Sári]

> On Sept. 26, 2016, 9:33 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java,
> >  line 97
> > 
> >
> > When I tried this on my cluster that was installed failed by making a 
> > jar, it did not come out of the bad state. Just want to make sure the 
> > manual testing on this was good.

I tested it by installing the cluster, then deleting the cluster version from 
the DB, then restarting the server. The server was able to restart. 
I don't know what other problems missing cluster versions can cause, but the 
startup issue is fixed by this patch. Could you describe what errors you saw 
after applying the patch?


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52266/#review150459
---


On Sept. 26, 2016, 6:23 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52266/
> ---
> 
> (Updated Sept. 26, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-18430
> https://issues.apache.org/jira/browse/AMBARI-18430
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problems during cluster install can result in clusters without a cluster 
> version. UpdateActiveRepoVersionOnStartup.process() threw NPE in these case. 
> NPE check is added
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
>  1413c66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
>  9c54a88 
> 
> Diff: https://reviews.apache.org/r/52266/diff/
> 
> 
> Testing
> ---
> 
> - Added a new unit test
> - All unit tests in ambari-server passed
> - Did manual testing to verify (removed cluster version from the DB and 
> restarted the server)
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52264/#review150529
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 26, 2016, 8:07 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52264/
> ---
> 
> (Updated Sept. 26, 2016, 8:07 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18466
> https://issues.apache.org/jira/browse/AMBARI-18466
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Simple string replacement
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  2182fd1 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/metainfo.xml
>  6998efc 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/service_advisor.py
>  891d2c9 
> 
> Diff: https://reviews.apache.org/r/52264/diff/
> 
> 
> Testing
> ---
> 
> Manual testing: created cluster with wizard
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>