Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53216/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Sumit 
Mohanty, and Sid Wagle.


Bugs: AMBARI-18711
https://issues.apache.org/jira/browse/AMBARI-18711


Repository: ambari


Description
---

AMBARI-18711: Ambari-server: DB changes to enable/disable credential store 
support


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
 6cb3ddee73a8035b9486c2fc7affb58399b85d2c 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
df3cfd8d589c1d4bf47b8fbcacb541b762de4bb9 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
9b560595dd837878cbea631fcef48ab93d6cc4a9 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
a0a0afdc1627c64839fa4a3c0449ab42326303fa 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
7a0231530c6d5385bbe305570253630593a6dac5 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
4ba371a12e527b96ac78e098a19c6f8361637855 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
c5a9119e7ca22b28da003d79923d4d521ad5c36c 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
2905eda40c143aaee6e90c76610ff0be24c84d38 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
6b19974318d7017f0a13bdd8f924b6878cac8900 

Diff: https://reviews.apache.org/r/53216/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.742s]
[INFO] Apache Ambari Project POM . SUCCESS [0.049s]
[INFO] Ambari Web  SUCCESS [1:12.384s]
[INFO] Ambari Views .. SUCCESS [1.056s]
[INFO] Ambari Admin View . SUCCESS [6.276s]
[INFO] utility ... SUCCESS [0.328s]
[INFO] ambari-metrics  SUCCESS [0.806s]
[INFO] Ambari Metrics Common . SUCCESS [6.815s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.661s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.347s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.318s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.499s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.459s]
[INFO] Ambari Metrics Collector .. SUCCESS [8.828s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.057s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.793s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.807s]
[INFO] Ambari Server . SUCCESS [2:27.298s]
[INFO] Ambari Functional Tests ... SUCCESS [1.001s]
[INFO] Ambari Agent .. SUCCESS [24.945s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [1.033s]
[INFO] Ambari Groovy Client .. SUCCESS [2.037s]
[INFO] Ambari Shell .. SUCCESS [0.038s]
[INFO] Ambari Python Shell ... SUCCESS [0.662s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.800s]
[INFO] ambari-logsearch .. SUCCESS [0.267s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.198s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.125s]
[INFO] Ambari Logsearch Portal ... SUCCESS [5.831s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.729s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.078s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:21.021s
[INFO] Finished at: Wed Oct 26 18:45:17 PDT 2016
[INFO] Final Memory: 305M/1207M
[INFO] 

** 2.  mvn test -DskipPythonTests -Dtest=*Service*,*MetaInfo*,*Component*

** The following tests were in failure prior to the current changes **
*
Results :

Tests in error:
  AmbariMetaInfoTest.testCrossCheckJmxToGangliaMetrics:1002 » NullPointer
  KerberosServiceMetaInfoTest.before:160->createAmbariMetaInfo:211 » NullPointer
  KerberosServiceMetaInfoTest.before:160->createAmbariMetaInfo:211 » 

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53182/#review153971
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 179)


Can we check for the existence of interpreter.json?


- Sumit Mohanty


On Oct. 26, 2016, 9:03 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53182/
> ---
> 
> (Updated Oct. 26, 2016, 9:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18690
> https://issues.apache.org/jira/browse/AMBARI-18690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - interpreter.json file isn't available before first server start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  8eb36c8 
> 
> Diff: https://reviews.apache.org/r/53182/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 53139: Zeppelin install not correctly setting user and group for notebook directory

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53139/#review153969
---


Ship it!




Ship It!

- Sumit Mohanty


On Oct. 26, 2016, 7:33 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53139/
> ---
> 
> (Updated Oct. 26, 2016, 7:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18677
> https://issues.apache.org/jira/browse/AMBARI-18677
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - change ownership of notebook directory
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  8eb36c8 
> 
> Diff: https://reviews.apache.org/r/53139/diff/
> 
> 
> Testing
> ---
> 
> manually tested on centos
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53213/
---

Review request for Ambari, Robert Levas and Robert Nettleton.


Bugs: AMBARI-18692
https://issues.apache.org/jira/browse/AMBARI-18692


Repository: ambari


Description
---

Exporting blueprint from kerberos enabled cluster, exports hardcoded values 
cluster name and realm in principal_name property.
When the same blueprint is used to create another cluster with different name, 
service start fail with following error:
"resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt 
/etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned 
1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] while 
getting initial credentials"


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 f890326 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 5bedb9d 

Diff: https://reviews.apache.org/r/53213/diff/


Testing
---

Tested manually. Suitable keytabs are generated automatically when not 
mentioned in blueprint. Service starts succeeded with a blueprint exported with 
the code change. 
Modified existing unit test cases.


Thanks,

Amruta Borkar

Review Request 53211: Ranger Audit Handler not working as expected as NN HA wizard does not set a few properties correctly

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53211/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi Wang, 
and Yusaku Sako.


Bugs: AMBARI-18706
https://issues.apache.org/jira/browse/AMBARI-18706


Repository: ambari


Description
---

When Ranger is installed and the user tries to enable NamenodeHA in HDFS, the 
following exception is encountered since a property is not configured properly 
in all the dependent services.


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js
 1dcf2b7 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js
 68366f6 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step7_controller.js
 0bfd1c9 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js
 05c6a58 
  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/wizard_controller.js
 72f9ec2 
  ambari-web/app/data/HDP2/ha_properties.js 388f85d 
  ambari-web/app/messages.js a3c5e58 
  ambari-web/app/routes/high_availability_routes.js 9530232 
  ambari-web/app/utils/ajax/ajax.js b761a14 
  ambari-web/app/utils/configs/nn_ha_config_initializer.js 3a48e8d 
  
ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js
 dfe2076 

Diff: https://reviews.apache.org/r/53211/diff/


Testing
---

Verified Manually.
Unit tests modified.
Ambari-web unit tests pass.
30372 tests complete (28 seconds)
151 tests pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53178/#review153941
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 26, 2016, 9:03 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53178/
> ---
> 
> (Updated Oct. 26, 2016, 9:03 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18696
> https://issues.apache.org/jira/browse/AMBARI-18696
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Hive View Links to Hive Summary Page.
> Fix some name typo.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/summary.js c16bb3f 
>   ambari-web/app/messages.js 8f49cce 
>   ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs cb97978 
>   ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 96f64ba 
>   ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs 884f322 
>   ambari-web/app/templates/main/service/item.hbs 43fb3dd 
>   ambari-web/app/templates/main/service/services/hive.hbs 23a2347 
>   ambari-web/app/views/common/log_search_ui_link_view.js 8227b7f 
>   ambari-web/app/views/common/quick_view_link_view.js 17d7c04 
>   ambari-web/app/views/main/service/services/hive.js 2530e42 
> 
> Diff: https://reviews.apache.org/r/53178/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   25699 tests complete (24 seconds)
>   57 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53178/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Bugs: AMBARI-18696
https://issues.apache.org/jira/browse/AMBARI-18696


Repository: ambari


Description
---

Add Hive View Links to Hive Summary Page.
Fix some name typo.


Diffs
-

  ambari-web/app/controllers/main/service/info/summary.js c16bb3f 
  ambari-web/app/messages.js 8f49cce 
  ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs cb97978 
  ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 96f64ba 
  ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs 884f322 
  ambari-web/app/templates/main/service/item.hbs 43fb3dd 
  ambari-web/app/templates/main/service/services/hive.hbs 23a2347 
  ambari-web/app/views/common/log_search_ui_link_view.js 8227b7f 
  ambari-web/app/views/common/quick_view_link_view.js 17d7c04 
  ambari-web/app/views/main/service/services/hive.js 2530e42 

Diff: https://reviews.apache.org/r/53178/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  25699 tests complete (24 seconds)
  57 tests pending


Thanks,

Richard Zang

Re: Review Request 53205: AMBARI-18709 - Javascript Error When Using ComponentState Filter On Host Page

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53205/#review153938
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 26, 2016, 8:37 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53205/
> ---
> 
> (Updated Oct. 26, 2016, 8:37 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18709
> https://issues.apache.org/jira/browse/AMBARI-18709
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix missing var statement.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/host/combo_search_box.js 4ab3b7c 
> 
> Diff: https://reviews.apache.org/r/53205/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   30371 tests complete (30 seconds)
>   151 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 53205: AMBARI-18709 - Javascript Error When Using ComponentState Filter On Host Page

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53205/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Bugs: AMBARI-18709
https://issues.apache.org/jira/browse/AMBARI-18709


Repository: ambari


Description
---

Fix missing var statement.


Diffs
-

  ambari-web/app/controllers/main/host/combo_search_box.js 4ab3b7c 

Diff: https://reviews.apache.org/r/53205/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  30371 tests complete (30 seconds)
  151 tests pending


Thanks,

Richard Zang

Re: Review Request 53200: AMBARI-18686 - Falcon user shouldn't be added to Oozie admin list if Falcon is not installed

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53200/#review153934
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 26, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53200/
> ---
> 
> (Updated Oct. 26, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-18686
> https://issues.apache.org/jira/browse/AMBARI-18686
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Falcon user shouldn't be added to Oozie admin list if Falcon is not installed
> 
> + if not "FALCON_SERVER" in clusterData["components"] :
> + print "Falcon is not part of the installation"
> + return
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> d2cc429 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 72e59aa 
> 
> Diff: https://reviews.apache.org/r/53200/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Added 2 new test cases to test for falcon being installed and falcon not 
> being installed
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 53187: AMBARI-18691: Improve and Update Workflow designer to support coordinators and bundles and enhancements

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53187/#review153922
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Oct. 26, 2016, 1:08 p.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53187/
> ---
> 
> (Updated Oct. 26, 2016, 1:08 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-18691
> https://issues.apache.org/jira/browse/AMBARI-18691
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Coordinators
> bundles
> multiple tabs
> undo/delete support
> copy/paste
> improved validations
> Fix JS6 lint issues
> Dag generation in the UI
> Use cytoscape for diagraming
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/JobType.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  3ed6352 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 
> PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/.jshintrc PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/.gitkeep 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/archive-config.js
>  d53b459 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/conditional-data-input.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/confirmation-dialog.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/credentials-config.js
>  f100808 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/data-input-output-config.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/data-input.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/dataset-config.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  84d1393 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  324be66 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action-info.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action.js 
> 1fbe4c9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/email-action-info.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/email-action.js 
> 357fe90 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/file-config.js 
> 46d30d1 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> bd2944b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action-info.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 
> 98a292d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/fsaction-info.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 
> fc5fd37 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action-info.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js 
> 125aac3 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action-info.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js 
> f8b53c5 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/info-header.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/instance-list-config.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/java-action-info.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
> 873c284 
>   

Review Request 53200: AMBARI-18686 - Falcon user shouldn't be added to Oozie admin list if Falcon is not installed

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53200/
---

Review request for Ambari, Alejandro Fernandez, Di Li, and Venkat Ranganathan.


Bugs: AMBARI-18686
https://issues.apache.org/jira/browse/AMBARI-18686


Repository: ambari


Description
---

Falcon user shouldn't be added to Oozie admin list if Falcon is not installed

+ if not "FALCON_SERVER" in clusterData["components"] :
+ print "Falcon is not part of the installation"
+ return


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
d2cc429 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 72e59aa 

Diff: https://reviews.apache.org/r/53200/diff/


Testing
---

mvn clean test

Added 2 new test cases to test for falcon being installed and falcon not being 
installed


Thanks,

Tim Thorpe

Re: Review Request 53177: Add PXF Hive ORC Profile

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53177/#review153917
---


Ship it!




Ship It!

- Lav Jain


On Oct. 26, 2016, midnight, Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53177/
> ---
> 
> (Updated Oct. 26, 2016, midnight)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-18695
> https://issues.apache.org/jira/browse/AMBARI-18695
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add PXF Hive ORC Profile
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  3c2aac0 
> 
> Diff: https://reviews.apache.org/r/53177/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 53177: Add PXF Hive ORC Profile

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53177/#review153915
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 26, 2016, midnight, Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53177/
> ---
> 
> (Updated Oct. 26, 2016, midnight)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-18695
> https://issues.apache.org/jira/browse/AMBARI-18695
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add PXF Hive ORC Profile
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  3c2aac0 
> 
> Diff: https://reviews.apache.org/r/53177/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 53177: Add PXF Hive ORC Profile

[Oleksandr Diachenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53177/#review153914
---


Ship it!




Ship It!

- Oleksandr Diachenko


On Oct. 26, 2016, midnight, Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53177/
> ---
> 
> (Updated Oct. 26, 2016, midnight)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-18695
> https://issues.apache.org/jira/browse/AMBARI-18695
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add PXF Hive ORC Profile
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml
>  3c2aac0 
> 
> Diff: https://reviews.apache.org/r/53177/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53182/#review153907
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 179)


Introducing sleeps is a bad way of checking for something to pass, 
especially since it adds delays during deployment/testing and may not be needed 
in future versions.

Is there anything else that can be checked?


- Alejandro Fernandez


On Oct. 26, 2016, 9:03 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53182/
> ---
> 
> (Updated Oct. 26, 2016, 9:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18690
> https://issues.apache.org/jira/browse/AMBARI-18690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - interpreter.json file isn't available before first server start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  8eb36c8 
> 
> Diff: https://reviews.apache.org/r/53182/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 53187: AMBARI-18691: Improve and Update Workflow designer to support coordinators and bundles and enhancements

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53187/#review153902
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 26, 2016, 1:08 p.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53187/
> ---
> 
> (Updated Oct. 26, 2016, 1:08 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-18691
> https://issues.apache.org/jira/browse/AMBARI-18691
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Coordinators
> bundles
> multiple tabs
> undo/delete support
> copy/paste
> improved validations
> Fix JS6 lint issues
> Dag generation in the UI
> Use cytoscape for diagraming
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/JobType.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  3ed6352 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 
> PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/.jshintrc PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/.gitkeep 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/archive-config.js
>  d53b459 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/conditional-data-input.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/confirmation-dialog.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/credentials-config.js
>  f100808 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/data-input-output-config.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/data-input.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/dataset-config.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  84d1393 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  324be66 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action-info.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action.js 
> 1fbe4c9 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/email-action-info.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/email-action.js 
> 357fe90 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/file-config.js 
> 46d30d1 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> bd2944b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action-info.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 
> 98a292d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/fsaction-info.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 
> fc5fd37 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action-info.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js 
> 125aac3 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action-info.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js 
> f8b53c5 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/info-header.js 
> PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/instance-list-config.js
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/java-action-info.js
>  PRE-CREATION 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
> 873c284 
>   

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153899
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 26, 2016, 5:04 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Oct. 26, 2016, 5:04 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53192: Create HOST_ORDERED Upgrade Pack

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53192/#review153897
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 26, 2016, 5:05 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53192/
> ---
> 
> (Updated Oct. 26, 2016, 5:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18679
> https://issues.apache.org/jira/browse/AMBARI-18679
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add skeleton and enum etc for Host-Ordered upgrades.
> 
> Host Ordered is a hybrid of Express and Rolling, whereby all components on a 
> host are stopped, the upgrade pauses, then the components start.  Continue 
> host-by-host until all services are upgraded.
> 
> This doesn't contain any new orchestration logic, that will happen as a 
> separate jira.  Upgrade Pack in this diff likely will be changed 
> significantly; it's just a starting point.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  be1f469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java
>  ff31008 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/upgrade-pack.xsd b02d941 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  6c81c61 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_host_ordered.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53192/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4665, Failures: 0, Errors: 0, Skipped: 42
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:10:24.649s
> [INFO] Finished at: Wed Oct 26 12:57:25 EDT 2016
> [INFO] Final Memory: 36M/660M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 53192: Create HOST_ORDERED Upgrade Pack

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53192/
---

(Updated Oct. 26, 2016, 1:05 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-18679
https://issues.apache.org/jira/browse/AMBARI-18679


Repository: ambari


Description
---

Add skeleton and enum etc for Host-Ordered upgrades.

Host Ordered is a hybrid of Express and Rolling, whereby all components on a 
host are stopped, the upgrade pauses, then the components start.  Continue 
host-by-host until all services are upgraded.

This doesn't contain any new orchestration logic, that will happen as a 
separate jira.  Upgrade Pack in this diff likely will be changed significantly; 
it's just a starting point.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 be1f469 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java
 ff31008 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml 
PRE-CREATION 
  ambari-server/src/main/resources/upgrade-pack.xsd b02d941 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 6c81c61 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_host_ordered.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53192/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4665, Failures: 0, Errors: 0, Skipped: 42

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:10:24.649s
[INFO] Finished at: Wed Oct 26 12:57:25 EDT 2016
[INFO] Final Memory: 36M/660M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153895
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 26, 2016, 8:04 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Oct. 26, 2016, 8:04 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/
---

(Updated Oct. 26, 2016, 5:04 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18704
https://issues.apache.org/jira/browse/AMBARI-18704


Repository: ambari


Description
---

This is necessary to debug issues on agent level. Where logs doesn't give 
enough insight.

The commit will include:

  * possibility to debug second agent process without restarting agent
  * show stack traces of where the process threads are without installing any 
additional modules as a separate commit


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
  ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 

Diff: https://reviews.apache.org/r/53194/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Andrew Onischuk]

> On Oct. 26, 2016, 4:38 p.m., Dmitro Lisnichenko wrote:
> > ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py, line 133
> > 
> >
> > is it secure? Is any user able to interrupt process and execute 
> > arbitrary python code from console?
> 
> Andrew Onischuk wrote:
> This doesn't interrupt the process and not able to anyhow change it's 
> context. It's readonly view of it's state.
> Also this is there for a long time, I have just moved it to other place.

I think the comment is incorrect there that's why it has confused you. I am 
gonna change the comment for that.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153890
---


On Oct. 26, 2016, 4:25 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Oct. 26, 2016, 4:25 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153893
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 26, 2016, 7:25 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Oct. 26, 2016, 7:25 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for Spark2 to AmbariPreupload script

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53188/#review153892
---


Ship it!




Ship It!

- Sandor Magyari


On Oct. 26, 2016, 2:33 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53188/
> ---
> 
> (Updated Oct. 26, 2016, 2:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Laszlo Puskas, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18700
> https://issues.apache.org/jira/browse/AMBARI-18700
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create `/hdp/spark2-events` in `Ambaripreupload.py`
> 2. Skip `make_tarfile` call in `spark_service.py` for sysprepped host
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  1cbca8b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 1082b5e 
> 
> Diff: https://reviews.apache.org/r/53188/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  * create sysprepped cluster
>  * submit blueprint with SPARK2 service and `sysprep_skip_copy_tarballs_hdfs: 
> true`
>  * submit `START_ONLY` cluster creation request
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Andrew Onischuk]

> On Oct. 26, 2016, 4:38 p.m., Dmitro Lisnichenko wrote:
> > ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py, line 133
> > 
> >
> > is it secure? Is any user able to interrupt process and execute 
> > arbitrary python code from console?

This doesn't interrupt the process and not able to anyhow change it's context. 
It's readonly view of it's state.
Also this is there for a long time, I have just moved it to other place.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153890
---


On Oct. 26, 2016, 4:25 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Oct. 26, 2016, 4:25 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153890
---




ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 


is it secure? Is any user able to interrupt process and execute arbitrary 
python code from console?


- Dmitro Lisnichenko


On Oct. 26, 2016, 7:25 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Oct. 26, 2016, 7:25 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 53189: AMBARI-18701 Add HDFS resources for HBase to AmbariPreupload script

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53189/#review153889
---


Ship it!




Ship It!

- Sandor Magyari


On Oct. 26, 2016, 2:44 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53189/
> ---
> 
> (Updated Oct. 26, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Laszlo Puskas, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18701
> https://issues.apache.org/jira/browse/AMBARI-18701
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create `/hbase`, `/apps/hbase/staging` and `/user/hbase` in 
> `Ambaripreupload.py`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  6f56512 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  1f32c41 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 1082b5e 
> 
> Diff: https://reviews.apache.org/r/53189/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  * create sysprepped cluster
>  * submit blueprint with HBASE service
>  * submit `START_ONLY` cluster creation request
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/#review153888
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 26, 2016, 4:25 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53194/
> ---
> 
> (Updated Жов. 26, 2016, 4:25 після полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18704
> https://issues.apache.org/jira/browse/AMBARI-18704
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is necessary to debug issues on agent level. Where logs doesn't give 
> enough insight.
> 
> The commit will include:
> 
>   * possibility to debug second agent process without restarting agent
>   * show stack traces of where the process threads are without installing any 
> additional modules as a separate commit
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
>   ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 
> 
> Diff: https://reviews.apache.org/r/53194/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 53194: Add code to improve debugging of ambari-agent related problems.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53194/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18704
https://issues.apache.org/jira/browse/AMBARI-18704


Repository: ambari


Description
---

This is necessary to debug issues on agent level. Where logs doesn't give 
enough insight.

The commit will include:

  * possibility to debug second agent process without restarting agent
  * show stack traces of where the process threads are without installing any 
additional modules as a separate commit


Diffs
-

  ambari-agent/src/main/python/ambari_agent/HeartbeatHandlers.py 4a3d372 
  ambari-agent/src/main/python/ambari_agent/RemoteDebugUtils.py f2a462b 
  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 8959640 

Diff: https://reviews.apache.org/r/53194/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 53087: Log Search schema meta data loader fix

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53087/
---

(Updated Oct. 26, 2016, 4:15 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

Fix pop up filter creation + handle log message include/exclude search 
wildcards properly


Bugs: AMBARI-18660
https://issues.apache.org/jira/browse/AMBARI-18660


Repository: ambari


Description
---

Log Search periodically queries the solr for the field meta data, which may not 
work on some clusters. Scheduling this task should be done by spring.

Also the luke request sent for this purpose must be requested from each shard, 
and the results must be summarized. Unfortunately the solr client can not be 
used for this purpose because it sends it to random shard.

Schema meta data interval is also configurable now via a new custom logsearch 
proprety:
logsearch.schema.fields.populate.interval.mins


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 79df3c2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 78012b0 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrUserPropsConfig.java
 38366d5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
 5945d72 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 2604f13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 2fbdb46 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 0e1d57c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 6389446 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 c83cd99 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
 35bc2dc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 418a405 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 e6f5103 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 aded1d4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 44d0c00 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/request/impl/CommonSearchRequest.java
 7001cf3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 492a5b2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 7a856d2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
 a4e3a1a 

Diff: https://reviews.apache.org/r/53087/diff/


Testing
---

Done.


Thanks,

Miklos Gergely

Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/
---

(Updated Oct. 26, 2016, 12:02 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.


Bugs: AMBARI-18699
https://issues.apache.org/jira/browse/AMBARI-18699


Repository: ambari


Description
---

The {{config-upgrade.xml}} packs which define the configuration changes during 
an upgrade do not have an XSD to validate them. They also contain and outdated 
and deprecated element called {{condition}} which can be replaced.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
 54431eb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
 a9b355a 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
c225cca 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
7d80a63 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
ecf324c 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
59e4ec5 
  ambari-server/src/main/resources/upgrade-config.xsd PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
 e764781 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
44f9e02 
  ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml 
90d64b4 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
 90d64b4 

Diff: https://reviews.apache.org/r/53185/diff/


Testing (updated)
---

Tests run: 4713, Failures: 0, Errors: 0, Skipped: 42

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 28:09 min
[INFO] Finished at: 2016-10-26T11:12:42-04:00
[INFO] Final Memory: 54M/744M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/
---

(Updated Oct. 26, 2016, 6:51 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

merged with latest 2.5


Bugs: AMBARI-18651
https://issues.apache.org/jira/browse/AMBARI-18651


Repository: ambari


Description
---

Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, the 
metainfo for ZKFC used {{false}}.  It 
was recently discovered that 2.5.0.0-1154+ has added this capability.

* Change versionAdvertised
* Add code to ZKFC python to hdp-select.  This code MUST check the 
stack_feature to ensure that it is executed ONLY for HDP-2.5+


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 1396bd8 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
912c441 
  
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 87247eb 
  
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
 5b32c4e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 a07d0e6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 f91a958 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 f383e80 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
 aa0ab0f 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dbde58b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
a3e4a64 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
 d22622e 

Diff: https://reviews.apache.org/r/53066/diff/


Testing
---

few runs on live cluster

mvn clean test


Thanks,

Dmitro Lisnichenko

Review Request 53192: Create HOST_ORDERED Upgrade Pack

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53192/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-18679
https://issues.apache.org/jira/browse/AMBARI-18679


Repository: ambari


Description
---

Add skeleton and enum etc for Host-Ordered upgrades.

Host Ordered is a hybrid of Express and Rolling, whereby all components on a 
host are stopped, the upgrade pauses, then the components start.  Continue 
host-by-host until all services are upgraded.

This doesn't contain any new orchestration logic, that will happen as a 
separate jira.  Upgrade Pack in this diff likely will be changed significantly; 
it's just a starting point.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 be1f469 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java
 ff31008 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml 
PRE-CREATION 
  ambari-server/src/main/resources/upgrade-pack.xsd b02d941 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 6c81c61 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_host_ordered.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53192/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53182/#review153884
---


Ship it!




Ship It!

- Prabhjyot Singh


On Oct. 26, 2016, 9:03 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53182/
> ---
> 
> (Updated Oct. 26, 2016, 9:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18690
> https://issues.apache.org/jira/browse/AMBARI-18690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - interpreter.json file isn't available before first server start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  8eb36c8 
> 
> Diff: https://reviews.apache.org/r/53182/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53066/#review153882
---


Ship it!




Ship It!

- Nate Cole


On Oct. 25, 2016, 12:21 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53066/
> ---
> 
> (Updated Oct. 25, 2016, 12:21 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-18651
> https://issues.apache.org/jira/browse/AMBARI-18651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select.  Therefore, 
> the metainfo for ZKFC used {{false}}.  
> It was recently discovered that 2.5.0.0-1154+ has added this capability.
> 
> * Change versionAdvertised
> * Add code to ZKFC python to hdp-select.  This code MUST check the 
> stack_feature to ensure that it is executed ONLY for HDP-2.5+
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  1396bd8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 912c441 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  87247eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java
>  5b32c4e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  a07d0e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  983cbdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  3e805a0 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py
>  aa0ab0f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dbde58b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml 
> a3e4a64 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java
>  3479334 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
>  18e2d3f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListenerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
>  d22622e 
> 
> Diff: https://reviews.apache.org/r/53066/diff/
> 
> 
> Testing
> ---
> 
> few runs on live cluster
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for Spark2 to AmbariPreupload script

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53188/#review153881
---


Ship it!




Ship It!

- Laszlo Puskas


On Oct. 26, 2016, 2:33 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53188/
> ---
> 
> (Updated Oct. 26, 2016, 2:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Laszlo Puskas, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18700
> https://issues.apache.org/jira/browse/AMBARI-18700
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create `/hdp/spark2-events` in `Ambaripreupload.py`
> 2. Skip `make_tarfile` call in `spark_service.py` for sysprepped host
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  1cbca8b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 1082b5e 
> 
> Diff: https://reviews.apache.org/r/53188/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  * create sysprepped cluster
>  * submit blueprint with SPARK2 service and `sysprep_skip_copy_tarballs_hdfs: 
> true`
>  * submit `START_ONLY` cluster creation request
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53174: AMBARI-18693 get_sysprep_skip_copy_tarballs_hdfs() always returns False

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53174/#review153880
---


Ship it!




Ship It!

- Sandor Magyari


On Oct. 26, 2016, 2:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53174/
> ---
> 
> (Updated Oct. 26, 2016, 2:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Laszlo Puskas, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18693
> https://issues.apache.org/jira/browse/AMBARI-18693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added missing `/configurations` prefix.
> 
> (See also https://reviews.apache.org/r/52792/)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  0355685 
> 
> Diff: https://reviews.apache.org/r/53174/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  * create sysprepped cluster
>  * submit blueprint with `sysprep_skip_copy_tarballs_hdfs: true`
>  * submit `START_ONLY` cluster creation request
> 
> ```
> $ cd /var/lib/ambari-agent/data
> $ grep -A6 'copy_to_hdfs.*mapreduce' *output*txt | grep mapreduce
> Called copy_to_hdfs tarball: mapreduce
> Skipping copying /usr/hdp/2.5.0.0-1245/hadoop/mapreduce.tar.gz to 
> /hdp/apps/2.5.0.0-1245/mapreduce/mapreduce.tar.gz for mapreduce as it is a 
> sys prepped host.
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53087: Log Search schema meta data loader fix

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53087/#review153875
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 26, 2016, 9:32 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53087/
> ---
> 
> (Updated Oct. 26, 2016, 9:32 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18660
> https://issues.apache.org/jira/browse/AMBARI-18660
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search periodically queries the solr for the field meta data, which may 
> not work on some clusters. Scheduling this task should be done by spring.
> 
> Also the luke request sent for this purpose must be requested from each 
> shard, and the results must be summarized. Unfortunately the solr client can 
> not be used for this purpose because it sends it to random shard.
> 
> Schema meta data interval is also configurable now via a new custom logsearch 
> proprety:
> logsearch.schema.fields.populate.interval.mins
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  79df3c2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
>  78012b0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrUserPropsConfig.java
>  38366d5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
>  5945d72 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
>  2604f13 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
>  2fbdb46 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
>  0e1d57c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
>  6389446 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
>  c83cd99 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  35bc2dc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  418a405 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  e6f5103 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  aded1d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  44d0c00 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
>  492a5b2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
>  7a856d2 
> 
> Diff: https://reviews.apache.org/r/53087/diff/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 53189: AMBARI-18701 Add HDFS resources for HBase to AmbariPreupload script

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53189/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Laszlo Puskas, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-18701
https://issues.apache.org/jira/browse/AMBARI-18701


Repository: ambari


Description
---

Create `/hbase`, `/apps/hbase/staging` and `/user/hbase` in 
`Ambaripreupload.py`.


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 6f56512 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 1f32c41 
  ambari-server/src/main/resources/scripts/Ambaripreupload.py 1082b5e 

Diff: https://reviews.apache.org/r/53189/diff/


Testing
---

Manual testing:
 * create sysprepped cluster
 * submit blueprint with HBASE service
 * submit `START_ONLY` cluster creation request


Thanks,

Attila Doroszlai

Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/#review153874
---


Ship it!




Ship It!

- Nate Cole


On Oct. 26, 2016, 8:19 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53185/
> ---
> 
> (Updated Oct. 26, 2016, 8:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-18699
> https://issues.apache.org/jira/browse/AMBARI-18699
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{config-upgrade.xml}} packs which define the configuration changes 
> during an upgrade do not have an XSD to validate them. They also contain and 
> outdated and deprecated element called {{condition}} which can be replaced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  54431eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  a9b355a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> c225cca 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 7d80a63 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> ecf324c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 59e4ec5 
>   ambari-server/src/main/resources/upgrade-config.xsd PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  e764781 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> 44f9e02 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml 
> 90d64b4 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
>  90d64b4 
> 
> Diff: https://reviews.apache.org/r/53185/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 53188: AMBARI-18700 Add HDFS resources for Spark2 to AmbariPreupload script

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53188/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Laszlo Puskas, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-18700
https://issues.apache.org/jira/browse/AMBARI-18700


Repository: ambari


Description
---

1. Create `/hdp/spark2-events` in `Ambaripreupload.py`
2. Skip `make_tarfile` call in `spark_service.py` for sysprepped host


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 1cbca8b 
  ambari-server/src/main/resources/scripts/Ambaripreupload.py 1082b5e 

Diff: https://reviews.apache.org/r/53188/diff/


Testing
---

Manual testing:
 * create sysprepped cluster
 * submit blueprint with SPARK2 service and `sysprep_skip_copy_tarballs_hdfs: 
true`
 * submit `START_ONLY` cluster creation request


Thanks,

Attila Doroszlai

Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/#review153872
---


Ship it!




Ship It!

- Robert Levas


On Oct. 26, 2016, 8:19 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53185/
> ---
> 
> (Updated Oct. 26, 2016, 8:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-18699
> https://issues.apache.org/jira/browse/AMBARI-18699
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{config-upgrade.xml}} packs which define the configuration changes 
> during an upgrade do not have an XSD to validate them. They also contain and 
> outdated and deprecated element called {{condition}} which can be replaced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
>  54431eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
>  a9b355a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> c225cca 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 7d80a63 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> ecf324c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 59e4ec5 
>   ambari-server/src/main/resources/upgrade-config.xsd PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  e764781 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 
> 44f9e02 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml 
> 90d64b4 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
>  90d64b4 
> 
> Diff: https://reviews.apache.org/r/53185/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 53187: AMBARI-18691: Improve and Update Workflow designer to support coordinators and bundles and enhancements

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53187/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-18691
https://issues.apache.org/jira/browse/AMBARI-18691


Repository: ambari


Description
---

Coordinators
bundles
multiple tabs
undo/delete support
copy/paste
improved validations
Fix JS6 lint issues
Dag generation in the UI
Use cytoscape for diagraming


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/JobType.java 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
 3ed6352 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java
 PRE-CREATION 
  contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/.jshintrc PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/.gitkeep 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/archive-config.js 
d53b459 
  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/conditional-data-input.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/confirmation-dialog.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/credentials-config.js
 f100808 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/data-input-output-config.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/data-input.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/dataset-config.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
 84d1393 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js 
324be66 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action-info.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action.js 
1fbe4c9 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/email-action-info.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/email-action.js 
357fe90 
  contrib/views/wfmanager/src/main/resources/ui/app/components/file-config.js 
46d30d1 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
bd2944b 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action-info.js 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 
98a292d 
  contrib/views/wfmanager/src/main/resources/ui/app/components/fsaction-info.js 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 
fc5fd37 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action-info.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js 
125aac3 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action-info.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js 
f8b53c5 
  contrib/views/wfmanager/src/main/resources/ui/app/components/info-header.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/instance-list-config.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/java-action-info.js
 PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
873c284 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
ce78e59 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/killnode-config.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/killnode-manager.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js 
c3782a3 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/map-reduce-action-info.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/name-value-config.js
 45dea7a 
  

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

[Mugdha Varadkar]

> On Oct. 25, 2016, 4:32 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 1771
> > 
> >
> > Technically item is an "index"

yes item is meant to be an index for the requiredServices. Updated in latest 
patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53129/#review153806
---


On Oct. 26, 2016, 10:53 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53129/
> ---
> 
> (Updated Oct. 26, 2016, 10:53 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18671
> https://issues.apache.org/jira/browse/AMBARI-18671
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add below properties under kms-site.xml having value as '*', if YARN|SPARK 
> services are installed
> 
> - hadoop.kms.proxyuser.[livy|yarn].groups
> - hadoop.kms.proxyuser.[livy|yarn].hosts
> - hadoop.kms.proxyuser.[livy|yarn].users
> 
> Also with above changes need to revert changes done for AMBARI-18096
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 24b9f6e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 986ca69 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> cd69dc3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 72e59aa 
> 
> Diff: https://reviews.apache.org/r/53129/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger Kms installation with Yarn|Spark on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53129/
---

(Updated Oct. 26, 2016, 10:53 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
and Velmurugan Periasamy.


Bugs: AMBARI-18671
https://issues.apache.org/jira/browse/AMBARI-18671


Repository: ambari


Description
---

Add below properties under kms-site.xml having value as '*', if YARN|SPARK 
services are installed

- hadoop.kms.proxyuser.[livy|yarn].groups
- hadoop.kms.proxyuser.[livy|yarn].hosts
- hadoop.kms.proxyuser.[livy|yarn].users

Also with above changes need to revert changes done for AMBARI-18096


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
24b9f6e 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
986ca69 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
cd69dc3 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 72e59aa 

Diff: https://reviews.apache.org/r/53129/diff/


Testing
---

Tested Ranger Kms installation with Yarn|Spark on centos 6


Thanks,

Mugdha Varadkar

Review Request 53183: Too many Stack advisor calls filling up disk space (Kerberized environment)

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53183/
---

Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18697
https://issues.apache.org/jira/browse/AMBARI-18697


Repository: ambari


Description
---

Got disk full while on ambari server while adding a service, I deleted all 
stack recommendation output directories and retried, but hit the issue again.
AMCImpl: 2317 => kerberosHelper.configureService(cluster, scHost);
We are making this call explicitly for every SCH on adding service. For 
clusters with 1000 nodes, stack_adviser will be called 1000 times with the same 
request.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 09e49ef 

Diff: https://reviews.apache.org/r/53183/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 53087: Log Search schema meta data loader fix

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53087/
---

(Updated Oct. 26, 2016, 9:32 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

Minor refactoring and unused code removal


Bugs: AMBARI-18660
https://issues.apache.org/jira/browse/AMBARI-18660


Repository: ambari


Description
---

Log Search periodically queries the solr for the field meta data, which may not 
work on some clusters. Scheduling this task should be done by spring.

Also the luke request sent for this purpose must be requested from each shard, 
and the results must be summarized. Unfortunately the solr client can not be 
used for this purpose because it sends it to random shard.

Schema meta data interval is also configurable now via a new custom logsearch 
proprety:
logsearch.schema.fields.populate.interval.mins


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 79df3c2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 78012b0 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrUserPropsConfig.java
 38366d5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
 5945d72 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 2604f13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 2fbdb46 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 0e1d57c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 6389446 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 c83cd99 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
 35bc2dc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 418a405 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 e6f5103 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 aded1d4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 44d0c00 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 492a5b2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 7a856d2 

Diff: https://reviews.apache.org/r/53087/diff/


Testing
---

Done.


Thanks,

Miklos Gergely

Review Request 53182: Zeppelin fails to start after deployment due to timing issue

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53182/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-18690
https://issues.apache.org/jira/browse/AMBARI-18690


Repository: ambari


Description
---

- interpreter.json file isn't available before first server start


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 8eb36c8 

Diff: https://reviews.apache.org/r/53182/diff/


Testing
---

manually tested on CentOS


Thanks,

Renjith Kamath