Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54028/#review156870
---


Ship it!




Ship It!

- Tim Thorpe


On Nov. 24, 2016, 9:18 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54028/
> ---
> 
> (Updated Nov. 24, 2016, 9:18 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18962
> https://issues.apache.org/jira/browse/AMBARI-18962
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> check_package_condition method in script.py was added via AMBARI-14739 to 
> make the conditionally installing RPMs controlled jointly by metainfo.xml and 
> functions defined in package_conditions.py. For example, with the following 
> metainfo.xml section. The package_conditions.py has the 
> should_install_ams_collector function implementation.
> 
> ambari-metrics-collector
> true
> should_install_ams_collector
> 
> 
> The issue is that this is not easily extendable by services extensions 
> (installed via mpack), as any third party service needs to add functions to 
> package_conditions.py in resource_management library.
> 
> This JIRA proposes to make check_package_condition overwritable at the 
> service level ( by changing it from a static method to a instance method).
> 
> Then each service can still maintain the metainfo.xml section, while 
> implement its own check_package_condition that pulls in its own 
> package_condition util.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> f8df842 
> 
> Diff: https://reviews.apache.org/r/54028/diff/
> 
> 
> Testing
> ---
> 
> existing unit tests still cover the code change
> patch a cluster with the new script.py, run service restart, verify the 
> install check still passes.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54028/
---

(Updated Nov. 24, 2016, 9:18 p.m.)


Review request for Ambari, Andrew Onischuk and Tim Thorpe.


Bugs: AMBARI-18962
https://issues.apache.org/jira/browse/AMBARI-18962


Repository: ambari


Description
---

check_package_condition method in script.py was added via AMBARI-14739 to make 
the conditionally installing RPMs controlled jointly by metainfo.xml and 
functions defined in package_conditions.py. For example, with the following 
metainfo.xml section. The package_conditions.py has the 
should_install_ams_collector function implementation.

ambari-metrics-collector
true
should_install_ams_collector


The issue is that this is not easily extendable by services extensions 
(installed via mpack), as any third party service needs to add functions to 
package_conditions.py in resource_management library.

This JIRA proposes to make check_package_condition overwritable at the service 
level ( by changing it from a static method to a instance method).

Then each service can still maintain the metainfo.xml section, while implement 
its own check_package_condition that pulls in its own package_condition util.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
f8df842 

Diff: https://reviews.apache.org/r/54028/diff/


Testing (updated)
---

existing unit tests still cover the code change
patch a cluster with the new script.py, run service restart, verify the install 
check still passes.


Thanks,

Di Li

Re: Review Request 54031: Remove Zeppelin View from Ambari

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review156863
---


Ship it!




Ship It!

- Prabhjyot Singh


On Nov. 23, 2016, 3:40 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> ---
> 
> (Updated Nov. 23, 2016, 3:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> details in the jira ticket
> 
> 
> Diffs
> -
> 
>   contrib/views/pom.xml ca5aef4 
>   contrib/views/zeppelin/pom.xml 6a7f585 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java
>  8f94260 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  ab61a3d 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e 
>   contrib/views/zeppelin/src/main/resources/view.xml 323e09a 
> 
> Diff: https://reviews.apache.org/r/54031/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54031: Remove Zeppelin View from Ambari

[Renjith Kamath]

> On Nov. 23, 2016, 7:23 p.m., Alejandro Fernandez wrote:
> > What will happen to existing clusters that have Zeppelin view? Does the 
> > view need to be deleted from the DB after they upgrade Ambari?

will update this request with db changes


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review156766
---


On Nov. 23, 2016, 3:40 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> ---
> 
> (Updated Nov. 23, 2016, 3:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> details in the jira ticket
> 
> 
> Diffs
> -
> 
>   contrib/views/pom.xml ca5aef4 
>   contrib/views/zeppelin/pom.xml 6a7f585 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java
>  8f94260 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  ab61a3d 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e 
>   contrib/views/zeppelin/src/main/resources/view.xml 323e09a 
> 
> Diff: https://reviews.apache.org/r/54031/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54064: Optimize loading of views in cloud environments

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156850
---


Ship it!




Ship It!

- Sandor Magyari


On Nov. 24, 2016, 4:09 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54064/
> ---
> 
> (Updated Nov. 24, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18979
> https://issues.apache.org/jira/browse/AMBARI-18979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On cloud environments loading views can last longer increasing the time 
> ambari-server is available to receive requests.
> The functionality adds the possibility to load only system views during the 
> server startup, loading the rest of the views are deferred toill the cluster 
> is configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  863c948 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 7ec5972 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  341633e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
> 3425691 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 7f58485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  279340e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  7ae4485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  4a71699 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  6b560ee 
> 
> Diff: https://reviews.apache.org/r/54064/diff/
> 
> 
> Testing
> ---
> 
> Manually done locally and cloud env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 54064: Optimize loading of views in cloud environments

[Laszlo Puskas]

> On Nov. 24, 2016, 3:03 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> >  line 4452
> > 
> >
> > Better return `boolean`.

I don't think this makes any difference in the compiled code.


> On Nov. 24, 2016, 3:03 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java,
> >  line 26
> > 
> >
> > Could be `final`.

Fixing it and the member name also changed to comply java naming


> On Nov. 24, 2016, 3:03 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java,
> >  lines 288-294
> > 
> >
> > I don't see the result of the `Callable` being used anywhere, so I 
> > guess it would be enough to `execute` a `Runnable` instead.

Makes it easier to unit test it (probably later)


> On Nov. 24, 2016, 3:03 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java,
> >  lines 1571-1610
> > 
> >
> > Indentation is +1 level than needed.

Formatted the whole class as it seemed the indentation was messed.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156838
---


On Nov. 24, 2016, 4:09 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54064/
> ---
> 
> (Updated Nov. 24, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18979
> https://issues.apache.org/jira/browse/AMBARI-18979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On cloud environments loading views can last longer increasing the time 
> ambari-server is available to receive requests.
> The functionality adds the possibility to load only system views during the 
> server startup, loading the rest of the views are deferred toill the cluster 
> is configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  863c948 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 7ec5972 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  341633e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
> 3425691 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 7f58485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  279340e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  7ae4485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  4a71699 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  6b560ee 
> 
> Diff: https://reviews.apache.org/r/54064/diff/
> 
> 
> Testing
> ---
> 
> Manually done locally and cloud env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 54064: Optimize loading of views in cloud environments

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/
---

(Updated Nov. 24, 2016, 4:09 p.m.)


Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
Toader.


Changes
---

Fixed review notes.


Bugs: AMBARI-18979
https://issues.apache.org/jira/browse/AMBARI-18979


Repository: ambari


Description
---

On cloud environments loading views can last longer increasing the time 
ambari-server is available to receive requests.
The functionality adds the possibility to load only system views during the 
server startup, loading the rest of the views are deferred toill the cluster is 
configured.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 863c948 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
7ec5972 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 341633e 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
3425691 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
7f58485 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
 279340e 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
 7ae4485 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 4a71699 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 
6b560ee 

Diff: https://reviews.apache.org/r/54064/diff/


Testing
---

Manually done locally and cloud env.


Thanks,

Laszlo Puskas

Re: Review Request 54064: Optimize loading of views in cloud environments

[Sebastian Toader]

> On Nov. 24, 2016, 4:01 p.m., Sebastian Toader wrote:
> >

Also can we test the following scenario? 
1. Create a cluster using Blueprint and view.extract-after-cluster-config=true. 
2. Stop Ambari once the cluster created and deployed. 
3. Drop a new view jar into Ambari views archive directory. 
4. Start Ambari server.
5. Check that ambari server extracted and deployed the newly added view.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156840
---


On Nov. 24, 2016, 3:02 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54064/
> ---
> 
> (Updated Nov. 24, 2016, 3:02 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18979
> https://issues.apache.org/jira/browse/AMBARI-18979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On cloud environments loading views can last longer increasing the time 
> ambari-server is available to receive requests.
> The functionality adds the possibility to load only system views during the 
> server startup, loading the rest of the views are deferred toill the cluster 
> is configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  863c948 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 7ec5972 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  341633e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
> 3425691 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 7f58485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  279340e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  7ae4485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  4a71699 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  6b560ee 
> 
> Diff: https://reviews.apache.org/r/54064/diff/
> 
> 
> Testing
> ---
> 
> Manually done locally and cloud env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 54064: Optimize loading of views in cloud environments

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156838
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 1866)


1. typo in: "other then" -> "other than"
2. I think something like "Whether to wait with extraction of non-system 
views until cluster creation finished." would be better than "When to extract 
views (other than system views)."



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 4452)


Better return `boolean`.



ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
 (line 26)


Could be `final`.



ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 (lines 288 - 294)


I don't see the result of the `Callable` being used anywhere, so I guess it 
would be enough to `execute` a `Runnable` instead.



ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
(lines 519 - 524)


The whole `if-else` could be simplified to:

```
boolean systemViewsOnly = configuration.extractViewsAfterClusterConfig() &&
  clustersProvider.get().getClusters().isEmpty();
readViewArchives(systemOnly, false, ALL_VIEWS_REG_EXP);
```



ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
(line 1013)


Typo: "Start" -> "Finished"



ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
(lines 1571 - 1610)


Indentation is +1 level than needed.


- Attila Doroszlai


On Nov. 24, 2016, 3:02 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54064/
> ---
> 
> (Updated Nov. 24, 2016, 3:02 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18979
> https://issues.apache.org/jira/browse/AMBARI-18979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On cloud environments loading views can last longer increasing the time 
> ambari-server is available to receive requests.
> The functionality adds the possibility to load only system views during the 
> server startup, loading the rest of the views are deferred toill the cluster 
> is configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  863c948 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 7ec5972 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  341633e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
> 3425691 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 7f58485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  279340e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  7ae4485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  4a71699 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  6b560ee 
> 
> Diff: https://reviews.apache.org/r/54064/diff/
> 
> 
> Testing
> ---
> 
> Manually done locally and cloud env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 54064: Optimize loading of views in cloud environments

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156840
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (lines 1866 - 1873)


If this feature only works with Blueprint deploymets that specify that in 
the description.

I can't see where the ClusterConfigFinish event is fired when the cluster 
is created via the UI.



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 1868)


'cluster created' might be confusing as views are deployed after cluster 
configuration.


- Sebastian Toader


On Nov. 24, 2016, 3:02 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54064/
> ---
> 
> (Updated Nov. 24, 2016, 3:02 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18979
> https://issues.apache.org/jira/browse/AMBARI-18979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On cloud environments loading views can last longer increasing the time 
> ambari-server is available to receive requests.
> The functionality adds the possibility to load only system views during the 
> server startup, loading the rest of the views are deferred toill the cluster 
> is configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  863c948 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 7ec5972 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  341633e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
> 3425691 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 7f58485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  279340e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  7ae4485 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  4a71699 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  6b560ee 
> 
> Diff: https://reviews.apache.org/r/54064/diff/
> 
> 
> Testing
> ---
> 
> Manually done locally and cloud env.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 54064: Optimize loading of views in cloud environments

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/
---

Review request for Ambari.


Bugs: AMBARI-18979
https://issues.apache.org/jira/browse/AMBARI-18979


Repository: ambari


Description
---

On cloud environments loading views can last longer increasing the time 
ambari-server is available to receive requests.
The functionality adds the possibility to load only system views during the 
server startup, loading the rest of the views are deferred toill the cluster is 
configured.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 863c948 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
7ec5972 
  
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigFinishedEvent.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 341633e 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 
3425691 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
7f58485 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
 279340e 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
 7ae4485 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 4a71699 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 
6b560ee 

Diff: https://reviews.apache.org/r/54064/diff/


Testing
---

Manually done locally and cloud env.


Thanks,

Laszlo Puskas

Re: Review Request 54063: typeahead was lost while bootstrap 2 to bootstrap3 mirgation

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54063/
---

(Updated Nov. 24, 2016, 1:52 p.m.)


Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-18985
https://issues.apache.org/jira/browse/AMBARI-18985


Repository: ambari


Description
---

{{typeahead}} was a part of bootstrap2. After upgrade to the bootstrap3 it was 
deleted. {{typeahead}} is used on the assign master page when there are lot of 
hosts in the cluster.


Diffs
-

  ambari-web/app/views/common/assign_master_components_view.js 53859f6 
  ambari-web/brunch-config.js 27a6057 
  ambari-web/vendor/scripts/jquery.typeahead.js PRE-CREATION 

Diff: https://reviews.apache.org/r/54063/diff/


Testing
---

19928 tests complete (32 seconds)
  154 tests pending


Thanks,

Oleg Nechiporenko

Re: Review Request 54059: Test and fix new tables styles on Ambari (part 5)

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54059/
---

(Updated Лис. 24, 2016, 11:47 до полудня)


Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-18984
https://issues.apache.org/jira/browse/AMBARI-18984


Repository: ambari


Description (updated)
---

- Highlight active table rows
- Shift to table markup in the following places:
  *-* Edit Repositories popup
  *-* Alerts popup
  *-* Background Operations popup
  *-* Host progress log popup
- Complete restyling in Service Auto Start section


Diffs
-

  ambari-web/app/messages.js aa4e2aa 
  ambari-web/app/styles/alerts.less bf3eaf3 
  ambari-web/app/styles/application.less aab3287 
  ambari-web/app/styles/modal_popups.less 1125c2a 
  ambari-web/app/styles/stack_versions.less aca9c65 
  ambari-web/app/styles/wizard.less 747c7eb 
  ambari-web/app/templates/common/configs/overrideWindow.hbs 1154bea 
  ambari-web/app/templates/common/host_progress_popup.hbs c6c8bf8 
  ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 7ace34c 
  ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs 
a717341 
  ambari-web/app/templates/experimental.hbs 640393b 
  ambari-web/app/templates/main/admin/service_auto_start.hbs be101e7 
  ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 
18760ec 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
84666a3 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history_details.hbs 
f9d0a2a 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_task.hbs 488fe39 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs 
445cfd4 
  ambari-web/app/templates/main/host/bulk_operation_confirm_popup.hbs e9f55a9 
  ambari-web/app/templates/wizard/step1.hbs dce6b27 
  ambari-web/app/templates/wizard/step9/step9HostTasksLogPopup.hbs 9640e32 
  ambari-web/app/utils/host_progress_popup.js 5bd0ceb 
  ambari-web/app/views/main/host.js 6043d63 
  ambari-web/app/views/wizard/step3_view.js 2f57b9e 
  ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js 3dad7d8 

Diff: https://reviews.apache.org/r/54059/diff/


Testing
---

19928 tests complete (21 seconds)
  154 tests pending


Thanks,

Andriy Babiichuk

Re: Review Request 54059: Test and fix new tables styles on Ambari (part 5)

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54059/#review156830
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 24, 2016, 11:24 д.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54059/
> ---
> 
> (Updated Ноя. 24, 2016, 11:24 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-18984
> https://issues.apache.org/jira/browse/AMBARI-18984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Highlight active table rows
> - Shift to table markup in the following places:
> *- Edit Repositories popup
> *- Alerts popup
> *- Background Operations popup
> *- Host progress log popup
> - Complete restyling in Service Auto Start section
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js aa4e2aa 
>   ambari-web/app/styles/alerts.less bf3eaf3 
>   ambari-web/app/styles/application.less aab3287 
>   ambari-web/app/styles/modal_popups.less 1125c2a 
>   ambari-web/app/styles/stack_versions.less aca9c65 
>   ambari-web/app/styles/wizard.less 747c7eb 
>   ambari-web/app/templates/common/configs/overrideWindow.hbs 1154bea 
>   ambari-web/app/templates/common/host_progress_popup.hbs c6c8bf8 
>   ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 7ace34c 
>   ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs 
> a717341 
>   ambari-web/app/templates/experimental.hbs 640393b 
>   ambari-web/app/templates/main/admin/service_auto_start.hbs be101e7 
>   ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 
> 18760ec 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> 84666a3 
>   
> ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history_details.hbs 
> f9d0a2a 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_task.hbs 488fe39 
>   ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs 
> 445cfd4 
>   ambari-web/app/templates/main/host/bulk_operation_confirm_popup.hbs e9f55a9 
>   ambari-web/app/templates/wizard/step1.hbs dce6b27 
>   ambari-web/app/templates/wizard/step9/step9HostTasksLogPopup.hbs 9640e32 
>   ambari-web/app/utils/host_progress_popup.js 5bd0ceb 
>   ambari-web/app/views/main/host.js 6043d63 
>   ambari-web/app/views/wizard/step3_view.js 2f57b9e 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js 3dad7d8 
> 
> Diff: https://reviews.apache.org/r/54059/diff/
> 
> 
> Testing
> ---
> 
> 19928 tests complete (21 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 54059: Test and fix new tables styles on Ambari (part 5)

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54059/
---

Review request for Ambari.


Bugs: AMBARI-18984
https://issues.apache.org/jira/browse/AMBARI-18984


Repository: ambari


Description
---

- Highlight active table rows
- Shift to table markup in the following places:
*- Edit Repositories popup
*- Alerts popup
*- Background Operations popup
*- Host progress log popup
- Complete restyling in Service Auto Start section


Diffs
-

  ambari-web/app/messages.js aa4e2aa 
  ambari-web/app/styles/alerts.less bf3eaf3 
  ambari-web/app/styles/application.less aab3287 
  ambari-web/app/styles/modal_popups.less 1125c2a 
  ambari-web/app/styles/stack_versions.less aca9c65 
  ambari-web/app/styles/wizard.less 747c7eb 
  ambari-web/app/templates/common/configs/overrideWindow.hbs 1154bea 
  ambari-web/app/templates/common/host_progress_popup.hbs c6c8bf8 
  ambari-web/app/templates/common/modal_popups/alerts_popup.hbs 7ace34c 
  ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs 
a717341 
  ambari-web/app/templates/experimental.hbs 640393b 
  ambari-web/app/templates/main/admin/service_auto_start.hbs be101e7 
  ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 
18760ec 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
84666a3 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history_details.hbs 
f9d0a2a 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_task.hbs 488fe39 
  ambari-web/app/templates/main/alerts/add_definition_to_group_popup.hbs 
445cfd4 
  ambari-web/app/templates/main/host/bulk_operation_confirm_popup.hbs e9f55a9 
  ambari-web/app/templates/wizard/step1.hbs dce6b27 
  ambari-web/app/templates/wizard/step9/step9HostTasksLogPopup.hbs 9640e32 
  ambari-web/app/utils/host_progress_popup.js 5bd0ceb 
  ambari-web/app/views/main/host.js 6043d63 
  ambari-web/app/views/wizard/step3_view.js 2f57b9e 
  ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js 3dad7d8 

Diff: https://reviews.apache.org/r/54059/diff/


Testing
---

19928 tests complete (21 seconds)
  154 tests pending


Thanks,

Andriy Babiichuk

Re: Review Request 54055: Failures due to timeout don't report any reason

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54055/#review156825
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 24, 2016, 10:57 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54055/
> ---
> 
> (Updated Nov. 24, 2016, 10:57 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18982
> https://issues.apache.org/jira/browse/AMBARI-18982
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Just to find out that install task was canceled due to timeout me and Dmytro 
> Grinenko had to do a half an hour debugging including running though java 
> code, just to find out the failure reason.
> 
> The failure reason should be obvious and always printed printed to task 
> stderr/stdout so user can see it.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> fbc1509 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
> 9f1241e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  7a84536 
> 
> Diff: https://reviews.apache.org/r/54055/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 54055: Failures due to timeout don't report any reason

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54055/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18982
https://issues.apache.org/jira/browse/AMBARI-18982


Repository: ambari


Description
---

Just to find out that install task was canceled due to timeout me and Dmytro 
Grinenko had to do a half an hour debugging including running though java code, 
just to find out the failure reason.

The failure reason should be obvious and always printed printed to task 
stderr/stdout so user can see it.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
fbc1509 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 
9f1241e 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 7a84536 

Diff: https://reviews.apache.org/r/54055/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk