Re: Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54866/#review159662
---


Ship it!




I agree it's a big patch, but I'm OK since the changes are just repeated a lot.

- Jonathan Hurley


On Dec. 19, 2016, 12:18 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54866/
> ---
> 
> (Updated Dec. 19, 2016, 12:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Miklos Gergely, and Nate Cole.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Eliminate unchecked cast warnings in `*AuditEvent` classes
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractAuditEvent.java
>  558b0eadf310e42375783e56056a45329a786498 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractUserAuditEvent.java
>  6aab071fe27fb1609d4261b423aca02929c5f3c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AccessUnauthorizedAuditEvent.java
>  b6e60e13463a65a197b824d29c35df1700b6ae00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/LoginAuditEvent.java
>  223dd189843e4264cfedcecd371b0dfb30cec5a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/LogoutAuditEvent.java
>  3ce8c310f784c77d9c3aa8c70aab9d2fa4068b89 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/OperationStatusAuditEvent.java
>  fd0068e5564f3da800c67fce9d294697a47dabe7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/TaskStatusAuditEvent.java
>  1682e7475d1e04be40fb9e09ffacad62d26213aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java
>  3de4e489dc4476d893557fcb35b0f0cfb12679dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/ChangeSecurityStateKerberosAuditEvent.java
>  ffb7e8a54d232cf9bae0800c8e2b0dd9f3702e84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreateKeyTabKerberosAuditEvent.java
>  7ac3ef4fe1c0fc05fe7b603446406f547c98094e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java
>  51c3c6b11bc3a41d63cd5f2bb4a5d17626673e61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java
>  1e3dd36cc15c0c07de5825d090f1bfd8051b0bd1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java
>  c947fb1da53f146a5f826d0cf2466b326a6adda2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertGroupRequestAuditEvent.java
>  cd92ba0246c4b0f4794e7174856affabc720b7dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertTargetRequestAuditEvent.java
>  1c4a8d53d3f45032100736858ffb9af295d8ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddBlueprintRequestAuditEvent.java
>  84431abf69ab436aa7abb1029625eec15b1500e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java
>  c2486655ceaa614b9824f7f2a5441b6d3a3c26a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddCredentialRequestAuditEvent.java
>  5d27abf0e9acf1a36c10cab642dd6fb7a3cf0758 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddHostRequestAuditEvent.java
>  c24175df9420fc173c82a0bd0edcbfd2f1c05355 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryRequestAuditEvent.java
>  ed6c1cdce68955bb16efbe2558d41be727a8d446 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryVersionRequestAuditEvent.java
>  b4d3401a87af5b3cccba02f2fe7134f6a2382e71 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRequestRequestAuditEvent.java
>  004c24a0c7764500bbe03159312bb15d222617e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUpgradeRequestAuditEvent.java
>  69b4536e865cec91f6d7aefd180e48e1d752ddba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUserToGroupRequestAuditEvent.java
>  33293c0f4fe9d6300ab3af51d314dc04a8e2ae53 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddViewInstanceRequestAuditEvent.java
>  d9ab59ab9151d7200883055d7dc1867b6f3338ae 
>   
>

Re: Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Alejandro Fernandez 


> On Dec. 19, 2016, 9:51 p.m., Nate Cole wrote:
> > While I see this patch is _technically_ correct, it's awfully big for just 
> > a simple change that could be handled with a 
> > @SuppressWarnings("unchecked").  I'll let others comment.

+1 on supressing that warning


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54866/#review159654
---


On Dec. 19, 2016, 5:18 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54866/
> ---
> 
> (Updated Dec. 19, 2016, 5:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Miklos Gergely, and Nate Cole.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Eliminate unchecked cast warnings in `*AuditEvent` classes
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractAuditEvent.java
>  558b0eadf310e42375783e56056a45329a786498 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractUserAuditEvent.java
>  6aab071fe27fb1609d4261b423aca02929c5f3c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AccessUnauthorizedAuditEvent.java
>  b6e60e13463a65a197b824d29c35df1700b6ae00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/LoginAuditEvent.java
>  223dd189843e4264cfedcecd371b0dfb30cec5a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/LogoutAuditEvent.java
>  3ce8c310f784c77d9c3aa8c70aab9d2fa4068b89 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/OperationStatusAuditEvent.java
>  fd0068e5564f3da800c67fce9d294697a47dabe7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/TaskStatusAuditEvent.java
>  1682e7475d1e04be40fb9e09ffacad62d26213aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java
>  3de4e489dc4476d893557fcb35b0f0cfb12679dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/ChangeSecurityStateKerberosAuditEvent.java
>  ffb7e8a54d232cf9bae0800c8e2b0dd9f3702e84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreateKeyTabKerberosAuditEvent.java
>  7ac3ef4fe1c0fc05fe7b603446406f547c98094e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java
>  51c3c6b11bc3a41d63cd5f2bb4a5d17626673e61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java
>  1e3dd36cc15c0c07de5825d090f1bfd8051b0bd1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java
>  c947fb1da53f146a5f826d0cf2466b326a6adda2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertGroupRequestAuditEvent.java
>  cd92ba0246c4b0f4794e7174856affabc720b7dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertTargetRequestAuditEvent.java
>  1c4a8d53d3f45032100736858ffb9af295d8ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddBlueprintRequestAuditEvent.java
>  84431abf69ab436aa7abb1029625eec15b1500e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java
>  c2486655ceaa614b9824f7f2a5441b6d3a3c26a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddCredentialRequestAuditEvent.java
>  5d27abf0e9acf1a36c10cab642dd6fb7a3cf0758 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddHostRequestAuditEvent.java
>  c24175df9420fc173c82a0bd0edcbfd2f1c05355 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryRequestAuditEvent.java
>  ed6c1cdce68955bb16efbe2558d41be727a8d446 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryVersionRequestAuditEvent.java
>  b4d3401a87af5b3cccba02f2fe7134f6a2382e71 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRequestRequestAuditEvent.java
>  004c24a0c7764500bbe03159312bb15d222617e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUpgradeRequestAuditEvent.java
>  69b4536e865cec91f6d7aefd180e48e1d752ddba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUserToGroupRequestAuditEvent.java
>  33293c0f4fe9d6300ab3af51d314dc04a8e2ae53 
>   
>

Re: Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54866/#review159654
---


Ship it!




While I see this patch is _technically_ correct, it's awfully big for just a 
simple change that could be handled with a @SuppressWarnings("unchecked").  
I'll let others comment.

- Nate Cole


On Dec. 19, 2016, 12:18 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54866/
> ---
> 
> (Updated Dec. 19, 2016, 12:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Miklos Gergely, and Nate Cole.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Eliminate unchecked cast warnings in `*AuditEvent` classes
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractAuditEvent.java
>  558b0eadf310e42375783e56056a45329a786498 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractUserAuditEvent.java
>  6aab071fe27fb1609d4261b423aca02929c5f3c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/AccessUnauthorizedAuditEvent.java
>  b6e60e13463a65a197b824d29c35df1700b6ae00 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/LoginAuditEvent.java
>  223dd189843e4264cfedcecd371b0dfb30cec5a2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/LogoutAuditEvent.java
>  3ce8c310f784c77d9c3aa8c70aab9d2fa4068b89 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/OperationStatusAuditEvent.java
>  fd0068e5564f3da800c67fce9d294697a47dabe7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/TaskStatusAuditEvent.java
>  1682e7475d1e04be40fb9e09ffacad62d26213aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java
>  3de4e489dc4476d893557fcb35b0f0cfb12679dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/ChangeSecurityStateKerberosAuditEvent.java
>  ffb7e8a54d232cf9bae0800c8e2b0dd9f3702e84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreateKeyTabKerberosAuditEvent.java
>  7ac3ef4fe1c0fc05fe7b603446406f547c98094e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java
>  51c3c6b11bc3a41d63cd5f2bb4a5d17626673e61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java
>  1e3dd36cc15c0c07de5825d090f1bfd8051b0bd1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java
>  c947fb1da53f146a5f826d0cf2466b326a6adda2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertGroupRequestAuditEvent.java
>  cd92ba0246c4b0f4794e7174856affabc720b7dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertTargetRequestAuditEvent.java
>  1c4a8d53d3f45032100736858ffb9af295d8ecd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddBlueprintRequestAuditEvent.java
>  84431abf69ab436aa7abb1029625eec15b1500e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java
>  c2486655ceaa614b9824f7f2a5441b6d3a3c26a1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddCredentialRequestAuditEvent.java
>  5d27abf0e9acf1a36c10cab642dd6fb7a3cf0758 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddHostRequestAuditEvent.java
>  c24175df9420fc173c82a0bd0edcbfd2f1c05355 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryRequestAuditEvent.java
>  ed6c1cdce68955bb16efbe2558d41be727a8d446 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryVersionRequestAuditEvent.java
>  b4d3401a87af5b3cccba02f2fe7134f6a2382e71 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRequestRequestAuditEvent.java
>  004c24a0c7764500bbe03159312bb15d222617e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUpgradeRequestAuditEvent.java
>  69b4536e865cec91f6d7aefd180e48e1d752ddba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUserToGroupRequestAuditEvent.java
>  33293c0f4fe9d6300ab3af51d314dc04a8e2ae53 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddViewInstanceRequestAuditEvent.java
>

Re: Review Request 54872: AMBARI-19226 Provide default value for hdfs_tmp_dir parameter in HDFS params script.

2016-12-19 Thread Tim Thorpe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54872/#review159651
---


Ship it!




Ship It!

- Tim Thorpe


On Dec. 19, 2016, 7:52 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54872/
> ---
> 
> (Updated Dec. 19, 2016, 7:52 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19226
> https://issues.apache.org/jira/browse/AMBARI-19226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> provide a default value in params.py for hdfs_tmp_dir. The property is not 
> shown on the UI, making it difficult for users to change its value via Ambari 
> web UI if the cluster is deployed via blueprint and the property is missing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  7567ab4 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
>  55544e0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  bebb375 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  cdadc80 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  daba3d3 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py
>  d838211 
> 
> Diff: https://reviews.apache.org/r/54872/diff/
> 
> 
> Testing
> ---
> 
> exsiting unit tests
> Patch a 2.4 cluster (Ambari upgraded to trunk build) with the changes, run 
> EU, then run downgrade once it reaches the Finalize step.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2016-12-19 Thread Tim Thorpe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54874/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Di Li, 
Jonathan Hurley, Jayush Luniya, and Sumit Mohanty.


Bugs: AMBARI-19241
https://issues.apache.org/jira/browse/AMBARI-19241


Repository: ambari


Description
---

Currently the hdfs_resources.py supports
1) create files/directories in HDFS
2) delete files/directories in HDFS
3) upload files/directories to HDFS

We should also support download of files/directories from HDFS. This will help 
particularly in cloud environments where the users of the cluster don't 
necessarily have write access to the local file system.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/download_from_hdfs.py
 PRE-CREATION 
  
ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
 f1aa3e1 
  
ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py
 5761fd6 
  
contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java
 da5a706 
  
contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java
 e4656c7 

Diff: https://reviews.apache.org/r/54874/diff/


Testing
---

Manual testing with and without web hdfs.  Tested download files and 
directories both when they existed locally and when they didn't.


Thanks,

Tim Thorpe

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-19 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/#review159645
---


Ship it!




Ship It!

- Jaimin Jetly


On Dec. 19, 2016, 7:38 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54460/
> ---
> 
> (Updated Dec. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19117
> https://issues.apache.org/jira/browse/AMBARI-19117
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a FE task to implement the "Create Alerts Wizard " based on the 
> design attached.
> 
> This task is to create Step 2 of PORT alert. see the design for details. 
> Pay attention to the dependencies on selecting different options. The further 
> fields will determined by the current selection.
> 
> eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display 
> totally different UI.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js 130cb39 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  7fb4b2d 
>   ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
> 138aaa4 
>   ambari-web/app/models/alerts/alert_config.js 980dfe5 
>   ambari-web/app/styles/alerts.less 77cc13c 
>   
> ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js
>  2ea42f7 
> 
> Diff: https://reviews.apache.org/r/54460/diff/
> 
> 
> Testing
> ---
> 
> 19713 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Review Request 54872: AMBARI-19226 Provide default value for hdfs_tmp_dir parameter in HDFS params script.

2016-12-19 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54872/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19226
https://issues.apache.org/jira/browse/AMBARI-19226


Repository: ambari


Description
---

provide a default value in params.py for hdfs_tmp_dir. The property is not 
shown on the UI, making it difficult for users to change its value via Ambari 
web UI if the cluster is deployed via blueprint and the property is missing.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 7567ab4 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py
 55544e0 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 bebb375 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
 cdadc80 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 daba3d3 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py
 d838211 

Diff: https://reviews.apache.org/r/54872/diff/


Testing
---

exsiting unit tests
Patch a 2.4 cluster (Ambari upgraded to trunk build) with the changes, run EU, 
then run downgrade once it reaches the Finalize step.


Thanks,

Di Li

Re: Review Request 54871: HDP 3.0 flatten Role Command Order and remote duplicate configs

2016-12-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54871/#review159640
---




ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-audit.xml
 


These configs were deleted in HDP 2.5



ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-plugin-properties.xml
 (line 32)


This was a duplicate config, its value should be "authentication"



ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml
 


Remove dup configs.


- Alejandro Fernandez


On Dec. 19, 2016, 7:48 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54871/
> ---
> 
> (Updated Dec. 19, 2016, 7:48 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-19095
> https://issues.apache.org/jira/browse/AMBARI-19095
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Flatten out Role Command Order for HDP 3.0 TP based on previous stacks.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-audit.xml
>  fd41817 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-plugin-properties.xml
>  b31742c 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml
>  01c3b47 
>   ambari-server/src/main/resources/stacks/HDP/3.0/role_command_order.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54871/diff/
> 
> 
> Testing
> ---
> 
> Ran python unit tests
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 54871: HDP 3.0 flatten Role Command Order and remote duplicate configs

2016-12-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54871/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-19095
https://issues.apache.org/jira/browse/AMBARI-19095


Repository: ambari


Description
---

Flatten out Role Command Order for HDP 3.0 TP based on previous stacks.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-audit.xml
 fd41817 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/ranger-hdfs-plugin-properties.xml
 b31742c 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml
 01c3b47 
  ambari-server/src/main/resources/stacks/HDP/3.0/role_command_order.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/54871/diff/


Testing
---

Ran python unit tests


Thanks,

Alejandro Fernandez

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-19 Thread Xi Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54460/
---

(Updated Dec. 19, 2016, 11:38 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-19117
https://issues.apache.org/jira/browse/AMBARI-19117


Repository: ambari


Description
---

This is a FE task to implement the "Create Alerts Wizard " based on the design 
attached.

This task is to create Step 2 of PORT alert. see the design for details. 
Pay attention to the dependencies on selecting different options. The further 
fields will determined by the current selection.

eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display 
totally different UI.


Diffs
-

  ambari-web/app/config.js 130cb39 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
7fb4b2d 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
138aaa4 
  ambari-web/app/models/alerts/alert_config.js 980dfe5 
  ambari-web/app/styles/alerts.less 77cc13c 
  
ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 
2ea42f7 

Diff: https://reviews.apache.org/r/54460/diff/


Testing (updated)
---

19713 passing (21s)
  153 pending


Thanks,

Xi Wang

Re: Review Request 54791: After rescanning yarn queue, Ambari still asks for RM to be restarted

2016-12-19 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/#review159624
---


Ship it!




Ship It!

- Jonathan Hurley


On Dec. 15, 2016, 12:51 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54791/
> ---
> 
> (Updated Dec. 15, 2016, 12:51 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19216
> https://issues.apache.org/jira/browse/AMBARI-19216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ran into this while troubleshooting a yarn issue.
> 1. Go to yarn view, and change any value in one of your queues.
> 2. Save and Refresh queues
> 3 Go to Yarn service. It now says RM needs to be restarted (**This is false, 
> and did not flag in 2.2.x versions of Ambari**)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9 
> 
> Diff: https://reviews.apache.org/r/54791/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 54861: 'Cluster User' role issue after Ambari 2.4.2.0 upgrade

2016-12-19 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54861/#review159623
---




ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
 


Please remove leftover unused imports.


- Attila Doroszlai


On Dec. 19, 2016, 2:45 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54861/
> ---
> 
> (Updated Dec. 19, 2016, 2:45 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-19235
> https://issues.apache.org/jira/browse/AMBARI-19235
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After upgrading from Ambari 2.4.0.1 to Ambari 2.4.2, something has changed 
> that breaks role based access control. Users in the "Cluster User" role no 
> longer get access to the views as they could in 2.4.0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
>  b3be046 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  90d4be0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestAmbariLdapAuthoritiesPopulator.java
>  5715906 
> 
> Diff: https://reviews.apache.org/r/54861/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54866/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo Puskas, 
Miklos Gergely, and Nate Cole.


Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149


Repository: ambari


Description
---

Eliminate unchecked cast warnings in `*AuditEvent` classes


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractAuditEvent.java
 558b0eadf310e42375783e56056a45329a786498 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/AbstractUserAuditEvent.java
 6aab071fe27fb1609d4261b423aca02929c5f3c7 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/AccessUnauthorizedAuditEvent.java
 b6e60e13463a65a197b824d29c35df1700b6ae00 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/LoginAuditEvent.java
 223dd189843e4264cfedcecd371b0dfb30cec5a2 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/LogoutAuditEvent.java
 3ce8c310f784c77d9c3aa8c70aab9d2fa4068b89 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/OperationStatusAuditEvent.java
 fd0068e5564f3da800c67fce9d294697a47dabe7 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/TaskStatusAuditEvent.java
 1682e7475d1e04be40fb9e09ffacad62d26213aa 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java
 3de4e489dc4476d893557fcb35b0f0cfb12679dc 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/ChangeSecurityStateKerberosAuditEvent.java
 ffb7e8a54d232cf9bae0800c8e2b0dd9f3702e84 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreateKeyTabKerberosAuditEvent.java
 7ac3ef4fe1c0fc05fe7b603446406f547c98094e 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java
 51c3c6b11bc3a41d63cd5f2bb4a5d17626673e61 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java
 1e3dd36cc15c0c07de5825d090f1bfd8051b0bd1 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java
 c947fb1da53f146a5f826d0cf2466b326a6adda2 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertGroupRequestAuditEvent.java
 cd92ba0246c4b0f4794e7174856affabc720b7dd 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddAlertTargetRequestAuditEvent.java
 1c4a8d53d3f45032100736858ffb9af295d8ecd7 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddBlueprintRequestAuditEvent.java
 84431abf69ab436aa7abb1029625eec15b1500e0 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java
 c2486655ceaa614b9824f7f2a5441b6d3a3c26a1 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddCredentialRequestAuditEvent.java
 5d27abf0e9acf1a36c10cab642dd6fb7a3cf0758 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddHostRequestAuditEvent.java
 c24175df9420fc173c82a0bd0edcbfd2f1c05355 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryRequestAuditEvent.java
 ed6c1cdce68955bb16efbe2558d41be727a8d446 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRepositoryVersionRequestAuditEvent.java
 b4d3401a87af5b3cccba02f2fe7134f6a2382e71 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddRequestRequestAuditEvent.java
 004c24a0c7764500bbe03159312bb15d222617e7 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUpgradeRequestAuditEvent.java
 69b4536e865cec91f6d7aefd180e48e1d752ddba 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddUserToGroupRequestAuditEvent.java
 33293c0f4fe9d6300ab3af51d314dc04a8e2ae53 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddViewInstanceRequestAuditEvent.java
 d9ab59ab9151d7200883055d7dc1867b6f3338ae 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AdminUserRequestAuditEvent.java
 a43d7839ceff0f47815f9afa14b40d5b609d847a 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/BlueprintExportRequestAuditEvent.java
 e5ea1bd0d5dce15716d004d7d298aa4b9cfa938a 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ChangeAlertGroupRequestAuditEvent.java
 d5a59df840fe32e76f47ad4626bfb43670ff493f 
  
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ChangeAlertTargetRequestAuditEvent.java
 63a45cafcfe080f2ebf1cb57c394913da371469a

Re: Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Tim Thorpe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54864/#review159621
---


Ship it!




Ship It!

- Tim Thorpe


On Dec. 19, 2016, 4:58 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54864/
> ---
> 
> (Updated Dec. 19, 2016, 4:58 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19225
> https://issues.apache.org/jira/browse/AMBARI-19225
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari server should prints error messages to its log if it can't find 
> property for given property attribute type, such as NOT_MANAGED_HDFS_PATH
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 3fb036d 
> 
> Diff: https://reviews.apache.org/r/54864/diff/
> 
> 
> Testing
> ---
> 
> 1. existing unit tests
> 2. patch a trunk cluster with the code change, modify HDFS configuration 
> hadoop-env in the ambari db to remove hdfs_tmp_dir. Verify hdfs restart 
> finishes successfully without errotd. ambari-server.log has error messages 
> about unable to find the property within the given config type for the 
> particular configuration version tag.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 54865: Ambari UI should use "hosts_with_failures" from "host_resolution_check" in host check

2016-12-19 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54865/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19240
https://issues.apache.org/jira/browse/AMBARI-19240


Repository: ambari


Description
---

Earlier UI parsed "failures" property value to get hosts which were failed. But 
in perf clusters "failures" is very big (more than 300 MB), so we decided to 
add one more property which contains only hostnames which failed.


Diffs
-

  ambari-web/app/mixins/main/host/details/actions/check_host.js faf8ef1 
  ambari-web/app/utils/ajax/ajax.js 5831521 
  ambari-web/test/controllers/wizard/step3_test.js 1e1b3bd 

Diff: https://reviews.apache.org/r/54865/diff/


Testing
---

19725 passing (25s)
  153 pending


Thanks,

Andrii Tkach

Re: Review Request 54865: Ambari UI should use "hosts_with_failures" from "host_resolution_check" in host check

2016-12-19 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54865/#review159620
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Дек. 19, 2016, 5:02 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54865/
> ---
> 
> (Updated Дек. 19, 2016, 5:02 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19240
> https://issues.apache.org/jira/browse/AMBARI-19240
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier UI parsed "failures" property value to get hosts which were failed. 
> But in perf clusters "failures" is very big (more than 300 MB), so we decided 
> to add one more property which contains only hostnames which failed.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/main/host/details/actions/check_host.js faf8ef1 
>   ambari-web/app/utils/ajax/ajax.js 5831521 
>   ambari-web/test/controllers/wizard/step3_test.js 1e1b3bd 
> 
> Diff: https://reviews.apache.org/r/54865/diff/
> 
> 
> Testing
> ---
> 
> 19725 passing (25s)
>   153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54864/
---

(Updated Dec. 19, 2016, 4:58 p.m.)


Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19225
https://issues.apache.org/jira/browse/AMBARI-19225


Repository: ambari


Description
---

Ambari server should prints error messages to its log if it can't find property 
for given property attribute type, such as NOT_MANAGED_HDFS_PATH


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
3fb036d 

Diff: https://reviews.apache.org/r/54864/diff/


Testing (updated)
---

1. existing unit tests
2. patch a trunk cluster with the code change, modify HDFS configuration 
hadoop-env in the ambari db to remove hdfs_tmp_dir. Verify hdfs restart 
finishes successfully without errotd. ambari-server.log has error messages 
about unable to find the property within the given config type for the 
particular configuration version tag.


Thanks,

Di Li

Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54864/
---

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-19225
https://issues.apache.org/jira/browse/AMBARI-19225


Repository: ambari


Description
---

Ambari server should prints error messages to its log if it can't find property 
for given property attribute type, such as NOT_MANAGED_HDFS_PATH


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
3fb036d 

Diff: https://reviews.apache.org/r/54864/diff/


Testing
---

1. existing unit tests
2. patch a trunk cluster with the code change, modify HDFS configuration 
hadoop-env in the ambari db to remove hdfs_tmp_dir. Verify hdfs restart 
finishes successfully without errotd. ambari-server.log has error messages 
about unable to find


Thanks,

Di Li

Re: Review Request 54817: AMBARI-19227 :: Provide support to show Ranger solr-configs in Ambari.

2016-12-19 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54817/
---

(Updated Dec. 19, 2016, 4:14 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy.


Changes
---

adding changes for solr-config.xml to be updated to solr configurations when 
its updated from Ambari.


Bugs: AMBARI-19227
https://issues.apache.org/jira/browse/AMBARI-19227


Repository: ambari


Description
---

Need to provide feature for Ranger and update Ambari stacks to show 
solrconfig.xml on Ambari, so that user can update solr related configs directly 
from Ambari.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 7fbd6bd 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 da9ee18 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ac5b38e 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-solr-configuration.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml 
c9f3a9b 
  
ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dde3e00 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py a3ce186 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
ad66c7a 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
5562ea7 

Diff: https://reviews.apache.org/r/54817/diff/


Testing (updated)
---

Verified install on cent-os 6.

test_start_default (test_ranger_admin.TestRangerAdmin) ... 2016-12-19 
21:37:16,265 - Stack Feature Version Info: stack_version=2.6, 
version=2.6.0.0-801, current_cluster_version=2.6.0.0-801 -> 2.6.0.0-801
2016-12-19 21:37:16,281 - Setting up Ranger DB and DB User
ok
test_start_secured (test_ranger_admin.TestRangerAdmin) ... 2016-12-19 
21:37:16,296 - Stack Feature Version Info: stack_version=2.6, 
version=2.6.0.0-801, current_cluster_version=2.6.0.0-801 -> 2.6.0.0-801
2016-12-19 21:37:16,312 - Setting up Ranger DB and DB User
ok


Thanks,

Vishal Suvagia

Re: Review Request 54862: Stackadvisor: incorrect recommendations when only one of two dependencies was changed

2016-12-19 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54862/#review159614
---


Ship it!




Ship It!

- Dmytro Sen


On Дек. 19, 2016, 2:34 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54862/
> ---
> 
> (Updated Дек. 19, 2016, 2:34 п.п.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19236
> https://issues.apache.org/jira/browse/AMBARI-19236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For example:
> 'mapreduce.map.memory.mb' depends on 'yarn.scheduler.maximum-allocation-mb' 
> and 'yarn.scheduler.minimum-allocation-mb'. 
> 
> *The case:*
> 'yarn.scheduler.minimum-allocation-mb' was changed, but 
> 'yarn.scheduler.maximum-allocation-mb' not. In this case recommendations will 
> use provided value for the first property and recommended value for the 
> second. 'mapreduce.map.memory.mb' will be recalculated incorrectly.
> 
> *Expected:*
> Use the provided values for both properties.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py f6191f8 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 081a66a 
> 
> Diff: https://reviews.apache.org/r/54862/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 54862: Stackadvisor: incorrect recommendations when only one of two dependencies was changed

2016-12-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54862/
---

Review request for Ambari, Dmytro Grinenko, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-19236
https://issues.apache.org/jira/browse/AMBARI-19236


Repository: ambari


Description
---

For example:
'mapreduce.map.memory.mb' depends on 'yarn.scheduler.maximum-allocation-mb' and 
'yarn.scheduler.minimum-allocation-mb'. 

*The case:*
'yarn.scheduler.minimum-allocation-mb' was changed, but 
'yarn.scheduler.maximum-allocation-mb' not. In this case recommendations will 
use provided value for the first property and recommended value for the second. 
'mapreduce.map.memory.mb' will be recalculated incorrectly.

*Expected:*
Use the provided values for both properties.


Diffs
-

  ambari-server/src/main/resources/stacks/stack_advisor.py f6191f8 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 081a66a 

Diff: https://reviews.apache.org/r/54862/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

2016-12-19 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54735/#review159606
---


Ship it!




Ship It!

- Nate Cole


On Dec. 19, 2016, 4:22 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54735/
> ---
> 
> (Updated Dec. 19, 2016, 4:22 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Miklos Gergely, 
> and Nate Cole.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Empty `synchronized` blocks in `ServiceInfo` seems to be bug
>  * Introduced `Closeables.closeSilently` to get rid of duplicated try-catch 
> logic with empty catch
>  * Exceptions caught and ignored should be named `ignored`, ideally catch 
> block should state why it's OK to ignore
>  * Added check for empty blocks and unnecessary nested blocks
> 
> 
> Diffs
> -
> 
>   ambari-server/checkstyle.xml 0c66556d513d7e3da0f969be584d666ba00b9c6c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  ed84e459a5c8e84a660e4b08e1f9cbe01624f582 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/CsvSerializer.java
>  92d8b69af5536b83c975cb0cb05b936aad866e19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
>  661f2845080c6202194e480ab84b6b79ca11fafa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 
> 6c77dee3bdff9d442e9efabf7321daadb8b076ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/ClusterDefinition.java
>  6f9876abfa90049997fac5d7cce6a8abe6742f63 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  5d462c56fbfc0cfd7b098c79d7553a3fe6841dc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  e2b44cab6f874b1f00d270db2344aaf89acd09e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  58675aea7b5454ce4be9f0bdcf183fe1b2788367 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java
>  764380409c96d640e6b79bfedc8ba66d21724ae0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
>  e118747e5d8ea2f7ff05a6e6711ecc517ddf47d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  2880f6e0c3099e0a86f58da8cae9e1682dd484e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java
>  9554f0c36b0338410482b4d157975c3971af220f 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 
> f07efea4052e5fbbc2dca45df61ca8d6b1c4a356 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 3fb036da92b23b4a6caf7dafbc5c36c9e320511e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> c9d497fc3d22b8c4bd14bc53a1fbe5c0c0727d54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  b62c834cb4125ee33d54860ad72c263bd49a4f85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  99e50fb630c34ea2b00beb0d7f693835908a7f6d 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/Closeables.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java
>  2ccf757107ebb81ac5ac4268917ac6fe418e49ad 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> cb1489a96acede603def5ff6e39f3d23b3af4160 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java
>  24d3527f411286ff138482b84ad4715a08508c5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/CloseablesTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54735/diff/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -am -pl ambari-server -Del.log=OFF -DskipPythonTests clean test
> ...
> Tests run: 4797, Failures: 0, Errors: 0, Skipped: 37
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 5367 licence.
> ...
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [6.464s]
> [INFO] Apache Ambari Project POM

Re: Review Request 54861: 'Cluster User' role issue after Ambari 2.4.2.0 upgrade

2016-12-19 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54861/
---

(Updated Dec. 19, 2016, 1:45 p.m.)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
Levas.


Bugs: AMBARI-19235
https://issues.apache.org/jira/browse/AMBARI-19235


Repository: ambari


Description
---

After upgrading from Ambari 2.4.0.1 to Ambari 2.4.2, something has changed that 
breaks role based access control. Users in the "Cluster User" role no longer 
get access to the views as they could in 2.4.0.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthoritiesPopulator.java
 b3be046 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 90d4be0 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestAmbariLdapAuthoritiesPopulator.java
 5715906 

Diff: https://reviews.apache.org/r/54861/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 54815: Exception when running Slider view - java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse

2016-12-19 Thread Tim Thorpe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54815/#review159598
---


Ship it!




Ship It!

- Tim Thorpe


On Dec. 17, 2016, 12:31 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54815/
> ---
> 
> (Updated Dec. 17, 2016, 12:31 a.m.)
> 
> 
> Review request for Ambari, Di Li, Srimanth Gunturi, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19218
> https://issues.apache.org/jira/browse/AMBARI-19218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a Slider view is executed, the following error is thrown.
> 15 Dec 2016 10:11:15,645 WARN [ambari-client-thread-28] [SLIDER 2.0.0 S1] 
> SliderAppsViewControllerImpl:847 - Unable to create SliderClient
> java.lang.NoClassDefFoundError: 
> org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse
> This is because the version of hadoop-yarn-api jar under 
> /var/lib/ambari-server/resources/views/work/SLIDER
> {2.0.0}
> is 2.6.0.
> The GetLabelsToNodesResponse class was added in 2.7.0 version.
> 
> Fix involves excluding the hadoop-yarn-api 2.6 jar that is inherited from the 
> slider-core dependency. With this exclusion, the 2.7 version of 
> hadoop-yarn-api (inherited via org.apache.ambari.contrib.views.utils 
> dependency) is included in the slider view jar and view can be executed.
> 
> 
> Diffs
> -
> 
>   contrib/views/slider/pom.xml bb1b150 
> 
> Diff: https://reviews.apache.org/r/54815/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. View execution does not throw execption any more and 
> application can be added.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 54860: ATS reports as down in Ambari UI after upgrade

2016-12-19 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54860/#review159596
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Dec. 19, 2016, 1:35 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54860/
> ---
> 
> (Updated Dec. 19, 2016, 1:35 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19233
> https://issues.apache.org/jira/browse/AMBARI-19233
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Live cluster from today's run:  (available for
> next 18 hours)  
> Cluster name: vs-hdp250-70297  
> ATS Host: 172.22.90.143  
> Keypair - see attached file named - ok
> 
> **Steps**
> 
>   1. Deploy HDP-2.5.0 cluster with Ambari-2.4.1.0
>   2. Upgrade Ambari to 2.5.0.0-419
>   3. Restart ATS and observe the status of ATS after sometime in Ambari UI
> 
> **Result:**  
> ATS shows down. Ambari-agent log shows below:
> 
> 
> 
> 
> INFO 2016-12-08 16:14:44,419 ActionQueue.py:105 - Adding STATUS_COMMAND 
> for component APP_TIMELINE_SERVER of service YARN of cluster cl1 to the queue.
> INFO 2016-12-08 16:14:44,621 ActionQueue.py:105 - Adding STATUS_COMMAND 
> for component NODEMANAGER of service YARN of cluster cl1 to the queue.
> INFO 2016-12-08 16:14:46,429 PythonReflectiveExecutor.py:65 - Reflective 
> command failed with exception:
> Traceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ambari_agent/PythonReflectiveExecutor.py", 
> line 57, in run_file
> imp.load_source('__main__', script)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py",
>  line 155, in 
> ApplicationTimelineServer().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 282, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py",
>  line 82, in status
> only_if = format("test -e {yarn_historyserver_pid_file_old}", 
> user=status_params.yarn_user))
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 143, in run
> Logger.info_resource(resource)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 
> 87, in info_resource
> Logger.info(Logger.filter_text(Logger._get_resource_repr(resource)))
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 
> 110, in _get_resource_repr
> return Logger.get_function_repr(repr(resource), resource.arguments, 
> resource)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 
> 180, in get_function_repr
> return unicode("{0} {{{1}}}", 'UTF-8').format(name, arguments_str)
>   File "/usr/lib64/python2.6/encodings/utf_8.py", line 16, in decode
> return codecs.utf_8_decode(input, errors, True)
> AttributeError: 'NoneType' object has no attribute 'utf_8_decode'
> INFO 2016-12-08 16:14:53,190 Controller.py:283 - Heartbeat (response id = 
> 15365) with server is running...
> INFO 2016-12-08 16:14:55,083 Heartbeat.py:90 - Adding host info/state to 
> heartbeat message.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py cfcd129 
> 
> Diff: https://reviews.apache.org/r/54860/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 54860: ATS reports as down in Ambari UI after upgrade

2016-12-19 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54860/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19233
https://issues.apache.org/jira/browse/AMBARI-19233


Repository: ambari


Description
---

Live cluster from today's run:  (available for
next 18 hours)  
Cluster name: vs-hdp250-70297  
ATS Host: 172.22.90.143  
Keypair - see attached file named - ok

**Steps**

  1. Deploy HDP-2.5.0 cluster with Ambari-2.4.1.0
  2. Upgrade Ambari to 2.5.0.0-419
  3. Restart ATS and observe the status of ATS after sometime in Ambari UI

**Result:**  
ATS shows down. Ambari-agent log shows below:




INFO 2016-12-08 16:14:44,419 ActionQueue.py:105 - Adding STATUS_COMMAND for 
component APP_TIMELINE_SERVER of service YARN of cluster cl1 to the queue.
INFO 2016-12-08 16:14:44,621 ActionQueue.py:105 - Adding STATUS_COMMAND for 
component NODEMANAGER of service YARN of cluster cl1 to the queue.
INFO 2016-12-08 16:14:46,429 PythonReflectiveExecutor.py:65 - Reflective 
command failed with exception:
Traceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ambari_agent/PythonReflectiveExecutor.py", 
line 57, in run_file
imp.load_source('__main__', script)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py",
 line 155, in 
ApplicationTimelineServer().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 282, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py",
 line 82, in status
only_if = format("test -e {yarn_historyserver_pid_file_old}", 
user=status_params.yarn_user))
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 143, in run
Logger.info_resource(resource)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 87, 
in info_resource
Logger.info(Logger.filter_text(Logger._get_resource_repr(resource)))
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 
110, in _get_resource_repr
return Logger.get_function_repr(repr(resource), resource.arguments, 
resource)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 
180, in get_function_repr
return unicode("{0} {{{1}}}", 'UTF-8').format(name, arguments_str)
  File "/usr/lib64/python2.6/encodings/utf_8.py", line 16, in decode
return codecs.utf_8_decode(input, errors, True)
AttributeError: 'NoneType' object has no attribute 'utf_8_decode'
INFO 2016-12-08 16:14:53,190 Controller.py:283 - Heartbeat (response id = 
15365) with server is running...
INFO 2016-12-08 16:14:55,083 Heartbeat.py:90 - Adding host info/state to 
heartbeat message.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/main.py cfcd129 

Diff: https://reviews.apache.org/r/54860/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 54791: After rescanning yarn queue, Ambari still asks for RM to be restarted

2016-12-19 Thread Dmytro Sen 


> On Дек. 16, 2016, 3:26 п.п., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/ActionQueue.py, lines 430-439
> > 
> >
> > Where in the Ambari Server code does it send down 
> > `forceRefreshConfigTags` - I couldn't find any spot where this is injected 
> > into the parameters being set on the command for the agent.

It's a parameter for REFRESHQUEUE command:

from ConfigurationService.java :
  private static final String REFRESH_RM_REQUEST_DATA =
  "{\n" +
  "  \"RequestInfo\" : {\n" +
  "\"command\" : \"REFRESHQUEUES\",\n" +
  "\"context\" : \"Refresh YARN Capacity Scheduler\"\n" +
  "\"parameters/forceRefreshConfigTags\" : \"capacity-scheduler\"\n" +
  "  },\n" +
  "  \"Requests/resource_filters\": [{\n" +
  "\"service_name\" : \"YARN\",\n" +
  "\"component_name\" : \"RESOURCEMANAGER\",\n" +
  "\"hosts\" : \"%s\"\n" +
  "  }]\n" +
  "}";

All the parameters from the command are sent to ambari-agent from the server 
side:
  @SerializedName("commandParams")
  private Map commandParams = new HashMap();

In AmbariManagementControllerImpl.createHostAction():
execCmd.setCommandParams(commandParams);


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54791/#review159449
---


On Дек. 15, 2016, 5:51 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54791/
> ---
> 
> (Updated Дек. 15, 2016, 5:51 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19216
> https://issues.apache.org/jira/browse/AMBARI-19216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ran into this while troubleshooting a yarn issue.
> 1. Go to yarn view, and change any value in one of your queues.
> 2. Save and Refresh queues
> 3 Go to Yarn service. It now says RM needs to be restarted (**This is false, 
> and did not flag in 2.2.x versions of Ambari**)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py cb4fcb9 
> 
> Diff: https://reviews.apache.org/r/54791/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 54857: Refactor Ambari service def configurations for Zeppelin

2016-12-19 Thread Renjith Kamath 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54857/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-17470
https://issues.apache.org/jira/browse/AMBARI-17470


Repository: ambari


Description
---

- Move shiro.ini and log4j.properties out of zeppelin-env configuration.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
 2beac97 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
 382e913 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 5ee6147 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/54857/diff/


Testing
---

Manually tested on CentOS 6.6


Thanks,

Renjith Kamath

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

2016-12-19 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54735/
---

(Updated Dec. 19, 2016, 10:22 a.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Miklos Gergely, and 
Nate Cole.


Changes
---

Added back `EmptyBlocks` check


Bugs: AMBARI-19149
https://issues.apache.org/jira/browse/AMBARI-19149


Repository: ambari


Description
---

* Empty `synchronized` blocks in `ServiceInfo` seems to be bug
 * Introduced `Closeables.closeSilently` to get rid of duplicated try-catch 
logic with empty catch
 * Exceptions caught and ignored should be named `ignored`, ideally catch block 
should state why it's OK to ignore
 * Added check for empty blocks and unnecessary nested blocks


Diffs (updated)
-

  ambari-server/checkstyle.xml 0c66556d513d7e3da0f969be584d666ba00b9c6c 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 ed84e459a5c8e84a660e4b08e1f9cbe01624f582 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/CsvSerializer.java
 92d8b69af5536b83c975cb0cb05b936aad866e19 
  
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java
 661f2845080c6202194e480ab84b6b79ca11fafa 
  ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 
6c77dee3bdff9d442e9efabf7321daadb8b076ee 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/ClusterDefinition.java
 6f9876abfa90049997fac5d7cce6a8abe6742f63 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 5d462c56fbfc0cfd7b098c79d7553a3fe6841dc1 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 e2b44cab6f874b1f00d270db2344aaf89acd09e7 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
 58675aea7b5454ce4be9f0bdcf183fe1b2788367 
  
ambari-server/src/main/java/org/apache/ambari/server/security/encryption/CredentialProvider.java
 764380409c96d640e6b79bfedc8ba66d21724ae0 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
 e118747e5d8ea2f7ff05a6e6711ecc517ddf47d7 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
 2880f6e0c3099e0a86f58da8cae9e1682dd484e3 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java
 9554f0c36b0338410482b4d157975c3971af220f 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 
f07efea4052e5fbbc2dca45df61ca8d6b1c4a356 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
3fb036da92b23b4a6caf7dafbc5c36c9e320511e 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
c9d497fc3d22b8c4bd14bc53a1fbe5c0c0727d54 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 b62c834cb4125ee33d54860ad72c263bd49a4f85 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 99e50fb630c34ea2b00beb0d7f693835908a7f6d 
  ambari-server/src/main/java/org/apache/ambari/server/utils/Closeables.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java
 2ccf757107ebb81ac5ac4268917ac6fe418e49ad 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
cb1489a96acede603def5ff6e39f3d23b3af4160 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java
 24d3527f411286ff138482b84ad4715a08508c5b 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/CloseablesTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/54735/diff/


Testing
---

```
$ mvn -am -pl ambari-server -Del.log=OFF -DskipPythonTests clean test
...
Tests run: 4797, Failures: 0, Errors: 0, Skipped: 37
...
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5367 licence.
...
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [6.464s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Views .. SUCCESS [2.253s]
[INFO] utility ... SUCCESS [1.178s]
[INFO] ambari-metrics  SUCCESS [2.299s]
[INFO] Ambari Metrics Common . SUCCESS [4.382s]
[INFO] Ambari Server . SUCCESS [23:27.066s]
[INFO] 
[INFO]