date:20161222

Re: Review Request 54895: AMBARI-19256:Asset support Rest API

2016-12-22 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54895/#review160042
---


Ship it!




Ship It!

- Nitiraj Rathore


On Dec. 21, 2016, 8:57 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54895/
> ---
> 
> (Updated Dec. 21, 2016, 8:57 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19256
> https://issues.apache.org/jira/browse/AMBARI-19256
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add rest API support for storing and retrieving assets from ambari view db.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/AssetDefinitionRefType.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/EntityStatus.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  08a166d 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java
>  f002102 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/ServiceFormattedException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  01bde47 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetDefinitionRepo.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java
>  1390ec0 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java
>  648a89f 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/ActionAsset.java
>  8eb6081 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/ActionAssetDefinition.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/AssetDefintion.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/APIResult.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/BaseModel.java
>  553ce24 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/Indexed.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/Paging.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/When.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/repo/BaseRepo.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java
>  4c88454 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  17a3296 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java
>  978c059 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/model/Workflow.java
>  ad5f48b 
>   contrib/views/wfmanager/src/main/resources/view.xml bfa1253 
> 
> Diff: https://reviews.apache.org/r/54895/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 54977: Zeppelin Notebook Component is not able start after reboot

2016-12-22 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54977/#review160041
---


Ship it!




Ship It!

- Nitiraj Rathore


On Dec. 22, 2016, 12:55 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54977/
> ---
> 
> (Updated Dec. 22, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19264
> https://issues.apache.org/jira/browse/AMBARI-19264
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - intermittently fails to start the service when /var/run/zeppelin dir is not 
> present.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  39941f7 
> 
> Diff: https://reviews.apache.org/r/54977/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 55009: HDFS Service check fails if previous active NN is down

2016-12-22 Thread Weiwei Yang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55009/
---

(Updated 十二月 23, 2016, 7:13 a.m.)


Review request for Ambari and Di Li.


Bugs: AMBARI-19289
https://issues.apache.org/jira/browse/AMBARI-19289


Repository: ambari


Description
---

On a HA cluster, I manually stop the active NN, standby takes over and becomes 
to be active, HDFS is healthy. However hdfs service check fails.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
 737ae04 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 

Diff: https://reviews.apache.org/r/55009/diff/


Testing (updated)
---

HA cluster

1. Both NN started
2. Shutdown active
3. Shutdown standby
4. Both NN started and manually put NN in safemode

Non-HA cluster

1. NN started
2. NN started and manually put NN in safemode
3. NN stopped


Thanks,

Weiwei Yang

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed

2016-12-22 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55007/#review160036
---


Ship it!




Ship It!

- Mugdha Varadkar


On Dec. 23, 2016, 5:23 a.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55007/
> ---
> 
> (Updated Dec. 23, 2016, 5:23 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Madhan Neethiraj, Mugdha Varadkar, and Oliver Szabo.
> 
> 
> Bugs: AMBARI-19288
> https://issues.apache.org/jira/browse/AMBARI-19288
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, for 2.5 and 2.6 stacks, there a call to install hive-hook if 
> Falcon client is installed.Need to remove that dependency.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  7fbd6bd 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  78874ef 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dde3e00 
> 
> Diff: https://reviews.apache.org/r/55007/diff/
> 
> 
> Testing
> ---
> 
> Verified fresh install on Cent-OS 6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 54817: AMBARI-19227 :: Provide support to show Ranger solr-configs in Ambari.

2016-12-22 Thread Vishal Suvagia



> On Dec. 21, 2016, 6:20 p.m., Oliver Szabo wrote:
> > Ship It!
> > 1 note: is it okay to add  to the 
> > properties? Maybe im wrong, but if the ranger-solr-configuration wont exist 
> > after ambari upgrade, the solr related config references can fail

Thank you Oliver,
As the solr-config feature is required to be shown only after 
stack installed is 2.6, the features are not required to be shown on an Ambari 
upgrade.This is tested for an upgrade scenario,where the configs are only 
visible after an stack upgrade.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54817/#review159844
---


On Dec. 20, 2016, 2:22 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54817/
> ---
> 
> (Updated Dec. 20, 2016, 2:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Mugdha Varadkar, Oliver Szabo, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19227
> https://issues.apache.org/jira/browse/AMBARI-19227
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to provide feature for Ranger and update Ambari stacks to show 
> solrconfig.xml on Ambari, so that user can update solr related configs 
> directly from Ambari.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  7fbd6bd 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  da9ee18 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ac5b38e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-solr-configuration.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml 
> c9f3a9b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dde3e00 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
> a3ce186 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
> ad66c7a 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
> 5562ea7 
> 
> Diff: https://reviews.apache.org/r/54817/diff/
> 
> 
> Testing
> ---
> 
> Verified install on cent-os 6.
> 
> test_start_default (test_ranger_admin.TestRangerAdmin) ... 2016-12-19 
> 21:37:16,265 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-801, current_cluster_version=2.6.0.0-801 -> 2.6.0.0-801
> 2016-12-19 21:37:16,281 - Setting up Ranger DB and DB User
> ok
> test_start_secured (test_ranger_admin.TestRangerAdmin) ... 2016-12-19 
> 21:37:16,296 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-801, current_cluster_version=2.6.0.0-801 -> 2.6.0.0-801
> 2016-12-19 21:37:16,312 - Setting up Ranger DB and DB User
> ok
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed

2016-12-22 Thread Vishal Suvagia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55007/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Madhan Neethiraj, Mugdha Varadkar, and Oliver Szabo.


Bugs: AMBARI-19288
https://issues.apache.org/jira/browse/AMBARI-19288


Repository: ambari


Description
---

Currently, for 2.5 and 2.6 stacks, there a call to install hive-hook if Falcon 
client is installed.Need to remove that dependency.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 7fbd6bd 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 78874ef 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 dde3e00 

Diff: https://reviews.apache.org/r/55007/diff/


Testing
---

Verified fresh install on Cent-OS 6.


Thanks,

Vishal Suvagia

Re: Review Request 54958: Single API to download all client configs

2016-12-22 Thread Jaimin Jetly



> On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java,
> >  line 299
> > 
> >
> > Would rather use new File(parent, child) syntax

suggestion has been incorporated in the 2nd revision of the patch


> On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java,
> >  line 206
> > 
> >
> > no need to qualify the generic for the type:  new ArrayList<> is 
> > sufficient

suggestion has been incorporated in the 2nd revision of the patch


> On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java,
> >  lines 549-561
> > 
> >
> > There could be a LOT of commands which seems like it would be a LOT of 
> > threads.  Use an Executor instead.  That will avoid both thread bloat and 
> > process handle bloat.

This has been addressed in the 2nd revision of the patch


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/#review159970
---


On Dec. 23, 2016, 12:57 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54958/
> ---
> 
> (Updated Dec. 23, 2016, 12:57 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-19275
> https://issues.apache.org/jira/browse/AMBARI-19275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there is an API to download compressed config files for a host 
> component
> 
> Scope of this ticket is to extend this functionality to do following:
> # Download all client config files for a host via single API
> # Download all client config files of a service via single API. some services 
> have more than one client
> # Download all client config files for cluster
> 
> Apart from extending the functionalty of API, an additional change has been 
> made to the behavior of the existing API that looked to be like a bug
> Without this patch Downloading client config files for a service component 
> used to fetch first host component and create config files as present on that 
> host component (host desired configs overlaid on cluster desired configs)
> Instead with a change in this patch when download client config is made on a 
> service component then config files with only cluster base configs will be 
> created for downoad.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml ceec39c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  ded2596 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
>  bc9bb30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  d2f7934 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  020a454 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java
>  cb3c2a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java
>  f67d961 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  cb88ae1 
> 
> Diff: https://reviews.apache.org/r/54958/diff/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster
> Added validation to existing unit tests
> Executed all unit tests on dev machine and checked there is no regression
> Jenkins QA job for 1st revision of the patch compltedt successsfully
> Jenkins QA job for 2nd revision of the patch in progress...
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 54958: Single API to download all client configs

2016-12-22 Thread Jaimin Jetly

> On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java,
> >  line 250
> > 
> >
> > Suggestion friendlier naming for variable: schResponseList, conveys 
> > better info than serviceComponentList.

suggestion has been incorporated in the 2nd revision of the patch

> On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java,
> >  line 299
> > 
> >
> > Isn't this the same as props.putAll(properties.values())?

This logic was existing before. I accidently happened to change just the 
variable name which I have again reverted back to what it was before.
To answer the question, I believe its not the same thing. Over here we are 
flatennig Map> to Map 
props.putAll(properties.values()) will be passing collection of Map to putAll method instead of passing a map: Map.

Note: putAll API of the map does not accept collection of maps.

> On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java,
> >  line 240
> > 
> >
> > Shouldn't this just log and error and move on why throw an exception?
> 
> Nate Cole wrote:
> +1

We are throwing exception over here only when config files is not present and 
the response has just one component.
For example: 
http://localhost:8080/api/v1/clusters/c1/services/HDFS/components/DATANODE?format=client_config_tar
 will throw an exception that "No configuration files defined for the component 
Datanode" or if any other new client is introduced but no config files are 
mapped with it in the service metainfo.xml. This is the existing behavior of 
the API and the patch tries to not change this behavior.

if an API call is made to download configs for a service/cluster/host (extended 
feature added as part of this patch) and none of the beneath components has 
config files mapped to it then we throw system exception later with a generic 
message "No configuration files defined for any component".

The intention of throwing the exception is to return API with failed error code 
raher than 200 OK with empty tar file considering python script will not burst 
when provided with empty config files input.

Again this is an existing API behavior and I personally feel it's correct.

- Jaimin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/#review159924
---

On Dec. 23, 2016, 12:57 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54958/
> ---
> 
> (Updated Dec. 23, 2016, 12:57 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-19275
> https://issues.apache.org/jira/browse/AMBARI-19275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there is an API to download compressed config files for a host 
> component
> 
> Scope of this ticket is to extend this functionality to do following:
> # Download all client config files for a host via single API
> # Download all client config files of a service via single API. some services 
> have more than one client
> # Download all client config files for cluster
> 
> Apart from extending the functionalty of API, an additional change has been 
> made to the behavior of the existing API that looked to be like a bug
> Without this patch Downloading client config files for a service component 
> used to fetch first host component and create config files as present on that 
> host component (host desired configs overlaid on cluster desired configs)
> Instead with a change in this patch when download client config is made on a 
> service component then config files with only cluster base configs will be 
> created for downoad.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml ceec39c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  ded2596 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
>  bc9bb30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  d2f7934 
>   
>

Re: Review Request 54958: Single API to download all client configs

2016-12-22 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/
---

(Updated Dec. 23, 2016, 12:57 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-19275
https://issues.apache.org/jira/browse/AMBARI-19275


Repository: ambari


Description
---

Currently there is an API to download compressed config files for a host 
component

Scope of this ticket is to extend this functionality to do following:
# Download all client config files for a host via single API
# Download all client config files of a service via single API. some services 
have more than one client
# Download all client config files for cluster

Apart from extending the functionalty of API, an additional change has been 
made to the behavior of the existing API that looked to be like a bug
Without this patch Downloading client config files for a service component used 
to fetch first host component and create config files as present on that host 
component (host desired configs overlaid on cluster desired configs)
Instead with a change in this patch when download client config is made on a 
service component then config files with only cluster base configs will be 
created for downoad.


Diffs
-

  ambari-server/pom.xml ceec39c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
 ded2596 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
 bc9bb30 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 d2f7934 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 020a454 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java
 cb3c2a7 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java
 f67d961 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 cb88ae1 

Diff: https://reviews.apache.org/r/54958/diff/


Testing (updated)
---

Tested manually on a cluster
Added validation to existing unit tests
Executed all unit tests on dev machine and checked there is no regression
Jenkins QA job for 1st revision of the patch compltedt successsfully
Jenkins QA job for 2nd revision of the patch in progress...


Thanks,

Jaimin Jetly

Re: Review Request 54958: Single API to download all client configs

2016-12-22 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/
---

(Updated Dec. 23, 2016, 12:55 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
Wagle.


Changes
---

Addresses reviewboard comments


Bugs: AMBARI-19275
https://issues.apache.org/jira/browse/AMBARI-19275


Repository: ambari


Description
---

Currently there is an API to download compressed config files for a host 
component

Scope of this ticket is to extend this functionality to do following:
# Download all client config files for a host via single API
# Download all client config files of a service via single API. some services 
have more than one client
# Download all client config files for cluster

Apart from extending the functionalty of API, an additional change has been 
made to the behavior of the existing API that looked to be like a bug
Without this patch Downloading client config files for a service component used 
to fetch first host component and create config files as present on that host 
component (host desired configs overlaid on cluster desired configs)
Instead with a change in this patch when download client config is made on a 
service component then config files with only cluster base configs will be 
created for downoad.


Diffs (updated)
-

  ambari-server/pom.xml ceec39c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
 ded2596 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
 bc9bb30 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 d2f7934 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 020a454 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java
 cb3c2a7 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java
 f67d961 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 cb88ae1 

Diff: https://reviews.apache.org/r/54958/diff/


Testing
---

Tested manually on a cluster
Added validation to existing unit tests
Executed all unit tests on dev machine and checked there is no regression
Jenkins QA job for unit test in progress...


Thanks,

Jaimin Jetly

Review Request 55000: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 4

2016-12-22 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55000/
---

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19058
https://issues.apache.org/jira/browse/AMBARI-19058


Repository: ambari


Description
---

1) Fixed problem with too low packet size in mysql.
2) Fixed problem with too short time to leave for kerberos ticket.


Diffs
-

  contrib/utils/perf/deploy-gce-perf-cluster.py 73c353e 

Diff: https://reviews.apache.org/r/55000/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 54942: AMBARI-19272. Ignored mount points logged for each mount

2016-12-22 Thread Dmytro Grinenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54942/#review160018
---


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 21, 2016, 4:52 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54942/
> ---
> 
> (Updated Dec. 21, 2016, 4:52 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Dmytro Grinenko, Laszlo Puskas, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19272
> https://issues.apache.org/jira/browse/AMBARI-19272
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Moved log out of the loop.
>  * Fixed typo ("was" -> "were")
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py 
> 0d431a389ee492fc8557ae04b56a6c178d5a8fdd 
> 
> Diff: https://reviews.apache.org/r/54942/diff/
> 
> 
> Testing
> ---
> 
> Verified that only the message with all ignored mounts is logged.  (Note: 
> /vagrant is really mounted twice.)
> 
> ```
> INFO 2016-12-21 16:41:03,424 Hardware.py:168 - Some mount points were 
> ignored: /, /dev/shm, /boot, /vagrant, /vagrant
> ```
> 
> Ran unit tests:
> 
> ```
> $ mvn -am -pl ambari-agent clean test
> ...
> Ran 451 tests in 15.070s
> 
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 151 licence.
> ...
> [INFO] Ambari Agent .. SUCCESS [17.537s]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 54955: Add common log4j settings to advanced config - hbase, zookeeper, ams

2016-12-22 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54955/
---

(Updated Dec. 22, 2016, 10:24 p.m.)


Review request for Ambari and Sumit Mohanty.


Changes
---

Incorporated review comments


Bugs: AMBARI-19274
https://issues.apache.org/jira/browse/AMBARI-19274


Repository: ambari


Description
---

Add common log4j settings to advanced config - hbase, zookeeper, ams


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
 08c7b94 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-log4j.xml
 81f6dbc 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 1ad3b85 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
 7fb9715 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 ad66ffe 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml
 8495de1 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
 e513677 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 8200a85 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml
 89dd52d 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
 04f872c 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_linux.py
 84cc431 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml
 84c6db1 

Diff: https://reviews.apache.org/r/54955/diff/


Testing
---

1. Ensure that log4j rolling parameters appear in UI as separate properties
2. Change value and check if reflected in Database, API and file


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 54994: Enable alert scripts from stack extensions

2016-12-22 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54994/#review160012
---


Ship it!




Ship It!

- Di Li


On Dec. 22, 2016, 8:59 p.m., Diego Santesteban wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54994/
> ---
> 
> (Updated Dec. 22, 2016, 8:59 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19283
> https://issues.apache.org/jira/browse/AMBARI-19283
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I added an "extensions_dir" parameter to the AlertSchedulerHandler class 
> initializer, and made necessary changes to implement the parameter in 
> script_alert.py, supply the parameter from Controller.py.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 234795b 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py a9ea8f6 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 8dfa73e 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 2bddc43 
> 
> Diff: https://reviews.apache.org/r/54994/diff/
> 
> 
> Testing
> ---
> 
> I modified the existing tests to use the new "extensions_dir" parameter in 
> AlertSchedulerHandler, and added a new test case that ensures the parameter 
> is being used correctly. Then I executed 'mvn clean test' in the ambari-agent 
> directory, and all tests ran clean
> 
> 
> Output (partial):
> 
> test_execute_alert (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... 
> ok
> test_execute_alert_emptyCommands 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_from_extension 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_noneCommands 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_noneScheduler 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_ams 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_metric 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_none 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_port 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_web 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_load_definitions (TestAlertSchedulerHandler.TestAlertSchedulerHandler) 
> ... ok
> test_load_definitions_noFile 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_start (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> 
> 
> Thanks,
> 
> Diego Santesteban
> 
>

Re: Review Request 54994: Enable alert scripts from stack extensions

2016-12-22 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54994/#review160011
---


Ship it!




Ship It!

- Tim Thorpe


On Dec. 22, 2016, 8:59 p.m., Diego Santesteban wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54994/
> ---
> 
> (Updated Dec. 22, 2016, 8:59 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19283
> https://issues.apache.org/jira/browse/AMBARI-19283
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I added an "extensions_dir" parameter to the AlertSchedulerHandler class 
> initializer, and made necessary changes to implement the parameter in 
> script_alert.py, supply the parameter from Controller.py.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 234795b 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py a9ea8f6 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 8dfa73e 
>   ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
> 1202c81 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 2bddc43 
> 
> Diff: https://reviews.apache.org/r/54994/diff/
> 
> 
> Testing
> ---
> 
> I modified the existing tests to use the new "extensions_dir" parameter in 
> AlertSchedulerHandler, and added a new test case that ensures the parameter 
> is being used correctly. Then I executed 'mvn clean test' in the ambari-agent 
> directory, and all tests ran clean
> 
> 
> Output (partial):
> 
> test_execute_alert (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... 
> ok
> test_execute_alert_emptyCommands 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_from_extension 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_noneCommands 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_execute_alert_noneScheduler 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_ams 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_metric 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_none 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_port 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_json_to_callable_web 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_load_definitions (TestAlertSchedulerHandler.TestAlertSchedulerHandler) 
> ... ok
> test_load_definitions_noFile 
> (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> test_start (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
> 
> 
> Thanks,
> 
> Diego Santesteban
> 
>

Review Request 54994: Enable alert scripts from stack extensions

2016-12-22 Thread Diego Santesteban


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54994/
---

Review request for Ambari, Di Li and Tim Thorpe.


Bugs: AMBARI-19283
https://issues.apache.org/jira/browse/AMBARI-19283


Repository: ambari


Description
---

I added an "extensions_dir" parameter to the AlertSchedulerHandler class 
initializer, and made necessary changes to implement the parameter in 
script_alert.py, supply the parameter from Controller.py.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 65cc8b0 
  ambari-agent/src/main/python/ambari_agent/Controller.py 234795b 
  ambari-agent/src/main/python/ambari_agent/FileCache.py a9ea8f6 
  ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 8dfa73e 
  ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py 
1202c81 
  ambari-agent/src/test/python/ambari_agent/TestAlerts.py 2bddc43 

Diff: https://reviews.apache.org/r/54994/diff/


Testing
---

I modified the existing tests to use the new "extensions_dir" parameter in 
AlertSchedulerHandler, and added a new test case that ensures the parameter is 
being used correctly. Then I executed 'mvn clean test' in the ambari-agent 
directory, and all tests ran clean


Output (partial):

test_execute_alert (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_execute_alert_emptyCommands 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_execute_alert_from_extension 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_execute_alert_noneCommands 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_execute_alert_noneScheduler 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_json_to_callable_ams (TestAlertSchedulerHandler.TestAlertSchedulerHandler) 
... ok
test_json_to_callable_metric 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_json_to_callable_none 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_json_to_callable_port 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_json_to_callable_web (TestAlertSchedulerHandler.TestAlertSchedulerHandler) 
... ok
test_load_definitions (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... 
ok
test_load_definitions_noFile 
(TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok
test_start (TestAlertSchedulerHandler.TestAlertSchedulerHandler) ... ok


Thanks,

Diego Santesteban

Re: Review Request 54936: Zookeeper and RM connection is not secure

2016-12-22 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/
---

(Updated Dec. 22, 2016, 8:53 p.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene 
Chekanskiy, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Changes
---

fixed python tests


Bugs: AMBARI-19269
https://issues.apache.org/jira/browse/AMBARI-19269


Repository: ambari


Description
---

I modified the kerberization/dekerberization process of YARN RM
based on 
https://docs.google.com/document/d/1IEAVBFU2QMhKP5It4_u7L1UtP_QRBTHUk9cOuHjK8AU/

- yarn.resourcemanager.zk-acl is set to sasl:rm:rwcda when kerberos is enabled 
(kerberos.json) 
- jaas file is added to YARN_OPTS with the correct principal and keytab when 
kerberos is enabled
- ACL is reverted to world:anyone:crdwa when disabling kerberos


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
4093431 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 0496995 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 6a7eea7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 f5acb11 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
e690204 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
 cdadc80 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/resourcemanager.py
 e053fe6 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
 70ed5b3 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
2fdce8a 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 
b02b3e9 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
0d67e59 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
e690204 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py bea3f81 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
466b0f7 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 4abf2c9 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
7b5ce18 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 3719fe5 

Diff: https://reviews.apache.org/r/54936/diff/


Testing (updated)
---

Manual testing:
 - created a cluster with YARN + HDFS + ZooKeeper
 - enabled kerberos
 - check that the acl on /rmstore/ZKRMStateRoot is set to sasl
 - disabled kerberos
 - checked that the acl on /rmstore/ZKRMStateRoot is 'world,'anyone
 - Enabled YARN RM HA mode, repeated the above test

Tests:
Ambari server:
Tests run: 4782, Failures: 0, Errors: 0, Skipped: 37

Python tests:
Total run:1146
Total errors:0
Total failures:0

Ambari agent:
Ran 447 tests in 22.056s


Thanks,

Attila Magyar

Re: Review Request 54989: HOU pre-checks indicate HA as a requirement

2016-12-22 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/
---

(Updated Dec. 22, 2016, 3:03 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19285
https://issues.apache.org/jira/browse/AMBARI-19285


Repository: ambari


Description
---

Host Ordered Upgrades do not require the cluster services to be installed in HA 
mode. However, when executing:

{code}
GET 
api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
{code}

HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
running and failing.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 3fc8650 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 45497b5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
 18fb2ad 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 455a92d 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
 dd1385b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
 11d6676 
  ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
b75e923 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
 6289ff5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
 5e44c7c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
 88d9de6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
 1f1980f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 eaedd3f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 620c651 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 52546d2 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
 a77ad9f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 5e2db33 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 b77e1d5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
 18a5bde 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 d4c7894 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
 90eea97 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
 3ed7a27 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
9e43560 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
 b770dd5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
 050d43e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
 64c79a8 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 2bcd482 

Diff: https://reviews.apache.org/r/54989/diff/


Testing (updated)
---

Results :

Tests run: 4813, Failures: 0, Errors: 0, Skipped: 37
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 28:15 min
[INFO] Finished at: 2016-12-22T15:00:07-05:00
[INFO] Final Memory: 59M/678M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 54989: HOU pre-checks indicate HA as a requirement

2016-12-22 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/
---

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.


Bugs: AMBARI-19285
https://issues.apache.org/jira/browse/AMBARI-19285


Repository: ambari


Description
---

Host Ordered Upgrades do not require the cluster services to be installed in HA 
mode. However, when executing:

{code}
GET 
api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
{code}

HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
running and failing.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 3fc8650 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 45497b5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
 18fb2ad 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 455a92d 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
 dd1385b 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
 11d6676 
  ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
b75e923 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
 6289ff5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
 5e44c7c 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
 88d9de6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
 1f1980f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 eaedd3f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 620c651 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
 52546d2 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
 a77ad9f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 5e2db33 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 b77e1d5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
 18a5bde 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 d4c7894 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
 90eea97 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
 3ed7a27 
  ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
9e43560 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
 b770dd5 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
 050d43e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
 64c79a8 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 2bcd482 

Diff: https://reviews.apache.org/r/54989/diff/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 54966: Fix typo in druid service postgresql

2016-12-22 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/#review159976
---


Ship it!




Ship It!

- Sebastian Toader


On Dec. 22, 2016, 5:31 p.m., Slim Bouguerra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54966/
> ---
> 
> (Updated Dec. 22, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix typo in the name of postgresql 
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> c06bebb 
> 
> Diff: https://reviews.apache.org/r/54966/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> python -m discover -v
> test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) 
> ... 
> /Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915:
>  SyntaxWarning: assertion is always true, perhaps remove parentheses?
>   assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage 
> retrieved = {1}. "
> ok
> test_recommendDruidConfigurations_WithDerby 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_WithPostgresql 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_heterogeneous_hosts 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_property_existence_check 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_withMysql 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> 
> --
> Ran 6 tests in 0.200s
> 
> OK
> 
> 
> Thanks,
> 
> Slim Bouguerra
> 
>

Re: Review Request 54966: Fix typo in druid service postgresql

2016-12-22 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/#review159975
---


Ship it!




Ship It!

- Attila Magyar


On Dec. 22, 2016, 4:31 p.m., Slim Bouguerra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54966/
> ---
> 
> (Updated Dec. 22, 2016, 4:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix typo in the name of postgresql 
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> c06bebb 
> 
> Diff: https://reviews.apache.org/r/54966/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> python -m discover -v
> test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) 
> ... 
> /Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915:
>  SyntaxWarning: assertion is always true, perhaps remove parentheses?
>   assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage 
> retrieved = {1}. "
> ok
> test_recommendDruidConfigurations_WithDerby 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_WithPostgresql 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_heterogeneous_hosts 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_property_existence_check 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_withMysql 
> (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> 
> --
> Ran 6 tests in 0.200s
> 
> OK
> 
> 
> Thanks,
> 
> Slim Bouguerra
> 
>

Re: Review Request 54966: Fix typo in druid service postgresql

2016-12-22 Thread Slim Bouguerra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/
---

(Updated Dec. 22, 2016, 4:31 p.m.)


Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278


Repository: ambari


Description
---

Fix typo in the name of postgresql 
https://issues.apache.org/jira/browse/AMBARI-19278


Diffs
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 39ede45 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
ee56899 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py c06bebb 

Diff: https://reviews.apache.org/r/54966/diff/


Testing
---

Tested manually.

python -m discover -v
test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) 
... 
/Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915:
 SyntaxWarning: assertion is always true, perhaps remove parentheses?
  assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage 
retrieved = {1}. "
ok
test_recommendDruidConfigurations_WithDerby 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_WithPostgresql 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_heterogeneous_hosts 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_property_existence_check 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_withMysql 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok

--
Ran 6 tests in 0.200s

OK


Thanks,

Slim Bouguerra

Re: Review Request 54982: Zeppelin Notebook start fails after reboot

2016-12-22 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54982/#review159974
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Гру. 22, 2016, 4:29 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54982/
> ---
> 
> (Updated Гру. 22, 2016, 4:29 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19284
> https://issues.apache.org/jira/browse/AMBARI-19284
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py",
>  line 361, in 
> Master().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 287, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py",
>  line 191, in start
> + params.zeppelin_log_file, user=params.zeppelin_user)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 262, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> resource_management.core.exceptions.ExecutionFailed: Execution of 
> '/usr/hdp/current/zeppelin-server/bin/zeppelin-daemon.sh restart >> 
> /grid/0/log/zeppelin/zeppelin-setup.log' returned 1.  Hortonworks 
> #
> This is MOTD message, added for testing in qe infra
> mkdir: cannot create directory `/var/run/zeppelin': Permission denied
> /usr/hdp/current/zeppelin-server/bin/zeppelin-daemon.sh: line 192: 
> /var/run/zeppelin/zeppelin-zeppelin-nat-d7-rrws-ambari-autostart-1-5.pid: No 
> such file or directory
> cat: 
> /var/run/zeppelin/zeppelin-zeppelin-nat-d7-rrws-ambari-autostart-1-5.pid: No 
> such file or directory
> 
> 
> Explanation:  
> 1\. /var/run/zeppelin created only during install stage  
> 2\. Reboot pc. So that /var/run is cleaned.  
> 3\. Zeppelin fails to start because /var/run/zeppelin is absent
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  0b79d37 
> 
> Diff: https://reviews.apache.org/r/54982/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 54982: Zeppelin Notebook start fails after reboot

2016-12-22 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54982/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-19284
https://issues.apache.org/jira/browse/AMBARI-19284


Repository: ambari


Description
---

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py",
 line 361, in 
Master().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 287, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py",
 line 191, in start
+ params.zeppelin_log_file, user=params.zeppelin_user)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 262, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
raise ExecutionFailed(err_msg, code, out, err)
resource_management.core.exceptions.ExecutionFailed: Execution of 
'/usr/hdp/current/zeppelin-server/bin/zeppelin-daemon.sh restart >> 
/grid/0/log/zeppelin/zeppelin-setup.log' returned 1.  Hortonworks 
#
This is MOTD message, added for testing in qe infra
mkdir: cannot create directory `/var/run/zeppelin': Permission denied
/usr/hdp/current/zeppelin-server/bin/zeppelin-daemon.sh: line 192: 
/var/run/zeppelin/zeppelin-zeppelin-nat-d7-rrws-ambari-autostart-1-5.pid: No 
such file or directory
cat: 
/var/run/zeppelin/zeppelin-zeppelin-nat-d7-rrws-ambari-autostart-1-5.pid: No 
such file or directory


Explanation:  
1\. /var/run/zeppelin created only during install stage  
2\. Reboot pc. So that /var/run is cleaned.  
3\. Zeppelin fails to start because /var/run/zeppelin is absent


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 0b79d37 

Diff: https://reviews.apache.org/r/54982/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2016-12-22 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review159973
---




ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 (line 22)


Why not use spark_conf placeholder and calculate the full patch in one 
shot, than having to calculate the spark home then concatenate the /conf


- Di Li


On Dec. 22, 2016, 9:48 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 22, 2016, 9:48 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2016-12-22 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review159972
---



Hello Ping,

Please also add Alejandro Fernandez (@afernandez)for the review.

- Di Li


On Dec. 22, 2016, 9:48 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 22, 2016, 9:48 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54958: Single API to download all client configs

2016-12-22 Thread Nate Cole



> On Dec. 22, 2016, 12:32 a.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java,
> >  line 240
> > 
> >
> > Shouldn't this just log and error and move on why throw an exception?

+1


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/#review159924
---


On Dec. 21, 2016, 7:28 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54958/
> ---
> 
> (Updated Dec. 21, 2016, 7:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-19275
> https://issues.apache.org/jira/browse/AMBARI-19275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there is an API to download compressed config files for a host 
> component
> 
> Scope of this ticket is to extend this functionality to do following:
> # Download all client config files for a host via single API
> # Download all client config files of a service via single API. some services 
> have more than one client
> # Download all client config files for cluster
> 
> Apart from extending the functionalty of API, an additional change has been 
> made to the behavior of the existing API that looked to be like a bug
> Without this patch Downloading client config files for a service component 
> used to fetch first host component and create config files as present on that 
> host component (host desired configs overlaid on cluster desired configs)
> Instead with a change in this patch when download client config is made on a 
> service component then config files with only cluster base configs will be 
> created for downoad.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml ceec39c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  ded2596 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
>  bc9bb30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  020a454 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java
>  cb3c2a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java
>  f67d961 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  cb88ae1 
> 
> Diff: https://reviews.apache.org/r/54958/diff/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster
> Added validation to existing unit tests
> Executed all unit tests on dev machine and checked there is no regression
> Jenkins QA job for unit test in progress...
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 54958: Single API to download all client configs

2016-12-22 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/#review159970
---




ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
 (line 299)


Would rather use new File(parent, child) syntax



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 (line 205)


no need to qualify the generic for the type:  new ArrayList<> is sufficient



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 (lines 541 - 553)


There could be a LOT of commands which seems like it would be a LOT of 
threads.  Use an Executor instead.  That will avoid both thread bloat and 
process handle bloat.


- Nate Cole


On Dec. 21, 2016, 7:28 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54958/
> ---
> 
> (Updated Dec. 21, 2016, 7:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-19275
> https://issues.apache.org/jira/browse/AMBARI-19275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there is an API to download compressed config files for a host 
> component
> 
> Scope of this ticket is to extend this functionality to do following:
> # Download all client config files for a host via single API
> # Download all client config files of a service via single API. some services 
> have more than one client
> # Download all client config files for cluster
> 
> Apart from extending the functionalty of API, an additional change has been 
> made to the behavior of the existing API that looked to be like a bug
> Without this patch Downloading client config files for a service component 
> used to fetch first host component and create config files as present on that 
> host component (host desired configs overlaid on cluster desired configs)
> Instead with a change in this patch when download client config is made on a 
> service component then config files with only cluster base configs will be 
> created for downoad.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml ceec39c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  ded2596 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
>  bc9bb30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  020a454 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java
>  cb3c2a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java
>  f67d961 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  cb88ae1 
> 
> Diff: https://reviews.apache.org/r/54958/diff/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster
> Added validation to existing unit tests
> Executed all unit tests on dev machine and checked there is no regression
> Jenkins QA job for unit test in progress...
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Slim Bouguerra



> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA 
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
> 
> Attila Magyar wrote:
> I think it was not applied because it was created from the ambari-server 
> directory instead of the project root.
> 
> Slim Bouguerra wrote:
> @Attila Magyar your patch is exactly the same to mine not sure what you 
> mean by created inside an ambari-server ?
> 
> Attila Magyar wrote:
> @Slim Bouguerra the content of the 2 patches are the same but something 
> is wrong with the format of your patch. If you download the 2 patch files and 
> compare it you'll see that one of them uses paths like:
> 
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
> 
> and the other uses:
> 
> 
> a/ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
> 
> This was the reason it didn't apply.

Well that `a` is a git detail it is removed when you generate a diff with the 
option --no-prefix thus both patch are generated against the same git branch


- Slim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
---


On Dec. 22, 2016, 3:16 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> ---
> 
> (Updated Dec. 22, 2016, 3:16 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim 
> Bouguerra, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The stack_advisor script for druid uses 'postgres' as storage type. The 
> documentation of druid says it should be postgresql
> 
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
> 
> Diff: https://reviews.apache.org/r/54979/diff/
> 
> 
> Testing
> ---
> 
> Manually tested by importing a druid blueprint:
>   1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err 
> contained an error 'NoneType' object has no attribute 'format'
>   2. after applying the patch the error disappeared
>  
>  
> Still waiting for the mvn test results
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/
---

(Updated Dec. 22, 2016, 3:16 p.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim Bouguerra, 
and Sebastian Toader.


Changes
---

added branches: trunk, 2.5


Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278


Repository: ambari


Description
---

The stack_advisor script for druid uses 'postgres' as storage type. The 
documentation of druid says it should be postgresql

http://druid.io/docs/latest/development/extensions-core/postgresql.html


Diffs
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 39ede45 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
ee56899 

Diff: https://reviews.apache.org/r/54979/diff/


Testing
---

Manually tested by importing a druid blueprint:
  1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained 
an error 'NoneType' object has no attribute 'format'
  2. after applying the patch the error disappeared
 
 
Still waiting for the mvn test results


Thanks,

Attila Magyar

Re: Review Request 54981: HA HDFS propreties may be written in different case, which prevents operations

2016-12-22 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54981/#review159965
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Dec. 22, 2016, 5:09 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54981/
> ---
> 
> (Updated Dec. 22, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-19282
> https://issues.apache.org/jira/browse/AMBARI-19282
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the command json file the hostname is in lower case, while in HA mode the
> hdfs-site property dfs.namenode.rpc-address.{dfs_ha_nameservices}.{nn_id} may
> have upper case parts, which prevents the /common-
> services/HDFS//package/scripts/params_linux.py file at line 300 from
> identifying the namenode_id, as it tries to find the hostname in the proprety,
> and their case doesn't match.
> 
> Either it should be fixed that the dfs.namenode.rpc-
> address.{dfs_ha_nameservices}.{nn_id} should be always in lower case too or
> the params_linux.py should identify the namenode_id by trying to find the
> hostname in the property ignoring case.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  0aac45e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
>  da00985 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  72e5196 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  daba3d3 
> 
> Diff: https://reviews.apache.org/r/54981/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Attila Magyar



> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA 
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
> 
> Attila Magyar wrote:
> I think it was not applied because it was created from the ambari-server 
> directory instead of the project root.
> 
> Slim Bouguerra wrote:
> @Attila Magyar your patch is exactly the same to mine not sure what you 
> mean by created inside an ambari-server ?

@Slim Bouguerra the content of the 2 patches are the same but something is 
wrong with the format of your patch. If you download the 2 patch files and 
compare it you'll see that one of them uses paths like:

ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py

and the other uses:

a/ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py

This was the reason it didn't apply.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
---


On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> ---
> 
> (Updated Dec. 22, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim 
> Bouguerra, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The stack_advisor script for druid uses 'postgres' as storage type. The 
> documentation of druid says it should be postgresql
> 
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
> 
> Diff: https://reviews.apache.org/r/54979/diff/
> 
> 
> Testing
> ---
> 
> Manually tested by importing a druid blueprint:
>   1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err 
> contained an error 'NoneType' object has no attribute 'format'
>   2. after applying the patch the error disappeared
>  
>  
> Still waiting for the mvn test results
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 54981: HA HDFS propreties may be written in different case, which prevents operations

2016-12-22 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54981/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-19282
https://issues.apache.org/jira/browse/AMBARI-19282


Repository: ambari


Description
---

In the command json file the hostname is in lower case, while in HA mode the
hdfs-site property dfs.namenode.rpc-address.{dfs_ha_nameservices}.{nn_id} may
have upper case parts, which prevents the /common-
services/HDFS//package/scripts/params_linux.py file at line 300 from
identifying the namenode_id, as it tries to find the hostname in the proprety,
and their case doesn't match.

Either it should be fixed that the dfs.namenode.rpc-
address.{dfs_ha_nameservices}.{nn_id} should be always in lower case too or
the params_linux.py should identify the namenode_id by trying to find the
hostname in the property ignoring case.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 0aac45e 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
 da00985 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 72e5196 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 daba3d3 

Diff: https://reviews.apache.org/r/54981/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Slim Bouguerra



> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA 
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.
> 
> Attila Magyar wrote:
> I think it was not applied because it was created from the ambari-server 
> directory instead of the project root.

@Attila Magyar your patch is exactly the same to mine not sure what you mean by 
created inside an ambari-server ?


- Slim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
---


On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> ---
> 
> (Updated Dec. 22, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim 
> Bouguerra, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The stack_advisor script for druid uses 'postgres' as storage type. The 
> documentation of druid says it should be postgresql
> 
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
> 
> Diff: https://reviews.apache.org/r/54979/diff/
> 
> 
> Testing
> ---
> 
> Manually tested by importing a druid blueprint:
>   1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err 
> contained an error 'NoneType' object has no attribute 'format'
>   2. after applying the patch the error disappeared
>  
>  
> Still waiting for the mvn test results
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Attila Magyar



> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote:
> > also i have sent the patch to Apache JIRA 
> > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.

I think it was not applied because it was created from the ambari-server 
directory instead of the project root.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
---


On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> ---
> 
> (Updated Dec. 22, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim 
> Bouguerra, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The stack_advisor script for druid uses 'postgres' as storage type. The 
> documentation of druid says it should be postgresql
> 
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
> 
> Diff: https://reviews.apache.org/r/54979/diff/
> 
> 
> Testing
> ---
> 
> Manually tested by importing a druid blueprint:
>   1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err 
> contained an error 'NoneType' object has no attribute 'format'
>   2. after applying the patch the error disappeared
>  
>  
> Still waiting for the mvn test results
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Slim Bouguerra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159961
---



also i have sent the patch to Apache JIRA 
https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied.

- Slim Bouguerra


On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> ---
> 
> (Updated Dec. 22, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim 
> Bouguerra, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The stack_advisor script for druid uses 'postgres' as storage type. The 
> documentation of druid says it should be postgresql
> 
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
> 
> Diff: https://reviews.apache.org/r/54979/diff/
> 
> 
> Testing
> ---
> 
> Manually tested by importing a druid blueprint:
>   1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err 
> contained an error 'NoneType' object has no attribute 'format'
>   2. after applying the patch the error disappeared
>  
>  
> Still waiting for the mvn test results
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Slim Bouguerra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/#review159960
---



i have sennt a PR alreadsy 
https://reviews.apache.org/r/54966/
can you please review it ?

- Slim Bouguerra


On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54979/
> ---
> 
> (Updated Dec. 22, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim 
> Bouguerra, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The stack_advisor script for druid uses 'postgres' as storage type. The 
> documentation of druid says it should be postgresql
> 
> http://druid.io/docs/latest/development/extensions-core/postgresql.html
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  39ede45 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> ee56899 
> 
> Diff: https://reviews.apache.org/r/54979/diff/
> 
> 
> Testing
> ---
> 
> Manually tested by importing a druid blueprint:
>   1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err 
> contained an error 'NoneType' object has no attribute 'format'
>   2. after applying the patch the error disappeared
>  
>  
> Still waiting for the mvn test results
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 54979: Typo in the PostgreSQL database name for druid service

2016-12-22 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54979/
---

Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim Bouguerra, 
and Sebastian Toader.


Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278


Repository: ambari


Description
---

The stack_advisor script for druid uses 'postgres' as storage type. The 
documentation of druid says it should be postgresql

http://druid.io/docs/latest/development/extensions-core/postgresql.html


Diffs
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 39ede45 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
ee56899 

Diff: https://reviews.apache.org/r/54979/diff/


Testing
---

Manually tested by importing a druid blueprint:
  1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err contained 
an error 'NoneType' object has no attribute 'format'
  2. after applying the patch the error disappeared
 
 
Still waiting for the mvn test results


Thanks,

Attila Magyar

Review Request 54977: Zeppelin Notebook Component is not able start after reboot

2016-12-22 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54977/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-19264
https://issues.apache.org/jira/browse/AMBARI-19264


Repository: ambari


Description
---

- intermittently fails to start the service when /var/run/zeppelin dir is not 
present.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 39941f7 

Diff: https://reviews.apache.org/r/54977/diff/


Testing
---

manually tested on CentOS


Thanks,

Renjith Kamath

Re: Review Request 54976: Display properties for all affected services before adding or deleting ZooKeeper Server

2016-12-22 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54976/#review159955
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Дек. 22, 2016, 12:33 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54976/
> ---
> 
> (Updated Дек. 22, 2016, 12:33 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19281
> https://issues.apache.org/jira/browse/AMBARI-19281
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Only the changes for Storm configs are displayed inside the confirmation 
> popup before adding and deleting ZooKeeper server.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/host/details.js 5f2af2c 
>   ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
> 713ad8c 
>   ambari-web/test/controllers/main/host/details_test.js cbebcf0 
> 
> Diff: https://reviews.apache.org/r/54976/diff/
> 
> 
> Testing
> ---
> 
> 19860 tests complete (23 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 54976: Display properties for all affected services before adding or deleting ZooKeeper Server

2016-12-22 Thread Andriy Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54976/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19281
https://issues.apache.org/jira/browse/AMBARI-19281


Repository: ambari


Description
---

Only the changes for Storm configs are displayed inside the confirmation popup 
before adding and deleting ZooKeeper server.


Diffs
-

  ambari-web/app/controllers/main/host/details.js 5f2af2c 
  ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 
713ad8c 
  ambari-web/test/controllers/main/host/details_test.js cbebcf0 

Diff: https://reviews.apache.org/r/54976/diff/


Testing
---

19860 tests complete (23 seconds)
  153 tests pending


Thanks,

Andriy Babiichuk

Re: Review Request 54973: Cover global controllers with unit tests

2016-12-22 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54973/#review159946
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Дек. 22, 2016, 11:19 д.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54973/
> ---
> 
> (Updated Дек. 22, 2016, 11:19 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19280
> https://issues.apache.org/jira/browse/AMBARI-19280
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cover following files:
> /ambari-web/app/controllers/global/background_operations_controller.js
> /ambari-web/app/controllers/global/cluster_controller.js
> /ambari-web/app/controllers/global/configuration_controller.js
> /ambari-web/app/controllers/global/errors_handler_controller.js
> /ambari-web/app/controllers/global/update_controller.js
> /ambari-web/app/controllers/global/user_settings_controller.js
> /ambari-web/app/controllers/global/wizard_watcher_controller.js
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/background_operations_controller.js 
> 9612141 
>   ambari-web/app/controllers/global/cluster_controller.js d7cedd3 
>   ambari-web/app/controllers/global/configuration_controller.js 43afc0f 
>   ambari-web/app/controllers/global/update_controller.js ce93b34 
>   ambari-web/app/controllers/global/user_settings_controller.js 9580400 
>   ambari-web/test/controllers/global/background_operations_test.js b22c105 
>   ambari-web/test/controllers/global/cluster_controller_test.js 47708ac 
>   ambari-web/test/controllers/global/configuration_controller_test.js 5baac0e 
>   ambari-web/test/controllers/global/errors_handler_controller_test.js 
> 2a726ee 
>   ambari-web/test/controllers/global/update_controller_test.js dc57a57 
>   ambari-web/test/controllers/global/user_settings_controller_test.js 5ae17f8 
> 
> Diff: https://reviews.apache.org/r/54973/diff/
> 
> 
> Testing
> ---
> 
> 19847 passing (26s)
>   153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 54973: Cover global controllers with unit tests

2016-12-22 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54973/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19280
https://issues.apache.org/jira/browse/AMBARI-19280


Repository: ambari


Description
---

Cover following files:
/ambari-web/app/controllers/global/background_operations_controller.js
/ambari-web/app/controllers/global/cluster_controller.js
/ambari-web/app/controllers/global/configuration_controller.js
/ambari-web/app/controllers/global/errors_handler_controller.js
/ambari-web/app/controllers/global/update_controller.js
/ambari-web/app/controllers/global/user_settings_controller.js
/ambari-web/app/controllers/global/wizard_watcher_controller.js


Diffs
-

  ambari-web/app/controllers/global/background_operations_controller.js 9612141 
  ambari-web/app/controllers/global/cluster_controller.js d7cedd3 
  ambari-web/app/controllers/global/configuration_controller.js 43afc0f 
  ambari-web/app/controllers/global/update_controller.js ce93b34 
  ambari-web/app/controllers/global/user_settings_controller.js 9580400 
  ambari-web/test/controllers/global/background_operations_test.js b22c105 
  ambari-web/test/controllers/global/cluster_controller_test.js 47708ac 
  ambari-web/test/controllers/global/configuration_controller_test.js 5baac0e 
  ambari-web/test/controllers/global/errors_handler_controller_test.js 2a726ee 
  ambari-web/test/controllers/global/update_controller_test.js dc57a57 
  ambari-web/test/controllers/global/user_settings_controller_test.js 5ae17f8 

Diff: https://reviews.apache.org/r/54973/diff/


Testing
---

19847 passing (26s)
  153 pending


Thanks,

Andrii Tkach

Re: Review Request 54935: ulimit override missing from upgrade catalogs

2016-12-22 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54935/
---

(Updated Дек. 22, 2016, 10:49 д.п.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19268
https://issues.apache.org/jira/browse/AMBARI-19268


Repository: ambari


Description
---

After upgrade from 2.0.0 hadoop-env doesn't contain:

{% if is_datanode_max_locked_memory_set %}
# Fix temporary bug, when ulimit from conf files is not picked up, without full 
relogin. 
# Makes sense to fix only when runing DN as root 
if [ "$command" == "datanode" ]  [ "$EUID" -eq 0 ]  [ -n 
"$HADOOP_SECURE_DN_USER" ]; then
  ulimit -l {{datanode_max_locked_memory}}
fi
{% endif %}


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 7a385f3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 8568a19 

Diff: https://reviews.apache.org/r/54935/diff/


Testing
---

Unit test passed


Thanks,

Dmytro Sen

Re: Review Request 54892: AMBARI-19254 : Prompting for underlying workflow job properties in a coordinator and coordinator job properties in a bundle during job submission

2016-12-22 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54892/#review159942
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 20, 2016, 12:32 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54892/
> ---
> 
> (Updated Dec. 20, 2016, 12:32 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19254
> https://issues.apache.org/jira/browse/AMBARI-19254
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The job properties of underlying workflow should be submitted when a 
> coordinator is submitted. Similiarly, the job properties of underlying 
> coordinators should be submitted while submitting a bundle job.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 4a8ac90 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 15eb1ce 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 28239fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js
>  17ff9aa 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 036f529 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs
>  8293dbe 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  6b0ea84 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> 6e281d3 
> 
> Diff: https://reviews.apache.org/r/54892/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 54971: AHW Configurations page looks not like any other wizard page

2016-12-22 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54971/#review159939
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Дек. 22, 2016, 9:59 д.п., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54971/
> ---
> 
> (Updated Дек. 22, 2016, 9:59 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: ambari-19279
> https://issues.apache.org/jira/browse/ambari-19279
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Configurations page on AHW wasn't updated when Ambari Theme was created.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/templates/main/host/addHost/step4.hbs 305b5f4 
> 
> Diff: https://reviews.apache.org/r/54971/diff/
> 
> 
> Testing
> ---
> 
> 19866 tests complete (30 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 54971: AHW Configurations page looks not like any other wizard page

2016-12-22 Thread Oleg Nechiporenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54971/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: ambari-19279
https://issues.apache.org/jira/browse/ambari-19279


Repository: ambari


Description
---

Configurations page on AHW wasn't updated when Ambari Theme was created.


Diffs
-

  ambari-web/app/templates/main/host/addHost/step4.hbs 305b5f4 

Diff: https://reviews.apache.org/r/54971/diff/


Testing
---

19866 tests complete (30 seconds)
  153 tests pending


Thanks,

Oleg Nechiporenko

Re: Review Request 54936: Zookeeper and RM connection is not secure

2016-12-22 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/#review159938
---


Ship it!




Ship It!

- Sebastian Toader


On Dec. 22, 2016, 10:14 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54936/
> ---
> 
> (Updated Dec. 22, 2016, 10:14 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19269
> https://issues.apache.org/jira/browse/AMBARI-19269
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I modified the kerberization/dekerberization process of YARN RM
> based on 
> https://docs.google.com/document/d/1IEAVBFU2QMhKP5It4_u7L1UtP_QRBTHUk9cOuHjK8AU/
> 
> - yarn.resourcemanager.zk-acl is set to sasl:rm:rwcda when kerberos is 
> enabled (kerberos.json) 
> - jaas file is added to YARN_OPTS with the correct principal and keytab when 
> kerberos is enabled
> - ACL is reverted to world:anyone:crdwa when disabling kerberos
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> 4093431 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  0496995 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  6a7eea7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  f5acb11 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> e690204 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  cdadc80 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/resourcemanager.py
>  e053fe6 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
>  70ed5b3 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> 2fdce8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  b02b3e9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 0d67e59 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> e690204 
> 
> Diff: https://reviews.apache.org/r/54936/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  - created a cluster with YARN + HDFS + ZooKeeper
>  - enabled kerberos
>  - check that the acl on /rmstore/ZKRMStateRoot is set to sasl
>  - disabled kerberos
>  - checked that the acl on /rmstore/ZKRMStateRoot is 'world,'anyone
>  - Enabled YARN RM HA mode, repeated the above test
>  
> Existing tests are still running..
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2016-12-22 Thread ping wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/
---

Review request for Ambari and Di Li.


Bugs: AMBARI-19250
https://issues.apache.org/jira/browse/AMBARI-19250


Repository: ambari


Description
---

Change default Spark configuration property in Oozie configuration settings to 
valid value


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 a2d725c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 cdb6972 

Diff: https://reviews.apache.org/r/54970/diff/


Testing
---

I have tested the fix by:
1) copy the changed files into ambari host and restart ambari-server
2) delete oozie service and then add it back
3) check the property value is point to the spark configuration directory 
correctly


Thanks,

ping wang

Re: Review Request 54936: Zookeeper and RM connection is not secure

2016-12-22 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/
---

(Updated Dec. 22, 2016, 9:14 a.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene 
Chekanskiy, Laszlo Puskas, Robert Levas, and Sebastian Toader.


Changes
---

replaced python format strings to format('{..}')


Bugs: AMBARI-19269
https://issues.apache.org/jira/browse/AMBARI-19269


Repository: ambari


Description
---

I modified the kerberization/dekerberization process of YARN RM
based on 
https://docs.google.com/document/d/1IEAVBFU2QMhKP5It4_u7L1UtP_QRBTHUk9cOuHjK8AU/

- yarn.resourcemanager.zk-acl is set to sasl:rm:rwcda when kerberos is enabled 
(kerberos.json) 
- jaas file is added to YARN_OPTS with the correct principal and keytab when 
kerberos is enabled
- ACL is reverted to world:anyone:crdwa when disabling kerberos


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
4093431 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 0496995 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 6a7eea7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 f5acb11 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
e690204 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
 cdadc80 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/resourcemanager.py
 e053fe6 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
 70ed5b3 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
2fdce8a 
  
ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 
b02b3e9 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
0d67e59 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
e690204 

Diff: https://reviews.apache.org/r/54936/diff/


Testing
---

Manual testing:
 - created a cluster with YARN + HDFS + ZooKeeper
 - enabled kerberos
 - check that the acl on /rmstore/ZKRMStateRoot is set to sasl
 - disabled kerberos
 - checked that the acl on /rmstore/ZKRMStateRoot is 'world,'anyone
 - Enabled YARN RM HA mode, repeated the above test
 
Existing tests are still running..


Thanks,

Attila Magyar

50 matches

Mail list logo