Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172586
---




ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
Lines 24-25 (patched)


Unused imports


- Attila Doroszlai


On April 20, 2017, 9:53 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58590/
> ---
> 
> (Updated April 20, 2017, 9:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20616
> https://issues.apache.org/jira/browse/AMBARI-20616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some services in our stack have custom commands where the name is a 
> combination of an operation and a component name.
> 
> For e.g. Remove_Logical_myservice_mycomponent
> 
> When the custom command is being executed, the operations window title is 
> displayed as "Remove Logical myservice mycomponent mycomponent"
> 
> It would be useful to provide an optional attribute e.g. useNameInOps for 
> custom commands to allow using the command name itself as the title displayed 
> in the operations window.
> 
> 
> Remove_Logical_myservice_mycomponent
> true
> 
> scripts/mycomponent.py
> PYTHON
>  10800
>  
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
>  87a6edf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  17bc718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
>  20b0417 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  86feceb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
>  280a59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  633d837 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d 
>   ambari-server/src/main/resources/properties.json c2545fe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
>  8a52b8a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  fec041c 
>   ambari-web/app/controllers/wizard/step9_controller.js 4697dad 
>   ambari-web/app/utils/ajax/ajax.js 2b5e52a 
>   ambari-web/app/utils/helper.js 03a2e82 
>   ambari-web/app/utils/host_progress_popup.js c615cae 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 
>   ambari-web/test/utils/helper_test.js 4b9ec36 
> 
> 
> Diff: https://reviews.apache.org/r/58590/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> Added new test cases.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/#review172567
---


Ship it!




Ship It!

- Jaimin Jetly


On April 21, 2017, 12:09 a.m., Yusaku Sako wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58596/
> ---
> 
> (Updated April 21, 2017, 12:09 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
> 
> 
> Bugs: AMBARI-20813
> https://issues.apache.org/jira/browse/AMBARI-20813
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> See https://issues.apache.org/jira/browse/AMBARI-20813
> 
> 
> Diffs
> -
> 
>   ambari-web/pom.xml 6182a60 
> 
> 
> Diff: https://reviews.apache.org/r/58596/diff/2/
> 
> 
> Testing
> ---
> 
> Tested locally to make sure that "mvn package" builds Ambari Web successfully.
> 
> Ran ambari-web unit tests:
>   30380 passing (19s)
>   157 pending
> 
> 
> Thanks,
> 
> Yusaku Sako
> 
>

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/
---

(Updated April 21, 2017, 12:09 a.m.)


Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.


Changes
---

While testing on a Jenkins build machine, I've encountered 
https://github.com/Medium/phantomjs/issues/673.  So I've included a workaround.


Bugs: AMBARI-20813
https://issues.apache.org/jira/browse/AMBARI-20813


Repository: ambari


Description
---

See https://issues.apache.org/jira/browse/AMBARI-20813


Diffs (updated)
-

  ambari-web/pom.xml 6182a60 


Diff: https://reviews.apache.org/r/58596/diff/2/

Changes: https://reviews.apache.org/r/58596/diff/1-2/


Testing
---

Tested locally to make sure that "mvn package" builds Ambari Web successfully.

Ran ambari-web unit tests:
  30380 passing (19s)
  157 pending


Thanks,

Yusaku Sako

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/#review172560
---


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On April 20, 2017, 10:43 p.m., Yusaku Sako wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58596/
> ---
> 
> (Updated April 20, 2017, 10:43 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.
> 
> 
> Bugs: AMBARI-20813
> https://issues.apache.org/jira/browse/AMBARI-20813
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> See https://issues.apache.org/jira/browse/AMBARI-20813
> 
> 
> Diffs
> -
> 
>   ambari-web/pom.xml 6182a60 
> 
> 
> Diff: https://reviews.apache.org/r/58596/diff/1/
> 
> 
> Testing
> ---
> 
> Tested locally to make sure that "mvn package" builds Ambari Web successfully.
> 
> Ran ambari-web unit tests:
>   30380 passing (19s)
>   157 pending
> 
> 
> Thanks,
> 
> Yusaku Sako
> 
>

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/
---

(Updated April 20, 2017, 10:43 p.m.)


Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.


Bugs: AMBARI-20813
https://issues.apache.org/jira/browse/AMBARI-20813


Repository: ambari


Description
---

See https://issues.apache.org/jira/browse/AMBARI-20813


Diffs
-

  ambari-web/pom.xml 6182a60 


Diff: https://reviews.apache.org/r/58596/diff/1/


Testing
---

Tested locally to make sure that "mvn package" builds Ambari Web successfully.

Ran ambari-web unit tests:
  30380 passing (19s)
  157 pending


Thanks,

Yusaku Sako

Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58596/
---

Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian.


Repository: ambari


Description
---

See https://issues.apache.org/jira/browse/AMBARI-20813


Diffs
-

  ambari-web/pom.xml 6182a60 


Diff: https://reviews.apache.org/r/58596/diff/1/


Testing
---

Tested locally to make sure that "mvn package" builds Ambari Web successfully.

Ran ambari-web unit tests:
  30380 passing (19s)
  157 pending


Thanks,

Yusaku Sako

Re: Review Request 58592: Upgrade is not taking care of AMBARI-15677

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58592/#review172552
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 20, 2017, 8:47 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58592/
> ---
> 
> (Updated April 20, 2017, 8:47 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20747
> https://issues.apache.org/jira/browse/AMBARI-20747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When customer upgraded their Ambari from 2.2.1 to 2.4.1 and HDP 2.3.4 to 
> 2.5.3 
> it is not taking care of https://issues.apache.org/jira/browse/AMBARI-15677 
> RESOLVED bug.
> Ambari does not set -XX:CMSInitiatingOccupancyFraction=70 or 
> -XX:+UseCMSInitiatingOccupancyOnly properties.
> where as fresh install comes up with these parameters. this needs to be fixed.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 63cf5f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  3d8041e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  fa06291 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  8b8b9a6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  2bf6e23 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 97904bf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> fd75e49 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 5318a51 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> d2e6288 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 2345d08 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  13f44fb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  ea261b9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  de6b8ef 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> fba7093 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 68efed2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 2ed7962 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> ad936c2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  d5387c6 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  d46353e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 1af96dd 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 94aab48 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> ceed59b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  ce07f7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 5b8f53b 
> 
> 
> Diff: https://reviews.apache.org/r/58592/diff/1/
> 
> 
> Testing
> ---
> 
> Performed an ugprade from HDP 2.4 to HDP 2.5 with a doctored property. 
> Observed the upgraded value post-upgrade.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172549
---




ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
Lines 72 (patched)


I would suggest to actually have a field to overwrite the display name to 
use in order to make it more flexible.

The reason being that the custom command name is used to find the function 
in python, which is not necessarily very human readable.


- Alejandro Fernandez


On April 20, 2017, 7:53 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58590/
> ---
> 
> (Updated April 20, 2017, 7:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20616
> https://issues.apache.org/jira/browse/AMBARI-20616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some services in our stack have custom commands where the name is a 
> combination of an operation and a component name.
> 
> For e.g. Remove_Logical_myservice_mycomponent
> 
> When the custom command is being executed, the operations window title is 
> displayed as "Remove Logical myservice mycomponent mycomponent"
> 
> It would be useful to provide an optional attribute e.g. useNameInOps for 
> custom commands to allow using the command name itself as the title displayed 
> in the operations window.
> 
> 
> Remove_Logical_myservice_mycomponent
> true
> 
> scripts/mycomponent.py
> PYTHON
>  10800
>  
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
>  87a6edf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  17bc718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
>  20b0417 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  86feceb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
>  280a59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  633d837 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d 
>   ambari-server/src/main/resources/properties.json c2545fe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
>  8a52b8a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  fec041c 
>   ambari-web/app/controllers/wizard/step9_controller.js 4697dad 
>   ambari-web/app/utils/ajax/ajax.js 2b5e52a 
>   ambari-web/app/utils/helper.js 03a2e82 
>   ambari-web/app/utils/host_progress_popup.js c615cae 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 
>   ambari-web/test/utils/helper_test.js 4b9ec36 
> 
> 
> Diff: https://reviews.apache.org/r/58590/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> Added new test cases.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 58592: Upgrade is not taking care of AMBARI-15677

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58592/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-20747
https://issues.apache.org/jira/browse/AMBARI-20747


Repository: ambari


Description
---

When customer upgraded their Ambari from 2.2.1 to 2.4.1 and HDP 2.3.4 to 2.5.3 
it is not taking care of https://issues.apache.org/jira/browse/AMBARI-15677 
RESOLVED bug.
Ambari does not set -XX:CMSInitiatingOccupancyFraction=70 or 
-XX:+UseCMSInitiatingOccupancyOnly properties.
where as fresh install comes up with these parameters. this needs to be fixed.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
63cf5f5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 3d8041e 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 fa06291 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 8b8b9a6 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 2bf6e23 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
97904bf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
fd75e49 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
5318a51 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
d2e6288 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
2345d08 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 13f44fb 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 ea261b9 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 de6b8ef 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
fba7093 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
68efed2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
2ed7962 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
ad936c2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 d5387c6 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 d46353e 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
1af96dd 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
94aab48 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
ceed59b 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 ce07f7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
5b8f53b 


Diff: https://reviews.apache.org/r/58592/diff/1/


Testing
---

Performed an ugprade from HDP 2.4 to HDP 2.5 with a doctored property. Observed 
the upgraded value post-upgrade.


Thanks,

Jonathan Hurley

Review Request 58591: Roles page in Ambari UI shows extra rows in IE browser

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58591/
---

Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and 
Sangeeta Ravindran.


Bugs: AMBARI-20810
https://issues.apache.org/jira/browse/AMBARI-20810


Repository: ambari


Description
---

Roles page in Ambari UI shows extra empty rows in Internet explorer.

javascript For..each loop doesn't work as expected for arrays in Internet 
explorer, which causes the extra rows as in screenshot.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js
 e1b74aa 


Diff: https://reviews.apache.org/r/58591/diff/1/


Testing
---

tested manually, verified in different browsers (IE/firefox/chrome)


File Attachments


After fix
  
https://reviews.apache.org/media/uploaded/files/2017/04/20/d891ffb5-e048-4c4c-9b50-dca3bab48ba2__Afterfix.jpg
Before fix
  
https://reviews.apache.org/media/uploaded/files/2017/04/20/a6915f9d-d69b-4dda-9e3b-6cfd338cb815__UI.jpg


Thanks,

Anita Jebaraj

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172542
---



Has upgrade been tested?

- Tim Thorpe


On April 20, 2017, 7:53 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58590/
> ---
> 
> (Updated April 20, 2017, 7:53 p.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20616
> https://issues.apache.org/jira/browse/AMBARI-20616
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some services in our stack have custom commands where the name is a 
> combination of an operation and a component name.
> 
> For e.g. Remove_Logical_myservice_mycomponent
> 
> When the custom command is being executed, the operations window title is 
> displayed as "Remove Logical myservice mycomponent mycomponent"
> 
> It would be useful to provide an optional attribute e.g. useNameInOps for 
> custom commands to allow using the command name itself as the title displayed 
> in the operations window.
> 
> 
> Remove_Logical_myservice_mycomponent
> true
> 
> scripts/mycomponent.py
> PYTHON
>  10800
>  
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
>  87a6edf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  17bc718 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
>  20b0417 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  86feceb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
>  280a59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  633d837 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d 
>   ambari-server/src/main/resources/properties.json c2545fe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
>  8a52b8a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  fec041c 
>   ambari-web/app/controllers/wizard/step9_controller.js 4697dad 
>   ambari-web/app/utils/ajax/ajax.js 2b5e52a 
>   ambari-web/app/utils/helper.js 03a2e82 
>   ambari-web/app/utils/host_progress_popup.js c615cae 
>   ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 
>   ambari-web/test/utils/helper_test.js 4b9ec36 
> 
> 
> Diff: https://reviews.apache.org/r/58590/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> Added new test cases.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/
---

(Updated April 20, 2017, 7:53 p.m.)


Review request for Ambari, Di Li and Tim Thorpe.


Summary (updated)
-

Provide an optional attribute for custom commands to allow using command name 
in operations window title


Bugs: AMBARI-20616
https://issues.apache.org/jira/browse/AMBARI-20616


Repository: ambari


Description
---

Some services in our stack have custom commands where the name is a combination 
of an operation and a component name.

For e.g. Remove_Logical_myservice_mycomponent

When the custom command is being executed, the operations window title is 
displayed as "Remove Logical myservice mycomponent mycomponent"

It would be useful to provide an optional attribute e.g. useNameInOps for 
custom commands to allow using the command name itself as the title displayed 
in the operations window.


Remove_Logical_myservice_mycomponent
true

scripts/mycomponent.py
PYTHON
 10800
 



Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
 87a6edf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 17bc718 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
 20b0417 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 86feceb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/CustomCommandDefinition.java
 280a59b 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 633d837 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fd49b94 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9fc3209 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 310208d 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c052104 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5a58ef8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8c7a31d 
  ambari-server/src/main/resources/properties.json c2545fe 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java
 8a52b8a 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntityTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 fec041c 
  ambari-web/app/controllers/wizard/step9_controller.js 4697dad 
  ambari-web/app/utils/ajax/ajax.js 2b5e52a 
  ambari-web/app/utils/helper.js 03a2e82 
  ambari-web/app/utils/host_progress_popup.js c615cae 
  ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 
  ambari-web/test/utils/helper_test.js 4b9ec36 


Diff: https://reviews.apache.org/r/58590/diff/1/


Testing
---

Manual Testing.
Added new test cases.


Thanks,

Sangeeta Ravindran

Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/#review172537
---


Ship it!




Can we write a simple unit test to verify that on a stack which has no config 
pack, one gets created?

- Jonathan Hurley


On April 20, 2017, 1:49 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58583/
> ---
> 
> (Updated April 20, 2017, 1:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20811
> https://issues.apache.org/jira/browse/AMBARI-20811
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following steps were followed.
> 1. Installed ambari 2.4.1.0
> 2. Installed HDF 2.0.2.0
> 3. Upgraded ambari to 2.5.0.3
> 4 Upgraded mpack to 3.0.0.0-169 is installed.
> 5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
> 6. Registered and installed the new version 3.0.0.0-169
> 7. Click on express upgrade. Throws 500
> 
> Ambari-server has the following exception in the logs
> {code:None}
> 11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] 
> ContainerResponse:419 - The RuntimeException could not be mapped to a 
> response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at 
> org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
> at 
> org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
> at 
> org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
> at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
> at 
> org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
> at 
> org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
> at 
> org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
> at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
> at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
> at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
> at 
> org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  daa9014162 
> 
> 
> Diff: https://reviews.apache.org/r/58583/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

[Vitalyi Brodetskyi]

> On Квітень 20, 2017, 6:11 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> > Lines 430 (patched)
> > 
> >
> > Why does core-site need special handling?

I discussed this situation with Sumit in jira 
https://hortonworks.jira.com/browse/BUG-76895?focusedCommentId=572585=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-572585
 and we decided to create it if it doesn;t break anything.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172528
---


On Квітень 20, 2017, 2:19 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated Квітень 20, 2017, 2:19 після полудня)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

[Miklos Gergely]

> On April 20, 2017, 6:02 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
> > Lines 30 (patched)
> > 
> >
> > Is Logsearch Server an optional component?
> > How is it possible to have the LogSearch service but not the server?

Starting from 2.5.1 we allow installing Log Feeders without a portal on the 
same cluster. In this case the Log Search Portal is in another cluster which 
may be the monitoring tool for multiple clusters. They both use the same solr 
for uploading/querying the log entries.


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58562/#review172525
---


On April 20, 2017, 11:51 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58562/
> ---
> 
> (Updated April 20, 2017, 11:51 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20798
> https://issues.apache.org/jira/browse/AMBARI-20798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Do not run Log Search service check if there is no portal in the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  c81268c 
> 
> 
> Diff: https://reviews.apache.org/r/58562/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58579/#review172530
---


Ship it!




Ship It!

- Robert Nettleton


On April 20, 2017, 4:13 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58579/
> ---
> 
> (Updated April 20, 2017, 4:13 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20808
> https://issues.apache.org/jira/browse/AMBARI-20808
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The zookeeper transaction log/snapshot data can be written continuously and 
> result disk full due to continous transaction request by Ambari Infra Solr. 
> That can happen because of audit log collection schema upgrade. (schema is 
> updated externally, adding new dynamic fields). Instead of that we will need 
> to send a request to ask Solr to add the new fields
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
>  2a4c790 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UpgradeSchemaHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
>  27a6705 
> 
> 
> Diff: https://reviews.apache.org/r/58579/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58562/#review172529
---


Ship it!




Ship It!

- Robert Nettleton


On April 20, 2017, 11:51 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58562/
> ---
> 
> (Updated April 20, 2017, 11:51 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20798
> https://issues.apache.org/jira/browse/AMBARI-20798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Do not run Log Search service check if there is no portal in the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  c81268c 
> 
> 
> Diff: https://reviews.apache.org/r/58562/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172528
---




ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
Lines 430 (patched)


Why does core-site need special handling?


- Alejandro Fernandez


On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58576: AMBARI-20792 : Atlas admin username and password should be configurable through ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58576/#review172527
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 20, 2017, 3:02 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58576/
> ---
> 
> (Updated April 20, 2017, 3:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20792
> https://issues.apache.org/jira/browse/AMBARI-20792
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need a feature to configure Atlas admin user-name and password in Ambari.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  c25445c 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  e243662 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58576/diff/1/
> 
> 
> Testing
> ---
> 
> Verified fresh install and upgrade scenario on centos.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58562/#review172525
---




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
Lines 30 (patched)


Is Logsearch Server an optional component?
How is it possible to have the LogSearch service but not the server?


- Alejandro Fernandez


On April 20, 2017, 11:51 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58562/
> ---
> 
> (Updated April 20, 2017, 11:51 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20798
> https://issues.apache.org/jira/browse/AMBARI-20798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Do not run Log Search service check if there is no portal in the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  c81268c 
> 
> 
> Diff: https://reviews.apache.org/r/58562/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58555: Ambari agent should log how it determines it's FQDN

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58555/#review172524
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 20, 2017, 8:14 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58555/
> ---
> 
> (Updated April 20, 2017, 8:14 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-20787
> https://issues.apache.org/jira/browse/AMBARI-20787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logging the steps of how fqdn of the agent is determined.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py 8cb8a28 
>   ambari-agent/src/main/python/ambari_agent/hostname.py 0f5f069 
> 
> 
> Diff: https://reviews.apache.org/r/58555/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> ambari-agent unit tests:
> 
> Ran 467 tests in 28.170s
> 
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0 fails with NPE

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-20811
https://issues.apache.org/jira/browse/AMBARI-20811


Repository: ambari


Description
---

The following steps were followed.
1. Installed ambari 2.4.1.0
2. Installed HDF 2.0.2.0
3. Upgraded ambari to 2.5.0.3
4 Upgraded mpack to 3.0.0.0-169 is installed.
5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
6. Registered and installed the new version 3.0.0.0-169
7. Click on express upgrade. Throws 500

Ambari-server has the following exception in the logs
{code:None}
11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 
- The RuntimeException could not be mapped to a response, re-throwing to the 
HTTP container
java.lang.NullPointerException
at 
org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
at 
org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
at 
org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
at 
org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
at 
org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
at 
org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
at 
org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
at 
org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
at 
org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
at 
org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
at 
org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
daa9014162 


Diff: https://reviews.apache.org/r/58583/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 58444: Log Feeder fill cluster name if it is not set

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/#review172522
---


Ship it!




Ship It!

- Robert Nettleton


On April 14, 2017, 1:20 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58444/
> ---
> 
> (Updated April 14, 2017, 1:20 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20766
> https://issues.apache.org/jira/browse/AMBARI-20766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If for some reason there is no cluster set for a log entry, set it to the 
> actual cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  9a9f973 
> 
> 
> Diff: https://reviews.apache.org/r/58444/diff/1/
> 
> 
> Testing
> ---
> 
> tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58574: BE: Characters used in usernames should be constrained

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/#review172521
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
Lines 1 (patched)


Missing license



ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
Lines 1 (patched)


Missing license


- Attila Doroszlai


On April 20, 2017, 5:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58574/
> ---
> 
> (Updated April 20, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20771
> https://issues.apache.org/jira/browse/AMBARI-20771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Characters used in usernames should be constrained such that they cannot 
> contain the following characters:
>  Less than symbols ( < )
>  Greater than symbols ( > )
>  Ampersand ( & )
>  Back slashes ( \ )
>  Backtick ( ` )
>  Pipe ( | )
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  576ca97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  4ed777b 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> fdc19d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
> bb0b0cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  d69d49a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  6b98a5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  9ff381f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
>  6541a59 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  f426c85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  e5e36f3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  e31a428 
> 
> 
> Diff: https://reviews.apache.org/r/58574/diff/2/
> 
> 
> Testing
> ---
> 
> Added new unittest, tested manually at end to end level using curl.
> 
> 
> [root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
> application/json" -u admin:admin -d 
> '{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
>  http://c6401.ambari.apache.org:8080/api/v1/users
> {
>   "status" : 400,
>   "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
> }
> 
> Existing tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172515
---




ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
Lines 380 (patched)


+1 for version tag


- Alejandro Fernandez


On April 20, 2017, 3:41 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> ---
> 
> (Updated April 20, 2017, 3:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
> https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  4cdeecb153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172516
---


Ship it!




Hi Vitaly,
Please make note that for trunk, 
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 there is a separate function called setup_metastore() where the snippet for 
the /tmp scratch directory will have to go.
Thanks.

- Madhuvanthi Radhakrishnan


On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172514
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
Lines 530-532 (original), 530-532 (patched)


Maybe these should be Log.info ?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
Lines 380 (patched)


I think you should use version_tag instead of timestamp ...


- Jonathan Hurley


On April 20, 2017, 11:41 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58577/
> ---
> 
> (Updated April 20, 2017, 11:41 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20805
> https://issues.apache.org/jira/browse/AMBARI-20805
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Existing implementation removes all entities of the same type
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  4cdeecb153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
> b727c720bb 
> 
> 
> Diff: https://reviews.apache.org/r/58577/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58579/#review172512
---


Ship it!




Ship It!

- Miklos Gergely


On April 20, 2017, 4:13 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58579/
> ---
> 
> (Updated April 20, 2017, 4:13 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20808
> https://issues.apache.org/jira/browse/AMBARI-20808
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The zookeeper transaction log/snapshot data can be written continuously and 
> result disk full due to continous transaction request by Ambari Infra Solr. 
> That can happen because of audit log collection schema upgrade. (schema is 
> updated externally, adding new dynamic fields). Instead of that we will need 
> to send a request to ask Solr to add the new fields
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
>  2a4c790 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UpgradeSchemaHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
>  27a6705 
> 
> 
> Diff: https://reviews.apache.org/r/58579/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58578: Log Search REST API calls for configuration should send proper error responses

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/#review172510
---


Ship it!




Ship It!

- Oliver Szabo


On April 20, 2017, 4:21 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58578/
> ---
> 
> (Updated April 20, 2017, 4:21 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20807
> https://issues.apache.org/jira/browse/AMBARI-20807
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case of a REST API call for configuration the error response should be in 
> the proper format if the configuration is not available yet.
> 
> Also removed some unused codes.
> Also modified REST API paths to have a cleaner structure
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
>  4f1725f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  2f9cba4 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
>  251619b 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java
>  38821bc 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
>  c14900e 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  84a6ad9 
> 
> 
> Diff: https://reviews.apache.org/r/58578/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 58578: Log Search REST API calls for configuration should send proper error responses

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58578/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20807
https://issues.apache.org/jira/browse/AMBARI-20807


Repository: ambari


Description
---

In case of a REST API call for configuration the error response should be in 
the proper format if the configuration is not available yet.

Also removed some unused codes.
Also modified REST API paths to have a cleaner structure


Diffs
-

  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 4f1725f 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 2f9cba4 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
 251619b 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java
 38821bc 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
 c14900e 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 84a6ad9 


Diff: https://reviews.apache.org/r/58578/diff/1/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Review Request 58579: Create schema requests to upgrade solr schema (do not change it externally)

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58579/
---

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-20808
https://issues.apache.org/jira/browse/AMBARI-20808


Repository: ambari


Description
---

The zookeeper transaction log/snapshot data can be written continuously and 
result disk full due to continous transaction request by Ambari Infra Solr. 
That can happen because of audit log collection schema upgrade. (schema is 
updated externally, adding new dynamic fields). Instead of that we will need to 
send a request to ask Solr to add the new fields


Diffs
-

  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
 2a4c790 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UpgradeSchemaHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
 27a6705 


Diff: https://reviews.apache.org/r/58579/diff/1/


Testing
---

done


Thanks,

Oliver Szabo

Re: Review Request 57610: Filter out kerberos rules in exported blueprint

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57610/#review172506
---



I've suggested using the thread local but overall looking at the patch now, it 
seems to me a litle bit overcomplicated.
May be it would much more simplier if we could pass authToLocal properties to 
KerberosAuthToLocalRulesFilter directly to the constructor. So instead of 
creating a static list of filters, we could create this list of filters 
(exportPropertyFilters) in doFilterPriorToExport method before filtering code - 
as it's not used anywhere else - where you can easily get authToLocal 
properties for the given cluster then pass it to KerberosAuthToLocalRulesFilter 
instance through the constructor. So I think actually we don't need to keep the 
list of filters statically all the time, we can create the list just for the 
time of export filtering.

- Sandor Magyari


On April 18, 2017, 9:13 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57610/
> ---
> 
> (Updated April 18, 2017, 9:13 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, Robert Nettleton, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-20366
> https://issues.apache.org/jira/browse/AMBARI-20366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If blueprint is exported from a kerberos enabled cluster Kerberos rules 
> export principal names which contain cluster name and Realm, this patch 
> filter out kerberos rules properties so that hardcoded cluster name and realm 
> are not exported.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  bb771a54a6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
>  13db5f8b56 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  5c1836a87d 
> 
> 
> Diff: https://reviews.apache.org/r/57610/diff/4/
> 
> 
> Testing
> ---
> 
> Tested manually.
> Modified test cases.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 58574: BE: Characters used in usernames should be constrained

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/#review172500
---


Ship it!




Ship It!

- Sebastian Toader


On April 20, 2017, 5:51 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58574/
> ---
> 
> (Updated April 20, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20771
> https://issues.apache.org/jira/browse/AMBARI-20771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Characters used in usernames should be constrained such that they cannot 
> contain the following characters:
>  Less than symbols ( < )
>  Greater than symbols ( > )
>  Ampersand ( & )
>  Back slashes ( \ )
>  Backtick ( ` )
>  Pipe ( | )
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  576ca97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  4ed777b 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> fdc19d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
> bb0b0cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  d69d49a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  6b98a5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  9ff381f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
>  6541a59 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  f426c85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  e5e36f3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  e31a428 
> 
> 
> Diff: https://reviews.apache.org/r/58574/diff/2/
> 
> 
> Testing
> ---
> 
> Added new unittest, tested manually at end to end level using curl.
> 
> 
> [root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
> application/json" -u admin:admin -d 
> '{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
>  http://c6401.ambari.apache.org:8080/api/v1/users
> {
>   "status" : 400,
>   "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
> }
> 
> Existing tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 58574: BE: Characters used in usernames should be constrained

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/
---

(Updated April 20, 2017, 3:51 p.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Changes
---

extract constant


Bugs: AMBARI-20771
https://issues.apache.org/jira/browse/AMBARI-20771


Repository: ambari


Description
---

Characters used in usernames should be constrained such that they cannot 
contain the following characters:
 Less than symbols ( < )
 Greater than symbols ( > )
 Ampersand ( & )
 Back slashes ( \ )
 Backtick ( ` )
 Pipe ( | )


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
 576ca97 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 4ed777b 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
fdc19d1 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
bb0b0cf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
 d69d49a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 6b98a5b 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 9ff381f 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
 6541a59 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
 f426c85 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
 e5e36f3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 e31a428 


Diff: https://reviews.apache.org/r/58574/diff/2/

Changes: https://reviews.apache.org/r/58574/diff/1-2/


Testing
---

Added new unittest, tested manually at end to end level using curl.


[root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
application/json" -u admin:admin -d 
'{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
 http://c6401.ambari.apache.org:8080/api/v1/users
{
  "status" : 400,
  "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
}

Existing tests: PENDING


Thanks,

Attila Magyar

Review Request 58577: Autofix db leads to dangling entries in ClusterConfigMapping table

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-20805
https://issues.apache.org/jira/browse/AMBARI-20805


Repository: ambari


Description
---

Existing implementation removes all entities of the same type


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 4cdeecb153 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 
b727c720bb 


Diff: https://reviews.apache.org/r/58577/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 58569: Ambari fails to upgrade from 2.4.2.0 to 2.5.1.0 during schema upgrade with NPE

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58569/#review172498
---


Ship it!




Ship It!

- Nate Cole


On April 20, 2017, 8:59 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58569/
> ---
> 
> (Updated April 20, 2017, 8:59 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20799
> https://issues.apache.org/jira/browse/AMBARI-20799
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On trying to upgrade ambari from 2.4.2.0 to 2.5.1.0 upgrade is failing with 
> nullPointerException during ambari schema upgrade
> {code:None}
> 20 Apr 2017 05:55:01,410 ERROR [main] SchemaUpgradeHelper:257 - Upgrade 
> failed.
> java.lang.NullPointerException
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateMetaInfoVersion(AbstractUpgradeCatalog.java:272)
> at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateDatabaseSchemaVersion(AbstractUpgradeCatalog.java:949)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeOnPostUpgrade(SchemaUpgradeHelper.java:255)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:433)
> 20 Apr 2017 05:55:01,413 ERROR [main] SchemaUpgradeHelper:444 - Exception 
> occurred during upgrade, failed
> org.apache.ambari.server.AmbariException
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeOnPostUpgrade(SchemaUpgradeHelper.java:258)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:433)
> Caused by: java.lang.NullPointerException
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateMetaInfoVersion(AbstractUpgradeCatalog.java:272)
> at 
> org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateDatabaseSchemaVersion(AbstractUpgradeCatalog.java:949)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeOnPostUpgrade(SchemaUpgradeHelper.java:255)
> ... 1 more
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  9a78ea1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
>  20f0d72 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
>  a5f38a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
>  3743b53 
> 
> 
> Diff: https://reviews.apache.org/r/58569/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 58574: BE: Characters used in usernames should be constrained

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/#review172497
---




ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
Lines 24 (patched)


The list of forbidden chars should be stored as a constant (or as a 
compiled regexp)


- Sebastian Toader


On April 20, 2017, 4:28 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58574/
> ---
> 
> (Updated April 20, 2017, 4:28 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20771
> https://issues.apache.org/jira/browse/AMBARI-20771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Characters used in usernames should be constrained such that they cannot 
> contain the following characters:
>  Less than symbols ( < )
>  Greater than symbols ( > )
>  Ampersand ( & )
>  Back slashes ( \ )
>  Backtick ( ` )
>  Pipe ( | )
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  576ca97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  4ed777b 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> fdc19d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
> bb0b0cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  d69d49a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  6b98a5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  9ff381f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
>  6541a59 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  f426c85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  e5e36f3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  e31a428 
> 
> 
> Diff: https://reviews.apache.org/r/58574/diff/1/
> 
> 
> Testing
> ---
> 
> Added new unittest, tested manually at end to end level using curl.
> 
> 
> [root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
> application/json" -u admin:admin -d 
> '{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
>  http://c6401.ambari.apache.org:8080/api/v1/users
> {
>   "status" : 400,
>   "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
> }
> 
> Existing tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 58565: AMBARI-20781. Hadoop QA test results link is broken

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58565/#review172494
---


Ship it!




Ship It!

- Laszlo Puskas


On April 20, 2017, 2:53 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58565/
> ---
> 
> (Updated April 20, 2017, 2:53 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit 
> Mohanty, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20781
> https://issues.apache.org/jira/browse/AMBARI-20781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Link to Maven's output from test run.
> Remove link to nonexistent page.
> 
> 
> Diffs
> -
> 
>   dev-support/test-patch.sh 934e09262e743b6acd42d2f5b440563a045dcc9d 
> 
> 
> Diff: https://reviews.apache.org/r/58565/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 58574: BE: Characters used in usernames should be constrained

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/#review172491
---


Ship it!




Ship It!

- Robert Levas


On April 20, 2017, 10:28 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58574/
> ---
> 
> (Updated April 20, 2017, 10:28 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20771
> https://issues.apache.org/jira/browse/AMBARI-20771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Characters used in usernames should be constrained such that they cannot 
> contain the following characters:
>  Less than symbols ( < )
>  Greater than symbols ( > )
>  Ampersand ( & )
>  Back slashes ( \ )
>  Backtick ( ` )
>  Pipe ( | )
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
>  576ca97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  4ed777b 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> fdc19d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
> bb0b0cf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
>  d69d49a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  6b98a5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  9ff381f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
>  6541a59 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
>  f426c85 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
>  e5e36f3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  e31a428 
> 
> 
> Diff: https://reviews.apache.org/r/58574/diff/1/
> 
> 
> Testing
> ---
> 
> Added new unittest, tested manually at end to end level using curl.
> 
> 
> [root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
> application/json" -u admin:admin -d 
> '{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
>  http://c6401.ambari.apache.org:8080/api/v1/users
> {
>   "status" : 400,
>   "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
> }
> 
> Existing tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 58565: AMBARI-20781. Hadoop QA test results link is broken

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58565/#review172492
---


Ship it!




Ship It!

- Sebastian Toader


On April 20, 2017, 4:53 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58565/
> ---
> 
> (Updated April 20, 2017, 4:53 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit 
> Mohanty, Sebastian Toader, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20781
> https://issues.apache.org/jira/browse/AMBARI-20781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Link to Maven's output from test run.
> Remove link to nonexistent page.
> 
> 
> Diffs
> -
> 
>   dev-support/test-patch.sh 934e09262e743b6acd42d2f5b440563a045dcc9d 
> 
> 
> Diff: https://reviews.apache.org/r/58565/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 58576: AMBARI-20792 : Atlas admin username and password should be configurable through ambari

[Vishal Suvagia via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58576/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-20792
https://issues.apache.org/jira/browse/AMBARI-20792


Repository: ambari


Description
---

Need a feature to configure Atlas admin user-name and password in Ambari.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 c25445c 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 e243662 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-env.xml
 PRE-CREATION 


Diff: https://reviews.apache.org/r/58576/diff/1/


Testing
---

Verified fresh install and upgrade scenario on centos.


Thanks,

Vishal Suvagia

Re: Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/#review172489
---


Ship it!




Ship It!

- Sumit Mohanty


On April 20, 2017, 2:19 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58568/
> ---
> 
> (Updated April 20, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-20802
> https://issues.apache.org/jira/browse/AMBARI-20802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a minimal Blueprint install was attempted in that issue, some failures 
> occurred during the Blueprint deployment.
> After some investigation, we determined that the Blueprints processor was 
> throwing a NullPointerException, due to some configuration types being 
> considered "updated", even though those configuration types are not included 
> in the "desired configuration" for the cluster, since the services associated 
> with those configuration types are not deployed in this current cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  ce36208 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  be79331 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6cd6d35 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> ad35688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 7ef5fad 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> f9fb1f5 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> 2d7322d 
> 
> 
> Diff: https://reviews.apache.org/r/58568/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/
---

Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-20797
https://issues.apache.org/jira/browse/AMBARI-20797


Repository: ambari


Description
---

I had in trouble compiling same as in 
https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
The solution is also mentioned in the URL above. We should use storm-1.1.0 , 
not storm-1.1.0-SNAPSHOT


Diffs
-

  ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 


Diff: https://reviews.apache.org/r/58575/diff/1/


Testing
---

-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 core tests. The patch passed unit tests in 
ambari-metrics/ambari-metrics-storm-sink.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
This message is automatically generated.


Thanks,

Masahiro Tanaka

Review Request 58565: AMBARI-20781. Hadoop QA test results link is broken

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58565/
---

Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit 
Mohanty, Sebastian Toader, and Yusaku Sako.


Bugs: AMBARI-20781
https://issues.apache.org/jira/browse/AMBARI-20781


Repository: ambari


Description
---

Link to Maven's output from test run.
Remove link to nonexistent page.


Diffs
-

  dev-support/test-patch.sh 934e09262e743b6acd42d2f5b440563a045dcc9d 


Diff: https://reviews.apache.org/r/58565/diff/1/


Testing
---


Thanks,

Attila Doroszlai

Review Request 58574: BE: Characters used in usernames should be constrained

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58574/
---

Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Bugs: AMBARI-20771
https://issues.apache.org/jira/browse/AMBARI-20771


Repository: ambari


Description
---

Characters used in usernames should be constrained such that they cannot 
contain the following characters:
 Less than symbols ( < )
 Greater than symbols ( > )
 Ampersand ( & )
 Back slashes ( \ )
 Backtick ( ` )
 Pipe ( | )


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserEntity.java
 576ca97 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserName.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 4ed777b 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
fdc19d1 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java 
bb0b0cf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/SecurityHelperImplTest.java
 d69d49a 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 6b98a5b 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 9ff381f 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariUserAuthenticationFilterTest.java
 6541a59 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UserNameTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/UsersTest.java
 f426c85 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
 e5e36f3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 e31a428 


Diff: https://reviews.apache.org/r/58574/diff/1/


Testing
---

Added new unittest, tested manually at end to end level using curl.


[root@c6401 vagrant]# curl -H "X-Requested-By: Ambari" -H "Content-Type: 
application/json" -u admin:admin -d 
'{"Users/user_name":"admin34`","Users/password":"admin","Users/active":true,"Users/admin":false}'
 http://c6401.ambari.apache.org:8080/api/v1/users
{
  "status" : 400,
  "message" : "Invalid username: admin34` Avoid characters [<, >, &, |, \, `]"
}

Existing tests: PENDING


Thanks,

Attila Magyar

Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/#review172484
---


Ship it!




Ship It!

- belliraj hb


On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58564/
> ---
> 
> (Updated April 20, 2017, 12:01 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-20800
> https://issues.apache.org/jira/browse/AMBARI-20800
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rearranged the Delete and Close buttons so as to keep the styling consistent.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
>  ac28de3 
> 
> 
> Diff: https://reviews.apache.org/r/58564/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Re: Review Request 58566: Remove Hard Coded Dependency to libtirpc-devel

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58566/#review172480
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 20, 2017, 12:33 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58566/
> ---
> 
> (Updated Квітень 20, 2017, 12:33 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20801
> https://issues.apache.org/jira/browse/AMBARI-20801
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It looks like there was a problem discovered with HDP 2.5 NFS Gateway's RPM
> where it was missing a dependency on `libtirpc-devel`. This seems to have been
> discovered at the exact same time by both Ambari and HDFS release teams. As
> such, two parallel fixes were made:
> 
>   * AMBARI-19567 adds this to the `metainfo.xml` of HDFS.
>   * HDFS fixed this in their NFS RPM
> 
> Because HDFS fixed this, Ambari should _not_ need to manually call out the
> requirement of this package. Instead, we should rely on the RPM dependencies.
> The code from AMBARI-19567 should be reverted.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 8a9c08a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
> 8c2ec8b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
> ccf9a4e 
> 
> 
> Diff: https://reviews.apache.org/r/58566/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 58571: Devdeploy: Logsearch service check fails

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58571/#review172479
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 20, 2017, 1:14 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58571/
> ---
> 
> (Updated Квітень 20, 2017, 1:14 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20803
> https://issues.apache.org/jira/browse/AMBARI-20803
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2017-04-20 13:11:55,559 - Log Search Server not running
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py",
>  line 38, in 
> LogSearchServiceCheck().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 315, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py",
>  line 31, in service_check
> tries=15, try_sleep=5, timeout=10)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 
> 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 262, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 72, in inner
> result = function(command, **kwargs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 102, in checked_call
> tries=tries, try_sleep=try_sleep, 
> timeout_kill_strategy=timeout_kill_strategy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 150, in _call_wrapper
> result = _call(command, **kwargs_copy)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 
> 303, in _call
> raise ExecutionFailed(err_msg, code, out, err)
> resource_management.core.exceptions.ExecutionFailed: Execution of 'curl 
> -k -s -o /dev/null -w "%{http_code}" http://:61888/login.html | grep 200' 
> returned 1.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  d00be4e 
> 
> 
> Diff: https://reviews.apache.org/r/58571/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 58571: Devdeploy: Logsearch service check fails

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58571/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-20803
https://issues.apache.org/jira/browse/AMBARI-20803


Repository: ambari


Description
---

2017-04-20 13:11:55,559 - Log Search Server not running
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py",
 line 38, in 
LogSearchServiceCheck().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 315, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py",
 line 31, in service_check
tries=15, try_sleep=5, timeout=10)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 262, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 72, 
in inner
result = function(command, **kwargs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 102, 
in checked_call
tries=tries, try_sleep=try_sleep, 
timeout_kill_strategy=timeout_kill_strategy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 150, 
in _call_wrapper
result = _call(command, **kwargs_copy)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 303, 
in _call
raise ExecutionFailed(err_msg, code, out, err)
resource_management.core.exceptions.ExecutionFailed: Execution of 'curl -k 
-s -o /dev/null -w "%{http_code}" http://:61888/login.html | grep 200' returned 
1.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 d00be4e 


Diff: https://reviews.apache.org/r/58571/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 58569: Ambari fails to upgrade from 2.4.2.0 to 2.5.1.0 during schema upgrade with NPE

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58569/
---

Review request for Ambari, Dmytro Grinenko and Nate Cole.


Bugs: AMBARI-20799
https://issues.apache.org/jira/browse/AMBARI-20799


Repository: ambari


Description
---

On trying to upgrade ambari from 2.4.2.0 to 2.5.1.0 upgrade is failing with 
nullPointerException during ambari schema upgrade
{code:None}
20 Apr 2017 05:55:01,410 ERROR [main] SchemaUpgradeHelper:257 - Upgrade failed.
java.lang.NullPointerException
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateMetaInfoVersion(AbstractUpgradeCatalog.java:272)
at 
org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateDatabaseSchemaVersion(AbstractUpgradeCatalog.java:949)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeOnPostUpgrade(SchemaUpgradeHelper.java:255)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:433)
20 Apr 2017 05:55:01,413 ERROR [main] SchemaUpgradeHelper:444 - Exception 
occurred during upgrade, failed
org.apache.ambari.server.AmbariException
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeOnPostUpgrade(SchemaUpgradeHelper.java:258)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:433)
Caused by: java.lang.NullPointerException
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateMetaInfoVersion(AbstractUpgradeCatalog.java:272)
at 
org.apache.ambari.server.orm.AmbariJpaLocalTxnInterceptor.invoke(AmbariJpaLocalTxnInterceptor.java:128)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.updateDatabaseSchemaVersion(AbstractUpgradeCatalog.java:949)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeOnPostUpgrade(SchemaUpgradeHelper.java:255)
... 1 more
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 9a78ea1 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
 20f0d72 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java
 a5f38a9 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
 3743b53 


Diff: https://reviews.apache.org/r/58569/diff/1/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Review Request 58568: StackAdvisor should not recommend configuration types for services that are not present in the cluster

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58568/
---

Review request for Ambari, Madhuvanthi Radhakrishnan and Sumit Mohanty.


Bugs: AMBARI-20802
https://issues.apache.org/jira/browse/AMBARI-20802


Repository: ambari


Description
---

When a minimal Blueprint install was attempted in that issue, some failures 
occurred during the Blueprint deployment.
After some investigation, we determined that the Blueprints processor was 
throwing a NullPointerException, due to some configuration types being 
considered "updated", even though those configuration types are not included in 
the "desired configuration" for the cluster, since the services associated with 
those configuration types are not deployed in this current cluster.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 ce36208 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 be79331 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 6cd6d35 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
ad35688 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
7ef5fad 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f9fb1f5 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 2d7322d 


Diff: https://reviews.apache.org/r/58568/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/#review172475
---


Ship it!




Ship It!

- venkat sairam


On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58564/
> ---
> 
> (Updated April 20, 2017, 12:01 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-20800
> https://issues.apache.org/jira/browse/AMBARI-20800
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rearranged the Delete and Close buttons so as to keep the styling consistent.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
>  ac28de3 
> 
> 
> Diff: https://reviews.apache.org/r/58564/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Supreeth Sharma
> 
>

Review Request 58566: Remove Hard Coded Dependency to libtirpc-devel

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58566/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-20801
https://issues.apache.org/jira/browse/AMBARI-20801


Repository: ambari


Description
---

It looks like there was a problem discovered with HDP 2.5 NFS Gateway's RPM
where it was missing a dependency on `libtirpc-devel`. This seems to have been
discovered at the exact same time by both Ambari and HDFS release teams. As
such, two parallel fixes were made:

  * AMBARI-19567 adds this to the `metainfo.xml` of HDFS.
  * HDFS fixed this in their NFS RPM

Because HDFS fixed this, Ambari should _not_ need to manually call out the
requirement of this package. Instead, we should rely on the RPM dependencies.
The code from AMBARI-19567 should be reverted.


Diffs
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
8a9c08a 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
8c2ec8b 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
ccf9a4e 


Diff: https://reviews.apache.org/r/58566/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 58564: Need to change the arrangement of the action buttons in project manager

[Supreeth Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58564/
---

Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and 
venkat sairam.


Bugs: AMBARI-20800
https://issues.apache.org/jira/browse/AMBARI-20800


Repository: ambari


Description
---

Rearranged the Delete and Close buttons so as to keep the styling consistent.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs
 ac28de3 


Diff: https://reviews.apache.org/r/58564/diff/1/


Testing
---

Manual testing done


Thanks,

Supreeth Sharma

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58562/
---

(Updated April 20, 2017, 11:51 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20798
https://issues.apache.org/jira/browse/AMBARI-20798


Repository: ambari


Description
---

Do not run Log Search service check if there is no portal in the cluster.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 c81268c 


Diff: https://reviews.apache.org/r/58562/diff/1/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

[Keta Patel]

> On April 20, 2017, 4:44 p.m., Oliver Szabo wrote:
> > Ship It!
> 
> Keta Patel wrote:
> Thank you!
> Could you please help me with pushing in the change?
> 
> Oliver Szabo wrote:
> thanks for the contribution.
> patches are merged:
> - trunk: 1c37ffc435995fc898941837a2cdcdffd51d06bc
> - branch-2.5: 682bd23194db38ddfeff2743888a9dee91bf514d
> 
> You can submit this review request

Thank you!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/#review172467
---


On April 20, 2017, 4:43 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58493/
> ---
> 
> (Updated April 20, 2017, 4:43 p.m.)
> 
> 
> Review request for Ambari, Di Li, Miklos Gergely, and Oliver Szabo.
> 
> 
> Bugs: AMBARI-20768
> https://issues.apache.org/jira/browse/AMBARI-20768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A local Ambari user with no cluster roles assigned to it can successfully log 
> into the Logsearch UI.
> 
> Logsearch service exercises restriction on who can access its UI using a 
> property "logsearch.roles.allowed". This property is a comma-separated list 
> of roles to be allowed access to Logsearch UI. This defect deals with the 
> following issue:
> 1. If Logsearch service requires that only certain roles be allowed to access 
> its UI, then a local Ambari user with no roles must not be allowed to access 
> the UI.
> 
> 
> DESIRED BEHAVIOR:
> =
> 1. A local user with no role assigned to it, must not be able to access 
> Logsearch UI.
> 
> Note: The description has been updated by removing the aspect of correcting 
> the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  e23f0a2 
> 
> 
> Diff: https://reviews.apache.org/r/58493/diff/2/
> 
> 
> Testing
> ---
> 
> The patch *AMBARI-20768.patch* contains the fix for this issue. The fix 
> involves correction in 1 place in the 
> LogsearchExternalServerAuthenticationProvider class.
> 1. In order to prevent a local user with no cluster roles assigned to it from 
> logging into Logsearch UI, we return *false*.
> 
> The results of the logsearch tests after applying the patch are shown in the 
> screenshot "all_tests_successful.png" on the Jira.
> 
> Note: The description for testing has been updated by removing the aspect of 
> correcting the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 58562: Do not run Log Search service check if there is no portal in the cluster.

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58562/#review172471
---


Ship it!




Ship It!

- Oliver Szabo


On April 20, 2017, 11:40 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58562/
> ---
> 
> (Updated April 20, 2017, 11:40 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20798
> https://issues.apache.org/jira/browse/AMBARI-20798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Do not run Log Search service check if there is no portal in the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  c81268c 
> 
> 
> Diff: https://reviews.apache.org/r/58562/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

[Keta Patel]

> On April 20, 2017, 4:44 p.m., Oliver Szabo wrote:
> > Ship It!

Thank you!
Could you please help me with pushing in the change?


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/#review172467
---


On April 20, 2017, 4:43 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58493/
> ---
> 
> (Updated April 20, 2017, 4:43 p.m.)
> 
> 
> Review request for Ambari, Di Li, Miklos Gergely, and Oliver Szabo.
> 
> 
> Bugs: AMBARI-20768
> https://issues.apache.org/jira/browse/AMBARI-20768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A local Ambari user with no cluster roles assigned to it can successfully log 
> into the Logsearch UI.
> 
> Logsearch service exercises restriction on who can access its UI using a 
> property "logsearch.roles.allowed". This property is a comma-separated list 
> of roles to be allowed access to Logsearch UI. This defect deals with the 
> following issue:
> 1. If Logsearch service requires that only certain roles be allowed to access 
> its UI, then a local Ambari user with no roles must not be allowed to access 
> the UI.
> 
> 
> DESIRED BEHAVIOR:
> =
> 1. A local user with no role assigned to it, must not be able to access 
> Logsearch UI.
> 
> Note: The description has been updated by removing the aspect of correcting 
> the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  e23f0a2 
> 
> 
> Diff: https://reviews.apache.org/r/58493/diff/2/
> 
> 
> Testing
> ---
> 
> The patch *AMBARI-20768.patch* contains the fix for this issue. The fix 
> involves correction in 1 place in the 
> LogsearchExternalServerAuthenticationProvider class.
> 1. In order to prevent a local user with no cluster roles assigned to it from 
> logging into Logsearch UI, we return *false*.
> 
> The results of the logsearch tests after applying the patch are shown in the 
> screenshot "all_tests_successful.png" on the Jira.
> 
> Note: The description for testing has been updated by removing the aspect of 
> correcting the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/#review172467
---


Ship it!




Ship It!

- Oliver Szabo


On April 20, 2017, 11:13 a.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58493/
> ---
> 
> (Updated April 20, 2017, 11:13 a.m.)
> 
> 
> Review request for Ambari, Di Li, Miklos Gergely, and Oliver Szabo.
> 
> 
> Bugs: AMBARI-20768
> https://issues.apache.org/jira/browse/AMBARI-20768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A local Ambari user with no cluster roles assigned to it can successfully log 
> into the Logsearch UI.
> 
> Logsearch service exercises restriction on who can access its UI using a 
> property "logsearch.roles.allowed". This property is a comma-separated list 
> of roles to be allowed access to Logsearch UI. This defect deals with the 
> following issue:
> 1. If Logsearch service requires that only certain roles be allowed to access 
> its UI, then a local Ambari user with no roles must not be allowed to access 
> the UI.
> 
> 
> DESIRED BEHAVIOR:
> =
> 1. A local user with no role assigned to it, must not be able to access 
> Logsearch UI.
> 
> Note: The description has been updated by removing the aspect of correcting 
> the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  e23f0a2 
> 
> 
> Diff: https://reviews.apache.org/r/58493/diff/2/
> 
> 
> Testing
> ---
> 
> The patch *AMBARI-20768.patch* contains the fix for this issue. The fix 
> involves correction in 1 place in the 
> LogsearchExternalServerAuthenticationProvider class.
> 1. In order to prevent a local user with no cluster roles assigned to it from 
> logging into Logsearch UI, we return *false*.
> 
> The results of the logsearch tests after applying the patch are shown in the 
> screenshot "all_tests_successful.png" on the Jira.
> 
> Note: The description for testing has been updated by removing the aspect of 
> correcting the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

[Keta Patel]

> On April 20, 2017, 3:22 p.m., Miklos Gergely wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
> > Line 126 (original), 126 (patched)
> > 
> >
> > As this is the only change that remained, and this is a bug fix not 
> > related to AMBARI.ADMINISTRATOR privileges please modify the description of 
> > the review request and the bug.

Hello Miklos,
Thank you for the suggestion. I have updated the description on both the 
ReviewBoard and the Jira.


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/#review172460
---


On April 20, 2017, 4:43 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58493/
> ---
> 
> (Updated April 20, 2017, 4:43 p.m.)
> 
> 
> Review request for Ambari, Di Li, Miklos Gergely, and Oliver Szabo.
> 
> 
> Bugs: AMBARI-20768
> https://issues.apache.org/jira/browse/AMBARI-20768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A local Ambari user with no cluster roles assigned to it can successfully log 
> into the Logsearch UI.
> 
> Logsearch service exercises restriction on who can access its UI using a 
> property "logsearch.roles.allowed". This property is a comma-separated list 
> of roles to be allowed access to Logsearch UI. This defect deals with the 
> following issue:
> 1. If Logsearch service requires that only certain roles be allowed to access 
> its UI, then a local Ambari user with no roles must not be allowed to access 
> the UI.
> 
> 
> DESIRED BEHAVIOR:
> =
> 1. A local user with no role assigned to it, must not be able to access 
> Logsearch UI.
> 
> Note: The description has been updated by removing the aspect of correcting 
> the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  e23f0a2 
> 
> 
> Diff: https://reviews.apache.org/r/58493/diff/2/
> 
> 
> Testing
> ---
> 
> The patch *AMBARI-20768.patch* contains the fix for this issue. The fix 
> involves correction in 1 place in the 
> LogsearchExternalServerAuthenticationProvider class.
> 1. In order to prevent a local user with no cluster roles assigned to it from 
> logging into Logsearch UI, we return *false*.
> 
> The results of the logsearch tests after applying the patch are shown in the 
> screenshot "all_tests_successful.png" on the Jira.
> 
> Note: The description for testing has been updated by removing the aspect of 
> correcting the behavior for Ambari Administrator role for the Logsearch UI.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/
---

(Updated April 20, 2017, 4:43 p.m.)


Review request for Ambari, Di Li, Miklos Gergely, and Oliver Szabo.


Bugs: AMBARI-20768
https://issues.apache.org/jira/browse/AMBARI-20768


Repository: ambari


Description (updated)
---

A local Ambari user with no cluster roles assigned to it can successfully log 
into the Logsearch UI.

Logsearch service exercises restriction on who can access its UI using a 
property "logsearch.roles.allowed". This property is a comma-separated list of 
roles to be allowed access to Logsearch UI. This defect deals with the 
following issue:
1. If Logsearch service requires that only certain roles be allowed to access 
its UI, then a local Ambari user with no roles must not be allowed to access 
the UI.


DESIRED BEHAVIOR:
=
1. A local user with no role assigned to it, must not be able to access 
Logsearch UI.

Note: The description has been updated by removing the aspect of correcting the 
behavior for Ambari Administrator role for the Logsearch UI.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 e23f0a2 


Diff: https://reviews.apache.org/r/58493/diff/2/


Testing (updated)
---

The patch *AMBARI-20768.patch* contains the fix for this issue. The fix 
involves correction in 1 place in the 
LogsearchExternalServerAuthenticationProvider class.
1. In order to prevent a local user with no cluster roles assigned to it from 
logging into Logsearch UI, we return *false*.

The results of the logsearch tests after applying the patch are shown in the 
screenshot "all_tests_successful.png" on the Jira.

Note: The description for testing has been updated by removing the aspect of 
correcting the behavior for Ambari Administrator role for the Logsearch UI.


Thanks,

Keta Patel

Re: Review Request 58493: AMBARI-20768: Local Ambari user with no cluster role must not be able to access Logsearch UI

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/#review172460
---


Fix it, then Ship it!




Ship It!


ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
Line 126 (original), 126 (patched)


As this is the only change that remained, and this is a bug fix not related 
to AMBARI.ADMINISTRATOR privileges please modify the description of the review 
request and the bug.


- Miklos Gergely


On April 20, 2017, 5:37 a.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58493/
> ---
> 
> (Updated April 20, 2017, 5:37 a.m.)
> 
> 
> Review request for Ambari, Di Li, Miklos Gergely, and Oliver Szabo.
> 
> 
> Bugs: AMBARI-20768
> https://issues.apache.org/jira/browse/AMBARI-20768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A local Ambari user with no cluster roles assigned to it can successfully log 
> into the Logsearch UI.
> 
> Logsearch service exercises restriction on who can access its UI using a 
> property "logsearch.roles.allowed". This property is a comma-separated list 
> of roles to be allowed access to Logsearch UI. This defect deals with the 
> following 2 issues:
> 1. If Logsearch service requires that only certain roles be allowed to access 
> its UI, then a local Ambari user with no roles must not be allowed to access 
> the UI.
> 2. If some user with privilege to edit the config properties, updates 
> "logsearch.roles.allowed" by removing the "AMBARI.ADMINISTRATOR" role from 
> its list, then the Ambari Admins will not be able to access the Logsearch UI. 
> This violates the Ambari Administrator privilege which must be able to access 
> all frames of Ambari UI as well as perform all UI operations.
> 
> 
> DESIRED BEHAVIOR:
> =
> 1. A local user with no role assigned to it, must not be able to access 
> Logsearch UI.
> 2. Ambari Administrators must be always be allowed to access the Logsearch 
> UI. No user is allowed to revoke this access right of Ambari Administrator 
> for the Logsearch UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  e23f0a2 
> 
> 
> Diff: https://reviews.apache.org/r/58493/diff/2/
> 
> 
> Testing
> ---
> 
> The patch *AMBARI-20768.patch* contains the fix for this issue. The fix 
> involves correction in 2 places in the 
> LogsearchExternalServerAuthenticationProvider class.
> 1. In order to prevent a local user with no cluster roles assigned to it from 
> logging into Logsearch UI, we return *false*.
> 2. We implicitly check whether the user is an Ambari Administrator or not, 
> thus removing the requirement of having "AMBARI.ADMINISTRATOR" role in the 
> "logsearch.roles.allowed" property on the UI. Now, even if some user removes 
> the "AMBARI.ADMINISTRATOR" property from the UI, it will not affect the 
> Ambari admin's accessibility to the Logsearch UI. Ambari Admins will always 
> be allowed to login.
> 
> The results of the logsearch tests after applying the patch are shown in the 
> screenshot "all_tests_successful.png" on the Jira.
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Re: Review Request 58555: Ambari agent should log how it determines it's FQDN

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58555/#review172458
---


Ship it!




Ship It!

- Attila Doroszlai


On April 20, 2017, 10:14 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58555/
> ---
> 
> (Updated April 20, 2017, 10:14 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-20787
> https://issues.apache.org/jira/browse/AMBARI-20787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logging the steps of how fqdn of the agent is determined.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py 8cb8a28 
>   ambari-agent/src/main/python/ambari_agent/hostname.py 0f5f069 
> 
> 
> Diff: https://reviews.apache.org/r/58555/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> ambari-agent unit tests:
> 
> Ran 467 tests in 28.170s
> 
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 58551: Miscellaneous fixes to support HDP 3.0 Tech Preview

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58551/#review172457
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 20, 2017, 5:28 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58551/
> ---
> 
> (Updated April 20, 2017, 5:28 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Sumit 
> Mohanty, Swapan Shridhar, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20790
> https://issues.apache.org/jira/browse/AMBARI-20790
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Miscellaneous fixes to support HDP 3.0 Tech Preview
> 
> * Temporarily rename Spark 2.x RPMs to "spark2" and "livy2"
> * ResourceManager failed to start because /var/log/hadoop-yarn needs to be 
> created first
> * mapreduce tarball was not uploaded to HDFS because HDFS Client needs to be 
> present on the host with HistoryServer
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 2c441ad 
>   ambari-server/src/main/resources/common-services/SPARK/2.2.0/metainfo.xml 
> 25a6855 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/job_history_server.py
>  16a2224 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_server.py
>  b09d9a9 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/params.py
>  ab58cb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_client.py
>  a2e53cd 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_service.py
>  c6619e4 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_thrift_server.py
>  de82c16 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  52338df 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
> 18186bd 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
>  d601f8f 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml
>  fbda35a 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration-mapred/mapred-env.xml
>  deb4ef7 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration-mapred/mapred-site.xml
>  cbeb08b 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 7a0514a 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py ab5e2cd 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> b7f90c8 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> 40db813 
>   ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py b523412 
> 
> 
> Diff: https://reviews.apache.org/r/58551/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Verified on a live cluster (except Spark which is still not ready from the 
> RPM perspective)
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 58555: Ambari agent should log how it determines it's FQDN

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58555/
---

Review request for Ambari, Attila Doroszlai and Andrew Onischuk.


Bugs: AMBARI-20787
https://issues.apache.org/jira/browse/AMBARI-20787


Repository: ambari


Description
---

Logging the steps of how fqdn of the agent is determined.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Hardware.py 8cb8a28 
  ambari-agent/src/main/python/ambari_agent/hostname.py 0f5f069 


Diff: https://reviews.apache.org/r/58555/diff/1/


Testing
---

Manual testing.

ambari-agent unit tests:

Ran 467 tests in 28.170s

OK


Thanks,

Sebastian Toader