Review Request 62719: Upgrades Do Not Finalize If Other Host Versions Are Out of Sync

2017-10-01 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62719/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-22105
https://issues.apache.org/jira/browse/AMBARI-22105


Repository: ambari


Description
---

STR:
- Install base version 2.6.0.0 with ZK and Storm
- Cause that base version to be out of sync for 1 component, say ZK.
- Install a patch for Storm
- Upgrade and attempt to finalize Storm

{noformat}
Finalizing the upgrade to 2.6.0.3-8 for the following services: STORM
The following 3 host(s) have not been upgraded to version 2.6.0.3-8. Please 
install and upgrade the Stack Version on those hosts and try again.
Hosts: ctr-e134-1499953498516-185715-01-02.hwx.site, 
ctr-e134-1499953498516-185715-01-03.hwx.site, 
ctr-e134-1499953498516-185715-01-04.hwx.site
{noformat}

This is because the code is detecting the OUT_OF_SYNC of other components/repos 
on that host.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 072863daed 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 f9d3cfc52a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java
 e9359ef1eb 


Diff: https://reviews.apache.org/r/62719/diff/1/


Testing
---

PENDING...


Thanks,

Jonathan Hurley



Review Request 62718: Refactor existing server side actions to use the common AbstractUpgradeServerAction

2017-10-01 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62718/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22104
https://issues.apache.org/jira/browse/AMBARI-22104


Repository: ambari


Description
---

Other server-side classes need to use the abstract class in the summary. 
Identify fields that are largely common with the server-side actions and put 
them in the abstract class.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
 664cb2c9a9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
 ec4d383dee 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java
 f14d702a45 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixLzoCodecPath.java
 483372943b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
 75588d5921 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
 5823c8bdf6 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseConfigCalculation.java
 739dd7e985 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseEnvMaxDirectMemorySizeAction.java
 fb1347 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveEnvClasspathAction.java
 c5000bf9b5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveZKQuorumConfigAction.java
 23eacec7d2 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/KerberosKeytabsAction.java
 4c6371b054 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ManualStageAction.java
 39b23bc930 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/OozieConfigCalculation.java
 9b8a7dc583 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerConfigCalculation.java
 e53c95f703 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
 348b69eac7 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java
 71c3a078f5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerUsersyncConfigCalculation.java
 3573748251 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 a6b94f4876 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/SparkShufflePropertyConfig.java
 b1aa6e187a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredRepositoryAction.java
 10d6630698 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java
 864060095b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/YarnConfigCalculation.java
 d6388584f0 


Diff: https://reviews.apache.org/r/62718/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko