Re: Review Request 62805: AMBARI-22155. Intermittent failure of FlumeTimelineMetricsSinkTest

2017-10-06 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62805/#review187319
---


Ship it!




Ship It!

- Oliver Szabo


On Oct. 6, 2017, 8:39 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62805/
> ---
> 
> (Updated Oct. 6, 2017, 8:39 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22155
> https://issues.apache.org/jira/browse/AMBARI-22155
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mock the executor to eliminate nondeterminism caused by threads.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  62779070419894064cb39ea5cc5da012572ff4cb 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6af88ee13f4ba6a3f14ac8c138b72d63c9d 
> 
> 
> Diff: https://reviews.apache.org/r/62805/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -am -pl ambari-metrics/ambari-metrics-flume-sink clean test
> ...
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  6.159 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.036 
> s]
> [INFO] ambari-utility . SUCCESS [  3.880 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.594 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.240 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.697 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62805: AMBARI-22155. Intermittent failure of FlumeTimelineMetricsSinkTest

2017-10-06 Thread Attila Doroszlai 


> On Oct. 6, 2017, 6:45 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
> > Lines 84 (patched)
> > 
> >
> > Missing expectLastCall() ?

Calling a method on the mock sets up the expectation, so `expectLastCall()` is 
only needed if you want to tweak the expectation (eg. return value, call count, 
or exception thrown).

However, it turned out that `PowerMock.verifyAll()` did not verify expectations 
of `executor`, because it is not "maintained" by PowerMock.  This allowed the 
test to pass even with the `stop()` call removed.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62805/#review187278
---


On Oct. 6, 2017, 10:39 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62805/
> ---
> 
> (Updated Oct. 6, 2017, 10:39 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22155
> https://issues.apache.org/jira/browse/AMBARI-22155
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mock the executor to eliminate nondeterminism caused by threads.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  62779070419894064cb39ea5cc5da012572ff4cb 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6af88ee13f4ba6a3f14ac8c138b72d63c9d 
> 
> 
> Diff: https://reviews.apache.org/r/62805/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -am -pl ambari-metrics/ambari-metrics-flume-sink clean test
> ...
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  6.159 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.036 
> s]
> [INFO] ambari-utility . SUCCESS [  3.880 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.594 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.240 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.697 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62805: AMBARI-22155. Intermittent failure of FlumeTimelineMetricsSinkTest

2017-10-06 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62805/
---

(Updated Oct. 6, 2017, 10:39 p.m.)


Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.


Changes
---

make sure executor mock is verified


Bugs: AMBARI-22155
https://issues.apache.org/jira/browse/AMBARI-22155


Repository: ambari


Description
---

Mock the executor to eliminate nondeterminism caused by threads.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
 62779070419894064cb39ea5cc5da012572ff4cb 
  
ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
 bd4ae6af88ee13f4ba6a3f14ac8c138b72d63c9d 


Diff: https://reviews.apache.org/r/62805/diff/2/

Changes: https://reviews.apache.org/r/62805/diff/1-2/


Testing
---

```
$ mvn -am -pl ambari-metrics/ambari-metrics-flume-sink clean test
...
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main  SUCCESS [  6.159 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.036 s]
[INFO] ambari-utility . SUCCESS [  3.880 s]
[INFO] ambari-metrics . SUCCESS [  0.594 s]
[INFO] Ambari Metrics Common .. SUCCESS [  4.240 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.697 s]
[INFO] 
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-06 Thread Attila Doroszlai 


> On Oct. 6, 2017, 9:47 p.m., Nishant Bangarwa wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2782 (patched)
> > 
> >
> > this seems odd, metadata store is not always installed on the same host 
> > as coordinator. 
> > Fwiw, metadata store for druid is not installed/managed by ambari, user 
> > needs to set it up and provide valid hostname and uri.

For explicit `%HOSTGROUP::some_host_group%` the hostname from the given host 
group is substituted, component is ignored.
Component ("DRUID_COORDINATOR") is relevant only if property value contains 
"localhost".


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187297
---


On Oct. 6, 2017, 5:35 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 6, 2017, 5:35 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-06 Thread Nishant Bangarwa 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187297
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2782 (patched)


this seems odd, metadata store is not always installed on the same host as 
coordinator. 
Fwiw, metadata store for druid is not installed/managed by ambari, user 
needs to set it up and provide valid hostname and uri.


- Nishant Bangarwa


On Oct. 6, 2017, 3:35 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 6, 2017, 3:35 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62805: AMBARI-22155. Intermittent failure of FlumeTimelineMetricsSinkTest

2017-10-06 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62805/#review187278
---


Ship it!





ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
Lines 84 (patched)


Missing expectLastCall() ?


- Sid Wagle


On Oct. 6, 2017, 9:47 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62805/
> ---
> 
> (Updated Oct. 6, 2017, 9:47 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22155
> https://issues.apache.org/jira/browse/AMBARI-22155
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mock the executor to eliminate nondeterminism caused by threads.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
>  bd4ae6af88ee13f4ba6a3f14ac8c138b72d63c9d 
> 
> 
> Diff: https://reviews.apache.org/r/62805/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -am -pl ambari-metrics/ambari-metrics-flume-sink clean test
> ...
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
> ...
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main  SUCCESS [  6.159 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.036 
> s]
> [INFO] ambari-utility . SUCCESS [  3.880 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.594 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  4.240 
> s]
> [INFO] Ambari Metrics Flume Sink .. SUCCESS [  4.697 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-06 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/
---

(Updated Oct. 6, 2017, 5:35 p.m.)


Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, and Swapan 
Shridhar.


Bugs: AMBARI-22159
https://issues.apache.org/jira/browse/AMBARI-22159


Repository: ambari


Description
---

Replace placeholders in `metastore_hostname`, 
`druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` when 
creating cluster via blueprint.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 68d6349db0207ab6df44b4b0a341c77ecabc46ea 


Diff: https://reviews.apache.org/r/62809/diff/1/


Testing (updated)
---

Tested manually on local cluster.

Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`


Thanks,

Attila Doroszlai

Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-06 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/
---

Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, and Swapan 
Shridhar.


Bugs: AMBARI-22159
https://issues.apache.org/jira/browse/AMBARI-22159


Repository: ambari


Description
---

Replace placeholders in `metastore_hostname`, 
`druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` when 
creating cluster via blueprint.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 68d6349db0207ab6df44b4b0a341c77ecabc46ea 


Diff: https://reviews.apache.org/r/62809/diff/1/


Testing
---

Tested manually on local cluster.
Unit tests: `BlueprintConfigurationProcessorTest` passed, others pending.


Thanks,

Attila Doroszlai

Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

2017-10-06 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/#review187263
---


Ship it!




Ship It!

- Nate Cole


On Oct. 5, 2017, 11:16 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62794/
> ---
> 
> (Updated Oct. 5, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22139
> https://issues.apache.org/jira/browse/AMBARI-22139
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> CURRENT cluster Shows Upgrade If Component Didn't Report Version
> 
> STR:
> - Install a cluster with 2.6.0.0 and Atlas
> - Atlas is busted in this version and doesn't report it's version
> - This causes the main install stack to be OUT_OF_SYNC which it should never 
> be since it's the only one.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py 75726d686d 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 829868e03a 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 
> 
> 
> Diff: https://reviews.apache.org/r/62794/diff/2/
> 
> 
> Testing
> ---
> 
> Install of a cluster with a broken component and verified that the stack 
> version is CURRENT after all services reported in.
> 
> --
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 55.313 s
> [INFO] Finished at: 2017-10-05T23:15:30-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62807/
---

(Updated Oct. 6, 2017, 5:01 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22158
https://issues.apache.org/jira/browse/AMBARI-22158


Repository: ambari


Description
---

While upgrading ambari from 2.5.1.0 to 2.6.0.0 using oracle database, schema 
upgrade fails with the below exception
{code:None}
05 Oct 2017 08:23:00,312  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE VIEWURL DROP PRIMARY KEY
05 Oct 2017 08:23:00,342 ERROR [main] DBAccessorImpl:880 - Error executing 
query: ALTER TABLE VIEWURL DROP PRIMARY KEY
java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
at 
oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
at 
oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed.
java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
at 
oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
at 
oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:437 - Exception 
occurred during upgrade, failed
org.apache.ambari.server.AmbariException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:203)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
Caused by: java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key 
is

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-06 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/
---

(Updated Oct. 6, 2017, 1:39 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.


Changes
---

.


Bugs: AMBARI-22160
https://issues.apache.org/jira/browse/AMBARI-22160


Repository: ambari


Description (updated)
---

Packages which installed via install_packages used different code to get 
package version than the one used to get versions of packages during start 
(e.g. lzo).
I merged them into a single method.


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
829868e03a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
4ade11a1a2 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py c10ff64e0b 


Diff: https://reviews.apache.org/r/62808/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62807/#review187258
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 6, 2017, 8:37 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62807/
> ---
> 
> (Updated Oct. 6, 2017, 8:37 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22158
> https://issues.apache.org/jira/browse/AMBARI-22158
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While upgrading ambari from 2.5.1.0 to 2.6.0.0 using oracle database, schema 
> upgrade fails with the below exception
> {code:None}
> 05 Oct 2017 08:23:00,312  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE VIEWURL DROP PRIMARY KEY
> 05 Oct 2017 08:23:00,342 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: ALTER TABLE VIEWURL DROP PRIMARY KEY
> java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
> referenced by some foreign keys
> 
> at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
> at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
> at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
> at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
> at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
> at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
> at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
> at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
> at 
> oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
> at 
> oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
> at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
> at 
> oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> 05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:202 - Upgrade 
> failed.
> java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
> referenced by some foreign keys
> 
> at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
> at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
> at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
> at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
> at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
> at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
> at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
> at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
> at 
> oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
> at 
> oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
> at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
> at 
> oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
>

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-06 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/#review187256
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 6, 2017, 12:53 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62808/
> ---
> 
> (Updated Жов. 6, 2017, 12:53 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22160
> https://issues.apache.org/jira/browse/AMBARI-22160
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 829868e03a 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 4ade11a1a2 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py c10ff64e0b 
> 
> 
> Diff: https://reviews.apache.org/r/62808/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-06 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22160
https://issues.apache.org/jira/browse/AMBARI-22160


Repository: ambari


Description
---


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
829868e03a 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
4ade11a1a2 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py c10ff64e0b 


Diff: https://reviews.apache.org/r/62808/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62807/
---

(Updated Oct. 6, 2017, 3:37 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22158
https://issues.apache.org/jira/browse/AMBARI-22158


Repository: ambari


Description
---

While upgrading ambari from 2.5.1.0 to 2.6.0.0 using oracle database, schema 
upgrade fails with the below exception
{code:None}
05 Oct 2017 08:23:00,312  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE VIEWURL DROP PRIMARY KEY
05 Oct 2017 08:23:00,342 ERROR [main] DBAccessorImpl:880 - Error executing 
query: ALTER TABLE VIEWURL DROP PRIMARY KEY
java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
at 
oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
at 
oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed.
java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
at 
oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
at 
oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:437 - Exception 
occurred during upgrade, failed
org.apache.ambari.server.AmbariException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:203)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
Caused by: java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key 
is

Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62807/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22158
https://issues.apache.org/jira/browse/AMBARI-22158


Repository: ambari


Description
---

While upgrading ambari from 2.5.1.0 to 2.6.0.0 using oracle database, schema 
upgrade fails with the below exception
{code:None}
05 Oct 2017 08:23:00,312  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE VIEWURL DROP PRIMARY KEY
05 Oct 2017 08:23:00,342 ERROR [main] DBAccessorImpl:880 - Error executing 
query: ALTER TABLE VIEWURL DROP PRIMARY KEY
java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
at 
oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
at 
oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed.
java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:440)
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:396)
at oracle.jdbc.driver.T4C8Oall.processError(T4C8Oall.java:837)
at oracle.jdbc.driver.T4CTTIfun.receive(T4CTTIfun.java:445)
at oracle.jdbc.driver.T4CTTIfun.doRPC(T4CTTIfun.java:191)
at oracle.jdbc.driver.T4C8Oall.doOALL(T4C8Oall.java:523)
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:193)
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:999)
at 
oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1315)
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1890)
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1855)
at 
oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:304)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1045)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1053)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropPKConstraint(DBAccessorImpl.java:1344)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.addViewUrlPKConstraint(UpgradeCatalog260.java:206)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:196)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
05 Oct 2017 08:23:00,347 ERROR [main] SchemaUpgradeHelper:437 - Exception 
occurred during upgrade, failed
org.apache.ambari.server.AmbariException: ORA-02273: this unique/primary key is 
referenced by some foreign keys

at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:203)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
Caused by: java.sql.SQLSyntaxErrorException: ORA-02273: this unique/primary key 
is referenced by some foreign keys

at

Re: Review Request 62803: On Zeppelin restart sometimes interpreter settings get reset

2017-10-06 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62803/
---

(Updated Oct. 6, 2017, 2:55 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22153
https://issues.apache.org/jira/browse/AMBARI-22153


Repository: ambari


Description
---

On Zeppelin restart sometimes interpreter settings get reset


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 a450fb6882 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
e8ef262ace 


Diff: https://reviews.apache.org/r/62803/diff/2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62803: On Zeppelin restart sometimes interpreter settings get reset

2017-10-06 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62803/
---

(Updated Oct. 6, 2017, 2:54 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: branch-2.6 and trunk
https://issues.apache.org/jira/browse/branch-2.6
https://issues.apache.org/jira/browse/trunk


Repository: ambari


Description
---

On Zeppelin restart sometimes interpreter settings get reset


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 a450fb6882 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
e8ef262ace 


Diff: https://reviews.apache.org/r/62803/diff/2/

Changes: https://reviews.apache.org/r/62803/diff/1-2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

2017-10-06 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62794/#review187241
---


Ship it!





ambari-common/src/main/python/resource_management/libraries/script/script.py
Lines 216 (patched)


instlled


- Dmitro Lisnichenko


On Oct. 6, 2017, 6:16 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62794/
> ---
> 
> (Updated Oct. 6, 2017, 6:16 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22139
> https://issues.apache.org/jira/browse/AMBARI-22139
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> CURRENT cluster Shows Upgrade If Component Didn't Report Version
> 
> STR:
> - Install a cluster with 2.6.0.0 and Atlas
> - Atlas is busted in this version and doesn't report it's version
> - This causes the main install stack to be OUT_OF_SYNC which it should never 
> be since it's the only one.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py 75726d686d 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 829868e03a 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 
> 
> 
> Diff: https://reviews.apache.org/r/62794/diff/2/
> 
> 
> Testing
> ---
> 
> Install of a cluster with a broken component and verified that the stack 
> version is CURRENT after all services reported in.
> 
> --
> Total run:1193
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 55.313 s
> [INFO] Finished at: 2017-10-05T23:15:30-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62803: On Zeppelin restart sometimes interpreter settings get reset

2017-10-06 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62803/#review187239
---


Ship it!




Ship It!

- Gaurav Nagar


On Oct. 6, 2017, 8:47 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62803/
> ---
> 
> (Updated Oct. 6, 2017, 8:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: branch-2.6 and trunk
> https://issues.apache.org/jira/browse/branch-2.6
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Zeppelin restart sometimes interpreter settings get reset
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  a450fb6882 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> e8ef262ace 
> 
> 
> Diff: https://reviews.apache.org/r/62803/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>