Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-09 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187486
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
Lines 149 (patched)


Should we move this around the switch statement in case anymore case's are 
added in the future which should also be skipped?


- Jonathan Hurley


On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62851/
> ---
> 
> (Updated Oct. 9, 2017, 5:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22178
> https://issues.apache.org/jira/browse/AMBARI-22178
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The HostVersionOutOfSyncListener is incorrectly setting ALL other 
> host_version records to OUT_OF_SYNC other than what the newly-added component 
> is for.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
>  78744613ed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
>  076190a47d 
> 
> 
> Diff: https://reviews.apache.org/r/62851/diff/1/
> 
> 
> Testing
> ---
> 
> Manual added host and added new service to verify records.  Unit tests 
> pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62801: AMBARI-21955: Update React version to 15.6.2 to get MIT license

2017-10-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62801/#review187474
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Oct. 6, 2017, 5 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62801/
> ---
> 
> (Updated Oct. 6, 2017, 5 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> Facebook has relicensed React with MIT license in their latest (15.6.2 & 16) 
> versions.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> BSD+Patents license, need to update the version to get MIT license.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>   
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cbd 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3.min.js 2856dd2 
>   contrib/views/storm/src/main/resources/libs/dagre-d3/dagre-d3.min.js 
> b4821d8 
>   contrib/views/storm/src/main/resources/libs/jQuery/js/jquery-2.2.3.min.js 
> b8c4187 
>   contrib/views/storm/src/main/resources/libs/jsx/JSXTransformer.js efc63ff 
>   contrib/views/storm/src/main/resources/libs/jsx/jsx.js 0a72088 
>

Re: Review Request 62801: AMBARI-21955: Update React version to 15.6.2 to get MIT license

2017-10-09 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62801/#review187475
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On Oct. 6, 2017, 5 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62801/
> ---
> 
> (Updated Oct. 6, 2017, 5 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> Facebook has relicensed React with MIT license in their latest (15.6.2 & 16) 
> versions.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> BSD+Patents license, need to update the version to get MIT license.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>   
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>   
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cbd 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3.min.js 2856dd2 
>   contrib/views/storm/src/main/resources/libs/dagre-d3/dagre-d3.min.js 
> b4821d8 
>   contrib/views/storm/src/main/resources/libs/jQuery/js/jquery-2.2.3.min.js 
> b8c4187 
>   contrib/views/storm/src/main/resources/libs/jsx/JSXTransformer.js efc63ff 
>   contrib/views/storm/src/main/resources/libs/jsx/jsx.js 0a72088 
>

Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-22178
https://issues.apache.org/jira/browse/AMBARI-22178


Repository: ambari


Description
---

The HostVersionOutOfSyncListener is incorrectly setting ALL other host_version 
records to OUT_OF_SYNC other than what the newly-added component is for.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
 78744613ed 
  
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
 076190a47d 


Diff: https://reviews.apache.org/r/62851/diff/1/


Testing
---

Manual added host and added new service to verify records.  Unit tests pending.


Thanks,

Nate Cole

Re: Review Request 62848: Not able to perform revert after deleting the upgraded service

2017-10-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62848/#review187444
---


Ship it!




Ship It!

- Nate Cole


On Oct. 9, 2017, 3:06 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62848/
> ---
> 
> (Updated Oct. 9, 2017, 3:06 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22166
> https://issues.apache.org/jira/browse/AMBARI-22166
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After deleting a service, you can't revert a PATCH or MAINT upgrade. This is 
> because we iterate over all prior services when creating the upgrade context 
> for the reversion.
> 
> STR:
> - Install ZK, HDFS, and Storm
> - Upgrade ZK and Storm using a PATCH or MAINT VDF
> - Remove Storm
> - Revert the prior patch
> 
> ```
> 09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] 
> AbstractResourceProvider:285 - Caught AmbariException when creating a resource
> org.apache.ambari.server.ServiceNotFoundException: Service not found, 
> clusterName=cl1, serviceName=ATLAS
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863)
>   at 
> org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403)
>   at 
> org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance()
>   at 
> com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
>   at 
> com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60)
>   at 
> com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
>   at 
> com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
>   at 
> com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
>   at 
> com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024)
>   at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
>   at 
> com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
>   at com.sun.proxy.$Proxy31.create(Unknown Source)
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  9f31ab8a62 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
>  5cf9a4c859 
> 
> 
> Diff: https://reviews.apache.org/r/62848/diff/2/
> 
> 
> Testing
> ---
> 
> Manual reversion of a PATCH after removing a service.
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62848: Not able to perform revert after deleting the upgraded service

2017-10-09 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62848/
---

(Updated Oct. 9, 2017, 3:06 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22166
https://issues.apache.org/jira/browse/AMBARI-22166


Repository: ambari


Description
---

After deleting a service, you can't revert a PATCH or MAINT upgrade. This is 
because we iterate over all prior services when creating the upgrade context 
for the reversion.

STR:
- Install ZK, HDFS, and Storm
- Upgrade ZK and Storm using a PATCH or MAINT VDF
- Remove Storm
- Revert the prior patch

```
09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] 
AbstractResourceProvider:285 - Caught AmbariException when creating a resource
org.apache.ambari.server.ServiceNotFoundException: Service not found, 
clusterName=cl1, serviceName=ATLAS
at 
org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863)
at 
org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403)
at 
org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance()
at 
com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
at 
com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60)
at 
com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
at 
com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
at 
com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
at 
com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024)
at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
at 
com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
at com.sun.proxy.$Proxy31.create(Unknown Source)
```


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
9f31ab8a62 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java
 5cf9a4c859 


Diff: https://reviews.apache.org/r/62848/diff/2/

Changes: https://reviews.apache.org/r/62848/diff/1-2/


Testing (updated)
---

Manual reversion of a PATCH after removing a service.

[INFO] Results:
[INFO]
[WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34


Thanks,

Jonathan Hurley

Review Request 62848: Not able to perform revert after deleting the upgraded service

2017-10-09 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62848/
---

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22166
https://issues.apache.org/jira/browse/AMBARI-22166


Repository: ambari


Description
---

After deleting a service, you can't revert a PATCH or MAINT upgrade. This is 
because we iterate over all prior services when creating the upgrade context 
for the reversion.

STR:
- Install ZK, HDFS, and Storm
- Upgrade ZK and Storm using a PATCH or MAINT VDF
- Remove Storm
- Revert the prior patch

```
09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] 
AbstractResourceProvider:285 - Caught AmbariException when creating a resource
org.apache.ambari.server.ServiceNotFoundException: Service not found, 
clusterName=cl1, serviceName=ATLAS
at 
org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863)
at 
org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403)
at 
org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance()
at 
com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40)
at 
com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60)
at 
com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
at 
com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
at 
com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
at 
com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024)
at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
at 
com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
at com.sun.proxy.$Proxy31.create(Unknown Source)
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 
9f31ab8a62 


Diff: https://reviews.apache.org/r/62848/diff/1/


Testing
---

Manual reversion of a PATCH after removing a service.

Unit Tests Pending...


Thanks,

Jonathan Hurley

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Attila Doroszlai 


> On Oct. 9, 2017, 4:23 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Line 1374 (original), 1420 (patched)
> > 
> >
> > Can you do the same for `MultipleHostTopologyUpdater` and other 
> > updaters which currently process hostgroup plcaeholders?

`MultipleHostTopologyUpdater` has much more complex logic for hostgroups, which 
I'd rather not change now.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187412
---


On Oct. 9, 2017, 2:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab

2017-10-09 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62676/#review187419
---


Ship it!




Ship It!

- venkat sairam


On Oct. 9, 2017, 3:42 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62676/
> ---
> 
> (Updated Oct. 9, 2017, 3:42 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-22089
> https://issues.apache.org/jira/browse/AMBARI-22089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Updating the same worksheet rather creating new one.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java
>  3690683 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryService.java
>  7139ce8 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 9e8b6db 
>   contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
> 4b4b29e 
>   contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c 
> 
> 
> Diff: https://reviews.apache.org/r/62676/diff/2/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab

2017-10-09 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62676/
---

(Updated Oct. 9, 2017, 3:42 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
venkat sairam.


Bugs: AMBARI-22089
https://issues.apache.org/jira/browse/AMBARI-22089


Repository: ambari


Description
---

- Updating the same worksheet rather creating new one.


Diffs (updated)
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java
 3690683 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryService.java
 7139ce8 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
9e8b6db 
  contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
4b4b29e 
  contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c 


Diff: https://reviews.apache.org/r/62676/diff/2/

Changes: https://reviews.apache.org/r/62676/diff/1-2/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187418
---


Ship it!




Overall, the patch looks fine to me, just a comment below about making sure 
this is tested thoroughly, since this patch does introduce a slight change to 
the Blueprints model for updater registration.  

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2812 (patched)


Generally, the model here is to create a new property updater for each 
property.

Off the top of my head, it seems fine to use a singleton for the property 
updater, but please make sure this change is tested thoroughly, since there 
might be un-intended consequences of changing the way these updaters are 
registered.


- Robert Nettleton


On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Robert Nettleton 


> On Oct. 7, 2017, noon, Oliver Szabo wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2783 (patched)
> > 
> >
> > can these variables calculated at params.py in the stack code instead 
> > of putting to the BlueprintConfigurationProcessor? (using jinja2 variables 
> > at configurations - you can get the proper hosts from command.json input). 
> > just because the ambari server java code could be independent from druid. 
> > im not too big fan of this class, we should get rid of it sooner or later
> > 
> > but you can drop this issue if zou do not want to do it, it's just a 
> > reccomendation from me.
> 
> Attila Doroszlai wrote:
> I agree that this class stinks.  However, currently no `%HOSTGROUP::...%` 
> substitution occurs in Python code.  I guess it shouldn't be introduced at 
> this point before 2.6 release.
> 
> Oliver Szabo wrote:
> no need for %HOSTGROUP::.. substitution. It can be a jinja variable like 
> {{ metadata_connector_connect_uri }}.
> like for logsearch and ambari infra solr, there are some refrerences for 
> zookeeper but you cannot find that in the BlueprintConfigurationProcessor 
> class

Hi Oliver, 

I don't think the python substitution you mentioned will totally work.  

While the substitution might work on the agent side, I've seen cases where this 
type of substitution won't show up properly on the UI, meaning that the UI will 
show the jinja variable tokens in the config properties, which is not the 
correct behavior.

I agree that the BlueprintConfigurationProcessor should eventually be removed, 
but the problem is that the stack metadata doesn't hold enough information yet 
about topology data to allow this class to be refactored or removed just yet. 

Thanks, 
Bob


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187335
---


On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62828: When regenerating keytab files for a service, non-service-specific principals are affected

2017-10-09 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62828/#review187415
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 8, 2017, 1:36 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62828/
> ---
> 
> (Updated Oct. 8, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22138
> https://issues.apache.org/jira/browse/AMBARI-22138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When regenerating keytab files for a service, non-service-specific principals 
> are affected. For example, when regenerating the keytab files for HDFS using 
> the following ReST API call:
> 
> ```
> PUT /api/v1/clusters/c1?regenerate_keytabs=all_components=HDFS
> {
>   "Clusters": {
> "security_type": "KERBEROS"
>   }
> }
> ```
> 
> The following principals are affected:
> - HTTP/c6402.ambari.apache@example.com
> - ambari-qa...@example.com
> - nn/c6402.ambari.apache@example.com
> - hdfs...@example.com
> - HTTP/c6403.ambari.apache@example.com
> - dn/c6403.ambari.apache@example.com
> - HTTP/c6401.ambari.apache@example.com
> - nn/c6401.ambari.apache@example.com
> - ambari-server...@example.com
> 
> However only the following principals *should be*  affected:
> - nn/c6402.ambari.apache@example.com
> - hdfs...@example.com
> - dn/c6403.ambari.apache@example.com
> - nn/c6401.ambari.apache@example.com
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  20c5708467 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  b691968919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RemovableIdentities.java
>  66bf7b3cd3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  4396a2ba7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  069c821f0e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  c86ffa36b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  f56e9464e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  3ec84fa681 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  49828cb462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  b4969420d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  9ddb9417db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  ef45343dbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  60d7fd9677 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java
>  663934fd3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  d6bef022cd 
> 
> 
> Diff: https://reviews.apache.org/r/62828/diff/1/
> 
> 
> Testing
> ---
> 
> manual tesing
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:02 min
> [INFO] Finished at: 2017-10-07T12:09:47-04:00
> [INFO] Final Memory: 108M/1995M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62828: When regenerating keytab files for a service, non-service-specific principals are affected

2017-10-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62828/#review187414
---


Ship it!




Ship It!

- Nate Cole


On Oct. 8, 2017, 7:36 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62828/
> ---
> 
> (Updated Oct. 8, 2017, 7:36 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22138
> https://issues.apache.org/jira/browse/AMBARI-22138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When regenerating keytab files for a service, non-service-specific principals 
> are affected. For example, when regenerating the keytab files for HDFS using 
> the following ReST API call:
> 
> ```
> PUT /api/v1/clusters/c1?regenerate_keytabs=all_components=HDFS
> {
>   "Clusters": {
> "security_type": "KERBEROS"
>   }
> }
> ```
> 
> The following principals are affected:
> - HTTP/c6402.ambari.apache@example.com
> - ambari-qa...@example.com
> - nn/c6402.ambari.apache@example.com
> - hdfs...@example.com
> - HTTP/c6403.ambari.apache@example.com
> - dn/c6403.ambari.apache@example.com
> - HTTP/c6401.ambari.apache@example.com
> - nn/c6401.ambari.apache@example.com
> - ambari-server...@example.com
> 
> However only the following principals *should be*  affected:
> - nn/c6402.ambari.apache@example.com
> - hdfs...@example.com
> - dn/c6403.ambari.apache@example.com
> - nn/c6401.ambari.apache@example.com
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  20c5708467 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  b691968919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RemovableIdentities.java
>  66bf7b3cd3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  4396a2ba7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  069c821f0e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  c86ffa36b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  f56e9464e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  3ec84fa681 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  49828cb462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  b4969420d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  9ddb9417db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  ef45343dbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  60d7fd9677 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java
>  663934fd3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  d6bef022cd 
> 
> 
> Diff: https://reviews.apache.org/r/62828/diff/1/
> 
> 
> Testing
> ---
> 
> manual tesing
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:02 min
> [INFO] Finished at: 2017-10-07T12:09:47-04:00
> [INFO] Final Memory: 108M/1995M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187412
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Line 1374 (original), 1420 (patched)


Can you do the same for `MultipleHostTopologyUpdater` and other updaters 
which currently process hostgroup plcaeholders?


- Sebastian Toader


On Oct. 9, 2017, 2:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Nishant Bangarwa 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187410
---


Ship it!




Ship It!

- Nishant Bangarwa


On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62828: When regenerating keytab files for a service, non-service-specific principals are affected

2017-10-09 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62828/#review187409
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 8, 2017, 7:36 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62828/
> ---
> 
> (Updated Oct. 8, 2017, 7:36 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22138
> https://issues.apache.org/jira/browse/AMBARI-22138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When regenerating keytab files for a service, non-service-specific principals 
> are affected. For example, when regenerating the keytab files for HDFS using 
> the following ReST API call:
> 
> ```
> PUT /api/v1/clusters/c1?regenerate_keytabs=all_components=HDFS
> {
>   "Clusters": {
> "security_type": "KERBEROS"
>   }
> }
> ```
> 
> The following principals are affected:
> - HTTP/c6402.ambari.apache@example.com
> - ambari-qa...@example.com
> - nn/c6402.ambari.apache@example.com
> - hdfs...@example.com
> - HTTP/c6403.ambari.apache@example.com
> - dn/c6403.ambari.apache@example.com
> - HTTP/c6401.ambari.apache@example.com
> - nn/c6401.ambari.apache@example.com
> - ambari-server...@example.com
> 
> However only the following principals *should be*  affected:
> - nn/c6402.ambari.apache@example.com
> - hdfs...@example.com
> - dn/c6403.ambari.apache@example.com
> - nn/c6401.ambari.apache@example.com
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  20c5708467 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  b691968919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RemovableIdentities.java
>  66bf7b3cd3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  4396a2ba7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  069c821f0e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  c86ffa36b1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  f56e9464e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  3ec84fa681 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  49828cb462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  b4969420d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  9ddb9417db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  ef45343dbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  60d7fd9677 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java
>  663934fd3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  d6bef022cd 
> 
> 
> Diff: https://reviews.apache.org/r/62828/diff/1/
> 
> 
> Testing
> ---
> 
> manual tesing
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:02 min
> [INFO] Finished at: 2017-10-07T12:09:47-04:00
> [INFO] Final Memory: 108M/1995M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-09 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62808/#review187402
---


Ship it!




Ship It!

- Nate Cole


On Oct. 6, 2017, 9:39 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62808/
> ---
> 
> (Updated Oct. 6, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22160
> https://issues.apache.org/jira/browse/AMBARI-22160
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Packages which installed via install_packages used different code to get 
> package version than the one used to get versions of packages during start 
> (e.g. lzo).
> I merged them into a single method.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 8f9cf5cd4d 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 
> 370b776914 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 665fc202c5 
> 
> 
> Diff: https://reviews.apache.org/r/62808/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/
---

(Updated Oct. 9, 2017, 2:43 p.m.)


Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
Swapan Shridhar, and Sebastian Toader.


Changes
---

extracted property updater that only replaces `%HOSTGROUP::name%` placeholders


Bugs: AMBARI-22159
https://issues.apache.org/jira/browse/AMBARI-22159


Repository: ambari


Description
---

Replace placeholders in `metastore_hostname`, 
`druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` when 
creating cluster via blueprint.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 68d6349db0207ab6df44b4b0a341c77ecabc46ea 


Diff: https://reviews.apache.org/r/62809/diff/2/

Changes: https://reviews.apache.org/r/62809/diff/1-2/


Testing
---

Tested manually on local cluster.

Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`


Thanks,

Attila Doroszlai

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187400
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 9, 2017, 9:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 9:16 a.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Attila Doroszlai 


> On Oct. 9, 2017, 11:41 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2782 (patched)
> > 
> >
> > Maybe we should introduce a property updater that handles only 
> > `%HOSTGROUP::name%` constructs.

Good idea.


> On Oct. 9, 2017, 11:41 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2784 (patched)
> > 
> >
> > Why property updater for `druid.zk.service.host` is not needed any more?

I don't understand the question.  The updater is being added by the patch, not 
removed.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187393
---


On Oct. 9, 2017, 9:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 9:16 a.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187393
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2782 (patched)


Maybe we should introduce a property updater that handles only 
`%HOSTGROUP::name%` constructs.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2783 (patched)


Maybe we should introduce a new property updater for this property that 
handles only `%HOSTGROUP::name%` constructs.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2784 (patched)


Why property updater for `druid.zk.service.host` is not needed any more?


- Sebastian Toader


On Oct. 9, 2017, 9:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 9:16 a.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62803: On Zeppelin restart sometimes interpreter settings get reset

2017-10-09 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62803/
---

(Updated Oct. 9, 2017, noon)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22153
https://issues.apache.org/jira/browse/AMBARI-22153


Repository: ambari


Description
---

On Zeppelin restart sometimes interpreter settings get reset


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 a450fb6882 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
e8ef262ace 


Diff: https://reviews.apache.org/r/62803/diff/2/


Testing
---

Manually


File Attachments (updated)


AMBARI-22153_branch-2.6_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/09/018aa099-d612-4132-b3cc-1970f4d3e586__AMBARI-22153_branch-2.6_v1.patch


Thanks,

Prabhjyot Singh

Re: Review Request 62803: On Zeppelin restart sometimes interpreter settings get reset

2017-10-09 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62803/#review187388
---


Ship it!




Ship It!

- venkat sairam


On Oct. 6, 2017, 9:25 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62803/
> ---
> 
> (Updated Oct. 6, 2017, 9:25 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22153
> https://issues.apache.org/jira/browse/AMBARI-22153
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Zeppelin restart sometimes interpreter settings get reset
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  a450fb6882 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> e8ef262ace 
> 
> 
> Diff: https://reviews.apache.org/r/62803/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>