Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-12-01 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/#review192606
---


Ship it!




Ship It!

- Yusaku Sako


On Dec. 1, 2017, 11:16 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63847/
> ---
> 
> (Updated Dec. 1, 2017, 11:16 p.m.)
> 
> 
> Review request for Ambari, Ishan Bhatt, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22445
> https://issues.apache.org/jira/browse/AMBARI-22445
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The mysql connector license is not compatible with Ambari's license and 
> Ambari no longer auto installs mysql-connector after AMBARI-22369. Warn the 
> user appropriately to install and setup mysql-connector to be used by Hive.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/data/HDP2/site_properties.js 6c2d5e1 
>   ambari-web/app/data/db_properties_info.js 6d93c2a 
>   ambari-web/app/messages.js 783baf1 
>   ambari-web/app/views/common/controls_view.js 74c1e6e 
>   ambari-web/test/views/common/controls_view_test.js 2d18396 
> 
> 
> Diff: https://reviews.apache.org/r/63847/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Ambari-web unit tests pass
>   30518 passing (27s)
>   157 pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-12-01 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/
---

(Updated Dec. 1, 2017, 11:16 p.m.)


Review request for Ambari, Ishan Bhatt, Jaimin Jetly, and Yusaku Sako.


Changes
---

Updated the warning message to contain the link to download JDBC driver and 
removed SQLAnywhere database option since it is no longer supported.


Bugs: AMBARI-22445
https://issues.apache.org/jira/browse/AMBARI-22445


Repository: ambari


Description
---

The mysql connector license is not compatible with Ambari's license and Ambari 
no longer auto installs mysql-connector after AMBARI-22369. Warn the user 
appropriately to install and setup mysql-connector to be used by Hive.


Diffs (updated)
-

  ambari-web/app/data/HDP2/site_properties.js 6c2d5e1 
  ambari-web/app/data/db_properties_info.js 6d93c2a 
  ambari-web/app/messages.js 783baf1 
  ambari-web/app/views/common/controls_view.js 74c1e6e 
  ambari-web/test/views/common/controls_view_test.js 2d18396 


Diff: https://reviews.apache.org/r/63847/diff/3/

Changes: https://reviews.apache.org/r/63847/diff/2-3/


Testing
---

Manually tested.
Ambari-web unit tests pass
  30518 passing (27s)
  157 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 64261: Update LDAP Authentication process to work with improved user management facility

2017-12-01 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/
---

(Updated Dec. 1, 2017, 4:53 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.


Changes
---

Regenerated index.md.


Bugs: AMBARI-21219
https://issues.apache.org/jira/browse/AMBARI-21219


Repository: ambari


Description
---

Update LDAP Authentication process to work with improved user management 
facility


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 514e9edcc3 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 8904199cfd 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
 f1e1881cea 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
0e28e50709 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 0e5c913baa 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java
 bf30b83dd1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 a6f4387398 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java
 a4a95165e1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 ebe26a237d 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 fdc4a2f1c3 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java
 64ec2019f6 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
 d465c019f7 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
 1aafaa1889 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
 cad734c682 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 e99bdfd5c6 


Diff: https://reviews.apache.org/r/64261/diff/2/

Changes: https://reviews.apache.org/r/64261/diff/1-2/


Testing
---

Manually tested against OpenLDAP and Active Directory

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 30:23 min
[INFO] Finished at: 2017-12-01T16:35:50-05:00
[INFO] Final Memory: 99M/2005M
[INFO] 
```

# Jenkins test results: PENDING


Thanks,

Robert Levas

Review Request 64261: Update LDAP Authentication process to work with improved user management facility

2017-12-01 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64261/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.


Bugs: AMBARI-21219
https://issues.apache.org/jira/browse/AMBARI-21219


Repository: ambari


Description
---

Update LDAP Authentication process to work with improved user management 
facility


Diffs
-

  ambari-server/docs/configuration/index.md 514e9edcc3 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 8904199cfd 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
 f1e1881cea 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 
0e28e50709 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 0e5c913baa 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthentication.java
 bf30b83dd1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 a6f4387398 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java
 a4a95165e1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 ebe26a237d 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 fdc4a2f1c3 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthenticationTest.java
 64ec2019f6 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
 d465c019f7 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
 1aafaa1889 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
 cad734c682 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 e99bdfd5c6 


Diff: https://reviews.apache.org/r/64261/diff/1/


Testing
---

Manually tested against OpenLDAP and Active Directory

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 30:23 min
[INFO] Finished at: 2017-12-01T16:35:50-05:00
[INFO] Final Memory: 99M/2005M
[INFO] 
```

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Sid Wagle 


> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote:
> > This is making the agent-side do the logic.  Shouldn't we check these 
> > things and not include GPL repos in the command to the agent?
> 
> Sid Wagle wrote:
> We would still need to make sure existing hosts get the changes if user 
> denies license during setup and then accepts it. Present behavior is that we 
> do not update the repo for existing hosts. Thereby, I was ok with limiting 
> the changes to the agent vs server and agent.
> 
> Nate Cole wrote:
> The command repository is being sent down and processed on every command.
> 
> Sid Wagle wrote:
> Fair enough, also what about accept and then deny. Ambari should reflect 
> presence or absence of the repo info based on the flag. Do you think doing 
> this on the server would be cleaner? IMO, this is pretty custom repo handling 
> in any case, we do not have a repo-tag -> license-tag mapping anywhere so 
> wouldn't it be equally ugly?
> 
> Sid Wagle wrote:
> By license-tag I meant some lookup to figure out whether license was 
> accepted.
> 
> Andrew Onischuk wrote:
> IMO this looks pretty much the same whether the check is on server or 
> agent. However it may take some time while I re-implement this to server if 
> that's the approach you prefer. @Sid @Nate If you decide we need this, we can 
> create re-factoring jira (not for 2.6.1) and do this.
> 
> Nate Cole wrote:
> The whole point of CommandRepository was to send down to the agent ONLY 
> what is necessary to create the repo.  Spreading logic around makes it 
> difficult to troubleshoot.  It should either ALL be in java or ALL be in 
> python.

@Andrew: NAte has avalid point I think we should address this in trunk to 
handled completely on the server side. Would you be able to open an Apache Jira 
for tracking this? Thanks.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64209/#review192365
---


On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64209/
> ---
> 
> (Updated Nov. 30, 2017, 1:28 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate 
> Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22561
> https://issues.apache.org/jira/browse/AMBARI-22561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * User denies the GPL license agreement, UI will still issue PUT call to 
> create the repo
>   * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo 
> because it will break yum in local repo world.
>   * Then the user accepts the license by running ambari-server setup
>   * The repo file does not get updated on existing hosts
>   * We need to push the HDP-GPL repo to the repo files on existing hosts only 
> when the license is accepted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
>  68ee607b9b 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1c8ef1b04 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> ccb8a547f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  e207ac5289 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> b819dcad96 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  82e57aa4f4 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe 
> 
> 
> Diff: https://reviews.apache.org/r/64209/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Jason Golieb 


> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote:
> > ambari-web/app/routes/installer.js
> > Lines 291 (patched)
> > 
> >
> > Could you elaborate on your problem, cause Ember upgrade requires a 
> > huge change in the codebase and not feasible in near future?
> 
> Jason Golieb wrote:
> OK, first let me say that I spent several hours trying to avoid this 
> workaround and I was surprised that something that should be simple was not. 
> The scenario is that I need to have a text field with its value bound to a 
> field on the controller. I also need to have a change event handler attached 
> to the field that **only responds to UI changes**, which is how a normal DOM 
> event handler would work. There are two options that I have seen for 
> implementing a text field in this code base:
> 
> 1. Use a regular `` tag. With this version, I was able to add the 
> event handler using `{{action}}`. However, and this is the really strange 
> part, I was unable to get the value to bind to the controller. I tried a 
> couple variations of `{{bindAttr value="..."}}` but it did not work. 
> 
> 2. Use `{{view Em.TextField}}`. This has no problem binding the value. 
> However, it does not support adding an event handler to the change event. 
> (Later versions of Ember seem to support this.)
> 
> My solution was to go with #2, and then create an observer of the bound 
> value on the controller to perform the change event handling. However, as 
> this is observing the controller directly, it reacts to ALL changes to the 
> controller value, not just those coming from the UI. That means it gets fired 
> on the initialization of the value from the database as well, which is not 
> desirable. Therefore, I had to add a Boolean flag to temporarily prevent the 
> observer from doing anything during the initial load of the screen.
> 
> I do not expect us to upgrade Ember any time soon, but I wanted to leave 
> the comment in the code for future understanding.
> 
> Andrii Tkach wrote:
> I think that's what you need:
> {{view Em.TextField changeBinding="yourFunc"}}
> Or you can just validate value so after controller initialization it will 
> be rejected and after user input will be applied.

I thought I had tried changeBinding before, but I tried it again and it worked. 
Thanks! I've updated the patch.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/#review192466
---


On Dec. 1, 2017, 4:28 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64225/
> ---
> 
> (Updated Dec. 1, 2017, 4:28 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, 
> Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22569
> https://issues.apache.org/jira/browse/AMBARI-22569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the Local Repo radio button. 
> Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
> Implemented the "Use Proxy" checkbox and related proxy settings fields.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
>  PRE-CREATION 
>   ambari-web/app/assets/test/tests.js b60e17a3e2 
>   ambari-web/app/controllers/wizard/configureDownload_controller.js 
> 0246ad0602 
>   ambari-web/app/messages.js e014d4a012 
>   ambari-web/app/routes/installer.js 73c716b7a9 
>   ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c 
>   ambari-web/app/utils.js 509efc15fa 
>   ambari-web/app/utils/constants.js PRE-CREATION 
>   ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c 
>   ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION 
>   ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64225/diff/2/
> 
> 
> Testing
> ---
> 
> 20297 passing (21s)
>   125 pending
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Jason Golieb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/
---

(Updated Dec. 1, 2017, 4:28 p.m.)


Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, 
Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.


Changes
---

Removed change handler hack and used changeBinding instead.


Bugs: AMBARI-22569
https://issues.apache.org/jira/browse/AMBARI-22569


Repository: ambari


Description
---

Enabled the Local Repo radio button. 
Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
Implemented the "Use Proxy" checkbox and related proxy settings fields.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
 PRE-CREATION 
  ambari-web/app/assets/test/tests.js b60e17a3e2 
  ambari-web/app/controllers/wizard/configureDownload_controller.js 0246ad0602 
  ambari-web/app/messages.js e014d4a012 
  ambari-web/app/routes/installer.js 73c716b7a9 
  ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c 
  ambari-web/app/utils.js 509efc15fa 
  ambari-web/app/utils/constants.js PRE-CREATION 
  ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c 
  ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION 
  ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION 


Diff: https://reviews.apache.org/r/64225/diff/2/

Changes: https://reviews.apache.org/r/64225/diff/1-2/


Testing
---

20297 passing (21s)
  125 pending


Thanks,

Jason Golieb

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Andrii Tkach 


> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote:
> > ambari-web/app/routes/installer.js
> > Lines 291 (patched)
> > 
> >
> > Could you elaborate on your problem, cause Ember upgrade requires a 
> > huge change in the codebase and not feasible in near future?
> 
> Jason Golieb wrote:
> OK, first let me say that I spent several hours trying to avoid this 
> workaround and I was surprised that something that should be simple was not. 
> The scenario is that I need to have a text field with its value bound to a 
> field on the controller. I also need to have a change event handler attached 
> to the field that **only responds to UI changes**, which is how a normal DOM 
> event handler would work. There are two options that I have seen for 
> implementing a text field in this code base:
> 
> 1. Use a regular `` tag. With this version, I was able to add the 
> event handler using `{{action}}`. However, and this is the really strange 
> part, I was unable to get the value to bind to the controller. I tried a 
> couple variations of `{{bindAttr value="..."}}` but it did not work. 
> 
> 2. Use `{{view Em.TextField}}`. This has no problem binding the value. 
> However, it does not support adding an event handler to the change event. 
> (Later versions of Ember seem to support this.)
> 
> My solution was to go with #2, and then create an observer of the bound 
> value on the controller to perform the change event handling. However, as 
> this is observing the controller directly, it reacts to ALL changes to the 
> controller value, not just those coming from the UI. That means it gets fired 
> on the initialization of the value from the database as well, which is not 
> desirable. Therefore, I had to add a Boolean flag to temporarily prevent the 
> observer from doing anything during the initial load of the screen.
> 
> I do not expect us to upgrade Ember any time soon, but I wanted to leave 
> the comment in the code for future understanding.

I think that's what you need:
{{view Em.TextField changeBinding="yourFunc"}}
Or you can just validate value so after controller initialization it will be 
rejected and after user input will be applied.


- Andrii


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/#review192466
---


On Nov. 30, 2017, 9:01 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64225/
> ---
> 
> (Updated Nov. 30, 2017, 9:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, 
> Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22569
> https://issues.apache.org/jira/browse/AMBARI-22569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the Local Repo radio button. 
> Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
> Implemented the "Use Proxy" checkbox and related proxy settings fields.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
>  PRE-CREATION 
>   ambari-web/app/assets/test/tests.js b60e17a3e2 
>   ambari-web/app/controllers/wizard/configureDownload_controller.js 
> 0246ad0602 
>   ambari-web/app/messages.js e014d4a012 
>   ambari-web/app/routes/installer.js 73c716b7a9 
>   ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c 
>   ambari-web/app/utils.js 509efc15fa 
>   ambari-web/app/utils/constants.js PRE-CREATION 
>   ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c 
>   ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION 
>   ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64225/diff/1/
> 
> 
> Testing
> ---
> 
> 20297 passing (21s)
>   125 pending
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Jason Golieb 


> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote:
> > ambari-web/app/routes/installer.js
> > Lines 291 (patched)
> > 
> >
> > Could you elaborate on your problem, cause Ember upgrade requires a 
> > huge change in the codebase and not feasible in near future?

OK, first let me say that I spent several hours trying to avoid this workaround 
and I was surprised that something that should be simple was not. The scenario 
is that I need to have a text field with its value bound to a field on the 
controller. I also need to have a change event handler attached to the field 
that **only responds to UI changes**, which is how a normal DOM event handler 
would work. There are two options that I have seen for implementing a text 
field in this code base:

1. Use a regular `` tag. With this version, I was able to add the event 
handler using `{{action}}`. However, and this is the really strange part, I was 
unable to get the value to bind to the controller. I tried a couple variations 
of `{{bindAttr value="..."}}` but it did not work. 

2. Use `{{view Em.TextField}}`. This has no problem binding the value. However, 
it does not support adding an event handler to the change event. (Later 
versions of Ember seem to support this.)

My solution was to go with #2, and then create an observer of the bound value 
on the controller to perform the change event handling. However, as this is 
observing the controller directly, it reacts to ALL changes to the controller 
value, not just those coming from the UI. That means it gets fired on the 
initialization of the value from the database as well, which is not desirable. 
Therefore, I had to add a Boolean flag to temporarily prevent the observer from 
doing anything during the initial load of the screen.

I do not expect us to upgrade Ember any time soon, but I wanted to leave the 
comment in the code for future understanding.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/#review192466
---


On Nov. 30, 2017, 9:01 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64225/
> ---
> 
> (Updated Nov. 30, 2017, 9:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, 
> Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22569
> https://issues.apache.org/jira/browse/AMBARI-22569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the Local Repo radio button. 
> Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
> Implemented the "Use Proxy" checkbox and related proxy settings fields.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
>  PRE-CREATION 
>   ambari-web/app/assets/test/tests.js b60e17a3e2 
>   ambari-web/app/controllers/wizard/configureDownload_controller.js 
> 0246ad0602 
>   ambari-web/app/messages.js e014d4a012 
>   ambari-web/app/routes/installer.js 73c716b7a9 
>   ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c 
>   ambari-web/app/utils.js 509efc15fa 
>   ambari-web/app/utils/constants.js PRE-CREATION 
>   ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c 
>   ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION 
>   ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64225/diff/1/
> 
> 
> Testing
> ---
> 
> 20297 passing (21s)
>   125 pending
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192480
---


Ship it!




Ship It!

- Robert Levas


On Dec. 1, 2017, 5:09 a.m., Sandor Molnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> ---
> 
> (Updated Dec. 1, 2017, 5:09 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
> 
> 
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove hack to set KDC admin credential via the API to set session attribute 
> via the Cluster resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  da206c6ccf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  d1f235f885 
> 
> 
> Diff: https://reviews.apache.org/r/64215/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on vagrant cluster
> 
> 
> Thanks,
> 
> Sandor Molnar
> 
>

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Andrew Onischuk 


> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote:
> > This is making the agent-side do the logic.  Shouldn't we check these 
> > things and not include GPL repos in the command to the agent?
> 
> Sid Wagle wrote:
> We would still need to make sure existing hosts get the changes if user 
> denies license during setup and then accepts it. Present behavior is that we 
> do not update the repo for existing hosts. Thereby, I was ok with limiting 
> the changes to the agent vs server and agent.
> 
> Nate Cole wrote:
> The command repository is being sent down and processed on every command.
> 
> Sid Wagle wrote:
> Fair enough, also what about accept and then deny. Ambari should reflect 
> presence or absence of the repo info based on the flag. Do you think doing 
> this on the server would be cleaner? IMO, this is pretty custom repo handling 
> in any case, we do not have a repo-tag -> license-tag mapping anywhere so 
> wouldn't it be equally ugly?
> 
> Sid Wagle wrote:
> By license-tag I meant some lookup to figure out whether license was 
> accepted.

IMO this looks pretty much the same whether the check is on server or agent. 
However it may take some time while I re-implement this to server if that's the 
approach you prefer. @Sid @Nate If you decide we need this, we can create 
re-factoring jira (not for 2.6.1) and do this.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64209/#review192365
---


On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64209/
> ---
> 
> (Updated Nov. 30, 2017, 1:28 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate 
> Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22561
> https://issues.apache.org/jira/browse/AMBARI-22561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * User denies the GPL license agreement, UI will still issue PUT call to 
> create the repo
>   * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo 
> because it will break yum in local repo world.
>   * Then the user accepts the license by running ambari-server setup
>   * The repo file does not get updated on existing hosts
>   * We need to push the HDP-GPL repo to the repo files on existing hosts only 
> when the license is accepted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
>  68ee607b9b 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1c8ef1b04 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> ccb8a547f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  e207ac5289 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> b819dcad96 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  82e57aa4f4 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe 
> 
> 
> Diff: https://reviews.apache.org/r/64209/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-12-01 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192471
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 30, 2017, 11:18 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64223/
> ---
> 
> (Updated Nov. 30, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22568
> https://issues.apache.org/jira/browse/AMBARI-22568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Deployed cluster with Ambari version: 2.6.1.0-65 and HDP version: 
> 2.6.3.0-215
> 2) Express upgrade to target version 2.6.4.0-52
> 
> Oozie Server Restart fails with below error:
> 
> ```
> Traceback (most recent call last):
> ...
>   File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 123, in pre_upgrade_restart
> OozieUpgrade.prepare_libext_directory(upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py",
>  line 113, in prepare_libext_directory
> raise Fail("Unable to find any Oozie source extension files from the 
> following paths {0}".format(source_ext_zip_paths))
> resource_management.core.exceptions.Fail: Unable to find any Oozie source 
> extension files from the following paths ['/usr/share/HDP-oozie/ext-2.2.zip', 
> '/var/lib/oozie/ext-2.2.zip']
> ```
> 
> This is because we have removed the requirement of having ExtJS in the 
> cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  b81186144c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  eb57c22834 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  2109a5d5e9 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 4d94723bbf 
> 
> 
> Diff: https://reviews.apache.org/r/64223/diff/2/
> 
> 
> Testing
> ---
> 
> Upgraded Oozie
> 
> --
> Total run:1196
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.251 s
> [INFO] Finished at: 2017-11-30T15:16:50-05:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Andrew Onischuk 


> On Nov. 30, 2017, 7:12 p.m., Sid Wagle wrote:
> > Can you provide some notes on the manual testing effort on this?

I did happy scenario.
Also I did the one described in jira. Meaning:
1. Deny the license install Ambari
2. Check that gpl repos are not written to agent filesystem
3. Accept the license and restart server
4. Restart Datanode.
5. Make sure lzo packages are installed and gpl repos and present.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64209/#review192335
---


On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64209/
> ---
> 
> (Updated Nov. 30, 2017, 1:28 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate 
> Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22561
> https://issues.apache.org/jira/browse/AMBARI-22561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * User denies the GPL license agreement, UI will still issue PUT call to 
> create the repo
>   * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo 
> because it will break yum in local repo world.
>   * Then the user accepts the license by running ambari-server setup
>   * The repo file does not get updated on existing hosts
>   * We need to push the HDP-GPL repo to the repo files on existing hosts only 
> when the license is accepted
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
>  68ee607b9b 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py
>  f1c8ef1b04 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> ccb8a547f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
>  e207ac5289 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> b819dcad96 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  82e57aa4f4 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe 
> 
> 
> Diff: https://reviews.apache.org/r/64209/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/#review192466
---




ambari-web/app/routes/installer.js
Lines 291 (patched)


Could you elaborate on your problem, cause Ember upgrade requires a huge 
change in the codebase and not feasible in near future?


- Andrii Tkach


On Nov. 30, 2017, 9:01 p.m., Jason Golieb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64225/
> ---
> 
> (Updated Nov. 30, 2017, 9:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, 
> Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22569
> https://issues.apache.org/jira/browse/AMBARI-22569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the Local Repo radio button. 
> Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
> Implemented the "Use Proxy" checkbox and related proxy settings fields.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
>  PRE-CREATION 
>   ambari-web/app/assets/test/tests.js b60e17a3e2 
>   ambari-web/app/controllers/wizard/configureDownload_controller.js 
> 0246ad0602 
>   ambari-web/app/messages.js e014d4a012 
>   ambari-web/app/routes/installer.js 73c716b7a9 
>   ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c 
>   ambari-web/app/utils.js 509efc15fa 
>   ambari-web/app/utils/constants.js PRE-CREATION 
>   ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c 
>   ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION 
>   ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64225/diff/1/
> 
> 
> Testing
> ---
> 
> 20297 passing (21s)
>   125 pending
> 
> 
> Thanks,
> 
> Jason Golieb
> 
>

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192460
---


Ship it!




Ship It!

- Attila Magyar


On Dec. 1, 2017, 10:09 a.m., Sandor Molnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> ---
> 
> (Updated Dec. 1, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
> 
> 
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove hack to set KDC admin credential via the API to set session attribute 
> via the Cluster resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  da206c6ccf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  d1f235f885 
> 
> 
> Diff: https://reviews.apache.org/r/64215/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on vagrant cluster
> 
> 
> Thanks,
> 
> Sandor Molnar
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-12-01 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
---

(Updated Dec. 1, 2017, 12:34 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Current patch state. Deploy still does not pass, fixing


Bugs: AMBARI-22353
https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
---

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern 
which properties can be used with the provider. This seems like excessive 
decoupling without any benefit and usually leads to runtime errors when new or 
removed properties are forgotten.

This file should be removed and the providers should be registering the known 
properties on their own.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
 b6464c2d89 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 f6ca16bc69 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
 a24c6394ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 cc2548cc61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java
 953a2a7c77 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
 290931555e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
 389f0b2bf2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 9579dca47d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
 0898bc3bee 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
 8d716eabe0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
 8ffd596cfa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 4ab78b7ba6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 c1e9eb42a0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java
 0ffceca84f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 67f5448826 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 f0ede5ddea 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 2678d55975 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java
 60cf783940 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 b9b3b5668c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 1c36c96cc0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 737bfa4d46 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
 0f260854f8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
 ebc7645828 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c3758b3f5e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
 db904bf714 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
 53e44e1888 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
 4aa357c0e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
 f9d75fd353 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java
 f9f838fe22 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 6cdd24e967 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
 2a25bc4d02 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 94766a5df6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Sandor Molnar 


> On Dec. 1, 2017, 9:03 a.m., Attila Magyar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Line 1454 (original), 1453 (patched)
> > 
> >
> > Do we still need this getCluster() and the null check?

Since we have the same checks in the underlying updateCluster(...) cll this is 
redundant. Let me submit a new one.


- Sandor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192453
---


On Dec. 1, 2017, 10:09 a.m., Sandor Molnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> ---
> 
> (Updated Dec. 1, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
> 
> 
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove hack to set KDC admin credential via the API to set session attribute 
> via the Cluster resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  da206c6ccf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  d1f235f885 
> 
> 
> Diff: https://reviews.apache.org/r/64215/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on vagrant cluster
> 
> 
> Thanks,
> 
> Sandor Molnar
> 
>

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Sandor Molnar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/
---

(Updated Dec. 1, 2017, 10:09 a.m.)


Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.


Bugs: AMBARI-22560
https://issues.apache.org/jira/browse/AMBARI-22560


Repository: ambari


Description
---

Remove hack to set KDC admin credential via the API to set session attribute 
via the Cluster resource.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 da206c6ccf 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 d1f235f885 


Diff: https://reviews.apache.org/r/64215/diff/2/

Changes: https://reviews.apache.org/r/64215/diff/1-2/


Testing
---

Tested on vagrant cluster


Thanks,

Sandor Molnar

Re: Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/#review192453
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 1454 (original), 1453 (patched)


Do we still need this getCluster() and the null check?


- Attila Magyar


On Dec. 1, 2017, 8:49 a.m., Sandor Molnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64215/
> ---
> 
> (Updated Dec. 1, 2017, 8:49 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.
> 
> 
> Bugs: AMBARI-22560
> https://issues.apache.org/jira/browse/AMBARI-22560
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove hack to set KDC admin credential via the API to set session attribute 
> via the Cluster resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  455814aa65 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  b774436d28 
> 
> 
> Diff: https://reviews.apache.org/r/64215/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on vagrant cluster
> 
> 
> Thanks,
> 
> Sandor Molnar
> 
>

Review Request 64215: Remove obsolete hack to set KDC admin credentials via Cluster session API

2017-12-01 Thread Sandor Molnar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64215/
---

Review request for Ambari, Attila Magyar, Eugene Chekanskiy, and Robert Levas.


Bugs: AMBARI-22560
https://issues.apache.org/jira/browse/AMBARI-22560


Repository: ambari


Description
---

Remove hack to set KDC admin credential via the API to set session attribute 
via the Cluster resource.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 455814aa65 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 b774436d28 


Diff: https://reviews.apache.org/r/64215/diff/1/


Testing
---

Tested on vagrant cluster


Thanks,

Sandor Molnar