Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145084 --- Ship it! Ship It! - Hayat Behlim On Aug. 8, 2016, 5:07 a.m., Hemanth Yamijala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50884/ > --- > > (Updated Aug. 8, 2016, 5:07 a.m.) > > > Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, > and Oliver Szabo. > > > Bugs: AMBARI-17785 > https://issues.apache.org/jira/browse/AMBARI-17785 > > > Repository: ambari > > > Description > --- > > This patch adds support for periodically uploading logs to S3 from logfeeder. > The set of changes included are: > > * Supports one at a time processing of log events in the OutputS3File case. > These are spooled locally and uploaded periodically to S3. > * Supports upload based on two criteria - file size threshold, and time based > threshold. > * Refactors code to achieve the above, while not duplicating any existing > functions - for e.g. the code path to upload files all at once is still > retained and uses the same helper classes like S3Uploader etc. > * Unit tests added for all new code. > > What is **not** part of this patch, which I plan to cover in forthcoming > patches: > > * Support for other security models as applicable (for e.g. using IAM role > based security for instances running on EC2) > * Better resilience to errors and fault tolerance. > * Copying configs, if required, to the S3 buckets. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java > 8def4b9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java > f42195c > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/S3LogPathResolver.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/S3OutputConfiguration.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/S3Uploader.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java > 306326a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java > ced2b5c > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputS3FileTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/S3LogPathResolverTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/S3UploaderTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java > 7d9d78a > > Diff: https://reviews.apache.org/r/50884/diff/ > > > Testing > --- > > * New UTs added for the new functionality > * Have manually tested that uploads to S3 occur based on reaching the file > size threshold and time based threshold both. > > > Thanks, > > Hemanth Yamijala > >
Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > <https://reviews.apache.org/r/50884/diff/1/?file=1465944#file1465944line47> > > > > I wanted S3Util as a singleton utility that's why I have made it enum, > > Is there any specific reason to make it class ? > > Hemanth Yamijala wrote: > Hayat, I needed to mock S3Util so I could test it by not needing S3 > functionality up and running (see S3UploaderTest). This was not possible > through an enum. Hence the reason to make it into a class. S3Util.INSTANCE > still works as the previously defined ENUM version. Let me know if you see > any issues with this. No, There is no issue it will work as previously,It looks fine.Now I understand mocking is the reason. Thanks for the clarification. - Hayat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145071 --- On Aug. 8, 2016, 5:07 a.m., Hemanth Yamijala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50884/ > --- > > (Updated Aug. 8, 2016, 5:07 a.m.) > > > Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, > and Oliver Szabo. > > > Bugs: AMBARI-17785 > https://issues.apache.org/jira/browse/AMBARI-17785 > > > Repository: ambari > > > Description > --- > > This patch adds support for periodically uploading logs to S3 from logfeeder. > The set of changes included are: > > * Supports one at a time processing of log events in the OutputS3File case. > These are spooled locally and uploaded periodically to S3. > * Supports upload based on two criteria - file size threshold, and time based > threshold. > * Refactors code to achieve the above, while not duplicating any existing > functions - for e.g. the code path to upload files all at once is still > retained and uses the same helper classes like S3Uploader etc. > * Unit tests added for all new code. > > What is **not** part of this patch, which I plan to cover in forthcoming > patches: > > * Support for other security models as applicable (for e.g. using IAM role > based security for instances running on EC2) > * Better resilience to errors and fault tolerance. > * Copying configs, if required, to the S3 buckets. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java > 8def4b9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java > f42195c > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/S3LogPathResolver.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/S3OutputConfiguration.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/S3Uploader.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java > 306326a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java > ced2b5c > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputS3FileTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/S3LogPathResolverTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/S3UploaderTest.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java > 7d9d78a > > Diff: https://reviews.apache.org/r/50884/diff/ > > > Testing > --- > > * New UTs added for the new functionality > * Have manually tested that uploads to S3 occur based on reaching the file > size threshold and time based threshold both. > > > Thanks, > > Hemanth Yamijala > >
Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50297/#review143486 --- Ship it! Ship It! - Hayat Behlim On July 26, 2016, 5:55 a.m., Hemanth Yamijala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50297/ > --- > > (Updated July 26, 2016, 5:55 a.m.) > > > Review request for Ambari, Hayat Behlim and Dharmesh Makwana. > > > Bugs: AMBARI-17788 > https://issues.apache.org/jira/browse/AMBARI-17788 > > > Repository: ambari > > > Description > --- > > This patch extracts spooling functions outside OutputHDFSFile so that it can > be used for AMBARI-17785. The patch allows callbacks to check the condition > on which spool files should be rolled over and what to do on rollover. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java > 87cc0eb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50297/diff/ > > > Testing > --- > > * New unit tests. > * Have tested by installing new RPM on an existing Ambari installation and > configuring the output for one of the services to write to HDFS. Tested that > upload to HDFS, rollover is working correctly for this service. > > > Thanks, > > Hemanth Yamijala > >
Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50297/#review143372 --- ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java (line 126) <https://reviews.apache.org/r/50297/#comment209150> I think just for sake of understanding initializeSpoolFile() will come after handleRollover method is invoked. - Hayat Behlim On July 25, 2016, 7:17 a.m., Hemanth Yamijala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50297/ > --- > > (Updated July 25, 2016, 7:17 a.m.) > > > Review request for Ambari, Hayat Behlim and Dharmesh Makwana. > > > Bugs: AMBARI-17788 > https://issues.apache.org/jira/browse/AMBARI-17788 > > > Repository: ambari > > > Description > --- > > This patch extracts spooling functions outside OutputHDFSFile so that it can > be used for AMBARI-17785. The patch allows callbacks to check the condition > on which spool files should be rolled over and what to do on rollover. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java > 87cc0eb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50297/diff/ > > > Testing > --- > > * New unit tests. > * Have tested by installing new RPM on an existing Ambari installation and > configuring the output for one of the services to write to HDFS. Tested that > upload to HDFS, rollover is working correctly for this service. > > > Thanks, > > Hemanth Yamijala > >
Re: Review Request 49519: Fix Logfeeder visibilities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49519/#review140605 --- Ship it! Ship It! - Hayat Behlim On July 1, 2016, 4:46 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49519/ > --- > > (Updated July 1, 2016, 4:46 p.m.) > > > Review request for Ambari, Hayat Behlim, Oliver Szabo, Robert Nettleton, and > Sumit Mohanty. > > > Bugs: AMBARI-17528 > https://issues.apache.org/jira/browse/AMBARI-17528 > > > Repository: ambari > > > Description > --- > > Many variables/functions have a broader visibility than needed. > > Also remvoed some more unused code. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java > c3b36df > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java > 088472e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java > d83642e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > c5d4fd5 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java > 1b9171b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java > 78d0499 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java > 4a8f7d0 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java > f6d3481 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > d34eed6 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > 31e1cd1 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java > 7b1e5e0 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 2e38255 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java > 3538ba0 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java > 9d5f970 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java > 7c455f6 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java > 4833d3f > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java > c71d4b9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java > e67512b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java > b87ce50 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java > f293ede > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java > afbb126 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java > 00a69df > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java > 0624c59 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java > 19dd404 > > Diff: https://reviews.apache.org/r/49519/diff/ > > > Testing > --- > > Tested on local cluster. > > Tests run: 36, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Miklos Gergely > >
Re: Review Request 49233: Remove superfluous Logfeeder codes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/#review139526 --- Ship it! Ship It! - Hayat Behlim On June 25, 2016, 11:49 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49233/ > --- > > (Updated June 25, 2016, 11:49 p.m.) > > > Review request for Ambari, Don Bosco Durai, Hayat Behlim, Dharmesh Makwana, > Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17347 > https://issues.apache.org/jira/browse/AMBARI-17347 > > > Repository: ambari > > > Description > --- > > Remove > - unnecessary imports > - unused functions > - unused variables > - empty comments > - meaningless comments > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java > 3836c76 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java > 521319e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java > 4359c78 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > d00ed67 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java > 6f29fde > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java > 7a68b4d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricCount.java > c715881 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java > be7594a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java > f84457e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > aa1edea > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > 9b2a717 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java > c4da3cb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/JSONFilterCode.java > 5c4d30e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 18e2184 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java > 7107a69 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputMarker.java > 6196068 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java > d68ab96 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java > 9c46c4e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/LogsearchReaderFactory.java > a231807 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java > 5b9fe8f > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederConstants.java > f177e49 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java > f223207 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java > a064663 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java > 5b89d4b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java > 107e7e4 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java > 99c33ed > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java > 9810ceb > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java > 99a2909 > > ambari-
Re: Review Request 48903: AMBARI-17307: LogFeeder output to Solr doesn't handle empty buffer queue properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48903/#review138520 --- Ship it! Ship It! - Hayat Behlim On June 18, 2016, 6:59 a.m., Don Bosco Durai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48903/ > --- > > (Updated June 18, 2016, 6:59 a.m.) > > > Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, > Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-17307 > https://issues.apache.org/jira/browse/AMBARI-17307 > > > Repository: ambari > > > Description > --- > > Reseting the retry timer if the buffer is empty. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > Diff: https://reviews.apache.org/r/48903/diff/ > > > Testing > --- > > > Thanks, > > Don Bosco Durai > >
Review Request 47118: Fixed Typo in logfeeder property name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47118/ --- Review request for Ambari. Bugs: AMBARI-16304 https://issues.apache.org/jira/browse/AMBARI-16304 Repository: ambari Description --- Rename property logfeeder.solr.config.internal to logfeeder.solr.config.interval Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java e645a3d ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 22f3b78 Diff: https://reviews.apache.org/r/47118/diff/ Testing --- Thanks, Hayat Behlim
Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46931/ --- Review request for Ambari. Bugs: AMBARI-16211 https://issues.apache.org/jira/browse/AMBARI-16211 Repository: ambari Description --- Patch contains : Some log messages were not getting parsed due to grok lib issue with v.0.1.1, need to update grok to latest version. Diffs - ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 12255fe Diff: https://reviews.apache.org/r/46931/diff/ Testing --- Thanks, Hayat Behlim
