Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-11-15 Thread Ishan Bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/#review191101
---


Ship it!




Ship It!

- Ishan Bhatt


On Nov. 15, 2017, 7:19 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63847/
> ---
> 
> (Updated Nov. 15, 2017, 7:19 p.m.)
> 
> 
> Review request for Ambari, Ishan Bhatt and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22445
> https://issues.apache.org/jira/browse/AMBARI-22445
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The mysql connector license is not compatible with Ambari's license and 
> Ambari no longer auto installs mysql-connector after AMBARI-22369. Warn the 
> user appropriately to install and setup mysql-connector to be used by Hive.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/controls_view.js f03e5c0 
>   ambari-web/test/views/common/controls_view_test.js c5c5338 
> 
> 
> Diff: https://reviews.apache.org/r/63847/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Ambari-web unit tests pass
>   30518 passing (27s)
>   157 pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>



Re: Review Request 62235: Some clients are shown as installed for a hosts page even when they have not been installed through ambari

2017-09-12 Thread Ishan Bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62235/#review185188
---


Ship it!




Ship It!

- Ishan Bhatt


On Sept. 12, 2017, 4:24 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62235/
> ---
> 
> (Updated Sept. 12, 2017, 4:24 a.m.)
> 
> 
> Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-21932
> https://issues.apache.org/jira/browse/AMBARI-21932
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some clients are shown as installed for a hosts page even when they have not 
> been installed through ambari
> 
> On an installed cluster:
> 1) Add a host with no clients
> 2) Now add a service with clients on all hosts (including the newely added 
> host)
> 3) On the newely added host, only one client is expected(from the newely 
> added service) to be shown but actually other clients are also present as well
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js e0c2f5d1d0 
> 
> 
> Diff: https://reviews.apache.org/r/62235/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested that the patch fixes the issue.
> 
> ambari-web unit test result:
> 
>   30489 passing (20s)
>   157 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>