Review Request 64276: hive2 queries fails after adding any service to the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64276/ --- Review request for Ambari, Jayush Luniya, Mahadev Konar, Swapan Shridhar, and Yusaku Sako. Bugs: AMBARI-22578 https://issues.apache.org/jira/browse/AMBARI-22578 Repository: ambari Description --- STR: Deploy a cluster using ambari with TEZ service (HDP2.2) Upgrade HDP to 2.6 Add a new service using Add service wizard of ambari Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/TEZ/configuration/tez-site.xml 393d077eb7 Diff: https://reviews.apache.org/r/64276/diff/1/ Testing --- Tested manually on repro cluster. Since only tez-site.xml file is changed, unit tests are not affected Thanks, Jaimin Jetly
Review Request 62427: Add service wizard stuck at step 8
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62427/ --- Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-22001 https://issues.apache.org/jira/browse/AMBARI-22001 Repository: ambari Description --- cherry-picking https://issues.apache.org/jira/browse/AMBARI-21932 commit from branch-2.6 to trunk caused this issue as a referenced variable which was defined in branch-2.6 bits was removed from trunk bits Diffs - ambari-web/app/controllers/wizard/step8_controller.js b99c6e39d7 Diff: https://reviews.apache.org/r/62427/diff/1/ Testing --- ambari-web unit test: 21334 passing (27s) 128 pending Thanks, Jaimin Jetly
Re: Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62294/ --- (Updated Sept. 13, 2017, 10:54 p.m.) Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-21944 https://issues.apache.org/jira/browse/AMBARI-21944 Repository: ambari Description --- Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java f3b3c415ee ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java f901bda2b7 ambari-web/app/controllers/main/host/details.js ad2ac98498 ambari-web/app/controllers/main/service/item.js 224f83bdd9 ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 140e7de641 ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js 9a73a9a3e1 Diff: https://reviews.apache.org/r/62294/diff/2/ Changes: https://reviews.apache.org/r/62294/diff/1-2/ Testing --- Tested manually on a cluster. verified that ambari-web unit test and ExecutionScheduleManagerTest test passes successfully: 30490 passing (20s) 157 pending Thanks, Jaimin Jetly
Review Request 62294: Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62294/ --- Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-21944 https://issues.apache.org/jira/browse/AMBARI-21944 Repository: ambari Description (updated) --- Batch requests(Rolling Restart, HSI enable/disable, decommission/recommission) not working when Ambari is configured with Knox proxy Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java f3b3c415ee ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java f901bda2b7 ambari-web/app/controllers/main/host/details.js ad2ac98498 ambari-web/app/controllers/main/service/item.js 224f83bdd9 ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 140e7de641 ambari-web/app/utils/batch_scheduled_requests.js 6d1e721d47 ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js 9a73a9a3e1 Diff: https://reviews.apache.org/r/62294/diff/1/ Testing (updated) --- Tested manually on a cluster. verified that ambari-web unit test and ExecutionScheduleManagerTest test passes successfully: 30490 passing (20s) 157 pending Thanks, Jaimin Jetly
Re: Review Request 62235: Some clients are being additionally installed via Add service wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62235/ --- (Updated Sept. 12, 2017, 4:38 p.m.) Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and Yusaku Sako. Summary (updated) - Some clients are being additionally installed via Add service wizard Bugs: AMBARI-21932 https://issues.apache.org/jira/browse/AMBARI-21932 Repository: ambari Description --- Some clients are shown as installed for a hosts page even when they have not been installed through ambari On an installed cluster: 1) Add a host with no clients 2) Now add a service with clients on all hosts (including the newely added host) 3) On the newely added host, only one client is expected(from the newely added service) to be shown but actually other clients are also present as well Diffs - ambari-web/app/controllers/wizard/step8_controller.js e0c2f5d1d0 Diff: https://reviews.apache.org/r/62235/diff/1/ Testing --- Manually tested that the patch fixes the issue. ambari-web unit test result: 30489 passing (20s) 157 pending Thanks, Jaimin Jetly
Review Request 62235: Some clients are shown as installed for a hosts page even when they have not been installed through ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62235/ --- Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-21932 https://issues.apache.org/jira/browse/AMBARI-21932 Repository: ambari Description --- Some clients are shown as installed for a hosts page even when they have not been installed through ambari On an installed cluster: 1) Add a host with no clients 2) Now add a service with clients on all hosts (including the newely added host) 3) On the newely added host, only one client is expected(from the newely added service) to be shown but actually other clients are also present as well Diffs - ambari-web/app/controllers/wizard/step8_controller.js e0c2f5d1d0 Diff: https://reviews.apache.org/r/62235/diff/1/ Testing --- Manually tested that the patch fixes the issue. ambari-web unit test result: 30489 passing (20s) 157 pending Thanks, Jaimin Jetly
Review Request 61894: 'Move Hive Metastore' wizard is stuck while configuring MYSQL_SERVER
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61894/ --- Review request for Ambari, Mahadev Konar, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-21807 https://issues.apache.org/jira/browse/AMBARI-21807 Repository: ambari Description --- Ambari incorrectly tries to reconfigure mysql server even when existing mysql (not ambari deployed) is being used Diffs - ambari-web/app/controllers/main/service/reassign/step1_controller.js c631e85bcb Diff: https://reviews.apache.org/r/61894/diff/1/ Testing --- Verified e2e that patch fixes the issue. Verified that ambari-web unit tests passes with the patch 21208 passing (22s) 128 pending Thanks, Jaimin Jetly
Re: Review Request 60516: AMBARI-21371 - Adding ranger failed when user has custom properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60516/#review179165 --- Ship it! Ship It! - Jaimin Jetly On June 28, 2017, 8:31 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60516/ > --- > > (Updated June 28, 2017, 8:31 p.m.) > > > Review request for Ambari, Andrii Babiichuk, Aleksandr Kovalenko, Denys > Buzhor, Jaimin Jetly, and Yusaku Sako. > > > Bugs: AMBARI-21371 > https://issues.apache.org/jira/browse/AMBARI-21371 > > > Repository: ambari > > > Description > --- > > propertyDependsOn is only available for stack level configuration. Add a null > check. > > > Diffs > - > > ambari-web/app/mixins/common/configs/enhanced_configs.js 4561f77 > > > Diff: https://reviews.apache.org/r/60516/diff/1/ > > > Testing > --- > > Manually tested on live cluster. All unit tests passed. > > 21208 passing (22s) > 128 pending > > > Thanks, > > Richard Zang > >
Review Request 60164: Swagger resources generation for doc purpose should not be part of default maven profile
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60164/ --- Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Sumit Mohanty, and Yusaku Sako. Bugs: AMBARI-21273 https://issues.apache.org/jira/browse/AMBARI-21273 Repository: ambari Description --- On executing mvn compile on ambari-server and then checking with git status, following files are automatically added/edited even when no code changes are made modified: ambari-server/docs/api/generated/index.html Untracked files: (use "git add ..." to include in what will be committed) docs/api/ As a fix to this issue, swagger resources that are presently checked in to ambari project at ambari-server/docs/api/generated/ will be updated only when mvn command is executed with -Dgenerate.swagger.resources flag. This is expected to be done and resources should be checked in just before every new ambari release. with this commit, ambari wiki page for release guideline will also be updated Diffs - ambari-server/pom.xml 91c35e5b50 Diff: https://reviews.apache.org/r/60164/diff/1/ Testing --- Tested by running "mvn clean test -Drat.skip -Dcheckstyle.skip -DskipTests" and "mvn clean test -Drat.skip -Dcheckstyle.skip -DskipTests -Dgenerate.swagger.resources" from ambari root project ane veroified behavior is as expected Thanks, Jaimin Jetly
Re: Review Request 59514: AMBARI-20970. Integrate StackService with Swagger - addendum: fix XML property names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59514/#review175904 --- Ship it! Ship It! - Jaimin Jetly On May 24, 2017, 6:15 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59514/ > --- > > (Updated May 24, 2017, 6:15 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jonathan Hurley, > and Sebastian Toader. > > > Bugs: AMBARI-20970 > https://issues.apache.org/jira/browse/AMBARI-20970 > > > Repository: ambari > > > Description > --- > > Update constants, use only for JSON where names are different > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java > 4137115b14ea195581313f9d33cc4f038ef3d163 > > > Diff: https://reviews.apache.org/r/59514/diff/1/ > > > Testing > --- > > Installed cluster via Ambari Web. > > Unit tests: > > ``` > Tests run: 4981, Failures: 0, Errors: 0, Skipped: 39 > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 59427: AMBARI-21082 - Ambari 3.0: Outstanding wizard issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59427/#review175744 --- Ship it! Ship It! - Jaimin Jetly On May 23, 2017, 1:49 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59427/ > --- > > (Updated May 23, 2017, 1:49 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-21082 > https://issues.apache.org/jira/browse/AMBARI-21082 > > > Repository: ambari > > > Description > --- > > Fix step indicator > Fix service selection click > > > Diffs > - > > ambari-web/app/styles/application.less 2fc1cf2 > ambari-web/app/templates/wizard/step4.hbs 9f1d7df > ambari-web/app/views/wizard/step4_view.js 137b9f5 > > > Diff: https://reviews.apache.org/r/59427/diff/3/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > 20699 passing (22s) > 128 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 59336: When adding services, new versions of configs get added for the config types associated with config groups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59336/#review175249 --- Ship it! Ship It! - Jaimin Jetly On May 17, 2017, 2:10 p.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59336/ > --- > > (Updated May 17, 2017, 2:10 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, Jaimin > Jetly, and Sid Wagle. > > > Bugs: AMBARI-21037 > https://issues.apache.org/jira/browse/AMBARI-21037 > > > Repository: ambari > > > Description > --- > > STR > Deploy 2.4.2, add HDFS, YARN, ZK > Create few config groups for YARN > Perform add service and after each add service you will find a new version of > the config type > All new config versions have the same text "Initial configurations for YARN" > There is no config changes between the versions. > > > Diffs > - > > ambari-web/app/controllers/wizard.js c3a54cf > ambari-web/app/controllers/wizard/step7_controller.js 8e14b70 > ambari-web/app/mixins/common/configs/configs_saver.js 7d8721d > ambari-web/test/mixins/common/configs/configs_saver_test.js 6e65cf9 > > > Diff: https://reviews.apache.org/r/59336/diff/1/ > > > Testing > --- > > branch-2.5: > 30383 passing (30s) > 157 pending > trunk: > 20696 passing (26s) > 128 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 59315: AMBARI-21035. Integrate ClusterService with Swagger (adoroszlai)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59315/#review175126 --- Ship it! Ship It! - Jaimin Jetly On May 16, 2017, 5:32 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59315/ > --- > > (Updated May 16, 2017, 5:32 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21035 > https://issues.apache.org/jira/browse/AMBARI-21035 > > > Repository: ambari > > > Description > --- > > * documented API (except subresources) > * renamed some methods to avoid conflict between ClusterService and > ServiceService > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > 55776332b4835d81968e5fb875a8d22f13b45605 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > e50d70f728698b2633a6afc2f259ae6eb677bd84 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java > 27de0b425c9a87eee53c0643fc8f277d232e3629 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 4c8154e82be1296e6c2c0dee7bdb6c44487c4e0b > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java > 4d4fd59515e7f63a9cf201b2cdbeb25197dd0d69 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java > b89bd457eeedf0801db6d8f12263ef5688367187 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactRequest.java > ac37c0f26e32f14faf7a85982a69e04d78241d17 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterServiceArtifactResponse.java > 29b8c94084f49887d5264fb8117e2cf203bba0c4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java > a6a731c2714b3ada1b28031dd4940e49b660f595 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > ae17de41f8aafd2a340f824dc2a2cb5f1ab8c8aa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > 1a14b016c097d9142e9d3bd844c0c01be5dece12 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterServiceTest.java > cfc43f5d87759d1c90be52c9ced9bfe2d7fb05c0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > d613a2e5eff053017b407b4f67948fd44e5512fc > > ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterRequestTest.java > 084e36b8b62f5b6c7302d990e9d21dd55da3cf2d > > ambari-server/src/test/java/org/apache/ambari/server/controller/ClusterResponseTest.java > cfb2611d98f6b8adb2b1d103bf549258a33c61b4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 49127d82742e59af23c81400010c02be1b179bc3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java > 73a80f609575f9c4b5b7f63dffe22afbaf690b9d > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 345c463cd32a3a6411aae37c3b61aabbb5440384 > > > Diff: https://reviews.apache.org/r/59315/diff/1/ > > > Testing > --- > > * verified generated doc > * unit tests pass, except `ServicePropertiesTest`, which fails due to > [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 59236: Integrate ActionService and subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59236/#review174838 --- Ship it! Ship It! - Jaimin Jetly On May 12, 2017, 6:59 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59236/ > --- > > (Updated May 12, 2017, 6:59 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21009 > https://issues.apache.org/jira/browse/AMBARI-21009 > > > Repository: ambari > > > Description > --- > > Annotated ActionService with Swagger annotations > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ActionService.java > 0290151 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0b2afd1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequest.java > 7a4fd36 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionRequestSwagger.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionResponse.java > e7edafb > > > Diff: https://reviews.apache.org/r/59236/diff/2/ > > > Testing > --- > > Unit tests pending. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 59187: AMBARI-20994. Integate RootServiceService with Swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59187/#review174739 --- Ship it! Ship It! - Jaimin Jetly On May 11, 2017, 10:07 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59187/ > --- > > (Updated May 11, 2017, 10:07 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20994 > https://issues.apache.org/jira/browse/AMBARI-20994 > > > Repository: ambari > > > Description > --- > > done > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0b2afd15be68de98de31f30adc1fb1218db3477c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceService.java > ce9240c1dbc5791842acee1d3faf3c1dd740989a > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce085d8a27a7f724dbd4fd807293c2e6ade69 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceComponentResponse.java > 4845c782a4994b1221a26dc4644370159ab9762e > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceHostComponentResponse.java > 6cbc30c23ba9c2fd4245fe3037810fa2d4b8c6df > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponse.java > 736565e3a5f1da29b9374b30f180ad94bc0c > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > 2ceb76924113bd16612335338b3f14f333c888bb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > 8a7891191ef046cec1f4792f0edd41c905f34728 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java > fe952101dea7b17c0559b8a80d420097361566bf > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java > d5c33c1b4b82b3eef8d6a340b3691c339743ffce > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceResourceProvider.java > 80f720c95741a1a038d1b4ff10f50d289f2b45d1 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/RootServiceServiceTest.java > 64898c8873abc9c5f3b68e9e9ec01df42c42b382 > > ambari-server/src/test/java/org/apache/ambari/server/controller/RootServiceResponseFactoryTest.java > e9b4aa73d04b327e4d2382a02b6e9ef6041507a4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProviderTest.java > eb6f08ea83614776768390bcf0973ddb2436 > > > Diff: https://reviews.apache.org/r/59187/diff/2/ > > > Testing > --- > > * compile, test-compile > * Verified generated doc. > * Unit tests: pass, except one existing failure. > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/#review174348 --- Ship it! Ship It! - Jaimin Jetly On May 9, 2017, 5:50 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59104/ > --- > > (Updated May 9, 2017, 5:50 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Repository: ambari > > > Description > --- > > - Documented StackssService (except 3 calls that return other services - > Swagger can't handle them out of the box) > - Some inaccuracies on the response schema (e.g. Artifact and Configuration > queries use the same response object, so service_name is reported for the > stack level API call) > - subresources are partially covered > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 76d2b70 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > 7b5f9cf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java > 86bacf1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java > 47515c9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 8e87e6f > > ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java > 99c9ce9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java > 14aab3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java > 0338ed9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java > 1901337 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > b48fad3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 8e4200d > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java > 3c65d05 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java > d0a5206 > > ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java > d4bdce8 > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 353dd86 > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java > c41cd9a > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java > 7824933 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java > a28d149 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java > 3bb8c77 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java > 840dbf0 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java > 43d2170 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java > 62fbfc1 > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java > b949a12 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java > f7d4187 > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java > 96d2fc0 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java > 58fe942 > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java > 7bd058c > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java > 1f38d8e > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java > 9e9c068 > > > Diff: https://reviews.apache.org/r/59104/diff/1/ > > > Testing > --- > > All unit tests for ambari-server pass, except ServicePropertiesTest, which > fails due to AMBARI-20443. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 59043: AMBARI-20951. Integrate HostService resource with swagger
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59043/#review174170 --- Ship it! Ship It! - Jaimin Jetly On May 8, 2017, 7 a.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59043/ > --- > > (Updated May 8, 2017, 7 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20951 > https://issues.apache.org/jira/browse/AMBARI-20951 > > > Repository: ambari > > > Description > --- > > * documented `HostService`, `HostRequest`, `HostResponse` > * removed unused attributes > * introduced constants for common Swagger parameters > * subresources are not covered yet > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 0185d37f1a9127c2bd414229b8ab7885e849fbf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c26c5d85d4c90a1aee81cb5aafbcac49d185c5e2 > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java > d05fe9dce86eaa712807c50744c1fb93000fbe56 > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java > a6168394bf4be45497924e73c84aae393d1c53fe > > ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java > 8032801dd7014b9532b5358c8fc44e5250b90c66 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java > 40fe3697e98acff0a36dd24f3e51193683b5af93 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > f604a7f8be9b2dad7810e46444ae79ead73f8a98 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java > 96457ed6302f98f6b402eb27f49cffc41bfe4585 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProvider.java > c2fb844ff7e81d8291ae27359dac864aadf50430 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > b5d2f9de8a297b68ee569b92bc475e39b39986d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java > c747a33a7d352d8614a573a6b9f3f7149ac5df7c > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > db228b194e240a0c895072362ae68d1973742cef > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 6d12402e9da92985176c8724f6b705304bba03e3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 168d13b44777b1891e72287de035e99d1064ab72 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostServiceTest.java > 6aef04dda19693cd2408dcfce9be5ca8751550e4 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java > 2d1cefcfdcb3604d54338c4c0b314c5fbb740b50 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e0891020d90593aeee76cbeddf65f5b66e2b0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > c7613231b13c8402cffe29f90fac2449e0f0a395 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RootServiceHostComponentResourceProviderTest.java > f15c9f2baa20fb69b855d24badb144e354b83891 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > 48d1351dc527488cea06168d2fe0fcc90d9a6eb7 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 2d5978b1788572c716ddfaae2e56b9502097e98f > > > Diff: https://reviews.apache.org/r/59043/diff/1/ > > > Testing > --- > > Unit tests pass, except `ServicePropertiesTest`, which fails due to > [AMBARI-20443](https://issues.apache.org/jira/browse/AMBARI-20443). > > ``` > $ mvn -am -pl ambari-server clean test > ... > Tests in error: > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:49 » Ambari File > /Us... > > Tests run: 4971, Failures: 0, Errors: 1, Skipped: 39 > ``` > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 58637: AMBARI-20826 - HIVE "Quick Links" section showing Graphana related quicklinks when Graphana is not installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58637/#review172725 --- Ship it! Ship It! - Jaimin Jetly On April 21, 2017, 11:55 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58637/ > --- > > (Updated April 21, 2017, 11:55 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20826 > https://issues.apache.org/jira/browse/AMBARI-20826 > > > Repository: ambari > > > Description > --- > > We cannot assume host for master component of current visiting service to be > the default host for all quicklinks. > Add component setting for SPARK2 quicklinks.json. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json > ff285fc > ambari-web/app/views/common/quick_view_link_view.js dfaf953 > > > Diff: https://reviews.apache.org/r/58637/diff/1/ > > > Testing > --- > > Manually tested on liver cluster. All unit tests passed. > 20700 passing (24s) > 128 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58596/#review172567 --- Ship it! Ship It! - Jaimin Jetly On April 21, 2017, 12:09 a.m., Yusaku Sako wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58596/ > --- > > (Updated April 21, 2017, 12:09 a.m.) > > > Review request for Ambari, Jaimin Jetly and Vivek Ratnavel Subramanian. > > > Bugs: AMBARI-20813 > https://issues.apache.org/jira/browse/AMBARI-20813 > > > Repository: ambari > > > Description > --- > > See https://issues.apache.org/jira/browse/AMBARI-20813 > > > Diffs > - > > ambari-web/pom.xml 6182a60 > > > Diff: https://reviews.apache.org/r/58596/diff/2/ > > > Testing > --- > > Tested locally to make sure that "mvn package" builds Ambari Web successfully. > > Ran ambari-web unit tests: > 30380 passing (19s) > 157 pending > > > Thanks, > > Yusaku Sako > >
Re: Review Request 58433: Add more database options for beacon in stack advisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58433/#review171951 --- Ship it! Ship It! - Jaimin Jetly On April 13, 2017, 10:08 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58433/ > --- > > (Updated April 13, 2017, 10:08 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20762 > https://issues.apache.org/jira/browse/AMBARI-20762 > > > Repository: ambari > > > Description > --- > > In the configs/Database page of beacon, on selecting each database type, the > JDBC Driver Class and URL should be updated automatically. > > This part should be done in stack advisor. > > (Beacon supports three db types : New derby, existed MySQL and existed Oracle > ) > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 7881917ab0 > > > Diff: https://reviews.apache.org/r/58433/diff/2/ > > > Testing > --- > > 20664 passing (27s) > 128 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/#review171884 --- Ship it! Ship It! - Jaimin Jetly On April 13, 2017, 3:44 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58356/ > --- > > (Updated April 13, 2017, 3:44 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Oliver Szabo, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20735 > https://issues.apache.org/jira/browse/AMBARI-20735 > > > Repository: ambari > > > Description > --- > > Created checkstyle check to ensure either @ApiOperation or @ApiIgnore is > present on all REST API methods > > > Diffs > - > > ambari-server/checkstyle.xml bf7698760ac8ddba1d692bcd448c19d939dc > ambari-server/pom.xml fbc2b9fd129dca0828624fe76e33616b6919f429 > ambari-server/src/main/assemblies/server.xml > 27835265f78a3a7aed37eaa544e25679eee8b400 > utility/checkstyle.xml PRE-CREATION > utility/pom.xml 6f602068ca863fd99d537b88462487d9f28e9c6d > utility/src/main/java/org/apache/ambari/annotations/ApiIgnore.java > PRE-CREATION > > utility/src/main/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheck.java > PRE-CREATION > > utility/src/test/java/org/apache/ambari/checkstyle/AvoidTransactionalOnPrivateMethodsCheckTest.java > 14d74867b81d58a35e732940ccb16f02d4e9b317 > > utility/src/test/java/org/apache/ambari/checkstyle/UndocumentedRestApiOperationCheckTest.java > PRE-CREATION > > utility/src/test/resources/org/apache/ambari/checkstyle/InputRestApiOperation.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58356/diff/2/ > > > Testing > --- > > Includes unit test for the new check. > Also ran the check on ambari-server: produces 315 errors. > > > Thanks, > > Attila Doroszlai > >
Re: Review Request 58405: Update the Accordion styles in horton style
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58405/#review171825 --- Ship it! Ship It! - Jaimin Jetly On April 12, 2017, 10:19 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58405/ > --- > > (Updated April 12, 2017, 10:19 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20752 > https://issues.apache.org/jira/browse/AMBARI-20752 > > > Repository: ambari > > > Description > --- > > Need to update the Accordion styles in style guide > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css b2f5ca4450 > > > Diff: https://reviews.apache.org/r/58405/diff/1/ > > > Testing > --- > > 20675 passing (25s) > 128 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 58405: Update the Accordion styles in horton style
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58405/#review171824 --- Ship it! Ship It! - Jaimin Jetly On April 12, 2017, 10:19 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58405/ > --- > > (Updated April 12, 2017, 10:19 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-20752 > https://issues.apache.org/jira/browse/AMBARI-20752 > > > Repository: ambari > > > Description > --- > > Need to update the Accordion styles in style guide > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css b2f5ca4450 > > > Diff: https://reviews.apache.org/r/58405/diff/1/ > > > Testing > --- > > 20675 passing (25s) > 128 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 58264: hive maybe not rely on slider
> On April 11, 2017, 2:51 a.m., Jaimin Jetly wrote: > > Enabling interactive query for Hive which installs HiveServer2 interactive > > host component and deploys LLAP requires slider service. > > That's the reason for slider being as a dependency for Hive. > > > > I doubt hive service check will pass if on installer wizard hive is > > selected without slider service and interactive query settings are enabled > > on "customize services" page for hive > > > > > > Reference: https://cwiki.apache.org/confluence/display/Hive/LLAP > > zhangxiaolu zhangxiaolu wrote: > yes,you're right. Even not installed slider, hive service check still > pass. I mean slider is required by hive service as of now. If not installed then hive interactive query will not work. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58264/#review171514 --- On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58264/ > --- > > (Updated April 11, 2017, 1:05 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro > Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-20710 > https://issues.apache.org/jira/browse/AMBARI-20710 > > > Repository: ambari > > > Description > --- > > when adding the hive, the dialog tips that > " > You did not select Slider, but it is needed by other services you selected. > We will automatically add Slider. Is this OK? > " > There is no dependency relationship between hive and slider,so maybe we > should remove requiceservice slider in hive's metainfo.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml > 6d9098f > > > Diff: https://reviews.apache.org/r/58264/diff/1/ > > > Testing > --- > > done it > > > File Attachments > > > AMBARI-20710.patch > > https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch > > > Thanks, > > zhangxiaolu zhangxiaolu > >
Re: Review Request 58264: hive maybe not rely on slider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58264/#review171514 --- Enabling interactive query for Hive which installs HiveServer2 interactive host component and deploys LLAP requires slider service. That's the reason for slider being as a dependency for Hive. I doubt hive service check will pass if on installer wizard hive is selected without slider service and interactive query settings are enabled on "customize services" page for hive Reference: https://cwiki.apache.org/confluence/display/Hive/LLAP - Jaimin Jetly On April 11, 2017, 1:05 a.m., zhangxiaolu zhangxiaolu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58264/ > --- > > (Updated April 11, 2017, 1:05 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro > Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-20710 > https://issues.apache.org/jira/browse/AMBARI-20710 > > > Repository: ambari > > > Description > --- > > when adding the hive, the dialog tips that > " > You did not select Slider, but it is needed by other services you selected. > We will automatically add Slider. Is this OK? > " > There is no dependency relationship between hive and slider,so maybe we > should remove requiceservice slider in hive's metainfo.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml > 6d9098f > > > Diff: https://reviews.apache.org/r/58264/diff/1/ > > > Testing > --- > > done it > > > File Attachments > > > AMBARI-20710.patch > > https://reviews.apache.org/media/uploaded/files/2017/04/11/31a2fb38-06e4-4208-8f26-82c5c0d9cf71__AMBARI-20710.patch > > > Thanks, > > zhangxiaolu zhangxiaolu > >
Review Request 58051: Misc fixes for ambari-server swagger integration prototype
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58051/ --- Review request for Ambari, Jayush Luniya, Oliver Szabo, and Sumit Mohanty. Bugs: AMBARI-20624 https://issues.apache.org/jira/browse/AMBARI-20624 Repository: ambari Description --- As part of this ticket following changes are done: # swagger spec file will be committed to ambari project at path: ambari-server/docs/api/generated/swagger.json # swagger doc file in html format will be auto-generated and committed at path: ambari-server/docs/api/generated/index.html # ascidoc directory with md files will not be maintained # currently swagger spec file had some validation errors. these errors has been addressed. Diffs - ambari-server/docs/api/asciidoc/definitions.adoc 76beb8c ambari-server/docs/api/asciidoc/overview.adoc e9e5649 ambari-server/docs/api/asciidoc/paths.adoc d756051 ambari-server/docs/api/generated/index.html PRE-CREATION ambari-server/docs/api/generated/swagger.json PRE-CREATION ambari-server/pom.xml 618d21f ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupPrivilegeService.java 8a23885 ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupService.java ad9db28 ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/MemberService.java ec02511 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java 30714d4 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthorizationService.java e6fda46 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserPrivilegeService.java d6b4b29 ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java ad9c485 ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewDataMigrationService.java 388f454 ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java 9657c0e ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPermissionService.java cbc037b ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPrivilegeService.java e6d817f ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewService.java 1936d5b ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewVersionService.java ed6ddb1 Diff: https://reviews.apache.org/r/58051/diff/1/ Testing --- verified that the swagger spec file has no validation error. verified that html doc file is generated as expected. Thanks, Jaimin Jetly
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >= 1.3 to make use of ignore proxy feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57914/#review170118 --- This patch causes views unit tests to fail: [INFO] npm ERR! argv "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/src/main/resources/ui/node/node" "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/src/main/resources/ui/node/npm/bin/npm-cli.js" "install" "--python=\"/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/../src/main/unix/ambari-python-wrap\"" "--unsafe-perm" "--color=false" [INFO] npm ERR! node v4.5.0 [INFO] npm ERR! npm v2.15.0 [INFO] npm ERR! code ELIFECYCLE [INFO] npm ERR! files-view@0.0.0 preinstall: `chmod +x node/node_modules/npm/bin/node-gyp-bin/node-gyp` [INFO] npm ERR! Exit status 1 [INFO] npm ERR! [INFO] npm ERR! Failed at the files-view@0.0.0 preinstall script 'chmod +x node/node_modules/npm/bin/node-gyp-bin/node-gyp'. [INFO] npm ERR! This is most likely a problem with the files-view package, [INFO] npm ERR! not with npm itself. [INFO] npm ERR! Tell the author that this fails on your system: [INFO] npm ERR! chmod +x node/node_modules/npm/bin/node-gyp-bin/node-gyp [INFO] npm ERR! You can get information on how to open an issue for this project with: [INFO] npm ERR! npm bugs files-view [INFO] npm ERR! Or if that isn't available, you can get their info via: [INFO] npm ERR! [INFO] npm ERR! npm owner ls files-view [INFO] npm ERR! There is likely additional logging output above. [INFO] [INFO] npm ERR! Please include the following file with any support request: [INFO] npm ERR! /Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/contrib/views/files/src/main/resources/ui/npm-debug.log [INFO] [INFO] Reactor Summary: [INFO] [INFO] Ambari Contrib Views ... SUCCESS [01:07 min] [INFO] Ambari View Utils .. SUCCESS [ 13.821 s] [INFO] Ambari View Commons SUCCESS [ 0.505 s] [INFO] Files .. FAILURE [ 9.725 s] [INFO] Jobs ... SKIPPED [INFO] Pig .... SKIPPED - Jaimin Jetly On March 24, 2017, 5:25 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57914/ > --- > > (Updated March 24, 2017, 5:25 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20549 > https://issues.apache.org/jira/browse/AMBARI-20549 > > > Repository: ambari > > > Description > --- > > We have changed the path for node modules in pom.xml and package.json > accordingly > > > Diffs > - > > contrib/views/capacity-scheduler/pom.xml f89bb8e > contrib/views/files/src/main/resources/ui/package.json d15c5c9 > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2 > contrib/views/hive20/src/main/resources/ui/package.json 5c0da36 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json > 64b3270 > contrib/views/pig/pom.xml 7f0ade8 > > > Diff: https://reviews.apache.org/r/57914/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 57895: upgrade frontend-maven-plugin to latest >= 1.3 to make use of ignore proxy feature
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57895/
---
Review request for Ambari, Richard Zang, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-20549
https://issues.apache.org/jira/browse/AMBARI-20549
Repository: ambari
Description
---
frontend-maven-plugin inherits maven settings.xml proxy values, in latest
version >=1.3 proxy settings can be ignore by setting
'npmInheritsProxyConfigFromMaven' to 'false'
REF: https://github.com/eirslett/frontend-maven-plugin/pull/387
The following files contain the plugin
{noformat}
ambari-admin/pom.xml
ambari-web/pom.xml
contrib/views/capacity-scheduler/pom.xml
contrib/views/files/pom.xml
contrib/views/hawq/pom.xml
contrib/views/hive-next/pom.xml
contrib/views/hive20/pom.xml
contrib/views/hueambarimigration/pom.xml
contrib/views/jobs/pom.xml
contrib/views/pig/pom.xml
contrib/views/wfmanager/pom.xml
contrib/views/wfmanager/src/main/resources/ui/pom.xml
{noformat}
Diffs
-
ambari-admin/pom.xml 97d5fd4
ambari-web/pom.xml 6c84688
contrib/views/capacity-scheduler/pom.xml e18514c
contrib/views/files/pom.xml 663615a
contrib/views/hawq/pom.xml c62af56
contrib/views/hive-next/pom.xml fd85a50
contrib/views/hive20/pom.xml 0d97bbd
contrib/views/hueambarimigration/pom.xml 891876d
contrib/views/jobs/pom.xml 3475191
contrib/views/pig/pom.xml d7d2de9
contrib/views/wfmanager/pom.xml cc48ef2
contrib/views/wfmanager/src/main/resources/ui/pom.xml 8bdb332
Diff: https://reviews.apache.org/r/57895/diff/1/
Testing
---
verified that the build passes with the patch:
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main SUCCESS [ 53.095 s]
[INFO] Apache Ambari Project POM .. SUCCESS [ 0.012 s]
[INFO] Ambari Web . SUCCESS [02:33 min]
[INFO] Ambari Views ... SUCCESS [ 2.499 s]
[INFO] Ambari Admin View .. SUCCESS [ 52.879 s]
[INFO] utility SUCCESS [ 0.542 s]
[INFO] ambari-metrics . SUCCESS [ 0.462 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 4.866 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [ 2.993 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [ 1.739 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [ 4.900 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [ 5.139 s]
[INFO] Ambari Metrics Storm Sink (Legacy) . SUCCESS [ 3.180 s]
[INFO] Ambari Metrics Collector ... SUCCESS [ 56.026 s]
[INFO] Ambari Metrics Monitor . SUCCESS [ 12.811 s]
[INFO] Ambari Metrics Grafana . SUCCESS [ 6.838 s]
[INFO] Ambari Metrics Assembly SUCCESS [05:46 min]
[INFO] Ambari Server .. SUCCESS [08:29 min]
[INFO] Ambari Functional Tests SUCCESS [ 11.808 s]
[INFO] Ambari Agent ... SUCCESS [02:26 min]
[INFO] Ambari Client .. SUCCESS [ 0.099 s]
[INFO] Ambari Python Client ... SUCCESS [ 5.032 s]
[INFO] Ambari Groovy Client ... SUCCESS [ 5.661 s]
[INFO] Ambari Shell ... SUCCESS [ 0.022 s]
[INFO] Ambari Python Shell SUCCESS [ 0.993 s]
[INFO] Ambari Groovy Shell SUCCESS [ 3.024 s]
[INFO] ambari-logsearch ... SUCCESS [ 0.243 s]
[INFO] Ambari Logsearch Appender .. SUCCESS [ 0.257 s]
[INFO] Ambari Logsearch Portal SUCCESS [ 57.573 s]
[INFO] Ambari Logsearch Log Feeder SUCCESS [ 12.128 s]
[INFO] Ambari Logsearch Solr Client ... SUCCESS [ 4.540 s]
[INFO] Ambari Infra Solr Plugin ... SUCCESS [ 1.887 s]
[INFO] Ambari Logsearch Assembly .. SUCCESS [ 0.099 s]
[INFO] Ambari Logsearch Integration Test .. SUCCESS [ 6.255 s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 24:37 min
[INFO] Finished at: 2017-03-23T14:43:59-07:00
[INFO] Final Memory: 233M/658M
[INFO]
Thanks,
Jaimin Jetly
Re: Review Request 57858: Add Service wizard: "Configure Services" and "Configure identities" pages should be coincided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57858/#review169836 --- Ship it! Ship It! - Jaimin Jetly On March 22, 2017, 6:06 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57858/ > --- > > (Updated March 22, 2017, 6:06 p.m.) > > > Review request for Ambari, Andrii Babiichuk and Jaimin Jetly. > > > Bugs: AMBARI-20535 > https://issues.apache.org/jira/browse/AMBARI-20535 > > > Repository: ambari > > > Description > --- > > Instead of having two different steps for "Configure Services" and "Configure > Identities", we should have configuring identities properties overlaid on > "Configure Services" page. > > > Diffs > - > > ambari-web/app/controllers/main/admin/kerberos.js 762f4d0 > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js f23814c > ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 2f07e1f > ambari-web/app/controllers/main/service/add_controller.js 0989f76 > ambari-web/app/controllers/wizard.js 7af9ab0 > ambari-web/app/controllers/wizard/step7_controller.js 0207e6b > ambari-web/app/controllers/wizard/step8_controller.js efd8834 > ambari-web/app/mixins/wizard/addSecurityConfigs.js b5f3e6a > ambari-web/app/routes/add_kerberos_routes.js f556acb > ambari-web/app/routes/add_service_routes.js 9ff0b10 > ambari-web/app/templates/main/service/add.hbs 2873a87 > ambari-web/app/utils/ajax/ajax.js b63027e > ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js > 422ac26 > ambari-web/test/controllers/main/service/add_controller_test.js ffde1f7 > ambari-web/test/controllers/wizard/step7_test.js d5d157d > ambari-web/test/controllers/wizard/step8_test.js bdc4f4c > > > Diff: https://reviews.apache.org/r/57858/diff/1/ > > > Testing > --- > > 20604 passing (24s) > 128 pending > > > Thanks, > > Aleksandr Kovalenko > >
Re: Review Request 57834: Config is not shown on comparison mode if it doesn't exist in the latest version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57834/#review169759 --- Ship it! Ship It! - Jaimin Jetly On March 22, 2017, 9:46 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57834/ > --- > > (Updated March 22, 2017, 9:46 a.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Bugs: AMBARI-20526 > https://issues.apache.org/jira/browse/AMBARI-20526 > > > Repository: ambari > > > Description > --- > > * Add custom config and save configs > * Remove this custom config and save configs > * Compare this to config versions > > *ER* Config is shown as "Undefined" > *AR* Config is not shown > > > Diffs > - > > ambari-web/app/mixins/common/configs/configs_comparator.js e9fb942 > ambari-web/test/mappers/configs/service_config_version_mapper_test.js > d99864a > ambari-web/test/mappers/configs/themes_mapper_test.js b869109 > ambari-web/test/mixins/common/configs/configs_comparator_test.js dc7534c > > > Diff: https://reviews.apache.org/r/57834/diff/1/ > > > Testing > --- > > 20620 passing (21s) > 128 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57771: Unlimited Key JCE policy is enabled or not on each host
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57771/#review169757
---
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
Line 230 (original), 230 (patched)
<https://reviews.apache.org/r/57771/#comment242325>
How will user interface behave when jce policy is not required ?
Instead of host resource rest api exposing a boolean, does it makes sense
to have enum "INSTALLED", "NOT_INSTALLED" and "NOT_REQUIRED"?
- Jaimin Jetly
On March 22, 2017, 9:44 a.m., Attila Magyar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57771/
> ---
>
> (Updated March 22, 2017, 9:44 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Robert Levas, and
> Sebastian Toader.
>
>
> Bugs: AMBARI-20525
> https://issues.apache.org/jira/browse/AMBARI-20525
>
>
> Repository: ambari
>
>
> Description
> ---
>
> In many cases support engineers want to look at if Unlimited Strength Java
> Cryptography Extension is installed on all hosts quickly and easily.
>
> This information is now visible on the host summary page, and can be accessed
> via api call: /api/v1/hosts?fields=Hosts/last_agent_env.
>
>
> Diffs
> -
>
> ambari-agent/src/main/python/ambari_agent/HostInfo.py 7f041eb
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 67294e0
>
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
> a4e4f6e
> ambari-server/src/main/java/org/apache/ambari/server/agent/AgentEnv.java
> 64d0865
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> 20431f6
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
> 3c36962
>
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py
> 71161e0
>
> ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java
> 3f62366
> ambari-web/app/controllers/global/update_controller.js 59eaf3e
> ambari-web/app/mappers/hosts_mapper.js e4dd08f
> ambari-web/app/messages.js c9926e6
> ambari-web/app/models/host.js 1b7b326
> ambari-web/app/templates/main/host/summary.hbs 5d0b09c
>
>
> Diff: https://reviews.apache.org/r/57771/diff/2/
>
>
> Testing
> ---
>
> added new unittests, tested the UI manually
>
> existing tests ran successfully with one irrelevant exception:
>
> ==
> FAIL: test_get_params_from_filesystem
> (TestSecurityCommons.TestSecurityCommons)
> --
> Traceback (most recent call last):
> File
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
> line 1199, in patched
> return func(*args, **keywargs)
> File
> "/Users/amagyar/development/ambari/ambari-agent/src/test/python/resource_management/TestSecurityCommons.py",
> line 203, in test_get_params_from_filesystem
> et_parser_mock.assert_called_with(conf_dir + os.sep + "config.xml")
> File
> "/Users/amagyar/development/ambari/ambari-common/src/test/python/mock/mock.py",
> line 829, in assert_called_with
> raise AssertionError('Expected call: %s\nNot called' % (expected,))
> AssertionError: Expected call:
> parse('/var/folders/hp/5rnr2yx14q7csg8xbtp_mkr8gn/T/config.xml')
> Not called
>
> --
> Ran 465 tests in 16.659s
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 57813: Service quick links not showing up in the UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57813/#review169600 --- ambari-web/app/utils/ajax/ajax.js Line 3059 (original), 3060 (patched) <https://reviews.apache.org/r/57813/#comment242040> Although it does not have any impact in API response as of now but lets not append "fields" and "minimal_response" param in the data body also. ambari-web/app/utils/ajax/ajax.js Lines 3061-3063 (original), 3062-3066 (patched) <https://reviews.apache.org/r/57813/#comment242039> only if '' param is present in the url then lets append opt.url = '&_=' + App.datetime instead of '?_=' - Jaimin Jetly On March 21, 2017, 5:34 p.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57813/ > --- > > (Updated March 21, 2017, 5:34 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. > > > Bugs: AMBARI-20521 > https://issues.apache.org/jira/browse/AMBARI-20521 > > > Repository: ambari > > > Description > --- > > STR: > Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with > master components hosted on 64 separate hosts) > Navigate to any service on ambari-web that has quicklinks > Actual Result: Quick links are incorrectly absent > Expected Result: Quick links should be shown > > > Diffs > - > > ambari-web/app/utils/ajax/ajax.js b856e44 > ambari-web/test/utils/ajax/ajax_test.js 35de05f > > > Diff: https://reviews.apache.org/r/57813/diff/1/ > > > Testing > --- > > 30380 passing (38s) > 157 pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
> On March 16, 2017, 3:16 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/groupApi/GroupPrivilegeService.java > > Lines 19-26 (patched) > > <https://reviews.apache.org/r/57582/diff/2/?file=1664931#file1664931line19> > > > > Why do these classes need to be in a different package? > > > > This is an odd package name, should just be > > "org.apache.ambari.server.api.services.group" > > > > I don't think I've ever seen a camel-case package name. The package name issue has been addressed in the last revision of the patch - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57582/#review169161 ------- On March 20, 2017, 6:20 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57582/ > --- > > (Updated March 20, 2017, 6:20 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Oliver > Szabo, Robert Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20436 > https://issues.apache.org/jira/browse/AMBARI-20436 > > > Repository: ambari > > > Description > --- > > A separate branch is created for this work: ambari-rest-api-explorer > > ## As part of this task, following changes are done: > 1. Users, Groups and Views API are integrated with swagger and exposed from > ambari rest api explorer ui (swagger ui) on a deployed cluster at path: > http://c6404.ambari.apache.org:8080/api-docs > 2. swagger-maven-plugin is used to generate swagger.json file on compile > time. This file is published in web resources directory. Note that this file > is generated build time and will be available on deployed ambari-server host > at web resources location but it is not yet decided to be committed and > maintained in Ambari source code > 3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json > file (that can be shown as markdown in github). More information about this > format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This > generates files in docs/api/asciidoc/** location at build time. This > directory is currently intended to be committed and maintained in ambari > source code > 4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin > (adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to > ambari-web/api-docs directory with certain modification to make it work with > ambari api. Further ui polishing will be done in subsequent tasks. Also there > is a strong possibility to maintain the fork code of swagger-ui and compile > (minify and concanate) it during ambari compile time rather than directly > using swagger-ui dist files. Doing so will help developers when customization > done over swagger-ui will increase > 5. swagger-annotation expects application to define schema of request body > and response for each endpoint to be encapsulated in a class. While Ambari > follows this pattern for some of the endpoint, there are many others which > does not do so. For The ones which do not does so, new request and response > classes were defined. Going forward at the completion of this epic, either > each resource type or each resource provider should be coupled with a > resource response class and a resource request class. As part of this patch, > each resourceprovider worked upon introduces a new method "getResponse". At > completion of this epic ResourceProvider interface should also declare > methods like "getResponse" and "getRequest" that returns response schema and > request schema instances for the resource API endpoints > 6. Currently it seems that swagger has a limitation in supporting > "subresource locator methods". This issue is been reported to swagger > community and is being tracked at > [link|https://github.com/swagger-api/swagger-core/issues/2136]. As a result > of which currently as a temporary workaround, all subresources are converted > to root resources. Also all root resources on similar path are moved under > same subpackages (like userApi, groupApi and viewApi). > > > Diffs > - > > LICENSE.txt f05016f > ambari-server/docs/api/asciidoc/definitions.adoc PRE-CREATION > ambari-server/docs/api/asciidoc/overview.adoc PRE-CREATION > ambari-server/docs/api/ascii
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
> On March 15, 2017, 8:31 p.m., Oliver Szabo wrote: > > ambari-web/api-docs/index.html > > Lines 1 (patched) > > <https://reviews.apache.org/r/57582/diff/2/?file=1665007#file1665007line1> > > > > Instead of storing all of html + css files from swagger in the source > > code, I think its better idea to use swagger ui webjar: > > > > https://mvnrepository.com/artifact/org.webjars/swagger-ui (i think the > > exact swagger-ui version is not there that you used, but newer one can work) > > > > I used that for Log Search. (you can unpack that during the build or > > use resource files from the jar somehow else) > > > > If you will need any custom files you can override those files during > > the build. In Log Search i needed a specific index.html which supports > > basic authentication instead of api key, so i changed the index.html > > (https://github.com/apache/ambari/blob/trunk/ambari-logsearch/ambari-logsearch-portal/src/main/resources/swagger/swagger.html), > > but for every other file is used from the webjar, so i did not need to > > store swagger html+css in the source code. > > Oliver Szabo wrote: > additon: you can drop my issue, if for using the modified swagger-ui, its > not enough just include the some new files (extra css files etc.) from > https://github.com/jensoleg/swagger-ui Since ambari-web using custom look on top of swagger-ui, ambari-web will need to maintain it's override of html+css file. But swagger-ui JS code is something we want to use from https://www.npmjs.com/package/swagger-ui. There is an existing task (https://issues.apache.org/jira/browse/AMBARI-20508) to do analysis on how much of the code we can use from the vendor library instead of maintaining all in ambari-web source code. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57582/#review169051 --- On March 20, 2017, 6:20 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57582/ > --- > > (Updated March 20, 2017, 6:20 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Oliver > Szabo, Robert Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20436 > https://issues.apache.org/jira/browse/AMBARI-20436 > > > Repository: ambari > > > Description > --- > > A separate branch is created for this work: ambari-rest-api-explorer > > ## As part of this task, following changes are done: > 1. Users, Groups and Views API are integrated with swagger and exposed from > ambari rest api explorer ui (swagger ui) on a deployed cluster at path: > http://c6404.ambari.apache.org:8080/api-docs > 2. swagger-maven-plugin is used to generate swagger.json file on compile > time. This file is published in web resources directory. Note that this file > is generated build time and will be available on deployed ambari-server host > at web resources location but it is not yet decided to be committed and > maintained in Ambari source code > 3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json > file (that can be shown as markdown in github). More information about this > format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This > generates files in docs/api/asciidoc/** location at build time. This > directory is currently intended to be committed and maintained in ambari > source code > 4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin > (adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to > ambari-web/api-docs directory with certain modification to make it work with > ambari api. Further ui polishing will be done in subsequent tasks. Also there > is a strong possibility to maintain the fork code of swagger-ui and compile > (minify and concanate) it during ambari compile time rather than directly > using swagger-ui dist files. Doing so will help developers when customization > done over swagger-ui will increase > 5. swagger-annotation expects application to define schema of request body > and response for each endpoint to be encapsulated in a class. While Ambari > follows this pattern for some of the endpoint, there are many others which > does not do so. For The ones which do not does so, new request and response > classes were defined. Going forward at the completion
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
va/org/apache/ambari/server/api/services/ViewExternalSubResourceServiceTest.java 155f91e ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewPermissionServiceTest.java 7f58fb2 ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java 9499466 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java ebe92e4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 5092db5 ambari-web/api-docs/css/api-explorer.css PRE-CREATION ambari-web/api-docs/css/index.css PRE-CREATION ambari-web/api-docs/css/print.css PRE-CREATION ambari-web/api-docs/css/reset.css PRE-CREATION ambari-web/api-docs/css/screen.css PRE-CREATION ambari-web/api-docs/css/standalone.css PRE-CREATION ambari-web/api-docs/css/typography.css PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff2 PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff2 PRE-CREATION ambari-web/api-docs/images/Swagger_explorer.png PRE-CREATION ambari-web/api-docs/images/Swagger_explorer_min.png PRE-CREATION ambari-web/api-docs/images/explorer_icons.png PRE-CREATION ambari-web/api-docs/images/favicon-16x16.png PRE-CREATION ambari-web/api-docs/images/favicon-32x32.png PRE-CREATION ambari-web/api-docs/images/favicon.ico PRE-CREATION ambari-web/api-docs/images/json_editor_integration.png PRE-CREATION ambari-web/api-docs/images/logo_small.png PRE-CREATION ambari-web/api-docs/images/pet_store_api.png PRE-CREATION ambari-web/api-docs/images/senodio.png PRE-CREATION ambari-web/api-docs/images/throbber.gif PRE-CREATION ambari-web/api-docs/images/wordnik_api.png PRE-CREATION ambari-web/api-docs/index.html PRE-CREATION ambari-web/api-docs/lib/backbone-min.js PRE-CREATION ambari-web/api-docs/lib/bootstrap.min.js PRE-CREATION ambari-web/api-docs/lib/handlebars-2.0.0.js PRE-CREATION ambari-web/api-docs/lib/highlight.7.3.pack.js PRE-CREATION ambari-web/api-docs/lib/jquery-1.8.0.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.ba-bbq.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.slideto.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.wiggle.min.js PRE-CREATION ambari-web/api-docs/lib/jsoneditor.js PRE-CREATION ambari-web/api-docs/lib/marked.js PRE-CREATION ambari-web/api-docs/lib/swagger-oauth.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.map PRE-CREATION ambari-web/api-docs/o2c.html PRE-CREATION ambari-web/api-docs/swagger-ui.js PRE-CREATION ambari-web/api-docs/swagger-ui.min.js PRE-CREATION ambari-web/brunch-config.js 31eb1cb ambari-web/pom.xml 2d567cc Diff: https://reviews.apache.org/r/57582/diff/3/ Changes: https://reviews.apache.org/r/57582/diff/2-3/ Testing --- Tested on dev environment for all integrated apis to be working from ui interface Verified that Rat check, style check and existing ambari-server unit tests are passing with the patch Thanks, Jaimin Jetly
Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/#review169207 --- Ship it! If there is no UX impact and patch has been tested to work e2e then please commit it. - Jaimin Jetly On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57507/ > --- > > (Updated March 16, 2017, 12:49 p.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Bugs: ambari-20388 > https://issues.apache.org/jira/browse/ambari-20388 > > > Repository: ambari > > > Description > --- > > - Create a custom config group for a service > - Update few properties and save to get a version for this custom group > - Add another property and save just to generate more config version > - Compare these 2 versions. Usually diff shows only the values from compared > versions > - But looks like it shows the current value and the values in each version as > well. > - In default group we dont see that extra line with the current value. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js 786c6f9 > ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4 > ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 > ambari-web/app/views/common/controls_view.js 4bd4a61 > > > Diff: https://reviews.apache.org/r/57507/diff/2/ > > > Testing > --- > > 20559 passing (23s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/#review169206 --- ambari-web/app/mixins/common/configs/configs_comparator.js Lines 290-295 (original), 290-297 (patched) <https://reviews.apache.org/r/57507/#comment241545> will this have any UX impact ? - Jaimin Jetly On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57507/ > --- > > (Updated March 16, 2017, 12:49 p.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Bugs: ambari-20388 > https://issues.apache.org/jira/browse/ambari-20388 > > > Repository: ambari > > > Description > --- > > - Create a custom config group for a service > - Update few properties and save to get a version for this custom group > - Add another property and save just to generate more config version > - Compare these 2 versions. Usually diff shows only the values from compared > versions > - But looks like it shows the current value and the values in each version as > well. > - In default group we dont see that extra line with the current value. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js 786c6f9 > ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4 > ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 > ambari-web/app/views/common/controls_view.js 4bd4a61 > > > Diff: https://reviews.apache.org/r/57507/diff/2/ > > > Testing > --- > > 20559 passing (23s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 57669: Ambari build fails at Files view
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57669/
---
Review request for Ambari, Sumit Mohanty and Yusaku Sako.
Bugs: AMBARI-20470
https://issues.apache.org/jira/browse/AMBARI-20470
Repository: ambari
Description
---
Files view fails with below error:
/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/gerrit/gerrit-ambari/contrib/views/files/src/main/resources/ui/node_modules/async-disk-cache/node_modules/username/index.js:2
const os = require('os');
^
Use of const in strict mode.
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object.
(/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/gerrit/gerrit-ambari/contrib/views/files/src/main/resources/ui/node_modules/async-disk-cache/index.js:24:16)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
Diffs
-
contrib/views/files/src/main/resources/ui/package.json d15c5c9
Diff: https://reviews.apache.org/r/57669/diff/1/
Testing
---
Verified that the patch fixes the issue and builds Files view project
successfully. Also build other ambari ui projects and verified that others are
not impacted with this issue
Thanks,
Jaimin Jetly
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
> On March 14, 2017, 7:46 p.m., Sid Wagle wrote: > > ambari-server/pom.xml > > Lines 1628 (patched) > > <https://reviews.apache.org/r/57582/diff/1/?file=1663087#file1663087line1628> > > > > Is this specific impl a required dep? We probably should shade some > > specific deps, I know we are not doing that currently in ambari. No. I have removed that dependency in the 2nd revision of the patch - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57582/#review168931 --- On March 14, 2017, 11:35 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57582/ > --- > > (Updated March 14, 2017, 11:35 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert > Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-20436 > https://issues.apache.org/jira/browse/AMBARI-20436 > > > Repository: ambari > > > Description > --- > > A separate branch is created for this work: ambari-rest-api-explorer > > ## As part of this task, following changes are done: > 1. Users, Groups and Views API are integrated with swagger and exposed from > ambari rest api explorer ui (swagger ui) on a deployed cluster at path: > http://c6404.ambari.apache.org:8080/api-docs > 2. swagger-maven-plugin is used to generate swagger.json file on compile > time. This file is published in web resources directory. Note that this file > is generated build time and will be available on deployed ambari-server host > at web resources location but it is not yet decided to be committed and > maintained in Ambari source code > 3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json > file (that can be shown as markdown in github). More information about this > format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This > generates files in docs/api/asciidoc/** location at build time. This > directory is currently intended to be committed and maintained in ambari > source code > 4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin > (adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to > ambari-web/api-docs directory with certain modification to make it work with > ambari api. Further ui polishing will be done in subsequent tasks. Also there > is a strong possibility to maintain the fork code of swagger-ui and compile > (minify and concanate) it during ambari compile time rather than directly > using swagger-ui dist files. Doing so will help developers when customization > done over swagger-ui will increase > 5. swagger-annotation expects application to define schema of request body > and response for each endpoint to be encapsulated in a class. While Ambari > follows this pattern for some of the endpoint, there are many others which > does not do so. For The ones which do not does so, new request and response > classes were defined. Going forward at the completion of this epic, either > each resource type or each resource provider should be coupled with a > resource response class and a resource request class. As part of this patch, > each resourceprovider worked upon introduces a new method "getResponse". At > completion of this epic ResourceProvider interface should also declare > methods like "getResponse" and "getRequest" that returns response schema and > request schema instances for the resource API endpoints > 6. Currently it seems that swagger has a limitation in supporting > "subresource locator methods". This issue is been reported to swagger > community and is being tracked at > [link|https://github.com/swagger-api/swagger-core/issues/2136]. As a result > of which currently as a temporary workaround, all subresources are converted > to root resources. Also all root resources on similar path are moved under > same subpackages (like userApi, groupApi and viewApi). > > > Diffs > - > > LICENSE.txt f05016f > ambari-server/docs/api/asciidoc/definitions.adoc PRE-CREATION > ambari-server/docs/api/asciidoc/overview.adoc PRE-CREATION > ambari-server/docs/api/asciidoc/paths.adoc PRE-CREATION > ambari-server/pom.xml f0c73e4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ActiveWidgetLayoutService.java > 40cd6e0 > > ambari-server/src/main/java/o
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
va/org/apache/ambari/server/api/services/ViewExternalSubResourceServiceTest.java 155f91e ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewPermissionServiceTest.java 7f58fb2 ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java 9499466 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java ebe92e4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 5092db5 ambari-web/api-docs/css/api-explorer.css PRE-CREATION ambari-web/api-docs/css/index.css PRE-CREATION ambari-web/api-docs/css/print.css PRE-CREATION ambari-web/api-docs/css/reset.css PRE-CREATION ambari-web/api-docs/css/screen.css PRE-CREATION ambari-web/api-docs/css/standalone.css PRE-CREATION ambari-web/api-docs/css/typography.css PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff2 PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff2 PRE-CREATION ambari-web/api-docs/images/Swagger_explorer.png PRE-CREATION ambari-web/api-docs/images/Swagger_explorer_min.png PRE-CREATION ambari-web/api-docs/images/explorer_icons.png PRE-CREATION ambari-web/api-docs/images/favicon-16x16.png PRE-CREATION ambari-web/api-docs/images/favicon-32x32.png PRE-CREATION ambari-web/api-docs/images/favicon.ico PRE-CREATION ambari-web/api-docs/images/json_editor_integration.png PRE-CREATION ambari-web/api-docs/images/logo_small.png PRE-CREATION ambari-web/api-docs/images/pet_store_api.png PRE-CREATION ambari-web/api-docs/images/senodio.png PRE-CREATION ambari-web/api-docs/images/throbber.gif PRE-CREATION ambari-web/api-docs/images/wordnik_api.png PRE-CREATION ambari-web/api-docs/index.html PRE-CREATION ambari-web/api-docs/lib/backbone-min.js PRE-CREATION ambari-web/api-docs/lib/bootstrap.min.js PRE-CREATION ambari-web/api-docs/lib/handlebars-2.0.0.js PRE-CREATION ambari-web/api-docs/lib/highlight.7.3.pack.js PRE-CREATION ambari-web/api-docs/lib/jquery-1.8.0.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.ba-bbq.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.slideto.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.wiggle.min.js PRE-CREATION ambari-web/api-docs/lib/jsoneditor.js PRE-CREATION ambari-web/api-docs/lib/marked.js PRE-CREATION ambari-web/api-docs/lib/swagger-oauth.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.map PRE-CREATION ambari-web/api-docs/o2c.html PRE-CREATION ambari-web/api-docs/swagger-ui.js PRE-CREATION ambari-web/api-docs/swagger-ui.min.js PRE-CREATION ambari-web/brunch-config.js 31eb1cb Diff: https://reviews.apache.org/r/57582/diff/2/ Changes: https://reviews.apache.org/r/57582/diff/1-2/ Testing --- Tested on dev environment for all integrated apis to be working from ui interface Verified that Rat check, style check and existing ambari-server unit tests are passing with the patch Thanks, Jaimin Jetly
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
va/org/apache/ambari/server/api/services/ViewPermissionServiceTest.java 7f58fb2 ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java 9499466 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java ebe92e4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 5092db5 ambari-web/api-docs/css/api-explorer.css PRE-CREATION ambari-web/api-docs/css/index.css PRE-CREATION ambari-web/api-docs/css/print.css PRE-CREATION ambari-web/api-docs/css/reset.css PRE-CREATION ambari-web/api-docs/css/screen.css PRE-CREATION ambari-web/api-docs/css/standalone.css PRE-CREATION ambari-web/api-docs/css/typography.css PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff2 PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff2 PRE-CREATION ambari-web/api-docs/images/Swagger_explorer.png PRE-CREATION ambari-web/api-docs/images/Swagger_explorer_min.png PRE-CREATION ambari-web/api-docs/images/explorer_icons.png PRE-CREATION ambari-web/api-docs/images/favicon-16x16.png PRE-CREATION ambari-web/api-docs/images/favicon-32x32.png PRE-CREATION ambari-web/api-docs/images/favicon.ico PRE-CREATION ambari-web/api-docs/images/json_editor_integration.png PRE-CREATION ambari-web/api-docs/images/logo_small.png PRE-CREATION ambari-web/api-docs/images/pet_store_api.png PRE-CREATION ambari-web/api-docs/images/senodio.png PRE-CREATION ambari-web/api-docs/images/throbber.gif PRE-CREATION ambari-web/api-docs/images/wordnik_api.png PRE-CREATION ambari-web/api-docs/index.html PRE-CREATION ambari-web/api-docs/lib/backbone-min.js PRE-CREATION ambari-web/api-docs/lib/bootstrap.min.js PRE-CREATION ambari-web/api-docs/lib/handlebars-2.0.0.js PRE-CREATION ambari-web/api-docs/lib/highlight.7.3.pack.js PRE-CREATION ambari-web/api-docs/lib/jquery-1.8.0.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.ba-bbq.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.slideto.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.wiggle.min.js PRE-CREATION ambari-web/api-docs/lib/jsoneditor.js PRE-CREATION ambari-web/api-docs/lib/marked.js PRE-CREATION ambari-web/api-docs/lib/swagger-oauth.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.map PRE-CREATION ambari-web/api-docs/o2c.html PRE-CREATION ambari-web/api-docs/swagger-ui.js PRE-CREATION ambari-web/api-docs/swagger-ui.min.js PRE-CREATION ambari-web/brunch-config.js 31eb1cb Diff: https://reviews.apache.org/r/57582/diff/1/ Testing --- Tested on dev environment for all integrated apis to be working from ui interface Verified that Rat check, style check and existing ambari-server unit tests are passing with the patch Thanks, Jaimin Jetly
Re: Review Request 57582: Create a prototype of ambari-server swagger integration
/ViewPermissionServiceTest.java 7f58fb2 ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewSubResourceServiceTest.java 9499466 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java ebe92e4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 5092db5 ambari-web/api-docs/css/api-explorer.css PRE-CREATION ambari-web/api-docs/css/index.css PRE-CREATION ambari-web/api-docs/css/print.css PRE-CREATION ambari-web/api-docs/css/reset.css PRE-CREATION ambari-web/api-docs/css/screen.css PRE-CREATION ambari-web/api-docs/css/standalone.css PRE-CREATION ambari-web/api-docs/css/typography.css PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff2 PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff2 PRE-CREATION ambari-web/api-docs/images/Swagger_explorer.png PRE-CREATION ambari-web/api-docs/images/Swagger_explorer_min.png PRE-CREATION ambari-web/api-docs/images/explorer_icons.png PRE-CREATION ambari-web/api-docs/images/favicon-16x16.png PRE-CREATION ambari-web/api-docs/images/favicon-32x32.png PRE-CREATION ambari-web/api-docs/images/favicon.ico PRE-CREATION ambari-web/api-docs/images/json_editor_integration.png PRE-CREATION ambari-web/api-docs/images/logo_small.png PRE-CREATION ambari-web/api-docs/images/pet_store_api.png PRE-CREATION ambari-web/api-docs/images/senodio.png PRE-CREATION ambari-web/api-docs/images/throbber.gif PRE-CREATION ambari-web/api-docs/images/wordnik_api.png PRE-CREATION ambari-web/api-docs/index.html PRE-CREATION ambari-web/api-docs/lib/backbone-min.js PRE-CREATION ambari-web/api-docs/lib/bootstrap.min.js PRE-CREATION ambari-web/api-docs/lib/handlebars-2.0.0.js PRE-CREATION ambari-web/api-docs/lib/highlight.7.3.pack.js PRE-CREATION ambari-web/api-docs/lib/jquery-1.8.0.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.ba-bbq.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.slideto.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.wiggle.min.js PRE-CREATION ambari-web/api-docs/lib/jsoneditor.js PRE-CREATION ambari-web/api-docs/lib/marked.js PRE-CREATION ambari-web/api-docs/lib/swagger-oauth.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.map PRE-CREATION ambari-web/api-docs/o2c.html PRE-CREATION ambari-web/api-docs/swagger-ui.js PRE-CREATION ambari-web/api-docs/swagger-ui.min.js PRE-CREATION ambari-web/brunch-config.js 31eb1cb Diff: https://reviews.apache.org/r/57582/diff/1/ Testing --- Tested on dev environment for all integrated apis to be working from ui interface Verified that Rat check, style check and existing ambari-server unit tests are passing with the patch Thanks, Jaimin Jetly
Review Request 57582: Create a prototype of ambari-server swagger integration
r/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java ebe92e4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 5092db5 ambari-web/api-docs/css/api-explorer.css PRE-CREATION ambari-web/api-docs/css/index.css PRE-CREATION ambari-web/api-docs/css/print.css PRE-CREATION ambari-web/api-docs/css/reset.css PRE-CREATION ambari-web/api-docs/css/screen.css PRE-CREATION ambari-web/api-docs/css/standalone.css PRE-CREATION ambari-web/api-docs/css/typography.css PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-700.woff2 PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.eot PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.svg PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.ttf PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff PRE-CREATION ambari-web/api-docs/fonts/droid-sans-v6-latin-regular.woff2 PRE-CREATION ambari-web/api-docs/images/Swagger_explorer.png PRE-CREATION ambari-web/api-docs/images/Swagger_explorer_min.png PRE-CREATION ambari-web/api-docs/images/explorer_icons.png PRE-CREATION ambari-web/api-docs/images/favicon-16x16.png PRE-CREATION ambari-web/api-docs/images/favicon-32x32.png PRE-CREATION ambari-web/api-docs/images/favicon.ico PRE-CREATION ambari-web/api-docs/images/json_editor_integration.png PRE-CREATION ambari-web/api-docs/images/logo_small.png PRE-CREATION ambari-web/api-docs/images/pet_store_api.png PRE-CREATION ambari-web/api-docs/images/senodio.png PRE-CREATION ambari-web/api-docs/images/throbber.gif PRE-CREATION ambari-web/api-docs/images/wordnik_api.png PRE-CREATION ambari-web/api-docs/index.html PRE-CREATION ambari-web/api-docs/lib/backbone-min.js PRE-CREATION ambari-web/api-docs/lib/bootstrap.min.js PRE-CREATION ambari-web/api-docs/lib/handlebars-2.0.0.js PRE-CREATION ambari-web/api-docs/lib/highlight.7.3.pack.js PRE-CREATION ambari-web/api-docs/lib/jquery-1.8.0.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.ba-bbq.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.slideto.min.js PRE-CREATION ambari-web/api-docs/lib/jquery.wiggle.min.js PRE-CREATION ambari-web/api-docs/lib/jsoneditor.js PRE-CREATION ambari-web/api-docs/lib/marked.js PRE-CREATION ambari-web/api-docs/lib/swagger-oauth.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.js PRE-CREATION ambari-web/api-docs/lib/underscore-min.map PRE-CREATION ambari-web/api-docs/o2c.html PRE-CREATION ambari-web/api-docs/swagger-ui.js PRE-CREATION ambari-web/api-docs/swagger-ui.min.js PRE-CREATION ambari-web/brunch-config.js 31eb1cb Diff: https://reviews.apache.org/r/57582/diff/1/ Testing --- Tested on dev environment for all integrated apis to be working from ui interface Verified that Rat check, style check and existing ambari-server unit tests are passing with the patch Thanks, Jaimin Jetly
Review Request 57577: ambari-web shows redundant configuration for "Number of nodes used by Hive's LLAP"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57577/ --- Review request for Ambari, Oleg Nechiporenko, Swapan Shridhar, and Yusaku Sako. Bugs: AMBARI-20432 https://issues.apache.org/jira/browse/AMBARI-20432 Repository: ambari Description --- *STR:* When the queue selected for LLAP not being managed by SA is saved, on navigating to Hive smart config page, "Number of nodes used by Hive's LLAP" shows both textbox and slider. This is because the observer for LLAP widget is not fired for the first time when readonly is true to begin with. Diffs - ambari-web/app/mixins/common/configs/widgets/unique/num_llap_nodes.js 781a40a Diff: https://reviews.apache.org/r/57577/diff/1/ Testing --- Tested the patch on a repro cluster. veified that all ambari-web unit tests passes: 30367 passing (21s) 157 pending Thanks, Jaimin Jetly
Re: Review Request 57567: Hive Server interactive not removed from Hive summary page after HSI is disabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57567/#review168824 --- Ship it! Ship It! - Jaimin Jetly On March 13, 2017, 7:20 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57567/ > --- > > (Updated March 13, 2017, 7:20 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-20426 > https://issues.apache.org/jira/browse/AMBARI-20426 > > > Repository: ambari > > > Description > --- > > Hive Server interactive not removed from Hive summary page even after HSI is > disabled. > Strange Fact : HSI is started without any error when did a restart all stale > components even though HSI is disabled > > > Diffs > - > > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > b01c784 > > > Diff: https://reviews.apache.org/r/57567/diff/1/ > > > Testing > --- > > Verified Manually. > > Ambari-web unit tests pass. > 30367 passing (20s) > 157 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 57526: Side Nav: several issues tested on IE 11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57526/#review168695 --- Ship it! Ship It! - Jaimin Jetly On March 11, 2017, 12:48 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57526/ > --- > > (Updated March 11, 2017, 12:48 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-20405 > https://issues.apache.org/jira/browse/AMBARI-20405 > > > Repository: ambari > > > Description > --- > > CSS: > 1. Active item should have a green triangle at left. Now there was no active > effect for menu items except for Admin's submenu. > 2. Hovering on Services, service actions icon is invisible. Cannot trigger > any service actions. > 3. The scrollbar was too prominent, should hide scrollbar on every browser. > > JS: > 4. Click on Services/Admin menu, no collapse effect. And will go to > Service/Admin page. > 5. Click on "<<" at the footer, no collapse effect. Cannot collapse side navi > menu. > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9 > ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f > > > Diff: https://reviews.apache.org/r/57526/diff/1/ > > > Testing > --- > > 20559 passing (27s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/#review167925 --- ambari-web/app/models/configs/theme/sub_section_tab.js Line 84 (original), 84-87 (patched) <https://reviews.apache.org/r/57268/#comment239918> Whats the reason behind making this computed property volatile ? - Jaimin Jetly On March 3, 2017, 7:34 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57268/ > --- > > (Updated March 3, 2017, 7:34 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20287 > https://issues.apache.org/jira/browse/AMBARI-20287 > > > Repository: ambari > > > Description > --- > > Take subSectionTab into consideration on show/hide > > > Diffs > - > > ambari-web/app/models/configs/theme/sub_section.js 7274569 > ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 466a88d > ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c > > > Diff: https://reviews.apache.org/r/57268/diff/1/ > > > Testing > --- > > Manully tested on live cluster. All unit tests passed. > 20560 passing (25s) > 153 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/#review167136 --- Ship it! Ship It! - Jaimin Jetly On Feb. 28, 2017, 7:44 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57062/ > --- > > (Updated Feb. 28, 2017, 7:44 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20194 > https://issues.apache.org/jira/browse/AMBARI-20194 > > > Repository: ambari > > > Description > --- > > Enabled manage alert notification option based on user's privileges > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > f37876f > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > 9b5442d > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5d81281 > > Diff: https://reviews.apache.org/r/57062/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/#review166985 --- Ship it! Ship It! - Jaimin Jetly On Feb. 25, 2017, 4:34 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57062/ > --- > > (Updated Feb. 25, 2017, 4:34 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20194 > https://issues.apache.org/jira/browse/AMBARI-20194 > > > Repository: ambari > > > Description > --- > > Enabled manage alert notification option based on user's privileges > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > a397b7b > > Diff: https://reviews.apache.org/r/57062/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for admin user after upgrading to ambari 2.4.2 or above
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166629
---
ambari-web/app/controllers/experimental.js (line 38)
<https://reviews.apache.org/r/57004/#comment238630>
$.merge(response, App.get('supports')) returns back the first argument
passed. As a result the application behavior remains the same as it was before
this patch
Please use $.extend instead of $.merge.
- Jaimin Jetly
On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> ---
>
> (Updated Feb. 23, 2017, 11:52 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
>
>
> Diffs
> -
>
> ambari-web/app/config.js 6afa810
> ambari-web/app/controllers/experimental.js 8b93761
> ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
>
> Diff: https://reviews.apache.org/r/57004/diff/
>
>
> Testing
> ---
>
> Manually tested on live cluster.
> All unit tests passed.
> 20375 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 55817: AMBARI-19618 Make cohosted components configurable in metainfo.xml instead of hardcoding in UI
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55817/#review166433
---
We already hasve the stack way to co-host a component. In 3.0.0, we have
committed a patch by which you can enforce a slave/master component to be
co-hosted with another slave/master component. There are snapshots of how UI
will behave on the reviewboard. Link: https://reviews.apache.org/r/55865/
There is another open ticket that have created to recommend the layout as per
the dependency mentioned in stack definition:
https://issues.apache.org/jira/browse/AMBARI-20122
I believ we should rather leverage stack advisor for the recommendation and
validation purpose of any stack defined dependency.
Even the existing single case of Hive/WebHCat which is a legacy code should be
refactored to remove it's hard-coded occurrnece from UI. All we need to do is
add in hive stack:
Add to node of HIVE_SERVER:
HIVE/WEBHCAT_SERVER
host
This will then use stack advisor logic committed as part of
https://issues.apache.org/jira/browse/AMBARI-19685. Further enhancement of
making sure both the component and host scope depencdency by default appears on
the same host can be achieved by addressing
https://issues.apache.org/jira/browse/AMBARI-20122
- Jaimin Jetly
On Feb. 22, 2017, 1:52 a.m., yao lei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55817/
> ---
>
> (Updated Feb. 22, 2017, 1:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Di Li, Jaimin Jetly, Jayush
> Luniya, Zhe (Joe) Wang, and Matt.
>
>
> Bugs: AMBARI-19618
> https://issues.apache.org/jira/browse/AMBARI-19618
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Cohosted components information now is hardcoded in
> stack_service_component.js as following:
>
> App.StackServiceComponent.coHost =
>{ 'WEBHCAT_SERVER': 'HIVE_SERVER' };
>
> It's better to move them from javascript to metainfom.xml by adding tag
> in stack like following:
>
> //HIVE
>
> WEBHCAT_SERVER
> WebHCat Server
> MASTER
> 1
> true
> true
> HIVE_SERVER
>
>
> //RANGER https://issues.apache.org/jira/browse/AMBARI-19557
>
> RANGER_USERSYNC
> Ranger Usersync
> MASTER
> 1
> true
> RANGER_ADMIN
>
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
> 2f42313
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
> c731641
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
> 51d9847
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java
> 409bcae
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml
> 4ba3cf1
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml
> a9db470
> ambari-server/src/main/resources/properties.json 72104a9
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> 89f9d94
>
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
> 6e37ded
>
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
> 87a1fc7
>
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml
> 3224eac
>
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/RANGER/metainfo.xml
> PRE-CREATION
>
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml
> edc5dfb
>
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/RANGER/metainfo.xml
> PRE-CREATION
> ambari-web/app/mappers/stack_service_mapper.js 4bda89d
> ambari-web/app/models/stack_service_component.js eb6f2db
> ambari-web/test/mappers/stack_service_mapper_test.js 9da8b24
> ambari-web/test/service_components.js bcc4a29
>
> Diff: https://reviews.apache.org/r/55817/diff/
>
>
> Testing
> ---
>
> 1.Ambari Web Unit Tests:
> 20307 passing (35s)
> 153 pending
>
> 2.Ambari Server Unit Tests:
> Failed tests:
> ViewRegistryTest.testReadViewArchives:239->testReadViewArchives:466
> expected: but was:
>
> ViewRegistryTest.testReadViewArchives_removeUndeployed:244->testReadViewArchives:466
> expected: but was:
>
> ViewRegistryTest.testReadViewArchives_viewAutoInstanceCreation:254->testReadViewArchives:466
> expected: but was:
> Tests run: 4417, Failures: 3, Errors: 0, Skipped: 30
>
> 3.Installed a cluster using RPM based on latest trunk codes and screenshots
> attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the
> expected result.
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 56597: Externalize the logic for making navigation bar interactive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56597/#review165592 --- Ship it! Ship It! - Jaimin Jetly On Feb. 13, 2017, 11:50 a.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56597/ > --- > > (Updated Feb. 13, 2017, 11:50 a.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Bugs: AMBARI-19983 > https://issues.apache.org/jira/browse/AMBARI-19983 > > > Repository: ambari > > > Description > --- > > Externalize the logic for making navigation bar interactive > > > Diffs > - > > ambari-web/app/assets/data/clusters/info.json PRE-CREATION > ambari-web/app/styles/side_navigation.less 48b8699 > ambari-web/app/styles/theme/bootstrap-ambari.css adbddcd > ambari-web/app/templates/application.hbs f18d314 > ambari-web/app/templates/main/side-menu-item.hbs 27739c8 > ambari-web/app/views/application.js f79aad9 > ambari-web/app/views/main/menu.js d82d56a > ambari-web/brunch-config.js d646fdc > ambari-web/vendor/scripts/theme/bootstrap-ambari.js PRE-CREATION > > Diff: https://reviews.apache.org/r/56597/diff/ > > > Testing > --- > > 20325 passing (22s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Re: Review Request 53686: Stage and Request status should be persisted in the database
> On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 445-447 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584761#file1584761line445> > > > > This could be problematic if the merge fails when the transaction > > commits. You've already fired the event. > > Jaimin Jetly wrote: > persistAction method has been annotated with @Transactional and > @TransactionalLock. > I believe if the publisher method is marked to be transactional then the > event listener will also fall in that transactional boundary considering that > the eventbus being used over here is default which I believe is synchronous. > > I will verify this myself by checking that publsiher method, eventbus and > subscriber method are running on same thread. > > Jaimin Jetly wrote: > I verified that the publisher and subscriber code runs on same thread and > so transactional boundary will extend for the entire logic making sure that > tasks and respective stage/request are consistent in their status > > Jonathan Hurley wrote: > Although it may be true that the event bus is synchronous here, the point > is that the merge() which comes before it doesn't necessarily count until the > entire transaction is committed. By firing the event in this code, you're > assuming that the merge() will succeed once the batches operations are > flushed and the transaction is commited. If the listener modifies any sort of > in-memory state, then this causes a data integrity problem. Thats true. The in-memory state can become inconsistent in that case. Meaning in-memory state of the listener can have most updated status data but DB that failed to merge can have stale status data. Although all data in the DB even though stale is consistent even at this point of time. Now listener will again try to update DB on next heratbeat and will get consistent with DB when merge happens next time. > On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > lines 282-287 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584766#file1584766line282> > > > > Would this count states like FAILED / TIMEDOUT twice? > > Jaimin Jetly wrote: > yes. It will increment the FAILED counter and also increment COMPLETED > counter which is desired. > > Jonathan Hurley wrote: > Why is this desired? Double counting them doesn't seem right. The COMPLETED key is represents any completed state hrc.getStatus().isCompletedState() and thats how it's used in subsequent function. So on getting FAILED state we are incrementing both completed and Failed This code is a copy of existing code logic: https://github.com/apache/ambari/blob/release-2.4.2/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java#L235-L240 On Dec. 15, 2016, 4:49 p.m., Jaimin Jetly wrote: > > One thing I don't quite see here (and it could be due to the size of the > > patch) is what happens in these two cases: > > - Something goes wrong when trying to store a task's status. How does the > > system recover and mark it completed? > > - What about waiting until a request is HOLDING and then restarting Ambari > > - will the relevent maps get re-populated? > > Jaimin Jetly wrote: > >> - Something goes wrong when trying to store a task's status. How does > the system recover and mark it completed? > > This work only adds logic to add/update stage and request status. The way > task status is being updated or the logic for system to recover from anything > that goes wrong when storing task status is not changed. > This work ensures that task status update, respective stage status update > and respective request status update happens inside same transactional > boundary. Thus all three entities remains consistent in the status they show. > This work does not add any recovery logic and piggybacks on existing > failure recovery mechanism for updating task status. Thus if something goes > wrong storing task status then stage/request status will also be not store > and vice-versa. Next time when ambari-agent sends command reports again then > task update and respective stage/request status update should also also get > updated successfully. > > >> - What about waiting until a request is HOLDING and then restarting > Ambari - will the relevent maps get re-populated? > > Yes, everytime ambari-server starts, we check for all stages in > HostRoleStatus.IN_PROGRESS_STATUSES
Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56426/#review164761 --- Ship it! Ship It! - Jaimin Jetly On Feb. 8, 2017, 8:18 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56426/ > --- > > (Updated Feb. 8, 2017, 8:18 p.m.) > > > Review request for Ambari, Jaimin Jetly and Xi Wang. > > > Bugs: AMBARI-19912 > https://issues.apache.org/jira/browse/AMBARI-19912 > > > Repository: ambari > > > Description > --- > > Keep host list sorted on initial loading as well as after any operation. > > > Diffs > - > > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > 07756f0 > ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 > > Diff: https://reviews.apache.org/r/56426/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 20327 passing (21s) > 153 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 56426: AMBARI-19912 - Manage Config Group host list is not sorted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56426/#review164745 --- ambari-web/app/controllers/main/service/manage_config_groups_controller.js (line 569) <https://reviews.apache.org/r/56426/#comment236500> parentconfiggroup should already be sorted to beging with as we are sorting all config groups in config group mapper. rmoving a host should keep the list sorted is again sorting required over here ? ambari-web/app/controllers/main/service/manage_config_groups_controller.js (line 590) <https://reviews.apache.org/r/56426/#comment236502> same as above. if a host is being emoved from a sorted list, again sorting the list may not be required. ambari-web/app/mappers/configs/config_groups_mapper.js (line 71) <https://reviews.apache.org/r/56426/#comment236503> sorting a list might not be very expensive on client side. But if there are multiple config groups with considerable hosts in each then it can have some performace impact. I don't see this to be significant. so I am ok with commiting this patch. But good to track this as a future requirement for ambari-server to expose an API that gives sorted hostnames for a configgroup by default or via sortBy predicate. - Jaimin Jetly On Feb. 8, 2017, 3:34 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56426/ > --- > > (Updated Feb. 8, 2017, 3:34 a.m.) > > > Review request for Ambari and Xi Wang. > > > Bugs: AMBARI-19912 > https://issues.apache.org/jira/browse/AMBARI-19912 > > > Repository: ambari > > > Description > --- > > Keep host list sorted on initial loading as well as after any operation. > > > Diffs > - > > ambari-web/app/controllers/main/service/manage_config_groups_controller.js > 07756f0 > ambari-web/app/mappers/configs/config_groups_mapper.js 8700135 > > Diff: https://reviews.apache.org/r/56426/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 20327 passing (21s) > 153 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 53686: Stage and Request status should be persisted in the database
d not cause any performance regression even on large clusters. > On Feb. 2, 2017, 10:08 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java, > > lines 647-650 > > <https://reviews.apache.org/r/53686/diff/7/?file=1608279#file1608279line647> > > > > Since you're deferring to mergeWithoutPublishEvent() that is marked > > @Transactional already, this method may not need those annotations. > > > > @Jonathan for input if it's required for both methods. This method is calling mergeWithoutPublishEvent() and also publishTaskUpdateEvent() We want both of them to be under same transaction, so if merging of stage/request status fails in the subscriber method of the taskupdate event then rollback happens for hostrolecommand status being updated from HostRoleCommandDAO#mergeWithoutPublishEvent method. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review164025 --- On Feb. 6, 2017, 11:09 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Feb. 6, 2017, 11:09 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7837a7b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > dabcb98 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 02c4091 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 1c4d0a3 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > d2f899f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 74271b9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > 7944d21 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java > f9c8810 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java > 9ca0470 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 4f90ef3 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 177ac70 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > ade625a > > ambari-server/src/test/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnableTest.java > 7b1a5a2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/
Re: Review Request 53686: Stage and Request status should be persisted in the database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/ --- (Updated Feb. 6, 2017, 11:09 p.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-18868 https://issues.apache.org/jira/browse/AMBARI-18868 Repository: ambari Description --- Stage and Request status should be persisted in the database. upgrading to ambari-3.0.0 should add status for all present stages and request for the cluster. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 31e11c1 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 4a05b32 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 3c415df ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 02c4091 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 1c4d0a3 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java d2f899f ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 74271b9 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java 7944d21 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java f9c8810 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java 9ca0470 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 4f90ef3 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 177ac70 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java ade625a ambari-server/src/test/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnableTest.java 7b1a5a2 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a0701b6 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java 619e367 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java b1c10f5 ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java 9d339e2 ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java ed95b0b ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java d7979e8 Diff: https://reviews.apache.org/r/53686/diff/ Testing --- Verified manually on a cluster by making api requests and upgrading ambari. Add unit tests. Verified that the patch does not break any existing unit tests on dev box. Jenkins job overall unit test result pending.. Verified on 1000 node cluster that the patch does not regress big operations. Executed Stop Services and Start Services API call which gernerated around 9000 tasks and compared request completion time for these operations. There was a minor performance gain with the patch. As part of https://issues.apache.org/jira/browse/AMBARI-18889, I will look if we can use the request status and stage status to further enhance performance. Thanks, Jaimin Jetly
Re: Review Request 56337: Ambari Web UI is unusably irresponsive on a 1000-node perf cluster after adding AMS (restart indicator loading is too heavy)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56337/#review164397 --- Ship it! Ship It! - Jaimin Jetly On Feb. 6, 2017, 7:24 p.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56337/ > --- > > (Updated Feb. 6, 2017, 7:24 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. > > > Bugs: AMBARI-19881 > https://issues.apache.org/jira/browse/AMBARI-19881 > > > Repository: ambari > > > Description > --- > > After adding AMS, the cluster became unusably irresponsive. The browser is > hanging for the most part. > > > Diffs > - > > ambari-web/app/controllers/main/service.js 6e68ec5 > ambari-web/app/mappers/component_config_mapper.js 866f811 > ambari-web/app/mappers/components_state_mapper.js b86aee5 > ambari-web/app/mappers/server_data_mapper.js da25212 > ambari-web/app/models/client_component.js 50a3bb6 > ambari-web/app/models/host_component.js d408bfd > ambari-web/app/models/service.js e9dc327 > ambari-web/app/views/main/service/menu.js aad718d > ambari-web/test/controllers/main/service_test.js 0421a43 > ambari-web/test/models/service_test.js e527e1e > > Diff: https://reviews.apache.org/r/56337/diff/ > > > Testing > --- > > 20326 passing (36s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 56233: Increase default timeout and threadpool size for the external script to work on slower machines
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56233/ --- Review request for Ambari, Sid Wagle and Yusaku Sako. Bugs: AMBARI-19433 https://issues.apache.org/jira/browse/AMBARI-19433 Repository: ambari Description --- Increase default timeout and threadpool size for the external script to work on slower machines Diffs - ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 7f047c8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 8a35c98 Diff: https://reviews.apache.org/r/56233/diff/ Testing --- Tested on slower machines. Hadoop QA job on the jira stated no existing test failures Thanks, Jaimin Jetly
Re: Review Request 56198: ADDENDUM. AMBARI-19814. Backend path for 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56198/#review163919 --- Ship it! Ship It! - Jaimin Jetly On Feb. 2, 2017, 12:58 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56198/ > --- > > (Updated Feb. 2, 2017, 12:58 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit > Mohanty. > > > Bugs: AMBARI-19814 > https://issues.apache.org/jira/browse/AMBARI-19814 > > > Repository: ambari > > > Description > --- > > Backend code change for using the config attribute 'read-only' instead of > 'visible'. > UI changes have already been checked-in and this is an addendum backend patch. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > fe9737a > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > fe58217 > > Diff: https://reviews.apache.org/r/56198/diff/ > > > Testing > --- > > > Thanks, > > Swapan Shridhar > >
Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs
> On Jan. 31, 2017, 6:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml, > > line 293 > > <https://reviews.apache.org/r/56097/diff/1/?file=1619361#file1619361line293> > > > > This is also needed in cluster-env for HDP 3.0 Thanks for letting me know. Fixed it as part of addendum patch - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56097/#review163691 --- On Jan. 30, 2017, 9:30 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56097/ > --- > > (Updated Jan. 30, 2017, 9:30 p.m.) > > > Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-19785 > https://issues.apache.org/jira/browse/AMBARI-19785 > > > Repository: ambari > > > Description > --- > > UI changes are required to show/hide ranger plugin configs under component > config tab. > > If Ranger is not installed on same cluster but is setup on external cluster > then cluster-env/enable_external_ranger can be set to true to expose ranger > plugin related properties for all services > > This Flag *cluster-env/enable_external_range* should show ranger plugin > config-types for all services: > ranger--plugin-properties.xml > ranger--audit.xml > ranger--security.xml > ranger--policymgr-ssl.xml > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 93680bf > ambari-web/app/controllers/main/service/info/configs.js d946ea0 > ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad > > Diff: https://reviews.apache.org/r/56097/diff/ > > > Testing > --- > > Verified on manual cluster > verified that all ambari-web unit tests passes: > > 20325 passing (24s) > 153 pending > > > Thanks, > > Jaimin Jetly > >
Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56097/ --- Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-19785 https://issues.apache.org/jira/browse/AMBARI-19785 Repository: ambari Description --- UI changes are required to show/hide ranger plugin configs under component config tab. If Ranger is not installed on same cluster but is setup on external cluster then cluster-env/enable_external_ranger can be set to true to expose ranger plugin related properties for all services This Flag *cluster-env/enable_external_range* should show ranger plugin config-types for all services: ranger--plugin-properties.xml ranger--audit.xml ranger--security.xml ranger--policymgr-ssl.xml Diffs - ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 93680bf ambari-web/app/controllers/main/service/info/configs.js d946ea0 ambari-web/app/controllers/wizard/step7_controller.js 7dcc2ad Diff: https://reviews.apache.org/r/56097/diff/ Testing --- Verified on manual cluster verified that all ambari-web unit tests passes: 20325 passing (24s) 153 pending Thanks, Jaimin Jetly
Re: Review Request 55953: CS queue refresh happens before the user clicks on the restart button
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55953/#review163535 --- Ship it! Ship It! - Jaimin Jetly On Jan. 29, 2017, 5:11 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55953/ > --- > > (Updated Jan. 29, 2017, 5:11 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-19716 > https://issues.apache.org/jira/browse/AMBARI-19716 > > > Repository: ambari > > > Description > --- > > Build 2.6.0.0-644. > > When the llap sliders are moved, and configuration is saved - a queue refresh > happens immediately if the CS config was affected. > > It does not wait for the user to click the Restart Services button. > This can cause problems when the num nodes is being reduced, since the app is > still running - and the queue size is too small for it. > > > Diffs > - > > ambari-web/app/messages.js bf3de62 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > ebfc2c7 > > Diff: https://reviews.apache.org/r/55953/diff/ > > > Testing > --- > > Verified Manually. > Ambari-web unit tests pass > > 30309 passing (19s) > 157 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 56033: Remove white border from the content area in popup wizards
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56033/#review163360 --- Ship it! Ship It! - Jaimin Jetly On Jan. 27, 2017, 7:25 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56033/ > --- > > (Updated Jan. 27, 2017, 7:25 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-19754 > https://issues.apache.org/jira/browse/AMBARI-19754 > > > Repository: ambari > > > Description > --- > > The idea is to get rid of the white border around the content so that it > looks more polished. > > > Diffs > - > > ambari-web/app/styles/modal_popups.less c10ef30 > ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f > ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js > c4a428e > > Diff: https://reviews.apache.org/r/56033/diff/ > > > Testing > --- > > 20325 passing (26s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 56033: Remove white border from the content area in popup wizards
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56033/#review163323 --- Does this cover modal popups for all wizards ? Has this patch been tested with wizards ? - Jaimin Jetly On Jan. 27, 2017, 7:25 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56033/ > --- > > (Updated Jan. 27, 2017, 7:25 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-19754 > https://issues.apache.org/jira/browse/AMBARI-19754 > > > Repository: ambari > > > Description > --- > > The idea is to get rid of the white border around the content so that it > looks more polished. > > > Diffs > - > > ambari-web/app/styles/modal_popups.less c10ef30 > ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f > ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js > c4a428e > > Diff: https://reviews.apache.org/r/56033/diff/ > > > Testing > --- > > 20325 passing (26s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55865/ --- (Updated Jan. 24, 2017, 7:50 p.m.) Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako. Bugs: AMBARI-19685 https://issues.apache.org/jira/browse/AMBARI-19685 Repository: ambari Description --- * Install Ambari cluster with latest trunk bits * Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following: Add to node of ZEPPELIN_MASTER: SPARK/LIVY_SERVER host Add to node: SPARK * Install HDP 2.5.3 cluster with Spark * Once the cluster is installed, use Add Service Wizard to add Zeppelin * Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped) * The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52 ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c ambari-server/src/main/resources/properties.json 698b6c5 ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json c1b2655 ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json e4b48da ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json b896a71 ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json 675aacb ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json 489d4df ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512 ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json 46a6f4d Diff: https://reviews.apache.org/r/55865/diff/ Testing --- Tested installer and Add Service wizard to work with the patch as expected. snapshots attached to the reviewboard of the UI impact Verfiied that related ambari-server (java/python) unit test passes with the patch File Attachments Validation error https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png Validation error cluster scope https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png Validation error host scope https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png Thanks, Jaimin Jetly
Re: Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55865/ --- (Updated Jan. 24, 2017, 12:16 a.m.) Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako. Bugs: AMBARI-19685 https://issues.apache.org/jira/browse/AMBARI-19685 Repository: ambari Description --- * Install Ambari cluster with latest trunk bits * Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following: Add to node of ZEPPELIN_MASTER: SPARK/LIVY_SERVER host Add to node: SPARK * Install HDP 2.5.3 cluster with Spark * Once the cluster is installed, use Add Service Wizard to add Zeppelin * Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped) * The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52 ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c ambari-server/src/main/resources/properties.json 698b6c5 ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512 Diff: https://reviews.apache.org/r/55865/diff/ Testing (updated) --- Tested installer and Add Service wizard to work with the patch as expected. snapshots attached to the reviewboard of the UI impact Verfiied that related ambari-server (java/python) unit test passes with the patch File Attachments Validation error https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png Validation error cluster scope https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png Validation error host scope https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png Thanks, Jaimin Jetly
Re: Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55865/ --- (Updated Jan. 24, 2017, 12:15 a.m.) Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako. Bugs: AMBARI-19685 https://issues.apache.org/jira/browse/AMBARI-19685 Repository: ambari Description --- * Install Ambari cluster with latest trunk bits * Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following: Add to node of ZEPPELIN_MASTER: SPARK/LIVY_SERVER host Add to node: SPARK * Install HDP 2.5.3 cluster with Spark * Once the cluster is installed, use Add Service Wizard to add Zeppelin * Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped) * The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52 ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c ambari-server/src/main/resources/properties.json 698b6c5 ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512 Diff: https://reviews.apache.org/r/55865/diff/ Testing --- Tested installer and Add Service wizard to work with the patch as expected. snapshots attached on the jira of the UI impact Verfiied that related ambari-server (java/python) unit test passes with the patch File Attachments (updated) Validation error https://reviews.apache.org/media/uploaded/files/2017/01/24/6fcfa745-e340-4373-919e-5b806749d50f__Validation_error.png Validation error cluster scope https://reviews.apache.org/media/uploaded/files/2017/01/24/99862028-b2e2-4994-8c11-7322f204b18c__Validation_error_cluster_scope.png Validation error host scope https://reviews.apache.org/media/uploaded/files/2017/01/24/c942ca85-6c5a-4ed0-beee-f0ce16b91532__Validation_error_host_scope.png Thanks, Jaimin Jetly
Review Request 55865: Stack advisor needs to enforce component dependency for slaves and masters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55865/ --- Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Yusaku Sako. Bugs: AMBARI-19685 https://issues.apache.org/jira/browse/AMBARI-19685 Repository: ambari Description --- * Install Ambari cluster with latest trunk bits * Modify /var/lib/ambari-server/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml to add the following: Add to node of ZEPPELIN_MASTER: SPARK/LIVY_SERVER host Add to node: SPARK * Install HDP 2.5.3 cluster with Spark * Once the cluster is installed, use Add Service Wizard to add Zeppelin * Assign Slaves and Clients step should appear (without the metainfo.xml change, it will be skipped) * The user should not be able to proceed beyond this page unless at least one Livy Server is selected <- this validation should be handled by the stack advisor Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java adcb5b5 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java 5fc5f52 ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java 5d9358c ambari-server/src/main/resources/properties.json 698b6c5 ambari-server/src/main/resources/stacks/stack_advisor.py ad3b510 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py ff25512 Diff: https://reviews.apache.org/r/55865/diff/ Testing --- Tested installer and Add Service wizard to work with the patch as expected. snapshots attached on the jira of the UI impact Verfiied that related ambari-server (java/python) unit test passes with the patch Thanks, Jaimin Jetly
Re: Review Request 55700: Ranger load balancer url needs to be updated for dependent properties during HA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55700/#review162348 --- Ship it! Ship It! - Jaimin Jetly On Jan. 19, 2017, 2:39 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55700/ > --- > > (Updated Jan. 19, 2017, 2:39 a.m.) > > > Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-19619 > https://issues.apache.org/jira/browse/AMBARI-19619 > > > Repository: ambari > > > Description > --- > > Ranger HA wizard should also update the Ranger load balancer url to dependent > plugin configs. > > ranger.plugin.hdfs.policy.rest.url/ranger-hdfs-security > ranger.plugin.yarn.policy.rest.url/ranger-yarn-security > ranger.plugin.hbase.policy.rest.url/ranger-hbase-security > ranger.plugin.hive.policy.rest.url/ranger-hive-security > ranger.plugin.knox.policy.rest.url/ranger-knox-security > ranger.plugin.kafka.policy.rest.url/ranger-kafka-security > ranger.plugin.kms.policy.rest.url/ranger-kms-security > ranger.plugin.storm.policy.rest.url/ranger-storm-security > ranger.plugin.atlas.policy.rest.url/ranger-atlas-security > > > Diffs > - > > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js > b7818d9 > ambari-web/app/messages.js a2a2fbf > > Diff: https://reviews.apache.org/r/55700/diff/ > > > Testing > --- > > Verified Manually. > Ambari-web unit tests pass. > 30297 passing (24s) > 157 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 53686: Stage and Request status should be persisted in the database
On Dec. 15, 2016, 4:49 p.m., Jaimin Jetly wrote: > > One thing I don't quite see here (and it could be due to the size of the > > patch) is what happens in these two cases: > > - Something goes wrong when trying to store a task's status. How does the > > system recover and mark it completed? > > - What about waiting until a request is HOLDING and then restarting Ambari > > - will the relevent maps get re-populated? > > Jaimin Jetly wrote: > >> - Something goes wrong when trying to store a task's status. How does > the system recover and mark it completed? > > This work only adds logic to add/update stage and request status. The way > task status is being updated or the logic for system to recover from anything > that goes wrong when storing task status is not changed. > This work ensures that task status update, respective stage status update > and respective request status update happens inside same transactional > boundary. Thus all three entities remains consistent in the status they show. > This work does not add any recovery logic and piggybacks on existing > failure recovery mechanism for updating task status. Thus if something goes > wrong storing task status then stage/request status will also be not store > and vice-versa. Next time when ambari-agent sends command reports again then > task update and respective stage/request status update should also also get > updated successfully. > > >> - What about waiting until a request is HOLDING and then restarting > Ambari - will the relevent maps get re-populated? > > Yes, everytime ambari-server starts, we check for all stages in > HostRoleStatus.IN_PROGRESS_STATUSES and publish an event with the tasks. > these will repopulate the maps. The patch adds that logic with > "publishInProgressTasks(stages)" method in ActionScheduler.java > > I have tested that scenario of restarting ambari-server when a request is > ongoing with in progress tasks and validating that stages and requests status > is correctly updated > > Sid Wagle wrote: > The agent re-sending command reports are we generally fault tolerant in > that area? Sicne you are probably mostly up-to-date on that part of the code > can you shed some light on loss of task status scenario. Do we recover the > correct status? Yes. Largely. Although There are following specific cases: 1) If persisting of "request, it's stages and it's host role commands" for the first time does not happen then the request will be completely missed and ambari-server will never log in the database or track it in anyways. 2) If "request, it's stages and it's host role commands" are persisted but subsequent updates and DB merge keeps failing then request will be eventually declared timeout and so will all hrcs As far as DB merge from subsequent agent command reports is successfully committed to DB, earlier failures will be recovered. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review159315 --- On Jan. 18, 2017, 10:33 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Jan. 18, 2017, 10:33 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7837a7b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > dabcb98 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 3656bfe > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskCr
Re: Review Request 53686: Stage and Request status should be persisted in the database
> On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 445-447 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584761#file1584761line445> > > > > This could be problematic if the merge fails when the transaction > > commits. You've already fired the event. > > Jaimin Jetly wrote: > persistAction method has been annotated with @Transactional and > @TransactionalLock. > I believe if the publisher method is marked to be transactional then the > event listener will also fall in that transactional boundary considering that > the eventbus being used over here is default which I believe is synchronous. > > I will verify this myself by checking that publsiher method, eventbus and > subscriber method are running on same thread. I verified that the publisher and subscriber code runs on same thread and so transactional boundary will extend for the entire logic making sure that tasks and respective stage/request are consistent in their status On Dec. 15, 2016, 4:49 p.m., Jaimin Jetly wrote: > > One thing I don't quite see here (and it could be due to the size of the > > patch) is what happens in these two cases: > > - Something goes wrong when trying to store a task's status. How does the > > system recover and mark it completed? > > - What about waiting until a request is HOLDING and then restarting Ambari > > - will the relevent maps get re-populated? >> - Something goes wrong when trying to store a task's status. How does the >> system recover and mark it completed? This work only adds logic to add/update stage and request status. The way task status is being updated or the logic for system to recover from anything that goes wrong when storing task status is not changed. This work ensures that task status update, respective stage status update and respective request status update happens inside same transactional boundary. Thus all three entities remains consistent in the status they show. This work does not add any recovery logic and piggybacks on existing failure recovery mechanism for updating task status. Thus if something goes wrong storing task status then stage/request status will also be not store and vice-versa. Next time when ambari-agent sends command reports again then task update and respective stage/request status update should also also get updated successfully. >> - What about waiting until a request is HOLDING and then restarting Ambari >> - will the relevent maps get re-populated? Yes, everytime ambari-server starts, we check for all stages in HostRoleStatus.IN_PROGRESS_STATUSES and publish an event with the tasks. these will repopulate the maps. The patch adds that logic with "publishInProgressTasks(stages)" method in ActionScheduler.java I have tested that scenario of restarting ambari-server when a request is ongoing with in progress tasks and validating that stages and requests status is correctly updated - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review159315 --- On Jan. 18, 2017, 10:33 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Jan. 18, 2017, 10:33 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7837a7b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > dabcb98 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 3656bfe > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-serv
Re: Review Request 53686: Stage and Request status should be persisted in the database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/ --- (Updated Jan. 18, 2017, 10:33 p.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-18868 https://issues.apache.org/jira/browse/AMBARI-18868 Repository: ambari Description --- Stage and Request status should be persisted in the database. upgrading to ambari-3.0.0 should add status for all present stages and request for the cluster. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java 3656bfe ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 31e11c1 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 4a05b32 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 3c415df ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 02c4091 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 1c4d0a3 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java d2f899f ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 74271b9 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java 7944d21 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java f9c8810 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java 9ca0470 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 4f90ef3 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 1ca777d ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 6cc511e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a702e6f ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java e398a54 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java ae85241 ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 7dd9932 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java d7979e8 Diff: https://reviews.apache.org/r/53686/diff/ Testing --- Verified manually on a cluster by making api requests and upgrading ambari. Add unit tests. Verified that the patch does not break any existing unit tests on dev box. Jenkins job overall unit test result pending.. Verified on 1000 node cluster that the patch does not regress big operations. Executed Stop Services and Start Services API call which gernerated around 9000 tasks and compared request completion time for these operations. There was a minor performance gain with the patch. As part of https://issues.apache.org/jira/browse/AMBARI-18889, I will look if we can use the request status and stage status to further enhance performance. Thanks, Jaimin Jetly
Re: Review Request 53686: Stage and Request status should be persisted in the database
> On Dec. 15, 2016, 3:40 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java, > > line 186 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584762#file1584762line186> > > > > What I meant was this isn't a typically-named java variable. Just use > > something like "taskStatusLoaded", and make the field private. > > Jaimin Jetly wrote: > ok. I will address this in next revision of the patch. This has been addressed in new revision of the patch. > On Dec. 15, 2016, 3:40 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java, > > line 34 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584768#file1584768line34> > > > > make private > > Jaimin Jetly wrote: > I will address this in next revision of the patch. This has been addressed in new revision of the patch. > On Dec. 15, 2016, 3:40 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java, > > lines 46-48 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584768#file1584768line46> > > > > javadoc > > Jaimin Jetly wrote: > I will address this in next revision of the patch. This has been addressed in new revision of the patch. > On Dec. 15, 2016, 3:40 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java, > > lines 616-620 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584770#file1584770line616> > > > > This enum probably shouldn't be defined here since it's use is mostly > > by CalculatedStatus > > Jaimin Jetly wrote: > I will address this in next revision of the patch. This has been addressed in new revision of the patch. > On Dec. 15, 2016, 3:40 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java, > > lines 658-665 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584772#file1584772line658> > > > > method is nearly identical to merge() - could just use a boolean > > overload: merge(HRCE, boolean) > > Jaimin Jetly wrote: > well I did not want to change the signature of merge() method but I see > your point about code duplicacy. > I will make necessary changes in next revision of the patch so that > merge(HostRoleCommandEntity entity) calls > mergeWithoutPublishEvent(HostRoleCommandEntity entity) to get the work done > rather than doing almost same work plus one extra line of code This has been addressed in new revision of the patch. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review159228 --- On Jan. 17, 2017, 9:43 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Jan. 17, 2017, 9:43 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7837a7b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > dabcb98 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 3656bfe > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java > PRE-CREATI
Re: Review Request 53686: Stage and Request status should be persisted in the database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/ --- (Updated Jan. 17, 2017, 9:43 p.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-18868 https://issues.apache.org/jira/browse/AMBARI-18868 Repository: ambari Description --- Stage and Request status should be persisted in the database. upgrading to ambari-3.0.0 should add status for all present stages and request for the cluster. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 7837a7b ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java dabcb98 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java 3656bfe ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 31e11c1 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 4a05b32 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 3c415df ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 02c4091 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 1c4d0a3 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java d2f899f ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 74271b9 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java 7944d21 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java f9c8810 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java 9ca0470 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 4f90ef3 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 1ca777d ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java 6cc511e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java a702e6f ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java e398a54 ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java ae85241 ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 7dd9932 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java d7979e8 Diff: https://reviews.apache.org/r/53686/diff/ Testing --- Verified manually on a cluster by making api requests and upgrading ambari. Add unit tests. Verified that the patch does not break any existing unit tests on dev box. Jenkins job overall unit test result pending.. Verified on 1000 node cluster that the patch does not regress big operations. Executed Stop Services and Start Services API call which gernerated around 9000 tasks and compared request completion time for these operations. There was a minor performance gain with the patch. As part of https://issues.apache.org/jira/browse/AMBARI-18889, I will look if we can use the request status and stage status to further enhance performance. Thanks, Jaimin Jetly
Re: Review Request 55399: Changing Capacity-scheduler configs while llap is enabled should warn the user if llap is affected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55399/#review161304 --- Ship it! Ship It! - Jaimin Jetly On Jan. 11, 2017, 12:34 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55399/ > --- > > (Updated Jan. 11, 2017, 12:34 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-19434 > https://issues.apache.org/jira/browse/AMBARI-19434 > > > Repository: ambari > > > Description > --- > > Changing Capacity-scheduler configs while llap is enabled should warn the > user if llap is affected > > > Diffs > - > > ambari-web/app/messages.js 6e35bd5 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > ba30dcd > ambari-web/app/models/configs/theme/config_action.js 905fecb > > Diff: https://reviews.apache.org/r/55399/diff/ > > > Testing > --- > > Verified Manually. > > Ambari-web unit tests pass. > 30288 passing (18s) > 154 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review161291 --- Ship it! Ship It! - Jaimin Jetly On Nov. 9, 2016, 12:11 a.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53213/ > --- > > (Updated Nov. 9, 2016, 12:11 a.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert Levas, > and Robert Nettleton. > > > Bugs: AMBARI-18692 > https://issues.apache.org/jira/browse/AMBARI-18692 > > > Repository: ambari > > > Description > --- > > Exporting blueprint from kerberos enabled cluster, exports hardcoded values > cluster name and realm in principal_name property. > When the same blueprint is used to create another cluster with different > name, service start fail with following error: > "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt > /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned > 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] > while getting initial credentials" > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > f890326 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java > 16f75ee > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > 81de76c > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml > 1d330dd > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-env.xml > d7ae236 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml > 2be101b > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > 9efa4f9 > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > 8712c7d > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml > 24bd563 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > afaaee8 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > e8a76b6 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml > 7016437 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml > 2e5a026 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > ee885e3 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > c5b9b4e > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > 36ebc8c > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml > a0bd322 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml > d267b75 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml > 1bce4e6 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml > b85cf50 > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml > 71a42f7 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml > a5115af > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > b78fd79 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml > 5d0b2ff > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > c03d2dc > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-env.xml > 696b28a > ambari-server/src/main/resources/configuration-schema.xsd daba29f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 5bedb9d > > Diff: https://reviews.apache.org/r/53213/diff/ > > > Testing > --- > > Tested manually. Suitable keytabs are generated automatically when not > mentioned in blueprint. Service starts succeeded with a blueprint exported > with the code change. > Modified existing unit test cases. > > > Thanks, > > Amruta Borkar > >
Re: Review Request 55367: Improve "Install Wizard step 1" after new guidelines
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55367/#review161106 --- Ship it! Ship It! - Jaimin Jetly On Jan. 10, 2017, 2:37 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55367/ > --- > > (Updated Jan. 10, 2017, 2:37 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-19432 > https://issues.apache.org/jira/browse/AMBARI-19432 > > > Repository: ambari > > > Description > --- > > Should do the following adjustments to integrate with the new style > guidelines: > > As for the contents inside of the white panel: > 1. Make tabs in a horizontal view. > 2. Select stack button changed from blue to white. > 3. Repositories should be the title of the following section, so move the > radio buttons under that. > 4. Make two radio buttons in horizontal view. > > > Diffs > - > > ambari-web/app/messages.js 0c3e10a > ambari-web/app/styles/wizard.less bc228c1 > ambari-web/app/templates/wizard/step1.hbs 3b85895 > > Diff: https://reviews.apache.org/r/55367/diff/ > > > Testing > --- > > 20205 passing (19s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 53686: Stage and Request status should be persisted in the database
> On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > lines 445-447 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584761#file1584761line445> > > > > This could be problematic if the merge fails when the transaction > > commits. You've already fired the event. persistAction method has been annotated with @Transactional and @TransactionalLock. I believe if the publisher method is marked to be transactional then the event listener will also fall in that transactional boundary considering that the eventbus being used over here is default which I believe is synchronous. I will verify this myself by checking that publsiher method, eventbus and subscriber method are running on same thread. > On Dec. 15, 2016, 4:49 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > lines 282-287 > > <https://reviews.apache.org/r/53686/diff/5/?file=1584766#file1584766line282> > > > > Would this count states like FAILED / TIMEDOUT twice? yes. It will increment the FAILED counter and also increment COMPLETED counter which is desired. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review159315 ------- On Dec. 14, 2016, 8:20 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Dec. 14, 2016, 8:20 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 2c87583 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > e80b020 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 3656bfe > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 02c4091 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 1c4d0a3 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > d2f899f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 74271b9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > 7944d21 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java > f9c8810 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java > 9ca0470 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 4f90ef3 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 8cf2c0d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 82ce31e > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e2c2dd5 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4e9a535 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0ba7df6 > ambari-server/src
Re: Review Request 55233: Improve and Fix "Hosts page" after new guidelines
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55233/#review160643 --- Ship it! Ship It! - Jaimin Jetly On Jan. 5, 2017, 10:18 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55233/ > --- > > (Updated Jan. 5, 2017, 10:18 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-19313 > https://issues.apache.org/jira/browse/AMBARI-19313 > > > Repository: ambari > > > Description > --- > > Hosts filter: > 1. Not aligned with Actions button. > 2. Filter dropdown menu, all host filter texts should be same font family as > other texts > 3. Remove icon has shadow, should not > > Hosts table: > 4. Text in every table row was not centered. > > > Diffs > - > > ambari-web/app/styles/application.less 7d18cf5 > > Diff: https://reviews.apache.org/r/55233/diff/ > > > Testing > --- > > 19976 passing (20s) > 153 pending > > > Thanks, > > Xi Wang > >
Review Request 55163: ambai-web action to download all client configs of host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55163/ --- Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-19351 https://issues.apache.org/jira/browse/AMBARI-19351 Repository: ambari Description --- ambai-web action to download all client configs of host curl --user admin:admin -H "X-Requested-By: ambari" -X GET http://localhost:8080/api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components?format=client_config_tar -o output.tar.gz Diffs - ambari-web/app/controllers/main/host/details.js ca033f2 ambari-web/app/controllers/main/service.js e4d751d ambari-web/app/controllers/main/service/item.js 18a121f ambari-web/app/messages.js a37b1c6 ambari-web/app/mixins/main/host/details/support_client_configs_download.js 58460f0 ambari-web/app/templates/main/host/details.hbs f709612 ambari-web/app/templates/main/service/all_services_actions.hbs 80fd916 ambari-web/app/views/main/host/details.js 784e63c ambari-web/test/controllers/main/host/details_test.js 154d0b2 ambari-web/test/controllers/main/service/item_test.js 082fbd9 Diff: https://reviews.apache.org/r/55163/diff/ Testing --- ambari-web unit test result with the patch: 29792 passing (20s) 154 pending Thanks, Jaimin Jetly
Re: Review Request 55096: AMBARI-19324 - Ambai-web action to download all client configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55096/#review160302 --- Ship it! Ship It! - Jaimin Jetly On Dec. 30, 2016, 3:41 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55096/ > --- > > (Updated Dec. 30, 2016, 3:41 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-19324 > https://issues.apache.org/jira/browse/AMBARI-19324 > > > Repository: ambari > > > Description > --- > > Support download all client configs > > > Diffs > - > > ambari-web/app/controllers/main/service.js 2677723 > ambari-web/app/messages.js 6296d55 > ambari-web/app/mixins/main/host/details/support_client_configs_download.js > 6e7cd9b > ambari-web/app/templates/main/service/all_services_actions.hbs 7cd36c8 > > Diff: https://reviews.apache.org/r/55096/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 19838 passing (17s) > 153 pending > > > Thanks, > > Richard Zang > >
Re: Review Request 54958: Single API to download all client configs
> On Dec. 27, 2016, 4:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 572 > > <https://reviews.apache.org/r/54958/diff/3/?file=1592286#file1592286line572> > > > > Do you depend on order of execution for success? If yes, this looks > > non-reliable. > > Jaimin Jetly wrote: > Not for success. But this order helps in collecting entire error/output > stream data. > We first start thread that collects the error/output stream data for the > subprocess and then start the thread that begins process execution. > If we reverse the order then the complete error/output stream might not > be collected. > > Note: We need this stream data to log if there are any failures in the > subprocess i.e while writing config tar files Also I figured out that Executors.newFixedThreadPool uses LinkedblockingQueue - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160172 ------- On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54958/ > --- > > (Updated Dec. 27, 2016, 4:16 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-19275 > https://issues.apache.org/jira/browse/AMBARI-19275 > > > Repository: ambari > > > Description > --- > > Currently there is an API to download compressed config files for a host > component > > Scope of this ticket is to extend this functionality to do following: > # Download all client config files for a host via single API > # Download all client config files of a service via single API. some services > have more than one client > # Download all client config files for cluster > > Apart from extending the functionalty of API, an additional change has been > made to the behavior of the existing API that looked to be like a bug > Without this patch Downloading client config files for a service component > used to fetch first host component and create config files as present on that > host component (host desired configs overlaid on cluster desired configs) > Instead with a change in this patch when download client config is made on a > service component then config files with only cluster base configs will be > created for downoad. > > > Diffs > - > > ambari-server/pom.xml 102cb71 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > ded2596 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > bc9bb30 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > d2f7934 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 020a454 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java > cb3c2a7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java > f67d961 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > cb88ae1 > > Diff: https://reviews.apache.org/r/54958/diff/ > > > Testing > --- > > Tested manually on a cluster > Added validation to existing unit tests > Executed all unit tests on dev machine and checked there is no regression > Jenkins QA job for 1st revision of the patch compltedt successsfully > Jenkins QA job for 2nd revision of the patch in progress... > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 55062: Improve and Fix "Services page" after new guidelines
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55062/#review160250 --- Ship it! Ship It! - Jaimin Jetly On Dec. 28, 2016, 2:52 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55062/ > --- > > (Updated Dec. 28, 2016, 2:52 a.m.) > > > Review request for Ambari, Richard Zang, Vivek Ratnavel Subramanian, and > Yusaku Sako. > > > Bugs: AMBARI-19305 > https://issues.apache.org/jira/browse/AMBARI-19305 > > > Repository: ambari > > > Description > --- > > Create wizard > Step 2: > The preview should be centered. > During "+ Add Metric" selection, when a metric/operator got selected, the > submenu should not disappear. > > > Diffs > - > > ambari-web/app/styles/enhanced_service_dashboard.less 0d549d7 > ambari-web/app/views/main/service/widgets/create/expression_view.js 436e3e9 > > Diff: https://reviews.apache.org/r/55062/diff/ > > > Testing > --- > > 19829 passing (21s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 54958: Single API to download all client configs
> On Dec. 27, 2016, 4:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 572 > > <https://reviews.apache.org/r/54958/diff/3/?file=1592286#file1592286line572> > > > > Do you depend on order of execution for success? If yes, this looks > > non-reliable. Not for success. But this order helps in collecting entire error/output stream data. We first start thread that collects the error/output stream data for the subprocess and then start the thread that begins process execution. If we reverse the order then the complete error/output stream might not be collected. Note: We need this stream data to log if there are any failures in the subprocess i.e while writing config tar files - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160172 ------- On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54958/ > --- > > (Updated Dec. 27, 2016, 4:16 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-19275 > https://issues.apache.org/jira/browse/AMBARI-19275 > > > Repository: ambari > > > Description > --- > > Currently there is an API to download compressed config files for a host > component > > Scope of this ticket is to extend this functionality to do following: > # Download all client config files for a host via single API > # Download all client config files of a service via single API. some services > have more than one client > # Download all client config files for cluster > > Apart from extending the functionalty of API, an additional change has been > made to the behavior of the existing API that looked to be like a bug > Without this patch Downloading client config files for a service component > used to fetch first host component and create config files as present on that > host component (host desired configs overlaid on cluster desired configs) > Instead with a change in this patch when download client config is made on a > service component then config files with only cluster base configs will be > created for downoad. > > > Diffs > - > > ambari-server/pom.xml 102cb71 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > ded2596 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > bc9bb30 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > d2f7934 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 020a454 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java > cb3c2a7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java > f67d961 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > cb88ae1 > > Diff: https://reviews.apache.org/r/54958/diff/ > > > Testing > --- > > Tested manually on a cluster > Added validation to existing unit tests > Executed all unit tests on dev machine and checked there is no regression > Jenkins QA job for 1st revision of the patch compltedt successsfully > Jenkins QA job for 2nd revision of the patch in progress... > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 54958: Single API to download all client configs
> On Dec. 27, 2016, 4:52 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2784 > > <https://reviews.apache.org/r/54958/diff/3/?file=1592285#file1592285line2784> > > > > Minor nit but it is hard to understand what external script means,can > > you please change to a more meaningful name, if only used for writing out > > cconfig files, naming the param as such is highly recommended The configuration name is in parity with other existing configuration name EXTERNAL_SCRIPT_TIMEOUT which was added as part of https://reviews.apache.org/r/27922/diff/2#index_header. I believe intention over here is to use same property names for any external process that we start (apart from just writing config tar files) and both these configurations EXTERNAL_SCRIPT_TIMEOUT and THREAD_POOL_SIZE_FOR_EXTERNAL_SCRIPT (if starting multiple processes) will hold true in all such scenarios - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review160170 ------- On Dec. 27, 2016, 4:16 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54958/ > --- > > (Updated Dec. 27, 2016, 4:16 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-19275 > https://issues.apache.org/jira/browse/AMBARI-19275 > > > Repository: ambari > > > Description > --- > > Currently there is an API to download compressed config files for a host > component > > Scope of this ticket is to extend this functionality to do following: > # Download all client config files for a host via single API > # Download all client config files of a service via single API. some services > have more than one client > # Download all client config files for cluster > > Apart from extending the functionalty of API, an additional change has been > made to the behavior of the existing API that looked to be like a bug > Without this patch Downloading client config files for a service component > used to fetch first host component and create config files as present on that > host component (host desired configs overlaid on cluster desired configs) > Instead with a change in this patch when download client config is made on a > service component then config files with only cluster base configs will be > created for downoad. > > > Diffs > - > > ambari-server/pom.xml 102cb71 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > ded2596 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > bc9bb30 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > d2f7934 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 020a454 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java > cb3c2a7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java > f67d961 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > cb88ae1 > > Diff: https://reviews.apache.org/r/54958/diff/ > > > Testing > --- > > Tested manually on a cluster > Added validation to existing unit tests > Executed all unit tests on dev machine and checked there is no regression > Jenkins QA job for 1st revision of the patch compltedt successsfully > Jenkins QA job for 2nd revision of the patch in progress... > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 54958: Single API to download all client configs
> On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java, > > line 299 > > <https://reviews.apache.org/r/54958/diff/1/?file=1590763#file1590763line299> > > > > Would rather use new File(parent, child) syntax suggestion has been incorporated in the 2nd revision of the patch > On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 206 > > <https://reviews.apache.org/r/54958/diff/1/?file=1590764#file1590764line206> > > > > no need to qualify the generic for the type: new ArrayList<> is > > sufficient suggestion has been incorporated in the 2nd revision of the patch > On Dec. 22, 2016, 3:59 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > lines 549-561 > > <https://reviews.apache.org/r/54958/diff/1/?file=1590764#file1590764line549> > > > > There could be a LOT of commands which seems like it would be a LOT of > > threads. Use an Executor instead. That will avoid both thread bloat and > > process handle bloat. This has been addressed in the 2nd revision of the patch - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review159970 --- On Dec. 23, 2016, 12:57 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54958/ > --- > > (Updated Dec. 23, 2016, 12:57 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-19275 > https://issues.apache.org/jira/browse/AMBARI-19275 > > > Repository: ambari > > > Description > --- > > Currently there is an API to download compressed config files for a host > component > > Scope of this ticket is to extend this functionality to do following: > # Download all client config files for a host via single API > # Download all client config files of a service via single API. some services > have more than one client > # Download all client config files for cluster > > Apart from extending the functionalty of API, an additional change has been > made to the behavior of the existing API that looked to be like a bug > Without this patch Downloading client config files for a service component > used to fetch first host component and create config files as present on that > host component (host desired configs overlaid on cluster desired configs) > Instead with a change in this patch when download client config is made on a > service component then config files with only cluster base configs will be > created for downoad. > > > Diffs > - > > ambari-server/pom.xml ceec39c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > ded2596 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > bc9bb30 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > d2f7934 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 020a454 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java > cb3c2a7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java > f67d961 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > cb88ae1 > > Diff: https://reviews.apache.org/r/54958/diff/ > > > Testing > --- > > Tested manually on a cluster > Added validation to existing unit tests > Executed all unit tests on dev machine and checked there is no regression > Jenkins QA job for 1st revision of the patch compltedt successsfully > Jenkins QA job for 2nd revision of the patch in progress... > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 54958: Single API to download all client configs
> On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 250 > > <https://reviews.apache.org/r/54958/diff/1/?file=1590764#file1590764line250> > > > > Suggestion friendlier naming for variable: schResponseList, conveys > > better info than serviceComponentList. suggestion has been incorporated in the 2nd revision of the patch > On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 299 > > <https://reviews.apache.org/r/54958/diff/1/?file=1590764#file1590764line299> > > > > Isn't this the same as props.putAll(properties.values())? This logic was existing before. I accidently happened to change just the variable name which I have again reverted back to what it was before. To answer the question, I believe its not the same thing. Over here we are flatennig Map<String, Map<String, String>> to Map<String,String> props.putAll(properties.values()) will be passing collection of Map<String, String> to putAll method instead of passing a map: Map<String, String>. Note: putAll API of the map does not accept collection of maps. > On Dec. 22, 2016, 5:32 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java, > > line 240 > > <https://reviews.apache.org/r/54958/diff/1/?file=1590764#file1590764line240> > > > > Shouldn't this just log and error and move on why throw an exception? > > Nate Cole wrote: > +1 We are throwing exception over here only when config files is not present and the response has just one component. For example: http://localhost:8080/api/v1/clusters/c1/services/HDFS/components/DATANODE?format=client_config_tar will throw an exception that "No configuration files defined for the component Datanode" or if any other new client is introduced but no config files are mapped with it in the service metainfo.xml. This is the existing behavior of the API and the patch tries to not change this behavior. if an API call is made to download configs for a service/cluster/host (extended feature added as part of this patch) and none of the beneath components has config files mapped to it then we throw system exception later with a generic message "No configuration files defined for any component". The intention of throwing the exception is to return API with failed error code raher than 200 OK with empty tar file considering python script will not burst when provided with empty config files input. Again this is an existing API behavior and I personally feel it's correct. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review159924 --- On Dec. 23, 2016, 12:57 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54958/ > --- > > (Updated Dec. 23, 2016, 12:57 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-19275 > https://issues.apache.org/jira/browse/AMBARI-19275 > > > Repository: ambari > > > Description > --- > > Currently there is an API to download compressed config files for a host > component > > Scope of this ticket is to extend this functionality to do following: > # Download all client config files for a host via single API > # Download all client config files of a service via single API. some services > have more than one client > # Download all client config files for cluster > > Apart from extending the functionalty of API, an additional change has been > made to the behavior of the existing API that looked to be like a bug > Without this patch Downloading client config files for a service component > used to fetch first host component and create config files as present on that > host component (host desired configs overlaid on cluster desired configs) > Instead with a change in this patch when download client config is made on a > service component then config files with only cluster base configs will be > created for downoad. > > > Diffs > - > > ambari-server/pom.xml ceec39c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/Com
Re: Review Request 54958: Single API to download all client configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/ --- (Updated Dec. 23, 2016, 12:57 a.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-19275 https://issues.apache.org/jira/browse/AMBARI-19275 Repository: ambari Description --- Currently there is an API to download compressed config files for a host component Scope of this ticket is to extend this functionality to do following: # Download all client config files for a host via single API # Download all client config files of a service via single API. some services have more than one client # Download all client config files for cluster Apart from extending the functionalty of API, an additional change has been made to the behavior of the existing API that looked to be like a bug Without this patch Downloading client config files for a service component used to fetch first host component and create config files as present on that host component (host desired configs overlaid on cluster desired configs) Instead with a change in this patch when download client config is made on a service component then config files with only cluster base configs will be created for downoad. Diffs - ambari-server/pom.xml ceec39c ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java ded2596 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java bc9bb30 ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d2f7934 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 020a454 ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java cb3c2a7 ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java f67d961 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java cb88ae1 Diff: https://reviews.apache.org/r/54958/diff/ Testing (updated) --- Tested manually on a cluster Added validation to existing unit tests Executed all unit tests on dev machine and checked there is no regression Jenkins QA job for 1st revision of the patch compltedt successsfully Jenkins QA job for 2nd revision of the patch in progress... Thanks, Jaimin Jetly
Re: Review Request 54958: Single API to download all client configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/ --- (Updated Dec. 23, 2016, 12:55 a.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Changes --- Addresses reviewboard comments Bugs: AMBARI-19275 https://issues.apache.org/jira/browse/AMBARI-19275 Repository: ambari Description --- Currently there is an API to download compressed config files for a host component Scope of this ticket is to extend this functionality to do following: # Download all client config files for a host via single API # Download all client config files of a service via single API. some services have more than one client # Download all client config files for cluster Apart from extending the functionalty of API, an additional change has been made to the behavior of the existing API that looked to be like a bug Without this patch Downloading client config files for a service component used to fetch first host component and create config files as present on that host component (host desired configs overlaid on cluster desired configs) Instead with a change in this patch when download client config is made on a service component then config files with only cluster base configs will be created for downoad. Diffs (updated) - ambari-server/pom.xml ceec39c ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java ded2596 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java bc9bb30 ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d2f7934 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 020a454 ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java cb3c2a7 ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java f67d961 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java cb88ae1 Diff: https://reviews.apache.org/r/54958/diff/ Testing --- Tested manually on a cluster Added validation to existing unit tests Executed all unit tests on dev machine and checked there is no regression Jenkins QA job for unit test in progress... Thanks, Jaimin Jetly
Review Request 54958: Single API to download all client configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-19275 https://issues.apache.org/jira/browse/AMBARI-19275 Repository: ambari Description --- Currently there is an API to download compressed config files for a host component Scope of this ticket is to extend this functionality to do following: # Download all client config files for a host via single API # Download all client config files of a service via single API. some services have more than one client # Download all client config files for cluster Apart from extending the functionalty of API, an additional change has been made to the behavior of the existing API that looked to be like a bug Without this patch Downloading client config files for a service component used to fetch first host component and create config files as present on that host component (host desired configs overlaid on cluster desired configs) Instead with a change in this patch when download client config is made on a service component then config files with only cluster base configs will be created for downoad. Diffs - ambari-server/pom.xml ceec39c ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java ded2596 ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java bc9bb30 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 020a454 ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java cb3c2a7 ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java f67d961 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java cb88ae1 Diff: https://reviews.apache.org/r/54958/diff/ Testing --- Tested manually on a cluster Added validation to existing unit tests Executed all unit tests on dev machine and checked there is no regression Jenkins QA job for unit test in progress... Thanks, Jaimin Jetly
Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54460/#review159645 --- Ship it! Ship It! - Jaimin Jetly On Dec. 19, 2016, 7:38 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54460/ > --- > > (Updated Dec. 19, 2016, 7:38 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-19117 > https://issues.apache.org/jira/browse/AMBARI-19117 > > > Repository: ambari > > > Description > --- > > This is a FE task to implement the "Create Alerts Wizard " based on the > design attached. > > This task is to create Step 2 of PORT alert. see the design for details. > Pay attention to the dependencies on selecting different options. The further > fields will determined by the current selection. > > eg. Selecting HDP service (such as HDFS, YARN) or Custom service will display > totally different UI. > > > Diffs > - > > ambari-web/app/config.js 130cb39 > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > 7fb4b2d > ambari-web/app/controllers/main/alerts/definition_configs_controller.js > 138aaa4 > ambari-web/app/models/alerts/alert_config.js 980dfe5 > ambari-web/app/styles/alerts.less 77cc13c > > ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js > 2ea42f7 > > Diff: https://reviews.apache.org/r/54460/diff/ > > > Testing > --- > > 19713 passing (21s) > 153 pending > > > Thanks, > > Xi Wang > >
Re: Review Request 54733: Alerts: Create new Alerts Notification type for SNMP to handle Ambari MIB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54733/#review159203 --- Ship it! Ship It! - Jaimin Jetly On Dec. 14, 2016, 8:46 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54733/ > --- > > (Updated Dec. 14, 2016, 8:46 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-14958 > https://issues.apache.org/jira/browse/AMBARI-14958 > > > Repository: ambari > > > Description > --- > > 1) Rename current notification type "SNMP" to "Custom SNMP" > 2) Create a new notification type "SNMP" that prompts for version, community, > hosts, ports > 3) When this is chosen, Ambari under-the-hood generates the SNMP traps based > on the MIB. > 4) The MIB file should be shipped with Ambari. > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > 10a7918 > ambari-web/app/templates/main/alerts/create_alert_notification.hbs 342b247 > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js abb1694 > > Diff: https://reviews.apache.org/r/54733/diff/ > > > Testing > --- > > Verified Manually. Ambari-web unit tests pass. > 19881 tests complete (23 seconds) > 153 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 53686: Stage and Request status should be persisted in the database
> On Nov. 14, 2016, 5:03 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java, > > lines 226-230 > > <https://reviews.apache.org/r/53686/diff/1/?file=1561984#file1561984line226> > > > > Won't be performant on large numbers of tasks (like during upgrade). This code is not part of the new revision of the patch. With the new work iterating all hostrolecommands of the stage happens in very minimal scenarios where entire stage status cannot be figured out from subset of updated host role command received from agent as command reports. For example if the stage current status is non-completed and a particular command report received has all tasks in it to be completed state then all host role commands of a stage will be iterated. But if any of the state is found to be in HOLDING, FAILED, TIMEDOUT or any of in progress states then only comamnds in the command report received are iterated. - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review155819 --- On Dec. 14, 2016, 2:11 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Dec. 14, 2016, 2:11 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 2c87583 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > e80b020 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 3656bfe > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 02c4091 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 1c4d0a3 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > d2f899f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 74271b9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > 7944d21 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java > f9c8810 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java > 9ca0470 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 4f90ef3 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 8cf2c0d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 82ce31e > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e2c2dd5 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4e9a535 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0ba7df6 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d8cad6f > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 1ca777d > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > f86c02e > > ambari-server/src/tes
Re: Review Request 53686: Stage and Request status should be persisted in the database
> On Nov. 14, 2016, 5:03 p.m., Nate Cole wrote: > > Is this effort spanning multiple jira? I was hoping we would be able to > > optimize queries against the database if we need to recalculate status. > > When tasks are completed can we compute the status of the whole based on > > just the status of the single task (for any case)? Where is the update > > code for Stage being run (when we know a task's own status)? The latest revision of the patch does change StageDAO query to find in progress stages by looking into stage status rather tahn subquerying host role command statuses. Although wider scan of the code to leverage stage/request persisted status will be done as part of https://issues.apache.org/jira/browse/AMBARI-18889. For now I have verified that this work does not regress performance by testing on 1000 node simulated cluster - Jaimin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/#review155819 --- On Dec. 14, 2016, 2:11 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53686/ > --- > > (Updated Dec. 14, 2016, 2:11 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-18868 > https://issues.apache.org/jira/browse/AMBARI-18868 > > > Repository: ambari > > > Description > --- > > Stage and Request status should be persisted in the database. > > upgrading to ambari-3.0.0 should add status for all present stages and > request for the cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 2c87583 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > e80b020 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java > 3656bfe > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java > 31e11c1 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 4a05b32 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > 3c415df > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 02c4091 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 1c4d0a3 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java > d2f899f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 74271b9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java > 7944d21 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java > f9c8810 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java > 9ca0470 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 4f90ef3 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 8cf2c0d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 82ce31e > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e2c2dd5 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4e9a535 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0ba7df6 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d8cad6f > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 1ca777d > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > f86c02e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > e23ba62 > >
Re: Review Request 53686: Stage and Request status should be persisted in the database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53686/ --- (Updated Dec. 14, 2016, 2:11 a.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18868 https://issues.apache.org/jira/browse/AMBARI-18868 Repository: ambari Description --- Stage and Request status should be persisted in the database. upgrading to ambari-3.0.0 should add status for all present stages and request for the cluster. Diffs - ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 2c87583 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java e80b020 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java 3656bfe ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java 31e11c1 ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 4a05b32 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 3c415df ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 02c4091 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 1c4d0a3 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java d2f899f ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 74271b9 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java 7944d21 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java f9c8810 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java 9ca0470 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 4f90ef3 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 8cf2c0d ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 82ce31e ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e2c2dd5 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4e9a535 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0ba7df6 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d8cad6f ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 1ca777d ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java f86c02e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java e23ba62 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java baec7df ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java PRE-CREATION ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java cc49cbd ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java 7dd9932 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java d7979e8 Diff: https://reviews.apache.org/r/53686/diff/ Testing (updated) --- Verified manually on a cluster by making api requests and upgrading ambari. Add unit tests. Verified that the patch does not break any existing unit tests on dev box. Jenkins job overall unit test result pending.. Verified on 1000 node cluster that the patch does not regress big operations. Executed Stop Services and Start Services API call which gernerated around 9000 tasks and compared request completion time for these operations. There was a minor performance gain with the patch. As part of https://issues.apache.org/jira/browse/AMBARI-18889, I will look if we can use the request status and stage status to further enhance performance. Thanks, Jaimin Jetly
Re: Review Request 54698: Disable security hook
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54698/#review159027 --- ambari-web/app/controllers/main/admin/kerberos/disable_controller.js (line 26) <https://reviews.apache.org/r/54698/#comment229956> It is possible that zookeeper is alreay stopped when user starts de-kerberizing. To handle that situation additional step to start zookeeper will be required. ['stopServices', 'startZk',...] - Jaimin Jetly On Dec. 13, 2016, 1:51 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54698/ > --- > > (Updated Dec. 13, 2016, 1:51 p.m.) > > > Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Oliver Szabo, Robert > Levas, and Sebastian Toader. > > > Bugs: AMBARI-19187 > https://issues.apache.org/jira/browse/AMBARI-19187 > > > Repository: ambari > > > Description > --- > > Hadoop components need to establish a secure connection with ZooKeeper when > Kerberos is enabled. This involves the setup of the correct authentication > (JAAS config file) and authorization (per-component Kerberos-backed ACLs on > the znodes) between the service and ZooKeeper. Most services are able to set > these ACLs based on their config when the user enable kerberos. > When we disable kerberos again, the sasl ACL should be removed otherwise the > services won't be able to access their znodes. > > This issue is about introducing a new command (DISABLE_SECURITY) that will be > sent by the ambari server to the services upon the dekerberiztion process. > When a service receives this command it will be able to do the zookeeper > secure to unsecure migration process (e.g. removing sasl ACLs). > > Notable changes: > - Added a java command line tool to the agent project that can setAcls > recursively on a znode > - Modified the dekerberization workflow: > - 1. UI stops all services but zookeeper > - 2. 2 new stages was introduced in the backend (send DISABLE_SECURITY > command to the services, start zookeeper) > > > Diffs > - > > ambari-agent/pom.xml a8ed7f1 > ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkAcl.java > PRE-CREATION > ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkConnection.java > PRE-CREATION > ambari-agent/src/main/java/org/apache/ambari/tools/zk/ZkMigrator.java > PRE-CREATION > ambari-agent/src/test/java/org/apache/ambari/tools/zk/ZkMigratorTest.java > PRE-CREATION > > ambari-common/src/main/python/resource_management/core/resources/zkmigrator.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 584775e > ambari-server/pom.xml 48ddb52 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > 3261a56 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java > 0064662 > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 90f8098 > ambari-web/app/controllers/main/admin/kerberos/disable_controller.js > cec4503 > > Diff: https://reviews.apache.org/r/54698/diff/ > > > Testing > --- > > Added unittests for ZkMigrator, KerberosHelperImpl > > Manual testings: > - created cluster with ambari > - enabled kerberos > - disabled kerberos > - checked if the DISABLE_SECURITY command was sent to the services > > > Ambari agent: > -- > Ran 450 tests in 10.634s > > Ambari server: > -- > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 34:44.448s > [INFO] Finished at: Tue Dec 13 14:29:00 CET 2016 > [INFO] Final Memory: 160M/798M > > > Thanks, > > Attila Magyar > >
Re: Review Request 54644: Ambari-web unit tests cannot be run in Mac OS Sierra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54644/ --- (Updated Dec. 12, 2016, 6:59 a.m.) Review request for Ambari, Oleg Nechiporenko, Xi Wang, and Yusaku Sako. Bugs: AMBARI-19165 https://issues.apache.org/jira/browse/AMBARI-19165 Repository: ambari Description --- Running "npm test" just hangs in Mac OS Sierra. Also while working on this ticket discovered that ambari-web unit tests as of now are getting short-circuit at https://github.com/apache/ambari/blob/branch-2.5/ambari-web/test/utils/configs/config_initializer_test.js#L954-L970 Thus no test of ambari-web after below file is getting executed as part of "mvn test" in ambari project. https://github.com/apache/ambari/blob/branch-2.5/ambari-web/app/assets/test/tests.js#L213 Diffs - ambari-web/app/assets/test/test.html d8ee080 ambari-web/package.json ad0bce4 ambari-web/test/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller_test.js bd6a67a ambari-web/test/controllers/wizard/step9_test.js b0c4c20 ambari-web/test/utils/configs/config_initializer_test.js d348055 ambari-web/test/utils/date/date_test.js 3d61c90 ambari-web/test/utils/date/timezone_test.js da89586 ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js a6b25ce Diff: https://reviews.apache.org/r/54644/diff/ Testing (updated) --- Verified that all ambari-web unit tests run without getting short-circuited at anypoint: Verified that ambari-web unit test runs on Mac OS X El Capitan, Mac OS Sierra and Ubuntu. npm test: 29760 passing (20s) 154 pending Thanks, Jaimin Jetly
Re: Review Request 54644: Ambari-web unit tests cannot be run in Mac OS Sierra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54644/ --- (Updated Dec. 12, 2016, 6:55 a.m.) Review request for Ambari, Oleg Nechiporenko, Xi Wang, and Yusaku Sako. Bugs: AMBARI-19165 https://issues.apache.org/jira/browse/AMBARI-19165 Repository: ambari Description --- Running "npm test" just hangs in Mac OS Sierra. Also while working on this ticket discovered that ambari-web unit tests as of now are getting short-circuit at https://github.com/apache/ambari/blob/branch-2.5/ambari-web/test/utils/configs/config_initializer_test.js#L954-L970 Thus no test of ambari-web after below file is getting executed as part of "mvn test" in ambari project. https://github.com/apache/ambari/blob/branch-2.5/ambari-web/app/assets/test/tests.js#L213 Diffs - ambari-web/app/assets/test/test.html d8ee080 ambari-web/package.json ad0bce4 ambari-web/test/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller_test.js bd6a67a ambari-web/test/controllers/wizard/step9_test.js b0c4c20 ambari-web/test/utils/configs/config_initializer_test.js d348055 ambari-web/test/utils/date/date_test.js 3d61c90 ambari-web/test/utils/date/timezone_test.js da89586 ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js a6b25ce Diff: https://reviews.apache.org/r/54644/diff/ Testing --- Verified that all ambari-web unit tests run: Verified that ambari-web unit test runs on Mac OS X El Capitan, Mac OS Sierra and Ubuntu. npm test: 29760 passing (20s) 154 pending Thanks, Jaimin Jetly
Re: Review Request 54644: Ambari-web unit tests cannot be run in Mac OS Sierra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54644/ --- (Updated Dec. 12, 2016, 6:55 a.m.) Review request for Ambari, Oleg Nechiporenko, Xi Wang, and Yusaku Sako. Repository: ambari Description --- Running "npm test" just hangs in Mac OS Sierra. Also while working on this ticket discovered that ambari-web unit tests as of now are getting short-circuit at https://github.com/apache/ambari/blob/branch-2.5/ambari-web/test/utils/configs/config_initializer_test.js#L954-L970 Thus no test of ambari-web after below file is getting executed as part of "mvn test" in ambari project. https://github.com/apache/ambari/blob/branch-2.5/ambari-web/app/assets/test/tests.js#L213 Diffs - ambari-web/app/assets/test/test.html d8ee080 ambari-web/package.json ad0bce4 ambari-web/test/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller_test.js bd6a67a ambari-web/test/controllers/wizard/step9_test.js b0c4c20 ambari-web/test/utils/configs/config_initializer_test.js d348055 ambari-web/test/utils/date/date_test.js 3d61c90 ambari-web/test/utils/date/timezone_test.js da89586 ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js a6b25ce Diff: https://reviews.apache.org/r/54644/diff/ Testing --- Verified that all ambari-web unit tests run: Verified that ambari-web unit test runs on Mac OS X El Capitan, Mac OS Sierra and Ubuntu. npm test: 29760 passing (20s) 154 pending Thanks, Jaimin Jetly
