Review Request 64816: Implement download configuration options and custom (i.e. local) repo support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64816/ --- Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-22695 https://issues.apache.org/jira/browse/AMBARI-22695 Repository: ambari Description --- Implement support for downloading mpacks from custom URLs (local repos) and using proxy configuration or Satellite/Spacewalker options. If the Custom/Local download option is selected, present a screen to the user that allows them to input custom URLs for the mpack locations. This will be presented after the mpack selection step. If the user selected the Custom/Local download configuration, present a screen where they can provide custom URLs for each product repo within the mpacks for each OS that is selected. This screen is pre-filled with the public repo URLs and the user can change any or all of them to use a custom URL. Diffs - ambari-web/app/controllers.js 5af0937f9b ambari-web/app/controllers/installer.js 59571e7f3c ambari-web/app/controllers/wizard.js c5a07fff8d ambari-web/app/controllers/wizard/configureDownload_controller.js 08af9603f9 ambari-web/app/controllers/wizard/customMpackRepos_controller.js PRE-CREATION ambari-web/app/controllers/wizard/customProductRepos_controller.js PRE-CREATION ambari-web/app/controllers/wizard/downloadProducts_controller.js d12ae11d1f ambari-web/app/controllers/wizard/selectMpacks_controller.js 7951d155e0 ambari-web/app/controllers/wizard/step0_controller.js 270c7a4b21 ambari-web/app/controllers/wizard/step10_controller.js 6840c1389b ambari-web/app/controllers/wizard/step1_controller.js c137d96b5d ambari-web/app/controllers/wizard/step2_controller.js dffc17e76b ambari-web/app/controllers/wizard/step3_controller.js 36bf05a20e ambari-web/app/controllers/wizard/step4_controller.js d82bf34df5 ambari-web/app/controllers/wizard/step5_controller.js 3ca4165e68 ambari-web/app/controllers/wizard/step6_controller.js b1941f070f ambari-web/app/controllers/wizard/step7_controller.js 4b1eacbd8a ambari-web/app/controllers/wizard/step8_controller.js 3ad65f170c ambari-web/app/controllers/wizard/step9_controller.js 9f27f654a6 ambari-web/app/controllers/wizard/verifyProducts_controller.js PRE-CREATION ambari-web/app/controllers/wizard/wizardStep_controller.js PRE-CREATION ambari-web/app/mappers/stack_mapper.js 415845e6e9 ambari-web/app/messages.js 2efc023cd3 ambari-web/app/mixins/wizard/wizard_menu_view.js 6dd7394bf6 ambari-web/app/models/repository.js c50750feda ambari-web/app/router.js d0b171477e ambari-web/app/routes/installer.js 80cf116f04 ambari-web/app/styles/theme/bootstrap-ambari.css 97419c7782 ambari-web/app/styles/wizard.less 4330c6a81b ambari-web/app/templates/installer.hbs 47e63ccac5 ambari-web/app/templates/wizard/customMpackRepos.hbs PRE-CREATION ambari-web/app/templates/wizard/customProductRepos.hbs PRE-CREATION ambari-web/app/templates/wizard/downloadProducts.hbs a42622507f ambari-web/app/templates/wizard/selectMpacks.hbs d78861e43f ambari-web/app/templates/wizard/verifyProducts.hbs PRE-CREATION ambari-web/app/views.js 8810f1328c ambari-web/app/views/wizard/configureDownload_view.js 71c6527b82 ambari-web/app/views/wizard/customMpackRepos_view.js PRE-CREATION ambari-web/app/views/wizard/customProductRepos_view.js PRE-CREATION ambari-web/app/views/wizard/downloadProducts_view.js b70275a9ea ambari-web/app/views/wizard/verifyProducts_view.js PRE-CREATION ambari-web/test/controllers/installer_test.js 88289b2a43 ambari-web/test/controllers/wizard/selectMpacks_test.js 13e28ce23b Diff: https://reviews.apache.org/r/64816/diff/1/ Testing --- 20297 passing (47s) 125 pending Note that no new tests were added. These will be done later. Current priority is to make this functional for the 1/1/18 milestone. Thanks, Jason Golieb
Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.
> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote:
> > ambari-web/app/routes/installer.js
> > Lines 291 (patched)
> > <https://reviews.apache.org/r/64225/diff/1/?file=1904854#file1904854line291>
> >
> > Could you elaborate on your problem, cause Ember upgrade requires a
> > huge change in the codebase and not feasible in near future?
>
> Jason Golieb wrote:
> OK, first let me say that I spent several hours trying to avoid this
> workaround and I was surprised that something that should be simple was not.
> The scenario is that I need to have a text field with its value bound to a
> field on the controller. I also need to have a change event handler attached
> to the field that **only responds to UI changes**, which is how a normal DOM
> event handler would work. There are two options that I have seen for
> implementing a text field in this code base:
>
> 1. Use a regular `` tag. With this version, I was able to add the
> event handler using `{{action}}`. However, and this is the really strange
> part, I was unable to get the value to bind to the controller. I tried a
> couple variations of `{{bindAttr value="..."}}` but it did not work.
>
> 2. Use `{{view Em.TextField}}`. This has no problem binding the value.
> However, it does not support adding an event handler to the change event.
> (Later versions of Ember seem to support this.)
>
> My solution was to go with #2, and then create an observer of the bound
> value on the controller to perform the change event handling. However, as
> this is observing the controller directly, it reacts to ALL changes to the
> controller value, not just those coming from the UI. That means it gets fired
> on the initialization of the value from the database as well, which is not
> desirable. Therefore, I had to add a Boolean flag to temporarily prevent the
> observer from doing anything during the initial load of the screen.
>
> I do not expect us to upgrade Ember any time soon, but I wanted to leave
> the comment in the code for future understanding.
>
> Andrii Tkach wrote:
> I think that's what you need:
> {{view Em.TextField changeBinding="yourFunc"}}
> Or you can just validate value so after controller initialization it will
> be rejected and after user input will be applied.
I thought I had tried changeBinding before, but I tried it again and it worked.
Thanks! I've updated the patch.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/#review192466
---
On Dec. 1, 2017, 4:28 p.m., Jason Golieb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64225/
> ---
>
> (Updated Dec. 1, 2017, 4:28 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor,
> Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-22569
> https://issues.apache.org/jira/browse/AMBARI-22569
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Enabled the Local Repo radio button.
> Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
> Implemented the "Use Proxy" checkbox and related proxy settings fields.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
> PRE-CREATION
> ambari-web/app/assets/test/tests.js b60e17a3e2
> ambari-web/app/controllers/wizard/configureDownload_controller.js
> 0246ad0602
> ambari-web/app/messages.js e014d4a012
> ambari-web/app/routes/installer.js 73c716b7a9
> ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c
> ambari-web/app/utils.js 509efc15fa
> ambari-web/app/utils/constants.js PRE-CREATION
> ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c
> ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION
> ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64225/diff/2/
>
>
> Testing
> ---
>
> 20297 passing (21s)
> 125 pending
>
>
> Thanks,
>
> Jason Golieb
>
>
Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64225/ --- (Updated Dec. 1, 2017, 4:28 p.m.) Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. Changes --- Removed change handler hack and used changeBinding instead. Bugs: AMBARI-22569 https://issues.apache.org/jira/browse/AMBARI-22569 Repository: ambari Description --- Enabled the Local Repo radio button. Implemented the "Use Red Hat Satellite/Spacewalk" checkbox. Implemented the "Use Proxy" checkbox and related proxy settings fields. Diffs (updated) - ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml PRE-CREATION ambari-web/app/assets/test/tests.js b60e17a3e2 ambari-web/app/controllers/wizard/configureDownload_controller.js 0246ad0602 ambari-web/app/messages.js e014d4a012 ambari-web/app/routes/installer.js 73c716b7a9 ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c ambari-web/app/utils.js 509efc15fa ambari-web/app/utils/constants.js PRE-CREATION ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION Diff: https://reviews.apache.org/r/64225/diff/2/ Changes: https://reviews.apache.org/r/64225/diff/1-2/ Testing --- 20297 passing (21s) 125 pending Thanks, Jason Golieb
Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.
> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote:
> > ambari-web/app/routes/installer.js
> > Lines 291 (patched)
> > <https://reviews.apache.org/r/64225/diff/1/?file=1904854#file1904854line291>
> >
> > Could you elaborate on your problem, cause Ember upgrade requires a
> > huge change in the codebase and not feasible in near future?
OK, first let me say that I spent several hours trying to avoid this workaround
and I was surprised that something that should be simple was not. The scenario
is that I need to have a text field with its value bound to a field on the
controller. I also need to have a change event handler attached to the field
that **only responds to UI changes**, which is how a normal DOM event handler
would work. There are two options that I have seen for implementing a text
field in this code base:
1. Use a regular `` tag. With this version, I was able to add the event
handler using `{{action}}`. However, and this is the really strange part, I was
unable to get the value to bind to the controller. I tried a couple variations
of `{{bindAttr value="..."}}` but it did not work.
2. Use `{{view Em.TextField}}`. This has no problem binding the value. However,
it does not support adding an event handler to the change event. (Later
versions of Ember seem to support this.)
My solution was to go with #2, and then create an observer of the bound value
on the controller to perform the change event handling. However, as this is
observing the controller directly, it reacts to ALL changes to the controller
value, not just those coming from the UI. That means it gets fired on the
initialization of the value from the database as well, which is not desirable.
Therefore, I had to add a Boolean flag to temporarily prevent the observer from
doing anything during the initial load of the screen.
I do not expect us to upgrade Ember any time soon, but I wanted to leave the
comment in the code for future understanding.
- Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64225/#review192466
-------
On Nov. 30, 2017, 9:01 p.m., Jason Golieb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64225/
> ---
>
> (Updated Nov. 30, 2017, 9:01 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor,
> Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako.
>
>
> Bugs: AMBARI-22569
> https://issues.apache.org/jira/browse/AMBARI-22569
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Enabled the Local Repo radio button.
> Implemented the "Use Red Hat Satellite/Spacewalk" checkbox.
> Implemented the "Use Proxy" checkbox and related proxy settings fields.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
> PRE-CREATION
> ambari-web/app/assets/test/tests.js b60e17a3e2
> ambari-web/app/controllers/wizard/configureDownload_controller.js
> 0246ad0602
> ambari-web/app/messages.js e014d4a012
> ambari-web/app/routes/installer.js 73c716b7a9
> ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c
> ambari-web/app/utils.js 509efc15fa
> ambari-web/app/utils/constants.js PRE-CREATION
> ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c
> ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION
> ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/64225/diff/1/
>
>
> Testing
> ---
>
> 20297 passing (21s)
> 125 pending
>
>
> Thanks,
>
> Jason Golieb
>
>
Review Request 64225: Implemented additional functionality on the Configure Download screen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64225/ --- Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-22569 https://issues.apache.org/jira/browse/AMBARI-22569 Repository: ambari Description --- Enabled the Local Repo radio button. Implemented the "Use Red Hat Satellite/Spacewalk" checkbox. Implemented the "Use Proxy" checkbox and related proxy settings fields. Diffs - ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml PRE-CREATION ambari-web/app/assets/test/tests.js b60e17a3e2 ambari-web/app/controllers/wizard/configureDownload_controller.js 0246ad0602 ambari-web/app/messages.js e014d4a012 ambari-web/app/routes/installer.js 73c716b7a9 ambari-web/app/templates/wizard/configureDownload.hbs b62a4d935c ambari-web/app/utils.js 509efc15fa ambari-web/app/utils/constants.js PRE-CREATION ambari-web/app/views/wizard/configureDownload_view.js 8a02c71d6c ambari-web/test/controllers/wizard/configureDownload_test.js PRE-CREATION ambari-web/test/views/wizard/configureDownload_view_test.js PRE-CREATION Diff: https://reviews.apache.org/r/64225/diff/1/ Testing --- 20297 passing (21s) 125 pending Thanks, Jason Golieb
Review Request 63956: Use case and service based mpack selection
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63956/ --- Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-22482 https://issues.apache.org/jira/browse/AMBARI-22482 Repository: ambari Description --- Enable selection of mpacks to install via use cases or by direct service selection. This includes switching between "basic" and "advanced" selection modes. Basic mode allows selection of use cases only. Advanced mode allows selection of mpacks and/or services directly. Diffs - ambari-web/app/controllers/installer.js 14ae790df97 ambari-web/app/controllers/wizard/downloadProducts_controller.js b3537320292 ambari-web/app/controllers/wizard/selectMpacks_controller.js a7c62ff0c6a ambari-web/app/messages.js c9bae250241 ambari-web/app/routes/installer.js 9a49c365344 ambari-web/app/templates/wizard/selectMpacks.hbs 19855d3071e ambari-web/app/templates/wizard/selectMpacks/mpack.hbs 9a65baf5b1a ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs 05e75ffb150 ambari-web/app/templates/wizard/selectMpacks/service.hbs PRE-CREATION ambari-web/app/templates/wizard/selectMpacks/usecase.hbs PRE-CREATION ambari-web/app/utils/ajax/ajax.js f86fd3ddbbf ambari-web/app/views/wizard/selectMpacks_view.js deab12b5354 ambari-web/test/controllers/wizard/selectMpacks_test.js 7102d91f026 Diff: https://reviews.apache.org/r/63956/diff/1/ Testing --- 20287 passing (30s) 124 pending Thanks, Jason Golieb
Review Request 63757: Enable mpack version selection
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63757/ --- Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-22420 https://issues.apache.org/jira/browse/AMBARI-22420 Repository: ambari Description --- Implement the ability to change mpack version in the available mpacks list. Diffs - .gitignore a40e61acbe4 ambari-web/app/app.js 2526baa0047 ambari-web/app/controllers/installer.js 5dd09414804 ambari-web/app/controllers/main/host/add_controller.js 6b158c131ee ambari-web/app/controllers/main/service/add_controller.js c11bcf267a4 ambari-web/app/controllers/wizard.js 540cc638eb2 ambari-web/app/controllers/wizard/configureDownload_controller.js f3a8b1b588a ambari-web/app/controllers/wizard/downloadProducts_controller.js 165debbfb95 ambari-web/app/controllers/wizard/selectMpacks_controller.js 9ab5a125f55 ambari-web/app/controllers/wizard/step2_controller.js 05813e28b3a ambari-web/app/controllers/wizard/step3_controller.js 2c61e02ea76 ambari-web/app/controllers/wizard/step5_controller.js 873665267a9 ambari-web/app/controllers/wizard/step6_controller.js 68ec3edf8de ambari-web/app/controllers/wizard/step7_controller.js 3def063ac00 ambari-web/app/controllers/wizard/step8_controller.js 0c72295d921 ambari-web/app/messages.js 82adc8082b9 ambari-web/app/mixins/wizard/assign_master_components.js 84a56f1d56b ambari-web/app/routes/installer.js 5899ff3d545 ambari-web/app/templates/common/assign_master_components.hbs a47e3f631a9 ambari-web/app/templates/wizard/selectMpacks.hbs dd55ff307a6 ambari-web/app/templates/wizard/selectMpacks/mpack.hbs aea598e3829 ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs cba1177052f ambari-web/app/templates/wizard/step2.hbs b4ee25c4113 ambari-web/app/templates/wizard/step3.hbs b480fd317c5 ambari-web/app/templates/wizard/step6.hbs 5741f09f36a ambari-web/app/views.js 1ef0b62321b ambari-web/app/views/wizard/selectMpacks/mpack_view.js 9c22eb98d76 ambari-web/app/views/wizard/selectMpacks/selectedMpackVersion_view.js ca503d78510 ambari-web/app/views/wizard/selectMpacks_view.js 3dc4ec05166 ambari-web/app/views/wizard/step2_view.js 6bbda30625e ambari-web/app/views/wizard/step6_view.js ab37245d9b8 ambari-web/test/controllers/installer_test.js f581d91857d ambari-web/test/controllers/main/host/add_controller_test.js 089d0182d76 ambari-web/test/controllers/main/service/add_controller_test.js 1119176977a ambari-web/test/controllers/wizard/selectMpacks_test.js 73210b460d3 ambari-web/test/controllers/wizard/step5_test.js 57c33b23afd ambari-web/test/controllers/wizard/step6_test.js 85b4fab283e ambari-web/test/controllers/wizard/step8_test.js fc977b764c2 ambari-web/test/views/wizard/step2_view_test.js 93939682a7d ambari-web/test/views/wizard/step6_view_test.js 7a4dc9f2d3d Diff: https://reviews.apache.org/r/63757/diff/1/ Testing --- 20268 passing (20s) 124 pending Thanks, Jason Golieb
Re: Review Request 63683: Improve install wizard data handling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63683/ --- (Updated Nov. 8, 2017, 9:19 p.m.) Review request for Ambari, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku Sako. Bugs: AMBARI-22385 https://issues.apache.org/jira/browse/AMBARI-22385 Repository: ambari Description --- Make data persistence more consistent by using consistent method calls and locating them in the same place for each step. This ensures that all steps persist if the browser is reloaded. Also, improve data handling behavior when navigating backward in the wizard. Now, the wizard tracks the saved state of all steps. If the user navigates backward, there will be a warning displayed indicating that if they make changes, they will lose saved data in later steps. If they don't change anything, they can navigate back and forth without losing data. If they do change something, the state of all later steps is reset. Diffs - .gitignore a40e61acbe4 ambari-web/app/app.js 2526baa0047 ambari-web/app/controllers/installer.js 5dd09414804 ambari-web/app/controllers/main/host/add_controller.js 6b158c131ee ambari-web/app/controllers/main/service/add_controller.js c11bcf267a4 ambari-web/app/controllers/wizard.js 540cc638eb2 ambari-web/app/controllers/wizard/configureDownload_controller.js f3a8b1b588a ambari-web/app/controllers/wizard/downloadProducts_controller.js 165debbfb95 ambari-web/app/controllers/wizard/selectMpacks_controller.js 9ab5a125f55 ambari-web/app/controllers/wizard/step2_controller.js 05813e28b3a ambari-web/app/controllers/wizard/step3_controller.js 2c61e02ea76 ambari-web/app/controllers/wizard/step5_controller.js 873665267a9 ambari-web/app/controllers/wizard/step6_controller.js 68ec3edf8de ambari-web/app/controllers/wizard/step7_controller.js 3def063ac00 ambari-web/app/controllers/wizard/step8_controller.js 0c72295d921 ambari-web/app/messages.js 82adc8082b9 ambari-web/app/mixins/wizard/assign_master_components.js 84a56f1d56b ambari-web/app/routes/installer.js 5899ff3d545 ambari-web/app/templates/common/assign_master_components.hbs a47e3f631a9 ambari-web/app/templates/wizard/selectMpacks.hbs dd55ff307a6 ambari-web/app/templates/wizard/selectMpacks/mpack.hbs aea598e3829 ambari-web/app/templates/wizard/selectMpacks/selectedMpackVersion.hbs cba1177052f ambari-web/app/templates/wizard/step2.hbs b4ee25c4113 ambari-web/app/templates/wizard/step3.hbs b480fd317c5 ambari-web/app/templates/wizard/step6.hbs 5741f09f36a ambari-web/app/views.js 1ef0b62321b ambari-web/app/views/wizard/selectMpacks/mpack_view.js 9c22eb98d76 ambari-web/app/views/wizard/selectMpacks/selectedMpackVersion_view.js ca503d78510 ambari-web/app/views/wizard/selectMpacks_view.js 3dc4ec05166 ambari-web/app/views/wizard/step2_view.js 6bbda30625e ambari-web/app/views/wizard/step6_view.js ab37245d9b8 ambari-web/test/controllers/installer_test.js f581d91857d ambari-web/test/controllers/main/host/add_controller_test.js 089d0182d76 ambari-web/test/controllers/main/service/add_controller_test.js 1119176977a ambari-web/test/controllers/wizard/step5_test.js 57c33b23afd ambari-web/test/controllers/wizard/step6_test.js 85b4fab283e ambari-web/test/controllers/wizard/step8_test.js fc977b764c2 ambari-web/test/views/wizard/step2_view_test.js 93939682a7d ambari-web/test/views/wizard/step6_view_test.js 7a4dc9f2d3d Diff: https://reviews.apache.org/r/63683/diff/1/ Testing --- 20262 passing (23s) 124 pending This also resolved outstanding unit tests from AMBARI-22311 Thanks, Jason Golieb
Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/ --- (Updated Sept. 13, 2017, 6:31 p.m.) Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako. Changes --- Updated summary Summary (updated) - AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal Bugs: AMBARI-21933 https://issues.apache.org/jira/browse/AMBARI-21933 Repository: ambari Description --- Implement breadcrumb navigation in the Background Operations modal and the drill-down views within it. This also affects the use of these views in the High Availability wizard. The breadcrumbs will provide a better navigation experience within this series of dialogs, helping the user to see the context of the current view and to navigate back up the hierarchy more easily. It will also be more consistent with the overall UX of Ambari 3.0.0. Diffs - ambari-web/app/controllers/global/background_operations_controller.js de420b5a131 ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js 4cbe59b020c ambari-web/app/messages.js 87a5e97a68d ambari-web/app/styles/modal_popups.less f7fe88be71d ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 ambari-web/app/utils/host_progress_popup.js 5bd02cd76de ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 ambari-web/test/controllers/global/background_operations_test.js 4a8235c484b ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js 364d9b0b451 ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 ambari-web/test/views/common/host_progress_popup_body_view_test.js 5ccc0245101 Diff: https://reviews.apache.org/r/62242/diff/2/ Testing --- 21293 passing Thanks, Jason Golieb
Re: Review Request 62242: Implement breadcrumbs in Background Operations modal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/ --- (Updated Sept. 12, 2017, 7:07 p.m.) Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako. Changes --- Completed unit testing. Bugs: AMBARI-21933 https://issues.apache.org/jira/browse/AMBARI-21933 Repository: ambari Description --- Implement breadcrumb navigation in the Background Operations modal and the drill-down views within it. This also affects the use of these views in the High Availability wizard. The breadcrumbs will provide a better navigation experience within this series of dialogs, helping the user to see the context of the current view and to navigate back up the hierarchy more easily. It will also be more consistent with the overall UX of Ambari 3.0.0. Diffs (updated) - ambari-web/app/controllers/global/background_operations_controller.js de420b5a131 ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js 4cbe59b020c ambari-web/app/messages.js 87a5e97a68d ambari-web/app/styles/modal_popups.less f7fe88be71d ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 ambari-web/app/utils/host_progress_popup.js 5bd02cd76de ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 ambari-web/test/controllers/global/background_operations_test.js 4a8235c484b ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js 364d9b0b451 ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 ambari-web/test/views/common/host_progress_popup_body_view_test.js 5ccc0245101 Diff: https://reviews.apache.org/r/62242/diff/2/ Changes: https://reviews.apache.org/r/62242/diff/1-2/ Testing (updated) --- 21293 passing Thanks, Jason Golieb
Review Request 62242: Implement breadcrumbs in Background Operations modal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-21933 https://issues.apache.org/jira/browse/AMBARI-21933 Repository: ambari Description --- Implement breadcrumb navigation in the Background Operations modal and the drill-down views within it. This also affects the use of these views in the High Availability wizard. The breadcrumbs will provide a better navigation experience within this series of dialogs, helping the user to see the context of the current view and to navigate back up the hierarchy more easily. It will also be more consistent with the overall UX of Ambari 3.0.0. Diffs - ambari-web/app/controllers/global/background_operations_controller.js de420b5a131 ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js 4cbe59b020c ambari-web/app/messages.js 87a5e97a68d ambari-web/app/styles/modal_popups.less f7fe88be71d ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 ambari-web/app/utils/host_progress_popup.js 5bd02cd76de ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 ambari-web/test/controllers/global/background_operations_test.js 4a8235c484b ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js 364d9b0b451 ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 ambari-web/test/views/common/host_progress_popup_body_view_test.js 5ccc0245101 Diff: https://reviews.apache.org/r/62242/diff/1/ Testing --- Pending Thanks, Jason Golieb
