Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61813/ --- Review request for Ambari, Jayush Luniya, Juanjo Marron, and Tim Thorpe. Bugs: AMBARI-21779 https://issues.apache.org/jira/browse/AMBARI-21779 Repository: ambari Description --- Storm Service should not include the following "" ranger-ugsync-site ranger-admin-site Else making any configuration change in Ranger service (for example: "Ranger User Info") will ask Storm service to be restarted. Looks like as part of JIRA "AMBARI-16250" this dependency was added in bulk by mistake. Diffs - ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 0c62c1a ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/metainfo.xml 1bc23e4 ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 084eac2 ambari-server/src/main/resources/common-services/STORM/1.1.0/metainfo.xml 94f5ca3 Diff: https://reviews.apache.org/r/61813/diff/1/ Testing --- . Thanks, Jay SenSharma
Review Request 61248: Grafana Kafka-Topic dashboard is forming incorrect url 'NaNundefined' appended
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61248/ --- Review request for Ambari, Aravindan Vijayan, Richard Zang, Sid Wagle, and Vivek Ratnavel Subramanian. Bugs: AMBARI-21600 https://issues.apache.org/jira/browse/AMBARI-21600 Repository: ambari Description --- - In Ambari 2.5.1, inside the Grafana UI "Kafka-Topic" dashboard is forming incorrect url, which has 'NaNundefined' appended to it, This is causing any kafka topic related graph to not work in grafana. Those graphs shows "No datapoint". - Affected graphs are "Mesages In & Bytes IN & OUT", "Fetch Requests", "Produce Requests", Shows "No datapoints". http://$GRAFANA_HOST:3000/dashboard/db/kafka-topics Diffs - ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b4a339e Diff: https://reviews.apache.org/r/61248/diff/1/ Testing --- - Manual testing done on Ambari 2.5.1 with the mentioned fix inside the "/usr/lib/ambari-metrics-grafana/public/app/plugins/datasource/ambari-metrics/datasource.js" file. Thanks, Jay SenSharma
Re: Review Request 60265: Grafana Yarn Queue dashboard is not working due to incorrect startTime.
> On June 21, 2017, 4:21 p.m., Aravindan Vijayan wrote: > > LGTM. Can you add a UI enginner (Vivek Subramanian or Richard Zang) to the > > review? Added reviewer 'rzang, vivekratnavel' - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60265/#review178503 --- On June 21, 2017, 12:35 p.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60265/ > --- > > (Updated June 21, 2017, 12:35 p.m.) > > > Review request for Ambari, Aravindan Vijayan and Sid Wagle. > > > Bugs: AMBARI-21290 > https://issues.apache.org/jira/browse/AMBARI-21290 > > > Repository: ambari > > > Description > --- > > In Ambari 2.5.1 when user try to access Grafana "Yarn Queue" dashboard it > throws error 400 Bad request. > This is because the startTime is formed incorrectly inside the dashboard.js. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 72e64e2 > > > Diff: https://reviews.apache.org/r/60265/diff/2/ > > > Testing > --- > > Manually tested, that after the mentioned fix in the "datasource.js" the > "startTime" value is getting generated properly. > > > Thanks, > > Jay SenSharma > >
Re: Review Request 60265: Grafana Yarn Queue dashboard is not working due to incorrect startTime.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60265/ --- (Updated June 21, 2017, 12:35 p.m.) Review request for Ambari, Aravindan Vijayan and Sid Wagle. Changes --- The "target.templatedCluster" can be 'undefined' so adding a check for it so that when it is undefined then it will be replaced with '' Bugs: AMBARI-21290 https://issues.apache.org/jira/browse/AMBARI-21290 Repository: ambari Description --- In Ambari 2.5.1 when user try to access Grafana "Yarn Queue" dashboard it throws error 400 Bad request. This is because the startTime is formed incorrectly inside the dashboard.js. Diffs (updated) - ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 72e64e2 Diff: https://reviews.apache.org/r/60265/diff/2/ Changes: https://reviews.apache.org/r/60265/diff/1-2/ Testing --- Manually tested, that after the mentioned fix in the "datasource.js" the "startTime" value is getting generated properly. Thanks, Jay SenSharma
Re: Review Request 60265: Grafana Yarn Queue dashboard is not working due to incorrect startTime.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60265/ --- (Updated June 21, 2017, 9:48 a.m.) Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-21290 https://issues.apache.org/jira/browse/AMBARI-21290 Repository: ambari Description --- In Ambari 2.5.1 when user try to access Grafana "Yarn Queue" dashboard it throws error 400 Bad request. This is because the startTime is formed incorrectly inside the dashboard.js. Diffs - ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 72e64e2 Diff: https://reviews.apache.org/r/60265/diff/1/ Testing (updated) --- Manually tested, that after the mentioned fix in the "datasource.js" the "startTime" value is getting generated properly. Thanks, Jay SenSharma
Review Request 60265: Grafana Yarn Queue dashboard is not working due to incorrect startTime.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60265/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-21290 https://issues.apache.org/jira/browse/AMBARI-21290 Repository: ambari Description --- In Ambari 2.5.1 when user try to access Grafana "Yarn Queue" dashboard it throws error 400 Bad request. This is because the startTime is formed incorrectly inside the dashboard.js. Diffs - ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 72e64e2 Diff: https://reviews.apache.org/r/60265/diff/1/ Testing --- Manual testing done. Thanks, Jay SenSharma
Review Request 60180: Amabri user create and remote cluster registration HTML forms should use POST method instead of GET.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60180/ --- Review request for Ambari, DIPAYAN BHOWMICK, Zhe (Joe) Wang, Pallav Kulshreshtha, Richard Zang, and Yusaku Sako. Bugs: AMBARI-21276 https://issues.apache.org/jira/browse/AMBARI-21276 Repository: ambari Description --- - Using of GET method for forms can show the data in Query String on form submission. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/remoteClusterPage.html 397149a ambari-admin/src/main/resources/ui/admin-web/app/views/users/create.html 80a3b04 Diff: https://reviews.apache.org/r/60180/diff/1/ Testing --- Manual testing done. Thanks, Jay SenSharma
Re: Review Request 55875: [AMBARI-18961] Ambari HiveView does not create or upload script in UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55875/ --- (Updated Jan. 24, 2017, 11:32 a.m.) Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. Bugs: AMBARI-18961 https://issues.apache.org/jira/browse/AMBARI-18961 Repository: ambari Description --- HiveView should use the UTF-8 character set for the queries entered in the 'Query Editor' while submitting the queries. The Special characters like Currency symbols '€' should not be replaced with '?' Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/files/FileService.java 654bfcc contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 4e1d24f Diff: https://reviews.apache.org/r/55875/diff/ Testing --- Manual Testing done. Checked the hive logs if the UTF-8 characters are being passed to it properly or not. Thanks, Jay SenSharma
Review Request 55875: [AMBARI-18961] Ambari HiveView does not create or upload script in UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55875/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. Bugs: AMBARI-18961 https://issues.apache.org/jira/browse/AMBARI-18961 Repository: ambari Description --- HiveView should use the UTF-8 character set for the queries entered in the 'Query Editor' while submitting the queries. The Special characters like Currency symbols '€' should not be replaced with '?' Diffs - contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/files/FileService.java 654bfcc contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java 4e1d24f Diff: https://reviews.apache.org/r/55875/diff/ Testing --- Manual Testing done. Checked the hive logs if the UTF-8 characters are being passed to it properly or not. Thanks, Jay SenSharma
Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.
> On Jan. 17, 2017, 8:08 p.m., Nate Cole wrote: > > Ping. > > Sumit Mohanty wrote: > I just committed it. Jay can you close it. Sumit, i see 'Alejandro' has some queries related to the property change to existing clusters. Once that discussion is over then we can close this review. - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55129/#review161930 --- On Jan. 3, 2017, 8:41 a.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55129/ > --- > > (Updated Jan. 3, 2017, 8:41 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-19337 > https://issues.apache.org/jira/browse/AMBARI-19337 > > > Repository: ambari > > > Description > --- > > YARN proxyusers properties has spelling mistake. For a long time the property > has ".proxyusers." where as it is supposed to be ".proxyuser." Even though > the incorrect properties will be ignored by YARN however it should be good to > correct the spelling mistake on these properties. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json > a8379ee > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json > 4cb18a9 > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json > 784589c > > ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json > 74b5746 > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json > c20bd23 > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json > 4cb18a9 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json > f33c07d > > ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json > 0d0c6f5 > > ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json > a9e0bcd > ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24 > ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8 > > Diff: https://reviews.apache.org/r/55129/diff/ > > > Testing > --- > > Existing testcases does not directly address this. So test not performed. > > > Thanks, > > Jay SenSharma > >
Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55129/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-19337 https://issues.apache.org/jira/browse/AMBARI-19337 Repository: ambari Description --- YARN proxyusers properties has spelling mistake. For a long time the property has ".proxyusers." where as it is supposed to be ".proxyuser." Even though the incorrect properties will be ignored by YARN however it should be good to correct the spelling mistake on these properties. Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json a8379ee ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 4cb18a9 ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 784589c ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json 74b5746 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json c20bd23 ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 4cb18a9 ambari-server/src/main/resources/stacks/PERF/1.0/services/YARN/kerberos.json f33c07d ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json 0d0c6f5 ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json a9e0bcd ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json d853f24 ambari-web/app/data/configs/wizards/secure_mapping.js 8d952e8 Diff: https://reviews.apache.org/r/55129/diff/ Testing --- Existing testcases does not directly address this. So test not performed. Thanks, Jay SenSharma
Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
> On Aug. 31, 2016, 1:55 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Can this fix be pushed to trunk? - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/#review147432 --- On Aug. 31, 2016, 8:08 a.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51550/ > --- > > (Updated Aug. 31, 2016, 8:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan > Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. > > > Bugs: AMBARI-18284 > https://issues.apache.org/jira/browse/AMBARI-18284 > > > Repository: ambari > > > Description > --- > > Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when > next time pig view loads the scripts from HDFS those have junk characters. > > > Diffs > - > > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 9dea2a2 > > Diff: https://reviews.apache.org/r/51550/diff/ > > > Testing > --- > > Test Succeeded fine. After aplying the fix the PigView shows the script with > the correct characters. > > > Thanks, > > Jay SenSharma > >
Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18284 https://issues.apache.org/jira/browse/AMBARI-18284 Repository: ambari Description --- Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when next time pig view loads the scripts from HDFS those have junk characters. Diffs - contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java 9dea2a2 Diff: https://reviews.apache.org/r/51550/diff/ Testing --- Test Succeeded fine. After aplying the fix the PigView shows the script with the correct characters. Thanks, Jay SenSharma
Review Request 51382: AMBARI-18250
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51382/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18250 https://issues.apache.org/jira/browse/AMBARI-18250 Repository: ambari Description --- Pig View Caching issue causes File does not exist: /user//pig/jobs/job_id/stdout and stderr intermittently Diffs - contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js 38ee093 Diff: https://reviews.apache.org/r/51382/diff/ Testing --- done. Issue is intermittent and can not be reproduced everytime. Thanks, Jay SenSharma
