Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58416/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, and venkat sairam. Bugs: AMBARI-20719 https://issues.apache.org/jira/browse/AMBARI-20719 Repository: ambari Description --- Added the conditions to show up on mouse move in flow graph Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js e74c873 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 0c5257e Diff: https://reviews.apache.org/r/58416/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58384/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, and venkat sairam. Bugs: AMBARI-20740 https://issues.apache.org/jira/browse/AMBARI-20740 Repository: ambari Description --- Added the api parameter(len 1000) to fetch all actions for a coordinator. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js 3fecbaa contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs b3f1097 Diff: https://reviews.apache.org/r/58384/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58341: Issue while adding custom job.properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58341/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20705 https://issues.apache.org/jira/browse/AMBARI-20705 Repository: ambari Description --- Added the custom properties if it is present even without clicking '+' Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js efe8385 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs e3d49ec Diff: https://reviews.apache.org/r/58341/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58230: Zooming workflows should happen more smoothly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58230/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20689 https://issues.apache.org/jira/browse/AMBARI-20689 Repository: ambari Description --- Changed the zoom factor of the workflow. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 03f0ae1 Diff: https://reviews.apache.org/r/58230/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58205: Centering workflows for zoom breaks when multiple tabs exists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58205/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20677 https://issues.apache.org/jira/browse/AMBARI-20677 Repository: ambari Description --- Made the workflow to center while switching between the tabs for the first time Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 980904f contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js fa7c861 contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js af84f86 Diff: https://reviews.apache.org/r/58205/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58204: User should be able to visualize inherited properties while submitting the workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58204/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20676 https://issues.apache.org/jira/browse/AMBARI-20676 Repository: ambari Description --- Added the inherited properies such as resourceManager, nameNode to job.properties while submitting the workflow. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 6aed9da contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 6d94dfe contrib/views/wfmanager/src/main/resources/ui/app/services/workflow-manager-configs.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/workflow-manager-configs-test.js PRE-CREATION Diff: https://reviews.apache.org/r/58204/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58170: The Zoom feature in WFM, hides the WF completely either with Maximum and Min
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58170/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20413 https://issues.apache.org/jira/browse/AMBARI-20413 Repository: ambari Description --- Removed the panning by x and made the graph to center on start node. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js bfe59e2 Diff: https://reviews.apache.org/r/58170/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58168: Need to auto populate the workflow parameters if its already defined in the global space
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58168/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20662 https://issues.apache.org/jira/browse/AMBARI-20662 Repository: ambari Description --- Populated job.properties with default values if the property is defined in workflow parameters Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js e9c7c15 Diff: https://reviews.apache.org/r/58168/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 58135: Workflow should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58135/ --- (Updated April 4, 2017, 6:01 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20654 https://issues.apache.org/jira/browse/AMBARI-20654 Repository: ambari Description --- Stored the job.properties on submission and retrieving the values when reopening the modal window Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 5f885e7 contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0da9f71 Diff: https://reviews.apache.org/r/58135/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 58138: Need to improve the grouping of the nodes available in transition section of WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58138/ --- (Updated April 4, 2017, 6:01 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20655 https://issues.apache.org/jira/browse/AMBARI-20655 Repository: ambari Description --- Moved the options inside optiongroup for ok to and error to transition selections. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs 83fe96c Diff: https://reviews.apache.org/r/58138/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/ --- (Updated April 4, 2017, 6 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20653 https://issues.apache.org/jira/browse/AMBARI-20653 Repository: ambari Description --- Removed the save button Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js 1072ca4 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs 366920d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/2/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 58139: Coordinator and bundle should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58139/ --- (Updated April 4, 2017, 6 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20656 https://issues.apache.org/jira/browse/AMBARI-20656 Repository: ambari Description --- Stored the job.properties when coordinator or bundle is submitted. Retrieving the submitted values and showing in the modal window. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 7c63b47 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js e8f8cc1 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 39ab06d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 0e35d0e Diff: https://reviews.apache.org/r/58139/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58139: Coordinator and bundle should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58139/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20656 https://issues.apache.org/jira/browse/AMBARI-20656 Repository: ambari Description --- Stored the job.properties when coordinator or bundle is submitted. Retrieving the submitted values and showing in the modal window. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 7c63b47 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js e8f8cc1 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 39ab06d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 0e35d0e Diff: https://reviews.apache.org/r/58139/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58138: Need to improve the grouping of the nodes available in transition section of WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58138/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20655 https://issues.apache.org/jira/browse/AMBARI-20655 Repository: ambari Description --- Moved the options inside optiongroup for ok to and error to transition selections. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/templates/components/transition-config.hbs 83fe96c Diff: https://reviews.apache.org/r/58138/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/ --- (Updated April 3, 2017, 8:07 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20653 https://issues.apache.org/jira/browse/AMBARI-20653 Repository: ambari Description --- Removed the save button Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js 1072ca4 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs 366920d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/2/ Changes: https://reviews.apache.org/r/58134/diff/1-2/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58135: Workflow should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58135/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20654 https://issues.apache.org/jira/browse/AMBARI-20654 Repository: ambari Description --- Stored the job.properties on submission and retrieving the values when reopening the modal window Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 5f885e7 contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 15c1fbf contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 0da9f71 Diff: https://reviews.apache.org/r/58135/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha. Bugs: AMBARI-20653 https://issues.apache.org/jira/browse/AMBARI-20653 Repository: ambari Description --- Removed the save button Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js 1072ca4 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs 366920d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs 464221f Diff: https://reviews.apache.org/r/58134/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 57841: Make home directory check as optional in wfmanager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/ --- (Updated March 24, 2017, 5:58 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20529 https://issues.apache.org/jira/browse/AMBARI-20529 Repository: ambari Description --- Added property(views.skip.home-directory-check.file-system.list) to skip home directory check Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java d06eb07 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java d82f928 contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js f4d93ea contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e Diff: https://reviews.apache.org/r/57841/diff/2/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 57841: Make home directory check as optional in wfmanager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/ --- (Updated March 23, 2017, 10:48 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20529 https://issues.apache.org/jira/browse/AMBARI-20529 Repository: ambari Description --- Added property(views.skip.home-directory-check.file-system.list) to skip home directory check Diffs (updated) - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java d06eb07 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java d82f928 contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js f4d93ea contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e Diff: https://reviews.apache.org/r/57841/diff/2/ Changes: https://reviews.apache.org/r/57841/diff/1-2/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57841: Make home directory check as optional in wfmanager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57841/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallavi Rao. Bugs: AMBARI-20529 https://issues.apache.org/jira/browse/AMBARI-20529 Repository: ambari Description --- Added property(views.skip.home-directory-check.file-system.list) to skip home directory check Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java d06eb07 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java d82f928 contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js f4d93ea contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 316ec0e Diff: https://reviews.apache.org/r/57841/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57682: Workflow manager is only showing 10 actions for a workflow in dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57682/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav Kulshreshtha. Bugs: AMBARI-20479 https://issues.apache.org/jira/browse/AMBARI-20479 Repository: ambari Description --- Removed the api parameter(len) to fetch all actions for a workflow. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 5d8d0a0 contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js 7d0fa92 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 837276b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs fe4c892 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs dd972b9 Diff: https://reviews.apache.org/r/57682/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57636: Need to improve log viewing on workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57636/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav Kulshreshtha. Bugs: AMBARI-20455 https://issues.apache.org/jira/browse/AMBARI-20455 Repository: ambari Description --- Made the styling changes to show logs within workflow container Diffs - contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0d96af4 Diff: https://reviews.apache.org/r/57636/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57552: AMBARI-20413. The Zoom feature in WFM, hides the WF completely either with Maximum and Min
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57552/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20413 https://issues.apache.org/jira/browse/AMBARI-20413 Repository: ambari Description --- Made the cytoscape flow graph centered using the start node and panned y by 50 Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js bfe59e2 Diff: https://reviews.apache.org/r/57552/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57505: AMBARI-20360. Need to show appropriate error message in cases of UI failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57505/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20360 https://issues.apache.org/jira/browse/AMBARI-20360 Repository: ambari Description --- Added error message to show if workflow xml doesn't contain workflow-app tag, similarly coordinator-app tag for coordinator xml and bundle-app tag for bundle xml. And also added the check for maximum number of nodes to render and shown the error message if it exceeds maximum. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e94d51a contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js c87ea99 contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js fdb4f5e contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 37992be contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js b3eed4b contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 12d923c contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js a076e3e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 3cab194 Diff: https://reviews.apache.org/r/57505/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57445: AMBARI-20359. Not able to import workflow with fs action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57445/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20359 https://issues.apache.org/jira/browse/AMBARI-20359 Repository: ambari Description --- Added the xmlDoc parameter to handle import node functionality Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js ccf8209 Diff: https://reviews.apache.org/r/57445/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57412/ --- (Updated March 8, 2017, 11:10 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Changes --- Removed wild card imports. Bugs: AMBARI-20353 https://issues.apache.org/jira/browse/AMBARI-20353 Repository: ambari Description --- Logger added to log exception while steaming the output Diffs (updated) - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda Diff: https://reviews.apache.org/r/57412/diff/2/ Changes: https://reviews.apache.org/r/57412/diff/1-2/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57414: AMBARI-20337. Need to show timer while loading coordinator name while bundle creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57414/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20337 https://issues.apache.org/jira/browse/AMBARI-20337 Repository: ambari Description --- Added the loading icon while fetching the coordinator name. And also showing the error message if any exception occurs. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-coord-config.js 2280f82 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 2d374a5 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 56cacd6 Diff: https://reviews.apache.org/r/57414/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57412: AMBARI-20353. Log error while importing the workflow from encrypted path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57412/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20353 https://issues.apache.org/jira/browse/AMBARI-20353 Repository: ambari Description --- Logger added to log exception while steaming the output Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9bf2f90 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 0b9adda Diff: https://reviews.apache.org/r/57412/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57289: AMBARI-20301. Ember should take node version specific to wfmanager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57289/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20301 https://issues.apache.org/jira/browse/AMBARI-20301 Repository: ambari Description --- Changing the execution of ember from local node Diffs - contrib/views/wfmanager/pom.xml 564a82d Diff: https://reviews.apache.org/r/57289/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57283: AMBARI-20295. Workflow manager view is not loading
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57283/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20295 https://issues.apache.org/jira/browse/AMBARI-20295 Repository: ambari Description --- Latest version of cytoscape.js is having issues. So setting the bower working versions. Diffs - contrib/views/wfmanager/src/main/resources/ui/bower.json b44a83b Diff: https://reviews.apache.org/r/57283/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57267: AMBARI-20247. Show full error while importing the workflow from encrypted file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57267/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20247 https://issues.apache.org/jira/browse/AMBARI-20247 Repository: ambari Description --- Showing the full stack trace on the UI if there is an exception. And also added the loggers. Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java c4e5bbd contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java 3355c85 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java fd4ce80 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java e1a5808 Diff: https://reviews.apache.org/r/57267/diff/1/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57029: AMBARI-20167. importing from workflow from the coordinator setup hangs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57029/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20167 https://issues.apache.org/jira/browse/AMBARI-20167 Repository: ambari Description --- Validating the path before import. Disabling the import if path has variables. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 4a57e37 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 7db5ce2 Diff: https://reviews.apache.org/r/57029/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 57027: AMBARI-20142. Job Link URL not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57027/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20142 https://issues.apache.org/jira/browse/AMBARI-20142 Repository: ambari Description --- Showing the Job Url link if it starts with http Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-action.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js 7a868fa contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs b5565c8 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 309c281 contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-action-test.js PRE-CREATION Diff: https://reviews.apache.org/r/57027/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56979: AMBARI-20050. Issue while importing workflow with insufficient permissions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56979/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20050 https://issues.apache.org/jira/browse/AMBARI-20050 Repository: ambari Description --- Exception handling properly Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java 55c4312 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 6603a9c contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java ef3b508 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/ErrorCode.java PRE-CREATION contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmException.java PRE-CREATION contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/exception/WfmWebException.java PRE-CREATION contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java a0aa234 contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 3ccbc07 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js bbd619d contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js 7a7c38d contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f97add8 contrib/views/wfmanager/src/main/resources/ui/app/components/stack-trace-dialog.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less e98d182 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs ca58431 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 7b607ca contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8438255 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 1a73421 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/stack-trace-dialog.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/stack-trace-dialog-test.js PRE-CREATION Diff: https://reviews.apache.org/r/56979/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56843: AMBARI-20077. Server Error when trying to save and not overwrite
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56843/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20077 https://issues.apache.org/jira/browse/AMBARI-20077 Repository: ambari Description --- Saving recent workflow has been changed to make it per user and also draft file save will be overwritten automatically. This solves the server errors in the bug described. Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java a119a7e contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java 9791c47 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 61d878e contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java 24c263b contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java fc08b80 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java 7513107 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 1fc0c5f contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js db7a180 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 369481f contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 29c9dd2 contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 75cdaf9 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 26e72d5 Diff: https://reviews.apache.org/r/56843/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56598: AMBARI-19985. Workflow Manager Styling changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56598/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19985 https://issues.apache.org/jira/browse/AMBARI-19985 Repository: ambari Description --- Fixed the styling changes ie, changing action items to blue color Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 83a1b27 contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js d1343b0 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 750ba62 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 623f2e0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 00e8b76 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs bca8dfa contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 044e053 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs aafae4a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs 80f3b14 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 33e3d56 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 265da9f contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 8865663 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js ef0758a Diff: https://reviews.apache.org/r/56598/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56539: AMBARI-19956. Workflow Manager Flow Graph should show line transition to decision path and error node.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56539/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19956 https://issues.apache.org/jira/browse/AMBARI-19956 Repository: ambari Description --- Made the changes to cytoscape datanodes to show transitions to decision path and error node Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 6507c49 Diff: https://reviews.apache.org/r/56539/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56440: AMBARI-19920. Workfow Manger- Issue in flow graph active transitions in case of decision and fork.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56440/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19920 https://issues.apache.org/jira/browse/AMBARI-19920 Repository: ambari Description --- Made all the transitions visited to green and not visited to grey Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js d0c5d11 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js e410262 Diff: https://reviews.apache.org/r/56440/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56207: AMBARI-19843. Publish asset has issues when different users logins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56207/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19843 https://issues.apache.org/jira/browse/AMBARI-19843 Repository: ambari Description --- Appended the temp workflow file name with random number for dry run. And also Deleting the temp workflow file after dry run. Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java af86810 Diff: https://reviews.apache.org/r/56207/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56168: AMBARI-19819. Styling changes and spelling fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56168/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19819 https://issues.apache.org/jira/browse/AMBARI-19819 Repository: ambari Description --- Fixed style changes and spellings Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 62d3be3 contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js fe6dfd1 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js f897d48 contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js beb15f6 contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 91e1ce3 contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 54d13ff contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5080560 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/archive-config.hbs 166a202 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs e11d896 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 7bc48d7 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs 7fd1236 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 6ca85c6 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 140ff0a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs 97eb859 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 1c80312 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 1418121 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/date-with-expr.hbs 4c86f3d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8b2911b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs f7a93e0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 66d3460 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs 923d89e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/help-icon.hbs a853955 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs eb959c3 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs 563cca8 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/instance-list-config.hbs 94f4e39 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs 7ffdf5f contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs c783ad0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs 25d81dd contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs f69a2d4 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/pig-action.hbs d0fe490 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config-fs.hbs 545664f contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs fab0d97 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs 913dc04 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs 4673c732 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 5b7e7a3 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sub-workflow.hbs 2841188 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs bb089c0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-config.hbs d425bd0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 89997aa contrib/views/wfmanager/src/main/resources/ui/app/validators/operand-length.js b79596b Diff: https://reviews.apache.org/r/56168/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 56068: AMBARI-19772. Job XML tag is not coming as part of FS action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56068/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19772 https://issues.apache.org/jira/browse/AMBARI-19772 Repository: ambari Description --- Added job-xml mapping to fs action node Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js c9d9887 Diff: https://reviews.apache.org/r/56068/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55840: AMBARI-19674. Asset Manager import and validation issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55840/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary. Bugs: AMBARI-19674 https://issues.apache.org/jira/browse/AMBARI-19674 Repository: ambari Description --- separate api for reading asset is implemented and used. Also validation for assetName check is added Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java 238b002 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java 53b43f9 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 7596de0 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java d8bf9ff contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java df936a4 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java 0622971 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java 9fe2f9c contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java afdee9e contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 7787bda contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js dcfba34 contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 9ad0494 contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 4674533 contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js a04c66d contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1822a20 contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 3e87644 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 3ae4bff contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs bc5201d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 7a21af1 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 7a6005a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 38d8eaf Diff: https://reviews.apache.org/r/55840/diff/ Testing --- manual Thanks, Madhan Reddy
Review Request 55757: AMBARI-19647. Issue while submitting workflow as its not able to register as a project
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55757/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19647 https://issues.apache.org/jira/browse/AMBARI-19647 Repository: ambari Description --- Issue while submitting workflow as its not able to register as a project Diffs - contrib/views/wfmanager/pom.xml be27496 contrib/views/wfmanager/src/main/resources/view.xml f2f520d Diff: https://reviews.apache.org/r/55757/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55614: AMBARI-19581. Need to show proper error message in scenarios of failures with asset import
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55614/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19581 https://issues.apache.org/jira/browse/AMBARI-19581 Repository: ambari Description --- Need to show proper error message in scenarios of failures with asset import. While importing the asset for a given action node, its better to show only assets belonging to that particular type. Steps to reproduce : 1) Save hive node settings as an asset. 2) Now try to import that setting for hive2 or node other than hive. 3) user is shown with the message 'Invalid asset settings'. Either user should be shown only the assets of that particular type or appropriate error message should be displayed as why import setting has failed. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 2ea82b0 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js d0c05d6 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less bc0e419 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 4ee6d05 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs d377d2c contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 0fa86b0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 80af968 Diff: https://reviews.apache.org/r/55614/diff/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/ --- (Updated Jan. 11, 2017, 12:28 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19454 https://issues.apache.org/jira/browse/AMBARI-19454 Repository: ambari Description (updated) --- Need below label changes for below action nodes : 1) Spark : a) 'Job Tracker' should be changed to 'Resource Manager' b) Change the 'Name' to 'Application Name' 2) Java : a) Java opts to 'java Options' b) Provide hidden label for 'Java opt' input field. (Required for automation) 4) SSH a) Provide label for 'args' radio group. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2 Diff: https://reviews.apache.org/r/55418/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19454 https://issues.apache.org/jira/browse/AMBARI-19454 Repository: ambari Description --- Need below label changes for below action nodes : 1) Spark : a) 'Job Tracker' should be changed to 'Resource Manager' b) Change the 'Name' to 'Application Name' c) 'Mode' field which is part of the xsd is missing. 2) Java : a) Java opts to 'java Options' b) Provide hidden label for 'Java opt' input field. (Required for automation) 3) Email : a) 'Content Type' and 'Attachment' fields missing in email node 4) SSH a) Provide label for 'args' radio group. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0c1e4ed contrib/views/wfmanager/src/main/resources/ui/app/templates/components/arg-config.hbs bcf393b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/file-config.hbs 7111c31 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs bdb5261 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/name-value-config.hbs 7d28d00 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/prepare-config.hbs 6c6c750 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs 52bdad5 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs ab2ebb2 Diff: https://reviews.apache.org/r/55418/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55405: AMBARI-19453. Dashboard should display appropriate message if workflow data fetching api fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55405/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19453 https://issues.apache.org/jira/browse/AMBARI-19453 Repository: ambari Description --- Dashboard should display appropriate message if workflow data fetching api fails. Currently dashboard shows empty table without any error message. This provides the user wrong impression that no workflow is being run. Instead its better to show error message explicitly. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js ddb19af Diff: https://reviews.apache.org/r/55405/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55203: AMBARI-19380. Workflow Draft Save-Not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55203/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19380 https://issues.apache.org/jira/browse/AMBARI-19380 Repository: ambari Description --- Workflow should be able to save as draft even if it has errors. The configuration should be stored as .draft.json in the proper location. On retrieving, user should be able to load the draft on choosing the draft. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js b02e021 contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 8514cb0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 6e1b054 Diff: https://reviews.apache.org/r/55203/diff/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/ --- (Updated Jan. 4, 2017, 7:14 a.m.) Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19306 https://issues.apache.org/jira/browse/AMBARI-19306 Repository: ambari Description --- User is not able to validate/submit the workflow after browsing workflow path. Steps to reproduce : 1) Import the workflow. (attaching the workflow) 2) Click on submit. 3) Browse the 'workflow path' using file browser. 4) After selecting the workflow path, UI scrolling is not functional and footer elements become non accessible. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 6296a64 Diff: https://reviews.apache.org/r/55133/diff/ Testing --- Manual Thanks, Madhan Reddy
Re: Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/ --- (Updated Jan. 4, 2017, 5:54 a.m.) Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19336 https://issues.apache.org/jira/browse/AMBARI-19336 Repository: ambari Description --- User should be prompted to enter valid workflow xml file name while Submit/Validate As of now user can provide any file name. Also user is not restricted even if he provides a directory structure. For example if user provides xml file as /tmp/testPath, a file 'testPath' is getting created under directory /tmp/ This file has permission : 'rw-rr-' Due to this restricted permission, below issues are faced : Issue 1 : User is not able to import the saved workflow. Issue 2 : From the dashboard, if user selects any instance of the workflow and decides to edit the workflow, user is shown with below error : There is some problem while importing.Please try again. Hide Log org.apache.hadoop.security.AccessControlException: Permission denied: user=admin, access=EXECUTE, inode="/oozieex/mr-ex1/workflow.xml":admin:hadoop:-rw-r--r-- at sun.reflect.GeneratedConstructorAccessor263.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106) Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9dd02d4 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java f98df0d Diff: https://reviews.apache.org/r/55130/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19306 https://issues.apache.org/jira/browse/AMBARI-19306 Repository: ambari Description --- User is not able to validate/submit the workflow after browsing workflow path. Steps to reproduce : 1) Import the workflow. (attaching the workflow) 2) Click on submit. 3) Browse the 'workflow path' using file browser. 4) After selecting the workflow path, UI scrolling is not functional and footer elements become non accessible. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 6296a64 Diff: https://reviews.apache.org/r/55133/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55130: AMBARI-19336 : User should be prompted to enter valid workflow xml file name while Submit/Validate
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55130/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19336 https://issues.apache.org/jira/browse/AMBARI-19336 Repository: ambari Description --- User should be prompted to enter valid workflow xml file name while Submit/Validate As of now user can provide any file name. Also user is not restricted even if he provides a directory structure. For example if user provides xml file as /tmp/testPath, a file 'testPath' is getting created under directory /tmp/ This file has permission : 'rw-rr-' Due to this restricted permission, below issues are faced : Issue 1 : User is not able to import the saved workflow. Issue 2 : From the dashboard, if user selects any instance of the workflow and decides to edit the workflow, user is shown with below error : There is some problem while importing.Please try again. Hide Log org.apache.hadoop.security.AccessControlException: Permission denied: user=admin, access=EXECUTE, inode="/oozieex/mr-ex1/workflow.xml":admin:hadoop:-rw-r--r-- at sun.reflect.GeneratedConstructorAccessor263.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106) Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 9dd02d4 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java f98df0d Diff: https://reviews.apache.org/r/55130/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55014: AMBARI-19292: Asset Manager/Asset Upload/Asset import from DB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55014/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19292 https://issues.apache.org/jira/browse/AMBARI-19292 Repository: ambari Description --- Manage Assets. -User should be able to list his assets. -users should be able to delete his asset. Export Asset. -user should be able to select action node and export by giving name and description. Import Asset -User should be able to browse all assets and select one to be imported either on transition or on the current action node. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 6cbc3dd contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 50c7592 contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-actions.js 55f86af contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 6296a64 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 20e5b35 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 101f861 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 50a87d8 contrib/views/wfmanager/src/main/resources/ui/bower.json 7fc1736 contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5dfb87c contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/asset-config-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/asset-list-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/asset-manager-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/asset-manager-test.js PRE-CREATION Diff: https://reviews.apache.org/r/55014/diff/ Testing --- Manual Thanks, Madhan Reddy
Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55012/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19291 https://issues.apache.org/jira/browse/AMBARI-19291 Repository: ambari Description --- User should be shown proper error message when user tries to navigate to a hdfs folder and he doesn't have access on that folder. Steps to reproduce : 1) Try to import workflow from HDFS . 2) In the file browser, click on a folder on which user doesn't have permission 3) Though api /api/v1/views/Workflow%20Manager/versions/1.0.0/instances/WFD/resources/proxy/fileServices/fileops/listdir?path=%2Ftmp%2Fhive fails with appropriate error, UI keeps on loading. UI should handle this error and show appropriate message to the user. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js c9be41a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 437640d Diff: https://reviews.apache.org/r/55012/diff/ Testing --- Manual Thanks, Madhan Reddy
