Re: Review Request 54966: Fix typo in druid service postgresql
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/
---
(Updated Dec. 22, 2016, 4:31 p.m.)
Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278
Repository: ambari
Description
---
Fix typo in the name of postgresql
https://issues.apache.org/jira/browse/AMBARI-19278
Diffs
-
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
39ede45
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
ee56899
ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py c06bebb
Diff: https://reviews.apache.org/r/54966/diff/
Testing
---
Tested manually.
python -m discover -v
test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor)
...
/Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915:
SyntaxWarning: assertion is always true, perhaps remove parentheses?
assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage
retrieved = {1}. "
ok
test_recommendDruidConfigurations_WithDerby
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_WithPostgresql
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_heterogeneous_hosts
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_property_existence_check
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_withMysql
(test_stack_advisor.TestHDP26StackAdvisor) ... ok
--
Ran 6 tests in 0.200s
OK
Thanks,
Slim Bouguerra
Re: Review Request 54979: Typo in the PostgreSQL database name for druid service
> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote: > > also i have sent the patch to Apache JIRA > > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied. > > Attila Magyar wrote: > I think it was not applied because it was created from the ambari-server > directory instead of the project root. > > Slim Bouguerra wrote: > @Attila Magyar your patch is exactly the same to mine not sure what you > mean by created inside an ambari-server ? > > Attila Magyar wrote: > @Slim Bouguerra the content of the 2 patches are the same but something > is wrong with the format of your patch. If you download the 2 patch files and > compare it you'll see that one of them uses paths like: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > > and the other uses: > > > a/ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > > This was the reason it didn't apply. Well that `a` is a git detail it is removed when you generate a diff with the option --no-prefix thus both patch are generated against the same git branch - Slim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54979/#review159961 --- On Dec. 22, 2016, 3:16 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54979/ > --- > > (Updated Dec. 22, 2016, 3:16 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim > Bouguerra, and Sebastian Toader. > > > Bugs: AMBARI-19278 > https://issues.apache.org/jira/browse/AMBARI-19278 > > > Repository: ambari > > > Description > --- > > The stack_advisor script for druid uses 'postgres' as storage type. The > documentation of druid says it should be postgresql > > http://druid.io/docs/latest/development/extensions-core/postgresql.html > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > 39ede45 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > ee56899 > > Diff: https://reviews.apache.org/r/54979/diff/ > > > Testing > --- > > Manually tested by importing a druid blueprint: > 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err > contained an error 'NoneType' object has no attribute 'format' > 2. after applying the patch the error disappeared > > > Still waiting for the mvn test results > > > Thanks, > > Attila Magyar > >
Re: Review Request 54979: Typo in the PostgreSQL database name for druid service
> On Dec. 22, 2016, 2:55 p.m., Slim Bouguerra wrote: > > also i have sent the patch to Apache JIRA > > https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied. > > Attila Magyar wrote: > I think it was not applied because it was created from the ambari-server > directory instead of the project root. @Attila Magyar your patch is exactly the same to mine not sure what you mean by created inside an ambari-server ? - Slim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54979/#review159961 --- On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54979/ > --- > > (Updated Dec. 22, 2016, 2:51 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim > Bouguerra, and Sebastian Toader. > > > Bugs: AMBARI-19278 > https://issues.apache.org/jira/browse/AMBARI-19278 > > > Repository: ambari > > > Description > --- > > The stack_advisor script for druid uses 'postgres' as storage type. The > documentation of druid says it should be postgresql > > http://druid.io/docs/latest/development/extensions-core/postgresql.html > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > 39ede45 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > ee56899 > > Diff: https://reviews.apache.org/r/54979/diff/ > > > Testing > --- > > Manually tested by importing a druid blueprint: > 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err > contained an error 'NoneType' object has no attribute 'format' > 2. after applying the patch the error disappeared > > > Still waiting for the mvn test results > > > Thanks, > > Attila Magyar > >
Re: Review Request 54979: Typo in the PostgreSQL database name for druid service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54979/#review159961 --- also i have sent the patch to Apache JIRA https://issues.apache.org/jira/browse/AMBARI-19278 but it is not applied. - Slim Bouguerra On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54979/ > --- > > (Updated Dec. 22, 2016, 2:51 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim > Bouguerra, and Sebastian Toader. > > > Bugs: AMBARI-19278 > https://issues.apache.org/jira/browse/AMBARI-19278 > > > Repository: ambari > > > Description > --- > > The stack_advisor script for druid uses 'postgres' as storage type. The > documentation of druid says it should be postgresql > > http://druid.io/docs/latest/development/extensions-core/postgresql.html > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > 39ede45 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > ee56899 > > Diff: https://reviews.apache.org/r/54979/diff/ > > > Testing > --- > > Manually tested by importing a druid blueprint: > 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err > contained an error 'NoneType' object has no attribute 'format' > 2. after applying the patch the error disappeared > > > Still waiting for the mvn test results > > > Thanks, > > Attila Magyar > >
Re: Review Request 54979: Typo in the PostgreSQL database name for druid service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54979/#review159960 --- i have sennt a PR alreadsy https://reviews.apache.org/r/54966/ can you please review it ? - Slim Bouguerra On Dec. 22, 2016, 2:51 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54979/ > --- > > (Updated Dec. 22, 2016, 2:51 p.m.) > > > Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Slim > Bouguerra, and Sebastian Toader. > > > Bugs: AMBARI-19278 > https://issues.apache.org/jira/browse/AMBARI-19278 > > > Repository: ambari > > > Description > --- > > The stack_advisor script for druid uses 'postgres' as storage type. The > documentation of druid says it should be postgresql > > http://druid.io/docs/latest/development/extensions-core/postgresql.html > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > 39ede45 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > ee56899 > > Diff: https://reviews.apache.org/r/54979/diff/ > > > Testing > --- > > Manually tested by importing a druid blueprint: > 1. /var/run/ambari-server/stack-recommendations/1/stackadvisor.err > contained an error 'NoneType' object has no attribute 'format' > 2. after applying the patch the error disappeared > > > Still waiting for the mvn test results > > > Thanks, > > Attila Magyar > >
Re: Review Request 50803: [Ambari-17981] Integrate Druid With Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/#review153707 --- Ship it! Ship It! - Slim Bouguerra On Oct. 22, 2016, 1:21 a.m., Nishant Bangarwa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50803/ > --- > > (Updated Oct. 22, 2016, 1:21 a.m.) > > > Review request for Ambari, Renjith Kamath and Swapan Shridhar. > > > Bugs: Ambari-17981 > https://issues.apache.org/jira/browse/Ambari-17981 > > > Repository: ambari > > > Description > --- > > Defines Druid as a new service in HDP 2.6 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 1f722dc > ambari-server/src/test/python/stacks/2.6/DRUID/test_druid.py PRE-CREATION > ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION > > Diff: https://reviews.apache.org/r/50803/diff/ > > > Testing > --- > > Tested it locally by installing ambari and adding the newly added resources. > Was able to install druid and start all newly added services. > > > Thanks, > > Nishant Bangarwa > >
Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/#review152683 --- Ship it! Ship It! - Slim Bouguerra On Oct. 14, 2016, 11:15 a.m., Nishant Bangarwa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50803/ > --- > > (Updated Oct. 14, 2016, 11:15 a.m.) > > > Review request for Ambari, Renjith Kamath and Swapan Shridhar. > > > Bugs: Ambari-19781 > https://issues.apache.org/jira/browse/Ambari-19781 > > > Repository: ambari > > > Description > --- > > Defines Druid as a new service in HDP 2.6 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 1f722dc > ambari-server/src/test/python/stacks/2.6/DRUID/test_druid_historical.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/configs/default.json PRE-CREATION > > Diff: https://reviews.apache.org/r/50803/diff/ > > > Testing > --- > > Tested it locally by installing ambari and adding the newly added resources. > Was able to install druid and start all newly added services. > > > Thanks, > > Nishant Bangarwa > >
Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/#review152150 --- ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py (line 89) <https://reviews.apache.org/r/50803/#comment220966> this is not used thought we can remove it i guess ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py (line 37) <https://reviews.apache.org/r/50803/#comment220971> this is using curl which means it will fail if curl is not installed or part of the bin path. Not an issue but it will be better to use python http clients. - Slim Bouguerra On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50803/ > --- > > (Updated Oct. 11, 2016, 2:44 p.m.) > > > Review request for Ambari, Renjith Kamath and Swapan Shridhar. > > > Bugs: Ambari-19781 > https://issues.apache.org/jira/browse/Ambari-19781 > > > Repository: ambari > > > Description > --- > > Defines Druid as a new service in HDP 2.6 > > > Diffs > - > > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 1f722dc > > Diff: https://reviews.apache.org/r/50803/diff/ > > > Testing > --- > > Tested it locally by installing ambari and adding the newly added resources. > Was able to install druid and start all newly added services. > > > Thanks, > > Nishant Bangarwa > >
