Re: Review Request 64861: Custom zeppelin interpreter properties are getting removed after moving zeppelin to a different host

2017-12-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64861/#review194571
---


Ship it!




Ship It!

- venkat sairam


On Dec. 28, 2017, 11:32 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64861/
> ---
> 
> (Updated Dec. 28, 2017, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22698
> https://issues.apache.org/jira/browse/AMBARI-22698
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Custom zeppelin interpreter properties are getting lost after moving zeppelin 
> to a different host
> 
> 
> Steps to reproduce :
> 1) Modify interpreter settings
> a) Add new custom properties
> b) Modify existing properties
> Changes are getting saved in HDFS path /user/zeppelin/conf/interpreter.json 
> and they are getting synced to local path /etc/zeppelin/conf/interpreter.json 
> after zeppelin restart.
> 2) Delete zeppelin server
> 3) Install zeppelin server on a different host
> 4) Modifications done in step 1 are lost.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  efa3ffe3ba 
> 
> 
> Diff: https://reviews.apache.org/r/64861/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 64528: Zeppelin Interpreter settings are getting updated after zeppelin restart

2017-12-11 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64528/#review193507
---


Ship it!




Ship It!

- venkat sairam


On Dec. 12, 2017, 7:39 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64528/
> ---
> 
> (Updated Dec. 12, 2017, 7:39 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22626
> https://issues.apache.org/jira/browse/AMBARI-22626
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin Interpreter settings are getting updated after zeppelin restart.
> 
> Steps to reproduce :
> 1) Update the zeppelin.pyspark.python to /base/tools/python-2.7.14/bin/python 
> for spark2 interpreter
> 2) Restart zeppelin
> 3) After restart zeppelin.pyspark.python is getting overridden with value 
> 'python'.
> Same is observed with livy2 interpreter.
> 
> But same steps for spark interpreter is working fine even after zeppelin 
> restart.
> 
> So looks like issue is happening only for spark2 and livy2 interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  713db232b1 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  c9030bd33e 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  bb4c5b227b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/spark2_config_template.py
>  28a63c6f1b 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  4b4dc1fe48 
> 
> 
> Diff: https://reviews.apache.org/r/64528/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 64368: Livy2 keytabs are not getting configured automatically in zeppelin

2017-12-06 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64368/#review192970
---


Ship it!




Ship It!

- venkat sairam


On Dec. 6, 2017, 9:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64368/
> ---
> 
> (Updated Dec. 6, 2017, 9:21 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22595
> https://issues.apache.org/jira/browse/AMBARI-22595
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 'zeppelin.livy.keytab' and 'zeppelin.livy.principal' are not configured for 
> zeppelin after installation on secured cluster.
> Because of this zeppelin notebook with livy interpreter is failing with 
> un-authenticated 401 error.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  5efc277caf 
> 
> 
> Diff: https://reviews.apache.org/r/64368/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 64046: Incorrect pie chart distribution

2017-11-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64046/#review191785
---


Ship it!




Ship It!

- venkat sairam


On Nov. 23, 2017, 7:04 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64046/
> ---
> 
> (Updated Nov. 23, 2017, 7:04 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22506
> https://issues.apache.org/jira/browse/AMBARI-22506
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Phoenix JDBC does number formatting if its a decimal, as describe in 
> https://phoenix.apache.org/tuning.html "phoenix.query.numberFormat" with 
> "#,##0.###", which causes a problem with displaying of graph.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  5efc277caf 
> 
> 
> Diff: https://reviews.apache.org/r/64046/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node

2017-11-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64035/
---

Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, 
Prabhjyot Singh, and Rohit Choudhary.


Bugs: AMBARI-22502
https://issues.apache.org/jira/browse/AMBARI-22502


Repository: ambari


Description
---

Condition for importing single node have been added.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
84a789d 


Diff: https://reviews.apache.org/r/64035/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 63656: Disable auto config of interpreter.json at the time of installation

2017-11-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63656/#review190424
---


Ship it!




Ship It!

- venkat sairam


On Nov. 8, 2017, 6:03 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63656/
> ---
> 
> (Updated Nov. 8, 2017, 6:03 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22373
> https://issues.apache.org/jira/browse/AMBARI-22373
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should not configure interpreter.json if 
> zeppelin.interpreter.config.upgrade is set to false even at the time of 
> installation
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  6ccdfbafcb 
> 
> 
> Diff: https://reviews.apache.org/r/63656/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 63020: jdbc(spark[2]) URLs not configured correctly for secure clusters

2017-10-16 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63020/#review188101
---


Ship it!




Ship It!

- venkat sairam


On Oct. 16, 2017, 7:08 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63020/
> ---
> 
> (Updated Oct. 16, 2017, 7:08 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-3
> https://issues.apache.org/jira/browse/AMBARI-3
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case of JDBC interpreter auto-configuration, URLs being set are not 
> accounting for security, transport mode and SSL upon zeppelin server restart 
> via ambari.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  6a84d7926b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  e69037cb10 
> 
> 
> Diff: https://reviews.apache.org/r/63020/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62976: Zeppelin service check failed during EU from 2.5 to 2.6 as ZeppelinServer can not be instantiated

2017-10-16 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62976/#review188102
---


Ship it!




Ship It!

- venkat sairam


On Oct. 13, 2017, 2:32 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62976/
> ---
> 
> (Updated Oct. 13, 2017, 2:32 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22233
> https://issues.apache.org/jira/browse/AMBARI-22233
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are two issuse 
>  - one a file can exists with zero byte, it should be treated as file not in 
> file system
>  - premission of interpreter.json should be 644 instead of 640
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  6a84d7926b 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 400350c4f0 
> 
> 
> Diff: https://reviews.apache.org/r/62976/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62968: Handle upload of interpreter.json to remote storage in Ambari

2017-10-13 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62968/#review187940
---


Ship it!




Ship It!

- venkat sairam


On Oct. 13, 2017, 7:10 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62968/
> ---
> 
> (Updated Oct. 13, 2017, 7:10 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-9
> https://issues.apache.org/jira/browse/AMBARI-9
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin can read interpreter.json from HDFS based on hdfs-site.xml present 
> in classpath.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  a8b1b321c8 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> e5d024092b 
> 
> 
> Diff: https://reviews.apache.org/r/62968/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

2017-10-12 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/#review187748
---


Ship it!




Ship It!

- venkat sairam


On Oct. 12, 2017, 7:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62925/
> ---
> 
> (Updated Oct. 12, 2017, 7:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22214
> https://issues.apache.org/jira/browse/AMBARI-22214
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Livy is running on https mode then Livy protocol to be set to https in 
> Zeppelin's interpreter setting.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
> 
> 
> Diff: https://reviews.apache.org/r/62925/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62924: Alter logic for storing interpreter.json

2017-10-12 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62924/#review187747
---


Ship it!




Ship It!

- venkat sairam


On Oct. 12, 2017, 6:37 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62924/
> ---
> 
> (Updated Oct. 12, 2017, 6:37 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22212
> https://issues.apache.org/jira/browse/AMBARI-22212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now Ambari assumes if "FileSystemNotebookRepo" is set for 
> "zeppelin.notebook.storage" then both notebook and conf are in HDFS.
> 
> But the right logic will be if ("zeppelin.config.fs.dir" is empty or 
> "zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS 
> and also check for 
> "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if exists.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 3adb94ce1a 
> 
> 
> Diff: https://reviews.apache.org/r/62924/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62883: Zeppelin start fails due to permission denied error during kinit

2017-10-11 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62883/#review187637
---


Ship it!




Ship It!

- venkat sairam


On Oct. 11, 2017, 8:56 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62883/
> ---
> 
> (Updated Oct. 11, 2017, 8:56 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22199
> https://issues.apache.org/jira/browse/AMBARI-22199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin fails to come up with following error in ambari stderr logs, on 
> kerberos enabled enviornment.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  d615d06d5a 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 3064880632 
> 
> 
> Diff: https://reviews.apache.org/r/62883/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab

2017-10-09 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62676/#review187419
---


Ship it!




Ship It!

- venkat sairam


On Oct. 9, 2017, 3:42 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62676/
> ---
> 
> (Updated Oct. 9, 2017, 3:42 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-22089
> https://issues.apache.org/jira/browse/AMBARI-22089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Updating the same worksheet rather creating new one.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java
>  3690683 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryService.java
>  7139ce8 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 9e8b6db 
>   contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js 
> 4b4b29e 
>   contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c 
> 
> 
> Diff: https://reviews.apache.org/r/62676/diff/2/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 62803: On Zeppelin restart sometimes interpreter settings get reset

2017-10-09 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62803/#review187388
---


Ship it!




Ship It!

- venkat sairam


On Oct. 6, 2017, 9:25 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62803/
> ---
> 
> (Updated Oct. 6, 2017, 9:25 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22153
> https://issues.apache.org/jira/browse/AMBARI-22153
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On Zeppelin restart sometimes interpreter settings get reset
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  a450fb6882 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> e8ef262ace 
> 
> 
> Diff: https://reviews.apache.org/r/62803/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 62715: Knox Proxy - Workflow Manager view fails to load when using ambari thru KNOX

2017-09-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62715/
---

Review request for Ambari, Knox, Gaurav Nagar, Sandeep More, Nitiraj Rathore, 
Padma Priya N, and Pallav Kulshreshtha.


Bugs: KNOX-1074
https://issues.apache.org/jira/browse/KNOX-1074


Repository: knox


Description
---

Rules are being added into service.xml file


Diffs
-

  
gateway-service-definitions/src/main/resources/services/ambariui/2.2.0/service.xml
 ab4ab2b 


Diff: https://reviews.apache.org/r/62715/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Review Request 62711: HiveView 1.5 is not showing the "Visualization" page when accessed over Knox.

2017-09-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62711/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-22103
https://issues.apache.org/jira/browse/AMBARI-22103


Repository: ambari


Description
---

Changed the adapter URL to make Visualization page accessible via Knox proxy


Diffs
-

  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/application.js
 2c68b89 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/visualization-ui.js
 c908afd 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
348454b 


Diff: https://reviews.apache.org/r/62711/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Review Request 62694: Entries related to hive query are found in RM UI after killing or stopping the execution of the query.

2017-09-29 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62694/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-22096
https://issues.apache.org/jira/browse/AMBARI-22096


Repository: ambari


Description
---

Ember data API changes are made and the exceptions on JS side are handled


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
291c335 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 36abf49 


Diff: https://reviews.apache.org/r/62694/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Review Request 62683: Hive view2.0 Jobs worksheets doesn't have hyperlink whereas view1.5 History worksheets had hyperlinks pointing to fetched results

2017-09-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62683/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-22091
https://issues.apache.org/jira/browse/AMBARI-22091


Repository: ambari


Description
---

Provided hyper link in jobs page which will fetch the jobs results.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/job-item.js 42a3411 
  contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js 
7e24843 
  contrib/views/hive20/src/main/resources/ui/app/routes/jobs.js 3e88ac6 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 76a7439 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
f6256898 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 522b2d3 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/job-item.hbs
 16caad0 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs
 d29ca73 
  contrib/views/hive20/src/main/resources/ui/app/templates/jobs.hbs 4382b7a 


Diff: https://reviews.apache.org/r/62683/diff/1/


Testing
---

Manual tetsing done


Thanks,

venkat sairam



Re: Review Request 62676: Hive View 2.0 - Unable to update existing saved queries, view creates new records under saved queries tab

2017-09-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62676/#review186640
---


Ship it!




Ship It!

- venkat sairam


On Sept. 28, 2017, 7:40 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62676/
> ---
> 
> (Updated Sept. 28, 2017, 7:40 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-22089
> https://issues.apache.org/jira/browse/AMBARI-22089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Updating the same worksheet rather creating new one.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/savedQueries/SavedQueryResourceManager.java
>  3690683 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> f6256898 
>   contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c 
> 
> 
> Diff: https://reviews.apache.org/r/62676/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 62677: INCORROUT in Hive SELECT-JOIN query using Hive View 2.0

2017-09-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62677/#review186638
---


Ship it!




Ship It!

- venkat sairam


On Sept. 28, 2017, 7:52 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62677/
> ---
> 
> (Updated Sept. 28, 2017, 7:52 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-22090
> https://issues.apache.org/jira/browse/AMBARI-22090
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor code correction to make the unique key.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-table.js
>  be5c43a 
> 
> 
> Diff: https://reviews.apache.org/r/62677/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 62612: Zeppelin JDBC queries should be split by default

2017-09-27 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62612/#review186380
---


Ship it!




Ship It!

- venkat sairam


On Sept. 27, 2017, 5:43 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62612/
> ---
> 
> (Updated Sept. 27, 2017, 5:43 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22069
> https://issues.apache.org/jira/browse/AMBARI-22069
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2554 there's a new interpreter setting that restricts splitting 
> of JDBC queries. This is to make "default.splitQueries=true".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  8bdfaece2d 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 1fdbadb1e6 
> 
> 
> Diff: https://reviews.apache.org/r/62612/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> File Attachments
> 
> 
> AMBARI-22069_branch-2.6_v1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/09/27/fe51e7ee-6a62-4822-a816-1062148a57b7__AMBARI-22069_branch-2.6_v1.patch
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62547: Zeppelin's version is wrong in alerts.json

2017-09-25 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62547/#review186131
---


Ship it!




Ship It!

- venkat sairam


On Sept. 25, 2017, 3:32 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62547/
> ---
> 
> (Updated Sept. 25, 2017, 3:32 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22053
> https://issues.apache.org/jira/browse/AMBARI-22053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After the merge of AMBARI-21901, Zeppelin's version is wrong in alerts.json 
> (only in branch-2.6).
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json 
> 8e9b6e7f4b 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/alerts.json 
> 8e9b6e7f4b 
> 
> 
> Diff: https://reviews.apache.org/r/62547/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62546: Zeppelin's conf HDFS directory owner is wrong

2017-09-25 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62546/#review186130
---


Ship it!




Ship It!

- venkat sairam


On Sept. 25, 2017, 3:02 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62546/
> ---
> 
> (Updated Sept. 25, 2017, 3:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22052
> https://issues.apache.org/jira/browse/AMBARI-22052
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin's conf HDFS directory owner is wrong. However, on restart of 
> Zeppelin server it takes the correct value
> 
> ```
> [zeppelin@test-clu-1 ~]$ hdfs dfs -ls /user/zeppelin
> Found 4 items
> drwx--   - zeppelin hdfs  0 2017-09-25 14:12 /user/zeppelin/.Trash
> drwxr-xr-x   - hdfs hdfs  0 2017-09-25 14:33 /user/zeppelin/conf
> drwxr-xr-x   - zeppelin hdfs  0 2017-09-25 14:08 
> /user/zeppelin/notebook
> drwxr-xr-x   - zeppelin hdfs  0 2017-09-25 13:13 /user/zeppelin/test
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  382566eff7 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> f379f40534 
> 
> 
> Diff: https://reviews.apache.org/r/62546/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62546: Zeppelin's conf HDFS directory owner is wrong

2017-09-25 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62546/#review186125
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
Lines 361 (patched)
<https://reviews.apache.org/r/62546/#comment262567>

Can we use owner for the same?
Or will there be seperate user and owner?


- venkat sairam


On Sept. 25, 2017, 3:02 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62546/
> ---
> 
> (Updated Sept. 25, 2017, 3:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22052
> https://issues.apache.org/jira/browse/AMBARI-22052
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin's conf HDFS directory owner is wrong. However, on restart of 
> Zeppelin server it takes the correct value
> 
> ```
> [zeppelin@test-clu-1 ~]$ hdfs dfs -ls /user/zeppelin
> Found 4 items
> drwx--   - zeppelin hdfs  0 2017-09-25 14:12 /user/zeppelin/.Trash
> drwxr-xr-x   - hdfs hdfs  0 2017-09-25 14:33 /user/zeppelin/conf
> drwxr-xr-x   - zeppelin hdfs  0 2017-09-25 14:08 
> /user/zeppelin/notebook
> drwxr-xr-x   - zeppelin hdfs  0 2017-09-25 13:13 /user/zeppelin/test
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  382566eff7 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> f379f40534 
> 
> 
> Diff: https://reviews.apache.org/r/62546/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62461: Livy not working with the default configuration

2017-09-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62461/#review185948
---


Ship it!




Ship It!

- venkat sairam


On Sept. 21, 2017, 1 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62461/
> ---
> 
> (Updated Sept. 21, 2017, 1 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22021
> https://issues.apache.org/jira/browse/AMBARI-22021
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This started failing with ZEPPELIN-2909, which introduces `"className": 
> "org.apache.zeppelin.livy.LivySharedInterpreter"` and now Livy fails with 
> following exception;
> 
> 
> java.lang.NullPointerException
>   at 
> org.apache.zeppelin.livy.BaseLivyInterpreter.open(BaseLivyInterpreter.java:109)
>   at 
> org.apache.zeppelin.interpreter.LazyOpenInterpreter.open(LazyOpenInterpreter.java:69)
>   at 
> org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:493)
>   at org.apache.zeppelin.scheduler.Job.run(Job.java:175)
>   at 
> org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/interpreter_json_template.py
>  6a9891972b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/livy2_config_template.py
>  71d381705a 
> 
> 
> Diff: https://reviews.apache.org/r/62461/diff/3/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62429: Ambari Unit Tests Fail In trunk

2017-09-20 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62429/#review185779
---


Ship it!




Ship It!

- venkat sairam


On Sept. 20, 2017, 7:09 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62429/
> ---
> 
> (Updated Sept. 20, 2017, 7:09 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22002
> https://issues.apache.org/jira/browse/AMBARI-22002
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following unit tests are failing trunk builds:
> https://builds.apache.org/job/Ambari-trunk-Commit/8095/consoleFull
> 
> OK
> --
> Failed tests:
> ERROR: test_configure_default (test_zeppelin_master.TestZeppelinMaster)
> --
> Traceback (most recent call last):
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-common/src/test/python/mock/mock.py",
>  line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py",
>  line 145, in test_configure_default
> target = RMFTestCase.TARGET_COMMON_SERVICES
>   File 
> "/home/jenkins/jenkins-slave/workspace/Ambari-trunk-Commit/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
>  line 126, in executeScript
> raise RuntimeError("Cannot load class %s from %s: %s" % (classname, 
> norm_path, err.message))
> 
> 
> Diffs
> -
> 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 9a28e686f5 
> 
> 
> Diff: https://reviews.apache.org/r/62429/diff/1/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185671
---


Ship it!




Ship It!

- venkat sairam


On Sept. 19, 2017, 10:17 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 10:17 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/4/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185653
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
Lines 90 (patched)
<https://reviews.apache.org/r/62399/#comment261977>

Can you make this work for relative path as well?


- venkat sairam


On Sept. 19, 2017, 5:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 5:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185652
---


Ship it!




Ship It!

- venkat sairam


On Sept. 19, 2017, 5:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 5:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 62155: Add 0.7.x stack definition for Zeppelin

2017-09-11 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62155/#review185060
---


Ship it!




Ship It!

- venkat sairam


On Sept. 9, 2017, 5:30 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62155/
> ---
> 
> (Updated Sept. 9, 2017, 5:30 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21901
> https://issues.apache.org/jira/browse/AMBARI-21901
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, in Zeppelin, there are two stack definitions 0.6.0.2.5 and 
> 0.6.0.3.0. The ideas of this Jira are following:
>  - rename 0.6.0.2.5 to 0.6.0
>  - delete redundant 0.6.0.3.0
>  - create another defination for 0.7.x as 0.7.0
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json
>  8e9b6e7f4b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/interpreter_json_template.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/livy2_config_template.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/spark2_config_template.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/templates/input.config-zeppelin.json.j2
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/quicklinks/quicklinks.json
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/role_command_order.json
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/alerts.json
>  8e9b6e7f4b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
>  b393def227 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-log4j-properties.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/kerberos.json
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/metainfo.xml
>  7f2f57025f 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/alert_check_zeppelin.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/livy2_config_template.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/master.py
>  ab798ec60c 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/params.py
>  2340df9dea 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/package/scripts/service_check.py
>   
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.

Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

2017-09-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 11:12 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
72ed840 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/5/

Changes: https://reviews.apache.org/r/62119/diff/4-5/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

2017-09-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 10:59 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
72ed840 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/4/

Changes: https://reviews.apache.org/r/62119/diff/3-4/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

2017-09-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 10:51 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
72ed840 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/3/

Changes: https://reviews.apache.org/r/62119/diff/2-3/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

2017-09-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

(Updated Sept. 7, 2017, 6:36 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs (updated)
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/components/file-search.js 
b65749c 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  
contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs
 298d672 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/2/

Changes: https://reviews.apache.org/r/62119/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)

2017-09-06 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62119/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, and Pallav Kulshreshtha.


Bugs: AMBARI-21890
https://issues.apache.org/jira/browse/AMBARI-21890


Repository: ambari


Description
---

A configurable limit have been imposed on the no of files being retrieved from 
the server and the limit by default is set to 5000.
Search has been provided to find the file faster.


Diffs
-

  
contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java
 d6e484d 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b 
  contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 
  
contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java
 f431f66 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java
 PRE-CREATION 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62119/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 61961: Support for Zeppelin notebook storage in HDFS

2017-09-04 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61961/#review184249
---



- venkat sairam


On Sept. 4, 2017, 8:27 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61961/
> ---
> 
> (Updated Sept. 4, 2017, 8:27 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21835
> https://issues.apache.org/jira/browse/AMBARI-21835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-1515 there is now support for storing Zeppelin's notebook in 
> HDFS, this patch is for making notebook to be stored by default in HDFS
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  03ad5f7b93 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  2142bb480b 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  f5a2a37818 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>  2bfc0dc18b 
> 
> 
> Diff: https://reviews.apache.org/r/61961/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61961: Support for Zeppelin notebook storage in HDFS

2017-08-31 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61961/#review184248
---


Ship it!




Ship It!

- venkat sairam


On Aug. 29, 2017, 4:53 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61961/
> ---
> 
> (Updated Aug. 29, 2017, 4:53 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21835
> https://issues.apache.org/jira/browse/AMBARI-21835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-1515 there is now support for storing Zeppelin's notebook in 
> HDFS, this patch is for making notebook to be stored by default in HDFS
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  13d726be97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  7f506c5839 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  6912c3db8d 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>  c0ce71146c 
> 
> 
> Diff: https://reviews.apache.org/r/61961/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61912: On installation of new services on Ambari, Zeppelin should configure new interpreters

2017-08-25 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61912/#review183842
---


Ship it!




Ship It!

- venkat sairam


On Aug. 25, 2017, 10:38 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61912/
> ---
> 
> (Updated Aug. 25, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21814
> https://issues.apache.org/jira/browse/AMBARI-21814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In current scenario, Ambari doesn't configure any interpreters that are 
> installed after installation. For example, if Livy was not present when 
> Zeppelin was installed, then Zeppelin's livy interpreter will never get 
> configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  13d726be97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  7f506c5839 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  6912c3db8d 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>  c0ce71146c 
> 
> 
> Diff: https://reviews.apache.org/r/61912/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61884: Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS mode

2017-08-24 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61884/#review183726
---


Ship it!




Ship It!

- venkat sairam


On Aug. 24, 2017, 10:38 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61884/
> ---
> 
> (Updated Aug. 24, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21802
> https://issues.apache.org/jira/browse/AMBARI-21802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS 
> mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  742f5bedca 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
>  25ea3d04ab 
> 
> 
> Diff: https://reviews.apache.org/r/61884/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61837: By Default Zeppelin notes should be visible only to Owner (note creator)

2017-08-24 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61837/#review183715
---


Ship it!




Ship It!

- venkat sairam


On Aug. 23, 2017, 4:07 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61837/
> ---
> 
> (Updated Aug. 23, 2017, 4:07 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21787
> https://issues.apache.org/jira/browse/AMBARI-21787
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A Zeppelin note by default should be private to the owner. By default it 
> should not be visible to non-owner.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  13d726be97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>  c0ce71146c 
> 
> 
> Diff: https://reviews.apache.org/r/61837/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61205: Users randomly getting "HDFS020 Could not write file" exceptions while running query from Hive View

2017-08-21 Thread venkat sairam
)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:103)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:113)


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/yarn.lock 477a15c 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java
 0670f1a 


Diff: https://reviews.apache.org/r/61205/diff/2/

Changes: https://reviews.apache.org/r/61205/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-08 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61479/#review182410
---


Ship it!




Ship It!

- venkat sairam


On Aug. 7, 2017, 8:07 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61479/
> ---
> 
> (Updated Aug. 7, 2017, 8:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21675
> https://issues.apache.org/jira/browse/AMBARI-21675
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The secure flag attribute must be set on session cookies containing session 
> tokens for Zeppelin Application
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  971e4af1c6 
> 
> 
> Diff: https://reviews.apache.org/r/61479/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 61205: Users randomly getting "HDFS020 Could not write file" exceptions while running query from Hive View

2017-07-28 Thread venkat sairam
$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:103)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:113)


Diffs
-

  contrib/views/hive-next/src/main/resources/view.log4j.properties 2e466cd2a6 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 c7ae952b86 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java
 8bc3ca5e7c 


Diff: https://reviews.apache.org/r/61205/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 61176: Apply zeppelin.server.kerberos.principal related changes to 0.6.0.3.0

2017-07-27 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61176/#review181546
---


Ship it!




Ship It!

- venkat sairam


On July 27, 2017, 9:09 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61176/
> ---
> 
> (Updated July 27, 2017, 9:09 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21586
> https://issues.apache.org/jira/browse/AMBARI-21586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With AMBARI-18692, and AMBARI-21426 there were few changes in zeppelin-env.sh 
> that was applied to 0.6.0.2.5 but the same was not applied to 0.6.0.3.0. This 
> is to sync zeppelin-env.xml.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
>  7bd597f6a6 
> 
> 
> Diff: https://reviews.apache.org/r/61176/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 7
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61169: Remove environment variables from zeppelin-env.sh

2017-07-27 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61169/#review181545
---


Ship it!




Ship It!

- venkat sairam


On July 27, 2017, 5:09 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61169/
> ---
> 
> (Updated July 27, 2017, 5:09 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21585
> https://issues.apache.org/jira/browse/AMBARI-21585
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is to remove three of the environment variables from zeppelin-env.sh;
>  - `ZEPPELIN_JAVA_OPTS` this initialises spark.executor.memory, 
> spark.executor.instances and spark.yarn.queue which should ideally be 
> configured in Zeppelin's interpreter setting to avoid confusion.
>  - `SPARK_YARN_USER_ENV` is no longer used.
>  - `PYTHONPATH` if required should be configured from Zeppelin's interpreter 
> setting.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  80ac2bbd45 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml
>  7bd597f6a6 
> 
> 
> Diff: https://reviews.apache.org/r/61169/diff/2/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 7
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60859: Zeppelin does not start and returns: params.zookeeper_znode_parent not in interpreter['properties']['phoenix.url']: KeyError: 'phoenix.url'

2017-07-17 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60859/#review180664
---


Ship it!




Ship It!

- venkat sairam


On July 14, 2017, 11:18 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60859/
> ---
> 
> (Updated July 14, 2017, 11:18 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21473
> https://issues.apache.org/jira/browse/AMBARI-21473
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin does not start and returns: params.zookeeper_znode_parent not in 
> interpreter['properties']['phoenix.url']: KeyError: 'phoenix.url'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  0013ab0eb8 
> 
> 
> Diff: https://reviews.apache.org/r/60859/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6 with kerberos enabled
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-08 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179981
---


Ship it!




Ship It!

- venkat sairam


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60702: Apply ZEPPELIN-2698 related changes in Ambari

2017-07-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60702/#review179855
---



Where is the value exported used in the application?

- venkat sairam


On July 7, 2017, 6:52 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60702/
> ---
> 
> (Updated July 7, 2017, 6:52 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21426
> https://issues.apache.org/jira/browse/AMBARI-21426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-2698, LAUNCH_KERBEROS_REFRESH_INTERVAL is renamed 
> to KERBEROS_REFRESH_INTERVAL.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  4032b2c45d 
> 
> 
> Diff: https://reviews.apache.org/r/60702/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on centOS 6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60459: Workflow Manager view build failure

2017-06-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

(Updated June 28, 2017, 9:25 a.m.)


Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description (updated)
---

Changed package.json to fix the build failure.
Due to version mismatch in meta data of bower repository, the latest version 
shown doesnt have the required modules to import.
Downgrading verison to fix the issue.


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 3f9de44 


Diff: https://reviews.apache.org/r/60459/diff/3/

Changes: https://reviews.apache.org/r/60459/diff/2-3/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 60459: Workflow Manager view build failure

2017-06-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

(Updated June 28, 2017, 9:15 a.m.)


Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description (updated)
---

Changed pom.xml to fix the build failure.
Due to version mismatch in meta data of bower repository, the latest version 
shown doesnt have the required modules to import.
Downgrading verison to fix the issue.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 


Diff: https://reviews.apache.org/r/60459/diff/2/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 60459: Workflow Manager view build failure

2017-06-28 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

(Updated June 28, 2017, 9:13 a.m.)


Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description
---

Changed pom.xml to fix the build failure


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 


Diff: https://reviews.apache.org/r/60459/diff/2/

Changes: https://reviews.apache.org/r/60459/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 60463: Apply KerberosInterpreter related changes in Ambari

2017-06-27 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60463/#review178974
---


Ship it!




Ship It!

- venkat sairam


On June 27, 2017, 11:20 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60463/
> ---
> 
> (Updated June 27, 2017, 11:20 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21354
> https://issues.apache.org/jira/browse/AMBARI-21354
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the merge of ZEPPELIN-1907, zeppelin-env.sh now exposes 
> LAUNCH_KERBEROS_REFRESH_INTERVAL, which is for duration at which kinit should 
> happen.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  bdef319f5b 
> 
> 
> Diff: https://reviews.apache.org/r/60463/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 60459: Workflow Manager view build failure

2017-06-27 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description
---

Changed pom.xml to fix the build failure


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 


Diff: https://reviews.apache.org/r/60459/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Review Request 60455: Styling Issues with newly implemented workflow manager file browser

2017-06-27 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60455/
---

Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21338
https://issues.apache.org/jira/browse/AMBARI-21338


Repository: ambari


Description
---

Changed styles as needed.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 597e2e8 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css
 b46fa34 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock e9ad6cc 


Diff: https://reviews.apache.org/r/60455/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 60384: User should be prompted for confirmation before closing the browser window

2017-06-23 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60384/#review178779
---


Ship it!




Ship It!

- venkat sairam


On June 23, 2017, 6:17 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60384/
> ---
> 
> (Updated June 23, 2017, 6:17 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, venkat sairam, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20702
> https://issues.apache.org/jira/browse/AMBARI-20702
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Handled onbeforeunload event to show a warning message one last time before 
> closing the window.
> - Unfortunately,  there is not much scope of UI customization of the warning 
> dialog. Here is stack overflow link for this 
> https://stackoverflow.com/questions/276660/how-can-i-override-the-onbeforeunload-dialog-and-replace-it-with-my-own
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/index.html efd3c64 
> 
> 
> Diff: https://reviews.apache.org/r/60384/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Review Request 60383: Remove slider view from Ambari-3.0.0

2017-06-22 Thread venkat sairam
.custom.css
 ad18ce7 
  contrib/views/slider/src/main/resources/ui/vendor/styles/rickshaw.css 9102bd4 
  contrib/views/slider/src/main/resources/view.log4j.properties 8fddbff 
  contrib/views/slider/src/main/resources/view.xml f4f6e9e 
  
contrib/views/slider/src/test/java/org/apache/ambari/view/slider/SliderClientTest.java
 8af22b7 
  
contrib/views/slider/src/test/java/org/apache/ambari/view/slider/rest/client/SliderAppMasterClientTest.java
 05bff35 


Diff: https://reviews.apache.org/r/60383/diff/1/


Testing
---

Manual Testing done


Thanks,

venkat sairam



Review Request 60366: Hive view 2.0-UI issues on IE11 +Win 7

2017-06-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60366/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav 
Kulshreshtha.


Bugs: AMBARI-21323
https://issues.apache.org/jira/browse/AMBARI-21323


Repository: ambari


Description
---

Fixed CSS for IE 11 and windows7.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 83fac86 


Diff: https://reviews.apache.org/r/60366/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 60362: Zeppelin should have a preconfigured %jdbc(spark) interpreter

2017-06-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60362/#review178652
---


Ship it!




Ship It!

- venkat sairam


On June 22, 2017, 10:41 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60362/
> ---
> 
> (Updated June 22, 2017, 10:41 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21304
> https://issues.apache.org/jira/browse/AMBARI-21304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If you install Zeppelin and have spark installed with STS it should come with 
> pre-configured %jdbc(spark) to point to the installed STS server
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  75ca6a5f89 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  2340df9dea 
> 
> 
> Diff: https://reviews.apache.org/r/60362/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CENTOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60363: zeppelin jdbc interpreter gives error for 'doAs'

2017-06-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60363/#review178651
---


Ship it!




Ship It!

- venkat sairam


On June 22, 2017, 10:46 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60363/
> ---
> 
> (Updated June 22, 2017, 10:46 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21306
> https://issues.apache.org/jira/browse/AMBARI-21306
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While running paragraphs with %jdbc(hive_interactive) - we get exception in 
> doAs
> However, it works with %jdbc(hive)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  75ca6a5f89 
> 
> 
> Diff: https://reviews.apache.org/r/60363/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 60112: Namenode variable should be auto populated for FS action node

2017-06-21 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60112/
---

(Updated June 21, 2017, 9:32 a.m.)


Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21252
https://issues.apache.org/jira/browse/AMBARI-21252


Repository: ambari


Description
---

This is a regression which have been fixed


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8 


Diff: https://reviews.apache.org/r/60112/diff/2/

Changes: https://reviews.apache.org/r/60112/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam



Review Request 60268: Convert Slider View to use yarn package manager

2017-06-21 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60268/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav 
Kulshreshtha.


Bugs: AMBARI-21292
https://issues.apache.org/jira/browse/AMBARI-21292


Repository: ambari


Description
---

Versions in package.json have been updated to fix the build


Diffs
-

  contrib/views/slider/src/main/resources/ui/package.json f9f8793 


Diff: https://reviews.apache.org/r/60268/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 60128: Integrate new hdfs-file browser in WFD

2017-06-21 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60128/
---

(Updated June 21, 2017, 8:47 a.m.)


Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21264
https://issues.apache.org/jira/browse/AMBARI-21264


Repository: ambari


Description
---

The new hdfs file-browser is integrated into WFD.


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 
0194f13 
  
contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js 
8636fd5 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0603b57 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
 5779e36 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/hdfsviewer.js 080409b 
  contrib/views/wfmanager/src/main/resources/ui/bower.json 75ac7a7 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js
 65746e8 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs
 4083ad6 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/utils/viewer-config.js
 64773c6 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/bower.json
 f016904 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/index.js
 dc074d7 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/package.json
 66a7b20 
  contrib/views/wfmanager/src/main/resources/ui/package.json b5973c1 


Diff: https://reviews.apache.org/r/60128/diff/2/

Changes: https://reviews.apache.org/r/60128/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 60114: Remove YARN client mode option from WFM

2017-06-20 Thread venkat sairam


> On June 16, 2017, 10:32 a.m., belliraj hb wrote:
> >

Made necessary changes.Please review again.


- venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/#review178094
---


On June 20, 2017, 5:59 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60114/
> ---
> 
> (Updated June 20, 2017, 5:59 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-21255
> https://issues.apache.org/jira/browse/AMBARI-21255
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> YARN client mode have been removed from WFD as oozie doesnt support Yarn 
> client mode
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 1cfe755 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> c9dc751 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  8c07d6d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs
>  de62e77 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 
> bf858d8 
> 
> 
> Diff: https://reviews.apache.org/r/60114/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>



Re: Review Request 60114: Remove YARN client mode option from WFM

2017-06-20 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/
---

(Updated June 20, 2017, 5:59 p.m.)


Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21255
https://issues.apache.org/jira/browse/AMBARI-21255


Repository: ambari


Description
---

YARN client mode have been removed from WFD as oozie doesnt support Yarn client 
mode


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
1cfe755 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
c9dc751 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 8c07d6d 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs
 de62e77 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8 


Diff: https://reviews.apache.org/r/60114/diff/2/

Changes: https://reviews.apache.org/r/60114/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 60152: Add "zeppelin.server.ssl.port" in Zeppelin's setting

2017-06-16 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60152/#review178093
---


Ship it!




Ship It!

- venkat sairam


On June 16, 2017, 9:28 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60152/
> ---
> 
> (Updated June 16, 2017, 9:28 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21271
> https://issues.apache.org/jira/browse/AMBARI-21271
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "zeppelin.server.ssl.port" in Zeppelin's setting. This is in associated 
> with the changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1321.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  85f1859509 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 2570657b70 
> 
> 
> Diff: https://reviews.apache.org/r/60152/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 60129: Workflow submission fails when action node names contain white space

2017-06-15 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60129/
---

Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21266
https://issues.apache.org/jira/browse/AMBARI-21266


Repository: ambari


Description
---

Validations have been written to check for white space in action node name


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js
 a6e1eeb 


Diff: https://reviews.apache.org/r/60129/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Review Request 60128: Integrate new hdfs-file browser in WFD

2017-06-15 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60128/
---

Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21264
https://issues.apache.org/jira/browse/AMBARI-21264


Repository: ambari


Description
---

The new hdfs file-browser is integrated into WFD.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.css 48232f5 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
 5779e36 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/hdfsviewer.js 080409b 
  contrib/views/wfmanager/src/main/resources/ui/bower.json 75ac7a7 
  contrib/views/wfmanager/src/main/resources/ui/config/environment.js 3e6d865 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js
 65746e8 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs
 4083ad6 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/utils/viewer-config.js
 64773c6 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/bower.json
 f016904 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/index.js
 dc074d7 
  
contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/package.json
 66a7b20 
  contrib/views/wfmanager/src/main/resources/ui/package.json b5973c1 


Diff: https://reviews.apache.org/r/60128/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 59679: Hdfs directory viewer should be changed from tree view to list view.

2017-06-15 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/
---

(Updated June 15, 2017, 10:50 a.m.)


Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21153
https://issues.apache.org/jira/browse/AMBARI-21153


Repository: ambari


Description
---

Hdfs directory viewer have been changed from tree view to list view with added 
views.


Diffs (updated)
-

  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js
 991d122 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css
 PRE-CREATION 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs
 75339c5 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js
 64773c6 
  contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json 
f016904 
  contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js 
dc074d7 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 
66a7b20 


Diff: https://reviews.apache.org/r/59679/diff/2/

Changes: https://reviews.apache.org/r/59679/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Review Request 60114: Remove YARN client mode option from WFM

2017-06-15 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60114/
---

Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21255
https://issues.apache.org/jira/browse/AMBARI-21255


Repository: ambari


Description
---

YARN client mode have been removed from WFD as oozie doesnt support Yarn client 
mode


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
1cfe755 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
c9dc751 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 8c07d6d 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs
 de62e77 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js bf858d8 


Diff: https://reviews.apache.org/r/60114/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Review Request 60112: Namenode variable should be auto populated for FS action node

2017-06-15 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60112/
---

Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, and 
Rohit Choudhary.


Bugs: AMBARI-21252
https://issues.apache.org/jira/browse/AMBARI-21252


Repository: ambari


Description
---

This is a regression which have been fixed


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
 7bf3534 


Diff: https://reviews.apache.org/r/60112/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 60108: Update Zeppelin version on Ambari from 0.7.0 to 0.7.2

2017-06-15 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60108/#review177977
---


Ship it!




Ship It!

- venkat sairam


On June 15, 2017, 6:04 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60108/
> ---
> 
> (Updated June 15, 2017, 6:04 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21251
> https://issues.apache.org/jira/browse/AMBARI-21251
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since, the release of Zeppelin 0.7.2 
> (http://zeppelin.apache.org/releases/zeppelin-release-0.7.2.html). Update 
> Zeppelin version on Ambari from 0.7.0 to 0.7.2
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/metainfo.xml
>  2e2996bcf3 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/ZEPPELIN/metainfo.xml
>  5e6c6b63c6 
> 
> 
> Diff: https://reviews.apache.org/r/60108/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6.4
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 59445: Hive view 2.0 does not work on IE 11 browser

2017-06-07 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59445/#review177152
---


Ship it!




Ship It!

- venkat sairam


On May 22, 2017, 11:22 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59445/
> ---
> 
> (Updated May 22, 2017, 11:22 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-21086
> https://issues.apache.org/jira/browse/AMBARI-21086
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added browser pollyfill.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/ember-cli-build.js 01682e7 
>   contrib/views/hive20/src/main/resources/ui/vendor/browser-pollyfills.js 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59445/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 59679: Hdfs directory viewer should be changed from tree view to list view.

2017-06-04 Thread venkat sairam


> On June 2, 2017, 2:43 a.m., Pallav Kulshreshtha wrote:
> > contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/59679/diff/1/?file=1735256#file1735256line41>
> >
> > Is there no specific version# for emeber colledction?

We have used this version to make this compatible with the plugins used in 
Files view.


- venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/#review176727
-------


On May 31, 2017, 6:32 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59679/
> ---
> 
> (Updated May 31, 2017, 6:32 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, 
> Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-21153
> https://issues.apache.org/jira/browse/AMBARI-21153
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hdfs directory viewer have been changed from tree view to list view with 
> added views.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js
>  991d122 
>   
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css
>  PRE-CREATION 
>   
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs
>  75339c5 
>   
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js
>  64773c6 
>   
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json 
> f016904 
>   contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js 
> dc074d7 
>   
> contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json
>  66a7b20 
> 
> 
> Diff: https://reviews.apache.org/r/59679/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>



Review Request 59679: Hdfs directory viewer should be changed from tree view to list view.

2017-05-31 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59679/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21153
https://issues.apache.org/jira/browse/AMBARI-21153


Repository: ambari


Description
---

Hdfs directory viewer have been changed from tree view to list view with added 
views.


Diffs
-

  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/components/directory-viewer.js
 991d122 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/styles/app.css
 PRE-CREATION 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs
 75339c5 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/addon/utils/viewer-config.js
 64773c6 
  contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/bower.json 
f016904 
  contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/index.js 
dc074d7 
  
contrib/views/commons/src/main/resources/ui/hdfs-directory-viewer/package.json 
66a7b20 


Diff: https://reviews.apache.org/r/59679/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 59526: Unable to upload table via Ambari Hive view if user does not have permission on default database

2017-05-24 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59526/#review175938
---


Ship it!




Ship It!

- venkat sairam


On May 24, 2017, 1:36 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59526/
> ---
> 
> (Updated May 24, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-21108
> https://issues.apache.org/jira/browse/AMBARI-21108
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive view 1.5 was using default DB for use statement in upload table feature. 
> corrected it to use selected database
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  a979dc9478 
> 
> 
> Diff: https://reviews.apache.org/r/59526/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 59444: Hive view 1.5 does not work in Safari8 and IE11

2017-05-23 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59444/#review175765
---


Ship it!




Ship It!

- venkat sairam


On May 22, 2017, 11:20 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59444/
> ---
> 
> (Updated May 22, 2017, 11:20 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-20812
> https://issues.apache.org/jira/browse/AMBARI-20812
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added browser pollyfills.
> 
> 
> Diffs
> -
> 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/Brocfile.js 318d1f8 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/vendor/browser-pollyfills.js
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59444/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review175751
---


Ship it!




Ship It!

- venkat sairam


On May 15, 2017, 7:07 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 15, 2017, 7:07 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, Sangeeta Ravindran, and venkat sairam.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/3/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>



Review Request 59442: Files view on IE 11- On Concatenating files or downloading, the concatenated or downloaded file occupies the entire UI.

2017-05-22 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21084
https://issues.apache.org/jira/browse/AMBARI-21084


Repository: ambari


Description
---

Content-Disposition have been changed from inline to attachment to fix issues 
in IE while downlaoding files


Diffs
-

  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
 10b7c9e 


Diff: https://reviews.apache.org/r/59442/diff/1/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-12 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/#review174766
---



When we enter some random text instead of selecting "tagsinput" option, the 
text is not cleared even after clicking clear filters button.
Please handle this use case too.

- venkat sairam


On May 4, 2017, 7:09 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58894/
> ---
> 
> (Updated May 4, 2017, 7:09 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya 
> N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20904
> https://issues.apache.org/jira/browse/AMBARI-20904
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the filters can be cleared only manually by removing the contents, 
> having a button to clear the filters on one click would be helpful.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  4bfb5fa 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
>  b9c6029 
> 
> 
> Diff: https://reviews.apache.org/r/58894/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> File Attachments
> 
> 
> ClearFilters
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg
> ClearFilters-updated
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/04/e1afff4e-d390-4566-8487-a0fe7d24f702__ClearFilters-1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>



Re: Review Request 59178: Hive view 1.5 : Saved query garbles the unicode characters in query.

2017-05-11 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59178/#review174654
---


Ship it!




Ship It!

- venkat sairam


On May 11, 2017, 1:28 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59178/
> ---
> 
> (Updated May 11, 2017, 1:28 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20990
> https://issues.apache.org/jira/browse/AMBARI-20990
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Writing to hdfs properly now to handle unicode characters.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/files/FileService.java
>  64880bba2f 
> 
> 
> Diff: https://reviews.apache.org/r/59178/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 59169: Hive 2.0 View Table Statistics overflows Integer Type convert to Long

2017-05-11 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59169/#review174627
---


Ship it!




Ship It!

- venkat sairam


On May 11, 2017, 8:28 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59169/
> ---
> 
> (Updated May 11, 2017, 8:28 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20981
> https://issues.apache.org/jira/browse/AMBARI-20981
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> converted the Integers to Longs to avoid overflow in case big ints are coming 
> from hive
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/TableStats.java
>  5d0f307a52 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/parsers/TableMetaParserImpl.java
>  711cab9183 
> 
> 
> Diff: https://reviews.apache.org/r/59169/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

2017-05-09 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59103/#review174339
---


Ship it!




Ship It!

- venkat sairam


On May 9, 2017, 5:02 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59103/
> ---
> 
> (Updated May 9, 2017, 5:02 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and venkat sairam.
> 
> 
> Bugs: AMBARI-20968
> https://issues.apache.org/jira/browse/AMBARI-20968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After "ember-precompile-brunch" package has been changed from "1.5.1" to 
> "0.1.0", ember fails to resolve view templates results in pig and capshed 
> views fails to render. This patch adds custom resolver to fix the issue.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 
> 
> 
> Diff: https://reviews.apache.org/r/59103/diff/1/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>



Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

2017-05-09 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/
---

(Updated May 9, 2017, 2:30 p.m.)


Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma 
Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20673
https://issues.apache.org/jira/browse/AMBARI-20673


Repository: ambari


Description
---

Now when we have only one reducer, the label for aort/partition will be 
displayed as partition.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
d0a3e0b 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 9dbbb00 


Diff: https://reviews.apache.org/r/58179/diff/2/

Changes: https://reviews.apache.org/r/58179/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

2017-05-09 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/
---

(Updated May 9, 2017, 10:54 a.m.)


Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma 
Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20673
https://issues.apache.org/jira/browse/AMBARI-20673


Repository: ambari


Description
---

Now when we have only one reducer, the label for aort/partition will be 
displayed as partition.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
1cfcb15 


Diff: https://reviews.apache.org/r/58179/diff/1/


Testing
---

Manual testing done


File Attachments (updated)


This patch contains code which should go along with other patch
  
https://reviews.apache.org/media/uploaded/files/2017/05/09/0c59f3e2-aedf-4893-9214-be56628dcbef__AMBARI-20673-trunk.01.patch


Thanks,

venkat sairam



Re: Review Request 59059: Runtime filtering is not rendering properly

2017-05-09 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59059/#review174279
---


Ship it!




Ship It!

- venkat sairam


On May 8, 2017, 6:18 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59059/
> ---
> 
> (Updated May 8, 2017, 6:18 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20519
> https://issues.apache.org/jira/browse/AMBARI-20519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Accomodate JSON interface changes.
> - fix arrow position for bloom filter queries.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  1a6d4b3 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  c880614 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  57fff1e 
> 
> 
> Diff: https://reviews.apache.org/r/59059/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread venkat sairam


> On May 4, 2017, 4:49 p.m., Yusaku Sako wrote:
> > contrib/views/files/pom.xml
> > Lines 183 (patched)
> > <https://reviews.apache.org/r/58984/diff/1/?file=1708165#file1708165line183>
> >
> > I tested the patch locally.  
> > 
> > This is a general comment that applies to all pom.xml file changes.
> > We can't have two arguments tags here like this, because the last one 
> > will overwrite the first one.  So essentially, yarn is being run with "yarn 
> > --ignore-engines".
> > 
> > Also, --pure-lockfile argument is missing in this particular pom.xml.

The --pure-lockfile argument is present in files/pom.xml and the arguments tag 
have been fixed in the similar manner how other tags are written.


- venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/#review173924
---


On May 5, 2017, 3:42 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58984/
> ---
> 
> (Updated May 5, 2017, 3:42 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-20928
> https://issues.apache.org/jira/browse/AMBARI-20928
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> npm package manager have been replaced with yarn manager and front-end 
> plugins, node versions have been updated as per the requirements.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/pom.xml 181deb4 
>   contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
>   contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock 
> PRE-CREATION 
>   contrib/views/files/pom.xml 8e691b1 
>   contrib/views/files/src/main/resources/ui/package.json 24da458 
>   contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hawq/pom.xml e4ed54a 
>   contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hive-next/pom.xml a1e116d 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock 
> PRE-CREATION 
>   contrib/views/hive/pom.xml de83dbc 
>   contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
>   contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
>   contrib/views/hueambarimigration/pom.xml f7a42dd 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
>  64b3270 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
>  PRE-CREATION 
>   contrib/views/jobs/pom.xml a8f44f3 
>   contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/pig/pom.xml cf2ed37 
>   contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
>   contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
>   contrib/views/pom.xml 0a1a77f 
>   contrib/views/wfmanager/pom.xml bcb9572 
>   contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
>   contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
>   pom.xml db3d457 
> 
> 
> Diff: https://reviews.apache.org/r/58984/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>



Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/
---

(Updated May 5, 2017, 3:42 a.m.)


Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-20928
https://issues.apache.org/jira/browse/AMBARI-20928


Repository: ambari


Description
---

npm package manager have been replaced with yarn manager and front-end plugins, 
node versions have been updated as per the requirements.


Diffs (updated)
-

  contrib/views/capacity-scheduler/pom.xml 181deb4 
  contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
  contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/files/pom.xml 8e691b1 
  contrib/views/files/src/main/resources/ui/package.json 24da458 
  contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hawq/pom.xml e4ed54a 
  contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hive-next/pom.xml a1e116d 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hive/pom.xml de83dbc 
  contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hueambarimigration/pom.xml f7a42dd 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 64b3270 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
 PRE-CREATION 
  contrib/views/jobs/pom.xml a8f44f3 
  contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/pig/pom.xml cf2ed37 
  contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
  contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
  contrib/views/pom.xml 0a1a77f 
  contrib/views/wfmanager/pom.xml bcb9572 
  contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
  pom.xml db3d457 


Diff: https://reviews.apache.org/r/58984/diff/2/

Changes: https://reviews.apache.org/r/58984/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 58983: Changes in Zeppelin JDBC config after ZEPPELIN-2367

2017-05-04 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58983/#review173888
---


Ship it!




Ship It!

- venkat sairam


On May 4, 2017, 6:21 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58983/
> ---
> 
> (Updated May 4, 2017, 6:21 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20929
> https://issues.apache.org/jira/browse/AMBARI-20929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After ZEPPELIN-2367 there are configuration parameter changes that required 
> to make user impersonation for JDBC interpreter.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  c2f816399b 
> 
> 
> Diff: https://reviews.apache.org/r/58983/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on Cent6.6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58984/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Yusaku Sako.


Bugs: AMBARI-20928
https://issues.apache.org/jira/browse/AMBARI-20928


Repository: ambari


Description
---

npm package manager have been replaced with yarn manager and front-end plugins, 
node versions have been updated as per the requirements.


Diffs
-

  contrib/views/capacity-scheduler/pom.xml 181deb4 
  contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
  contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/files/pom.xml 8e691b1 
  contrib/views/files/src/main/resources/ui/package.json 24da458 
  contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hawq/pom.xml e4ed54a 
  contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hive-next/pom.xml a1e116d 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hive/pom.xml de83dbc 
  contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hueambarimigration/pom.xml f7a42dd 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 64b3270 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
 PRE-CREATION 
  contrib/views/jobs/pom.xml a8f44f3 
  contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/pig/pom.xml cf2ed37 
  contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
  contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
  contrib/views/pom.xml 0a1a77f 
  contrib/views/wfmanager/pom.xml bcb9572 
  contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
  pom.xml db3d457 


Diff: https://reviews.apache.org/r/58984/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

2017-05-02 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58842/#review173567
---


Ship it!




Ship It!

- venkat sairam


On April 28, 2017, noon, Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58842/
> ---
> 
> (Updated April 28, 2017, noon)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20888
> https://issues.apache.org/jira/browse/AMBARI-20888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> wrong ZK parent node (hbase-unsecure) getting configured as part of the 
> jdbc(phoenix) URL on ubuntu secured cluster the jdbc(phoenix) url was getting 
> appended as /hbase-unsecure which is not correct
> If you check the hbase-site.xml
> 
> zookeeper.znode.parent
> /hbase-secure
> 
> I think how the phoenix URL is being constructed is not consistent across the 
> configs and we need to see why. On some of the other platforms, I have seen 
> it getting configured correctly (for e.g. Centos6 secured wire-encrypted)
> Options
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  fbf2246672 
> 
> 
> Diff: https://reviews.apache.org/r/58842/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on Cent6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Review Request 58882: Ambari build failure after npm to yarn package manager migration.

2017-05-01 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58882/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-20902
https://issues.apache.org/jira/browse/AMBARI-20902


Repository: ambari


Description
---

Added yarn.lock in RAT skip section


Diffs
-

  pom.xml 1cf13f4 


Diff: https://reviews.apache.org/r/58882/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 58837: Convert all Ambari Views to use yarn package manager

2017-04-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/
---

(Updated April 30, 2017, 6:16 p.m.)


Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Changes
---

Added --pure-lockfile option to yarn install, added yarn.lock file to yarn 
exclude list.


Bugs: AMBARI-20885
https://issues.apache.org/jira/browse/AMBARI-20885


Repository: ambari


Description
---

Converted all Ambari Views to use yarn package manager with changes in pom.xml 
and package.json.


Diffs (updated)
-

  contrib/views/capacity-scheduler/pom.xml 7a65ffb 
  contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/files/pom.xml 478a537 
  contrib/views/files/src/main/resources/ui/package.json 3f27897 
  contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hawq/pom.xml 8089d68 
  contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hive-next/pom.xml c0eb774 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f 
  contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hive20/pom.xml a583d23 
  contrib/views/hive20/src/main/resources/ui/package.json 0453a52 
  contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hueambarimigration/pom.xml 30e7694 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 09c3a27 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
 PRE-CREATION 
  contrib/views/jobs/pom.xml 062f15f 
  contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/pig/pom.xml d89d47e 
  contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
  contrib/views/pom.xml 6dcfce2 
  contrib/views/wfmanager/pom.xml 86c03f9 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 


Diff: https://reviews.apache.org/r/58837/diff/4/

Changes: https://reviews.apache.org/r/58837/diff/3-4/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 58876: Need to show data in sorted order in Hive view

2017-04-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58876/
---

(Updated April 30, 2017, 3:35 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20139
https://issues.apache.org/jira/browse/AMBARI-20139


Repository: ambari


Description
---

Data is shown in the folowing way.
Case 1: Tables list view in 'Query' Tab and 'Tables' tab
Tables should be listed in alphabetical order
Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending 
order makes sense.
Case 3 : 'Saved Queries' and 'UDFs' tab
Result should be sorted based on user action time. Recent action should come 
first.
Case 4: 'Settings' tab :
Lexicographical order based on KEY.


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js 
be2771c 
  contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 
72a83a3 
  contrib/views/hive20/src/main/resources/ui/app/controllers/savedqueries.js 
PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs
 338828e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs
 c3f9c76 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
ce7315f 
  contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca 


Diff: https://reviews.apache.org/r/58876/diff/2/

Changes: https://reviews.apache.org/r/58876/diff/1-2/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 58877: hive view 2.0 : uploaded table does not contain any data.

2017-04-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58877/#review173446
---


Ship it!




Ship It!

- venkat sairam


On April 30, 2017, 1:26 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58877/
> ---
> 
> (Updated April 30, 2017, 1:26 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20900
> https://issues.apache.org/jira/browse/AMBARI-20900
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Semicolon was missing in the recently changed insert from query.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  19d4f06d71 
> 
> 
> Diff: https://reviews.apache.org/r/58877/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 58876: Need to show data in sorted order in Hive view

2017-04-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58876/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20139
https://issues.apache.org/jira/browse/AMBARI-20139


Repository: ambari


Description
---

Data is shown in the folowing way.
Case 1: Tables list view in 'Query' Tab and 'Tables' tab
Tables should be listed in alphabetical order
Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending 
order makes sense.
Case 3 : 'Saved Queries' and 'UDFs' tab
Result should be sorted based on user action time. Recent action should come 
first.
Case 4: 'Settings' tab :
Lexicographical order based on KEY.


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js 
be2771c 
  contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 
72a83a3 
  contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 
  contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348 
  contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs
 338828e 
  
contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs
 c3f9c76 
  contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 
ce7315f 
  contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca 


Diff: https://reviews.apache.org/r/58876/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam



Re: Review Request 58875: Ambari Header misaligned when transitioned to view route

2017-04-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58875/#review173441
---


Ship it!




Ship It!

- venkat sairam


On April 30, 2017, 4:58 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58875/
> ---
> 
> (Updated April 30, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20899
> https://issues.apache.org/jira/browse/AMBARI-20899
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor css adjustments
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 716e272 
>   ambari-web/app/styles/bootstrap_overrides.less 09e68b6 
> 
> 
> Diff: https://reviews.apache.org/r/58875/diff/2/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 58837: Convert all Ambari Views to use yarn package manager

2017-04-30 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/
---

(Updated April 30, 2017, 6:37 a.m.)


Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, 
Pallav Kulshreshtha, and Rohit Choudhary.


Changes
---

Added moment libabry ember-cli reference.


Bugs: AMBARI-20885
https://issues.apache.org/jira/browse/AMBARI-20885


Repository: ambari


Description
---

Converted all Ambari Views to use yarn package manager with changes in pom.xml 
and package.json.


Diffs (updated)
-

  contrib/views/capacity-scheduler/pom.xml 7a65ffb 
  contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/files/pom.xml 478a537 
  contrib/views/files/src/main/resources/ui/package.json 3f27897 
  contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hawq/pom.xml 8089d68 
  contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hive-next/pom.xml c0eb774 
  contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f 
  contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION 
  contrib/views/hive20/pom.xml a583d23 
  contrib/views/hive20/src/main/resources/ui/package.json 0453a52 
  contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/hueambarimigration/pom.xml 30e7694 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
 09c3a27 
  
contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
 PRE-CREATION 
  contrib/views/jobs/pom.xml 062f15f 
  contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
  contrib/views/pig/pom.xml d89d47e 
  contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
  contrib/views/wfmanager/pom.xml 86c03f9 
  contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 


Diff: https://reviews.apache.org/r/58837/diff/3/

Changes: https://reviews.apache.org/r/58837/diff/2-3/


Testing
---

Manual testing done.


Thanks,

venkat sairam



Re: Review Request 58841: UI - Ambari top nav width changes for views applications

2017-04-29 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58841/#review173420
---


Ship it!




Ship It!

- venkat sairam


On April 28, 2017, 11:47 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58841/
> ---
> 
> (Updated April 28, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, 
> and venkat sairam.
> 
> 
> Bugs: AMBARI-20887
> https://issues.apache.org/jira/browse/AMBARI-20887
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> minor css change.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 23c534b 
>   ambari-web/app/styles/bootstrap_overrides.less a856d82 
> 
> 
> Diff: https://reviews.apache.org/r/58841/diff/1/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>



Re: Review Request 58835: Visual explain issues

2017-04-29 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58835/
---

(Updated April 29, 2017, 7:04 a.m.)


Review request for Ambari, Abhishek Kumar, belliraj hb, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Changes
---

Fixed arrow allignment for huge graphs.


Bugs: AMBARI-20883
https://issues.apache.org/jira/browse/AMBARI-20883


Repository: ambari


Description
---

Used directed arrows rather than simple lines in visual explain and Issue in 
connection lines for simple queries in visual-explain in Firefox have been 
fixed.


Diffs (updated)
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
4d9eff4 


Diff: https://reviews.apache.org/r/58835/diff/2/

Changes: https://reviews.apache.org/r/58835/diff/1-2/


Testing
---

Manual testing have been done


Thanks,

venkat sairam



Re: Review Request 58837: Convert all Ambari Views to use yarn package manager

2017-04-29 Thread venkat sairam


> On April 28, 2017, 4:23 p.m., DIPAYAN BHOWMICK wrote:
> >

Fixed it and added yarn.lock files.


- venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58837/#review173334
---


On April 29, 2017, 6:26 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58837/
> ---
> 
> (Updated April 29, 2017, 6:26 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20885
> https://issues.apache.org/jira/browse/AMBARI-20885
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Converted all Ambari Views to use yarn package manager with changes in 
> pom.xml and package.json.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/pom.xml 7a65ffb 
>   contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock 
> PRE-CREATION 
>   contrib/views/files/pom.xml 478a537 
>   contrib/views/files/src/main/resources/ui/package.json 3f27897 
>   contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hawq/pom.xml 8089d68 
>   contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hive-next/pom.xml c0eb774 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f 
>   contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock 
> PRE-CREATION 
>   contrib/views/hive20/pom.xml a583d23 
>   contrib/views/hive20/src/main/resources/ui/package.json 0453a52 
>   contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/hueambarimigration/pom.xml 30e7694 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json
>  09c3a27 
>   
> contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock
>  PRE-CREATION 
>   contrib/views/jobs/pom.xml 062f15f 
>   contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION 
>   contrib/views/pig/pom.xml d89d47e 
>   contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION 
>   contrib/views/wfmanager/pom.xml 86c03f9 
>   contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58837/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> venkat sairam
> 
>



  1   2   >