subject:"Re\: Review Request 45458\: AMBARI\-15528\: Stack Featurize RANGER and RANGER

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Jayush Luniya



> On March 30, 2016, 2:57 p.m., Sumit Mohanty wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/constants.py,
> >  line 62
> > 
> >
> > OK, for now but should not this be in the stack definition as these are 
> > service related?

Some refactoring of resource_management is required but will leave it for 
future.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45458/#review126112
---


On March 30, 2016, 4:06 a.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45458/
> ---
> 
> (Updated March 30, 2016, 4:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Juanjo  Marron, 
> Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15528
> https://issues.apache.org/jira/browse/AMBARI-15528
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize RANGER and RANGER_KMS service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f051cfd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  6095a80 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  1046d62 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  da34696 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  b25549f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  07f3ab6 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
>  8bbab02 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  51e5eab 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  3542814 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/upgrade.py
>  aa75949 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  11a705a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  42f1cb9 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  1e55d4a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/upgrade.py
>  315a417 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  86e5971 
> 
> Diff: https://reviews.apache.org/r/45458/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 56.375s
> [INFO] Finished at: Tue Mar 29 16:22:03 PDT 2016
> [INFO] Final Memory: 62M/1136M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45458/#review126112
---




ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 (line 62)


OK, for now but should not this be in the stack definition as these are 
service related?


- Sumit Mohanty


On March 30, 2016, 4:06 a.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45458/
> ---
> 
> (Updated March 30, 2016, 4:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Juanjo  Marron, 
> Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15528
> https://issues.apache.org/jira/browse/AMBARI-15528
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize RANGER and RANGER_KMS service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f051cfd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  6095a80 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  1046d62 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  da34696 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  b25549f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  07f3ab6 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
>  8bbab02 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  51e5eab 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  3542814 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/upgrade.py
>  aa75949 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  11a705a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  42f1cb9 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  1e55d4a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/upgrade.py
>  315a417 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  86e5971 
> 
> Diff: https://reviews.apache.org/r/45458/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 56.375s
> [INFO] Finished at: Tue Mar 29 16:22:03 PDT 2016
> [INFO] Final Memory: 62M/1136M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45458/#review126113
---


Ship it!




One minor question - probably future work item. Ship it.

- Sumit Mohanty


On March 30, 2016, 4:06 a.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45458/
> ---
> 
> (Updated March 30, 2016, 4:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Juanjo  Marron, 
> Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15528
> https://issues.apache.org/jira/browse/AMBARI-15528
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize RANGER and RANGER_KMS service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f051cfd 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  6095a80 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  1046d62 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  da34696 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  b25549f 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  07f3ab6 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
>  8bbab02 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  51e5eab 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  3542814 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/upgrade.py
>  aa75949 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  11a705a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  42f1cb9 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  1e55d4a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/upgrade.py
>  315a417 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  86e5971 
> 
> Diff: https://reviews.apache.org/r/45458/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 56.375s
> [INFO] Finished at: Tue Mar 29 16:22:03 PDT 2016
> [INFO] Final Memory: 62M/1136M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-29 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45458/
---

(Updated March 30, 2016, 4:06 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Juanjo  Marron, 
Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-15528
https://issues.apache.org/jira/browse/AMBARI-15528


Repository: ambari


Description
---

Stack Featurize RANGER and RANGER_KMS service


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 f051cfd 
  
ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
 6095a80 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 1046d62 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 da34696 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 b25549f 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 07f3ab6 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
 8bbab02 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 51e5eab 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 3542814 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/upgrade.py
 aa75949 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 11a705a 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 42f1cb9 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 1e55d4a 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/upgrade.py
 315a417 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 86e5971 

Diff: https://reviews.apache.org/r/45458/diff/


Testing
---

mvn clean test -DskipSurefireTests
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 56.375s
[INFO] Finished at: Tue Mar 29 16:22:03 PDT 2016
[INFO] Final Memory: 62M/1136M
[INFO] 


Thanks,

Jayush Luniya

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

2016-03-29 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45458/
---

(Updated March 30, 2016, 1:34 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Juanjo  Marron, 
Sumit Mohanty, and Velmurugan Periasamy.


Changes
---

Spot fix for missing stack_root declaration


Bugs: AMBARI-15528
https://issues.apache.org/jira/browse/AMBARI-15528


Repository: ambari


Description
---

Stack Featurize RANGER and RANGER_KMS service


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 f766a82 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 1046d62 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2f0e6bf 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 b25549f 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 07f3ab6 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
 8bbab02 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 51e5eab 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 3542814 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/upgrade.py
 aa75949 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 11a705a 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 42f1cb9 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 1e55d4a 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/upgrade.py
 315a417 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 97bd19c 

Diff: https://reviews.apache.org/r/45458/diff/


Testing
---

mvn clean test -DskipSurefireTests
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 56.375s
[INFO] Finished at: Tue Mar 29 16:22:03 PDT 2016
[INFO] Final Memory: 62M/1136M
[INFO] 


Thanks,

Jayush Luniya

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

Re: Review Request 45458: AMBARI-15528: Stack Featurize RANGER and RANGER_KMS service

5 matches

Site Navigation

Mail list logo

Footer information