Re: Review Request 47117: HiveServer interactive fails to start

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132677
---


Ship it!




Ship It!

- Sebastian Toader


On May 11, 2016, 4:53 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 11, 2016, 4:53 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> e9ddc25 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
> (failing tests are not related to this issue)
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

(Updated máj. 11, 2016, 2:53 du)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Changes
---

Memory setting is needed to be added even if other llap related configs are 
skipped. (hive.llap.daemon.yarn.container.mb must be greater or equal to 
yarn.scheduler.allocation-minimum-mb, otherwise hive server interactive does 
not start)


Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303


Repository: ambari


Description
---

If Total Daemon Size of hive server interactive is less than yarn container 
minimum size, then hive server interactive fails to start. Stack advisor was 
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was 
simply missing from the BlueprintConfigurationProcessor.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 29f937a 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
37e6ef6 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e9ddc25 

Diff: https://reviews.apache.org/r/47117/diff/


Testing
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if 
the resolver itself works correctly.

Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
(failing tests are not related to this issue)


Thanks,

Daniel Gergely

Re: Review Request 47117: HiveServer interactive fails to start

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132285
---


Ship it!




Ship It!

- Sandor Magyari


On May 9, 2016, 2:18 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 2:18 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
> (failing tests are not related to this issue)
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132281
---


Ship it!




- Sebastian Toader


On May 9, 2016, 4:18 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 4:18 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
> (failing tests are not related to this issue)
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

(Updated máj. 9, 2016, 2:18 du)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Changes
---

Unit test report


Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303


Repository: ambari


Description
---

If Total Daemon Size of hive server interactive is less than yarn container 
minimum size, then hive server interactive fails to start. Stack advisor was 
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was 
simply missing from the BlueprintConfigurationProcessor.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 29f937a 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
37e6ef6 

Diff: https://reviews.apache.org/r/47117/diff/


Testing (updated)
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if 
the resolver itself works correctly.

Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
(failing tests are not related to this issue)


Thanks,

Daniel Gergely

Re: Review Request 47117: HiveServer interactive fails to start

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132267
---


Ship it!




Ship It!

- Sumit Mohanty


On May 9, 2016, 1:01 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 1:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132266
---


Ship it!




Ship It!

- Laszlo Puskas


On May 9, 2016, 1:01 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 1:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/
---

(Updated máj. 9, 2016, 1:01 du)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-16303
https://issues.apache.org/jira/browse/AMBARI-16303


Repository: ambari


Description
---

If Total Daemon Size of hive server interactive is less than yarn container 
minimum size, then hive server interactive fails to start. Stack advisor was 
corrected to take yarn container size into account.
The property *hive_server_interactive_host* was not resolved, not it is. It was 
simply missing from the BlueprintConfigurationProcessor.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 29f937a 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
37e6ef6 

Diff: https://reviews.apache.org/r/47117/diff/


Testing
---

The stack advisor issue is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if 
the resolver itself works correctly.

Unit tests are still running locally...


Thanks,

Daniel Gergely

Re: Review Request 47117: HiveServer interactive fails to start

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132265
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
332)


Is there any function in python for min/max calculation instead of the "if" 
structure ...


- Laszlo Puskas


On May 9, 2016, 12:28 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 12:28 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 47117: HiveServer interactive fails to start

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47117/#review132261
---


Ship it!




Ship It!

- Oliver Szabo


On May 9, 2016, 12:28 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47117/
> ---
> 
> (Updated May 9, 2016, 12:28 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16303
> https://issues.apache.org/jira/browse/AMBARI-16303
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Total Daemon Size of hive server interactive is less than yarn container 
> minimum size, then hive server interactive fails to start. Stack advisor was 
> corrected to take yarn container size into account.
> The property *hive_server_interactive_host* was not resolved, not it is. It 
> was simply missing from the BlueprintConfigurationProcessor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  29f937a 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 37e6ef6 
> 
> Diff: https://reviews.apache.org/r/47117/diff/
> 
> 
> Testing
> ---
> 
> The stack advisor issue is checked manually.
> The blueprint issue is also checked manually, a separated unit test checks if 
> the resolver itself works correctly.
> 
> Unit tests are still running locally...
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>