Re: Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52709/#review152201
---


Ship it!




Ship It!

- Robert Levas


On Oct. 10, 2016, 7:21 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52709/
> ---
> 
> (Updated Oct. 10, 2016, 7:21 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-18565
> https://issues.apache.org/jira/browse/AMBARI-18565
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deprecate the older UpgradeCatalog tests that are no longer needed to 
> decrease time it takes to run unit tests.
> UpgradeCatalog150Test
> UpgradeCatalog151Test
> UpgradeCatalog160Test
> UpgradeCatalog161Test
> UpgradeCatalog170Test
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
>  7469bbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityFilterTest.java
>  49eefed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
>  ec01b80 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DeadlockWarningThread.java
>  589aee1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java
>  4647815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java
>  b47f411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
>  303fa3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
>  a3b41b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
>  10e4993 
> 
> Diff: https://reviews.apache.org/r/52709/diff/
> 
> 
> Testing
> ---
> 
> "mvn clean test" passed
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52709/
---

(Updated Oct. 10, 2016, 11:21 p.m.)


Review request for Ambari, Jonathan Hurley and Sid Wagle.


Bugs: AMBARI-18565
https://issues.apache.org/jira/browse/AMBARI-18565


Repository: ambari


Description
---

Deprecate the older UpgradeCatalog tests that are no longer needed to decrease 
time it takes to run unit tests.
UpgradeCatalog150Test
UpgradeCatalog151Test
UpgradeCatalog160Test
UpgradeCatalog161Test
UpgradeCatalog170Test


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
 7469bbc 
  
ambari-server/src/test/java/org/apache/ambari/server/security/SecurityFilterTest.java
 49eefed 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
 ec01b80 
  
ambari-server/src/test/java/org/apache/ambari/server/testing/DeadlockWarningThread.java
 589aee1 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java
 4647815 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java
 b47f411 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
 303fa3a 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
 a3b41b8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
 10e4993 

Diff: https://reviews.apache.org/r/52709/diff/


Testing (updated)
---

"mvn clean test" passed


Thanks,

Alejandro Fernandez

Re: Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52709/#review152073
---




ambari-server/src/test/java/org/apache/ambari/server/security/SecurityFilterTest.java
 (line 115)


Gain a small improvement in this class by switching to mock module



ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
 (line 74)


Added more threads here and reduced the number of hosts, time went down 
from 2 min to 1:30


- Alejandro Fernandez


On Oct. 10, 2016, 10:12 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52709/
> ---
> 
> (Updated Oct. 10, 2016, 10:12 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-18565
> https://issues.apache.org/jira/browse/AMBARI-18565
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deprecate the older UpgradeCatalog tests that are no longer needed to 
> decrease time it takes to run unit tests.
> UpgradeCatalog150Test
> UpgradeCatalog151Test
> UpgradeCatalog160Test
> UpgradeCatalog161Test
> UpgradeCatalog170Test
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
>  7469bbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityFilterTest.java
>  49eefed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
>  ec01b80 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DeadlockWarningThread.java
>  589aee1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java
>  4647815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java
>  b47f411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
>  303fa3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
>  a3b41b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
>  10e4993 
> 
> Diff: https://reviews.apache.org/r/52709/diff/
> 
> 
> Testing
> ---
> 
> Waiting for unit test results to make sure trunk is clean.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>