Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2017-09-05 Thread Attila Doroszlai 


> On Oct. 13, 2016, 2:26 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/python/setupAgent.py
> > Line 125 (original), 125 (patched)
> > 
> >
> > The `-y` flag for `install` is an alias for `--non-interactive`, so 
> > this change is not strictly necessary.
> > 
> > https://en.opensuse.org/SDB:Zypper_manual_(plain)
> 
> Zsombor Gegesy wrote:
> Interesting. In this case, I'm very curious, why that flag didn't work, 
> and stucked in the middle, unfortunately I can't reproduce it now.
> 
> Attila Doroszlai wrote:
> It was stuck at "zypper search", not this one.
> 
> Zsombor Gegesy wrote:
> Sorry, I was confused a bit, obviously. 
> 
> Could you merge it?

Already merged it earlier today, so the review request can be closed.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152483
---


On Oct. 18, 2016, 1:05 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 18, 2016, 1:05 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> 
> Diff: https://reviews.apache.org/r/52785/diff/3/
> 
> 
> Testing
> ---
> 
> I've tested on a Suse 11p3, with manually editing the setupAgent.py file, to 
> start the installation.
> Unfortunately I couldn't build ambari locally, some npm/brunch compilation 
> error blocks maven
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2017-09-05 Thread Zsombor Gegesy 


> On Oct. 13, 2016, 12:26 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/python/setupAgent.py
> > Line 125 (original), 125 (patched)
> > 
> >
> > The `-y` flag for `install` is an alias for `--non-interactive`, so 
> > this change is not strictly necessary.
> > 
> > https://en.opensuse.org/SDB:Zypper_manual_(plain)
> 
> Zsombor Gegesy wrote:
> Interesting. In this case, I'm very curious, why that flag didn't work, 
> and stucked in the middle, unfortunately I can't reproduce it now.
> 
> Attila Doroszlai wrote:
> It was stuck at "zypper search", not this one.

Sorry, I was confused a bit, obviously. 

Could you merge it?


- Zsombor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152483
---


On Oct. 18, 2016, 11:05 a.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 18, 2016, 11:05 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> 
> Diff: https://reviews.apache.org/r/52785/diff/3/
> 
> 
> Testing
> ---
> 
> I've tested on a Suse 11p3, with manually editing the setupAgent.py file, to 
> start the installation.
> Unfortunately I couldn't build ambari locally, some npm/brunch compilation 
> error blocks maven
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2017-09-05 Thread Attila Doroszlai 


> On Oct. 13, 2016, 2:26 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/python/setupAgent.py
> > Line 125 (original), 125 (patched)
> > 
> >
> > The `-y` flag for `install` is an alias for `--non-interactive`, so 
> > this change is not strictly necessary.
> > 
> > https://en.opensuse.org/SDB:Zypper_manual_(plain)
> 
> Zsombor Gegesy wrote:
> Interesting. In this case, I'm very curious, why that flag didn't work, 
> and stucked in the middle, unfortunately I can't reproduce it now.

It was stuck at "zypper search", not this one.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152483
---


On Oct. 18, 2016, 1:05 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 18, 2016, 1:05 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> 
> Diff: https://reviews.apache.org/r/52785/diff/3/
> 
> 
> Testing
> ---
> 
> I've tested on a Suse 11p3, with manually editing the setupAgent.py file, to 
> start the installation.
> Unfortunately I couldn't build ambari locally, some npm/brunch compilation 
> error blocks maven
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2017-09-05 Thread Zsombor Gegesy 


> On Oct. 13, 2016, 12:26 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/python/setupAgent.py
> > Line 125 (original), 125 (patched)
> > 
> >
> > The `-y` flag for `install` is an alias for `--non-interactive`, so 
> > this change is not strictly necessary.
> > 
> > https://en.opensuse.org/SDB:Zypper_manual_(plain)

Interesting. In this case, I'm very curious, why that flag didn't work, and 
stucked in the middle, unfortunately I can't reproduce it now.


- Zsombor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152483
---


On Oct. 18, 2016, 11:05 a.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 18, 2016, 11:05 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> 
> Diff: https://reviews.apache.org/r/52785/diff/3/
> 
> 
> Testing
> ---
> 
> I've tested on a Suse 11p3, with manually editing the setupAgent.py file, to 
> start the installation.
> Unfortunately I couldn't build ambari locally, some npm/brunch compilation 
> error blocks maven
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-13 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/
---

(Updated Oct. 13, 2016, 2:52 p.m.)


Review request for Ambari and Sandor Magyari.


Bugs: AMBARI-18577
https://issues.apache.org/jira/browse/AMBARI-18577


Repository: ambari


Description
---

Add "--non-interactive" flag to zypper invocations in setupAgent


Diffs (updated)
-

  ambari-server/src/main/python/setupAgent.py 9a1cae9 

Diff: https://reviews.apache.org/r/52785/diff/


Testing (updated)
---

I've tested on a Suse 11p3, with manually editing the setupAgent.py file, to 
start the installation.
Unfortunately I couldn't build ambari locally, some npm/brunch compilation 
error blocks maven


Thanks,

Zsombor Gegesy

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-13 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/
---

(Updated Oct. 13, 2016, 2:24 p.m.)


Review request for Ambari and Sandor Magyari.


Bugs: AMBARI-18577
https://issues.apache.org/jira/browse/AMBARI-18577


Repository: ambari


Description
---

Add "--non-interactive" flag to zypper invocations in setupAgent


Diffs (updated)
-

  ambari-server/src/main/python/setupAgent.py 9a1cae9 

Diff: https://reviews.apache.org/r/52785/diff/


Testing
---


Thanks,

Zsombor Gegesy

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-13 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152483
---


Ship it!





ambari-server/src/main/python/setupAgent.py (line 125)


The `-y` flag for `install` is an alias for `--non-interactive`, so this 
change is not strictly necessary.

https://en.opensuse.org/SDB:Zypper_manual_(plain)


- Attila Doroszlai


On Oct. 12, 2016, 4:36 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 12, 2016, 4:36 p.m.)
> 
> 
> Review request for Ambari and Sandor Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> Diff: https://reviews.apache.org/r/52785/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-13 Thread Laszlo Puskas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152470
---


Ship it!




Ship It!

- Laszlo Puskas


On Oct. 12, 2016, 2:36 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 12, 2016, 2:36 p.m.)
> 
> 
> Review request for Ambari and Sandor Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> Diff: https://reviews.apache.org/r/52785/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>

Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-13 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152466
---


Ship it!




Could you please run 'mvn clean test  -DskipSurefireTests=true' to make sure 
pyhton unit tests are fine and add the result to 'Testing done' section. Also 
you can add there if you have made some manual testing etc.

- Sandor Magyari


On Oct. 12, 2016, 2:36 p.m., Zsombor Gegesy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52785/
> ---
> 
> (Updated Oct. 12, 2016, 2:36 p.m.)
> 
> 
> Review request for Ambari and Sandor Magyari.
> 
> 
> Bugs: AMBARI-18577
> https://issues.apache.org/jira/browse/AMBARI-18577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "--non-interactive" flag to zypper invocations in setupAgent
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/setupAgent.py 9a1cae9 
> 
> Diff: https://reviews.apache.org/r/52785/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>