Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52932/#review153102
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 18, 2016, 10:27 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52932/
> ---
> 
> (Updated Oct. 18, 2016, 10:27 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18611
> https://issues.apache.org/jira/browse/AMBARI-18611
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Ambari MIB located at 
> https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt
>  should be included on the file system when Ambari is installed.
> It's location should be alongside other resources at:
> /var/lib/ambari-server/resources
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml 9252c56 
>   ambari-server/src/main/resources/APACHE-AMBARI-MIB.txt PRE-CREATION 
>   contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt 85ec3cd 
>   contrib/alert-snmp-mib/README.md 37fbc0a 
> 
> Diff: https://reviews.apache.org/r/52932/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

[Jonathan Hurley]

> On Oct. 17, 2016, 5:10 p.m., Jonathan Hurley wrote:
> > ambari-server/pom.xml, line 44
> > 
> >
> > I think that perhaps we should now move this out of contrib and into 
> > resources directly since it's a first-class part of the product.
> 
> Dmytro Sen wrote:
> Do you mean moving whole alert-snmp-mib directory to 
> /var/lib/ambari-server/resources ? Or only APACHE-AMBARI-MIB.txt ?

Only the MIB - The idea here is that we are shipping a first-class MIB with 
known OIDs which can be imported into any organization's existing SNMP 
structure. I don't think we need the rest of alert-snmp-mib since it contains 
examples for setting up a quick ad-hoc SNMP infra.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52932/#review152957
---


On Oct. 17, 2016, 12:05 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52932/
> ---
> 
> (Updated Oct. 17, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18611
> https://issues.apache.org/jira/browse/AMBARI-18611
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Ambari MIB located at 
> https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt
>  should be included on the file system when Ambari is installed.
> It's location should be alongside other resources at:
> /var/lib/ambari-server/resources
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml e02b7a5 
>   ambari-server/src/main/assemblies/server.xml 9252c56 
> 
> Diff: https://reviews.apache.org/r/52932/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

[Dmytro Sen]

> On Окт. 17, 2016, 9:10 п.п., Jonathan Hurley wrote:
> > ambari-server/pom.xml, line 44
> > 
> >
> > I think that perhaps we should now move this out of contrib and into 
> > resources directly since it's a first-class part of the product.

Do you mean moving whole alert-snmp-mib directory to 
/var/lib/ambari-server/resources ? Or only APACHE-AMBARI-MIB.txt ?


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52932/#review152957
---


On Окт. 17, 2016, 4:05 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52932/
> ---
> 
> (Updated Окт. 17, 2016, 4:05 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18611
> https://issues.apache.org/jira/browse/AMBARI-18611
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Ambari MIB located at 
> https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt
>  should be included on the file system when Ambari is installed.
> It's location should be alongside other resources at:
> /var/lib/ambari-server/resources
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml e02b7a5 
>   ambari-server/src/main/assemblies/server.xml 9252c56 
> 
> Diff: https://reviews.apache.org/r/52932/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52932/#review152957
---




ambari-server/pom.xml (line 44)


I think that perhaps we should now move this out of contrib and into 
resources directly since it's a first-class part of the product.


- Jonathan Hurley


On Oct. 17, 2016, 12:05 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52932/
> ---
> 
> (Updated Oct. 17, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18611
> https://issues.apache.org/jira/browse/AMBARI-18611
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Ambari MIB located at 
> https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt
>  should be included on the file system when Ambari is installed.
> It's location should be alongside other resources at:
> /var/lib/ambari-server/resources
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml e02b7a5 
>   ambari-server/src/main/assemblies/server.xml 9252c56 
> 
> Diff: https://reviews.apache.org/r/52932/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>