Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/
---
(Updated Oct. 26, 2016, 12:02 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
Bugs: AMBARI-18699
https://issues.apache.org/jira/browse/AMBARI-18699
Repository: ambari
Description
---
The {{config-upgrade.xml}} packs which define the configuration changes during
an upgrade do not have an XSD to validate them. They also contain and outdated
and deprecated element called {{condition}} which can be replaced.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
54431eb
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
a9b355a
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml
c225cca
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml
7d80a63
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml
ecf324c
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
59e4ec5
ambari-server/src/main/resources/upgrade-config.xsd PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
e764781
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml
44f9e02
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml
90d64b4
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
90d64b4
Diff: https://reviews.apache.org/r/53185/diff/
Testing (updated)
---
Tests run: 4713, Failures: 0, Errors: 0, Skipped: 42
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 28:09 min
[INFO] Finished at: 2016-10-26T11:12:42-04:00
[INFO] Final Memory: 54M/744M
[INFO]
Thanks,
Jonathan Hurley
Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/#review153874
---
Ship it!
Ship It!
- Nate Cole
On Oct. 26, 2016, 8:19 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53185/
> ---
>
> (Updated Oct. 26, 2016, 8:19 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
>
>
> Bugs: AMBARI-18699
> https://issues.apache.org/jira/browse/AMBARI-18699
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The {{config-upgrade.xml}} packs which define the configuration changes
> during an upgrade do not have an XSD to validate them. They also contain and
> outdated and deprecated element called {{condition}} which can be replaced.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
> 54431eb
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
> a9b355a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml
> c225cca
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml
> 7d80a63
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml
> ecf324c
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
> 59e4ec5
> ambari-server/src/main/resources/upgrade-config.xsd PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
> e764781
>
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml
> 44f9e02
>
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml
> 90d64b4
>
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
> 90d64b4
>
> Diff: https://reviews.apache.org/r/53185/diff/
>
>
> Testing
> ---
>
> PENDING
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/#review153872
---
Ship it!
Ship It!
- Robert Levas
On Oct. 26, 2016, 8:19 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53185/
> ---
>
> (Updated Oct. 26, 2016, 8:19 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
>
>
> Bugs: AMBARI-18699
> https://issues.apache.org/jira/browse/AMBARI-18699
>
>
> Repository: ambari
>
>
> Description
> ---
>
> The {{config-upgrade.xml}} packs which define the configuration changes
> during an upgrade do not have an XSD to validate them. They also contain and
> outdated and deprecated element called {{condition}} which can be replaced.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java
> 54431eb
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
> a9b355a
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml
> c225cca
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml
> 7d80a63
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml
> ecf324c
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
> 59e4ec5
> ambari-server/src/main/resources/upgrade-config.xsd PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
> e764781
>
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml
> 44f9e02
>
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml
> 90d64b4
>
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
> 90d64b4
>
> Diff: https://reviews.apache.org/r/53185/diff/
>
>
> Testing
> ---
>
> PENDING
>
>
> Thanks,
>
> Jonathan Hurley
>
>
