Re: Review Request 53200: AMBARI-18686 - Falcon user shouldn't be added to Oozie admin list if Falcon is not installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53200/#review154094 --- Ship it! Ship It! - Di Li On Oct. 26, 2016, 6:27 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53200/ > --- > > (Updated Oct. 26, 2016, 6:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, and Venkat Ranganathan. > > > Bugs: AMBARI-18686 > https://issues.apache.org/jira/browse/AMBARI-18686 > > > Repository: ambari > > > Description > --- > > Falcon user shouldn't be added to Oozie admin list if Falcon is not installed > > + if not "FALCON_SERVER" in clusterData["components"] : > + print "Falcon is not part of the installation" > + return > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > d2cc429 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 72e59aa > > Diff: https://reviews.apache.org/r/53200/diff/ > > > Testing > --- > > mvn clean test > > Added 2 new test cases to test for falcon being installed and falcon not > being installed > > > Thanks, > > Tim Thorpe > >
Re: Review Request 53200: AMBARI-18686 - Falcon user shouldn't be added to Oozie admin list if Falcon is not installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53200/#review153934 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 26, 2016, 6:27 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53200/ > --- > > (Updated Oct. 26, 2016, 6:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, and Venkat Ranganathan. > > > Bugs: AMBARI-18686 > https://issues.apache.org/jira/browse/AMBARI-18686 > > > Repository: ambari > > > Description > --- > > Falcon user shouldn't be added to Oozie admin list if Falcon is not installed > > + if not "FALCON_SERVER" in clusterData["components"] : > + print "Falcon is not part of the installation" > + return > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > d2cc429 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 72e59aa > > Diff: https://reviews.apache.org/r/53200/diff/ > > > Testing > --- > > mvn clean test > > Added 2 new test cases to test for falcon being installed and falcon not > being installed > > > Thanks, > > Tim Thorpe > >
