Re: Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

2016-10-31 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53300/#review154261
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 31, 2016, 1:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53300/
> ---
> 
> (Updated Oct. 31, 2016, 1:04 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-18747
> https://issues.apache.org/jira/browse/AMBARI-18747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari Upgrade from 2.4.1 to 2.5 is failing with a circular dependency 
> problem. This is due to the refactor of ClustersImpl which now loads the data 
> on injection exactly once. The fix is not to reference entity-users before 
> initializing our businless logic framework from JPA.
> 
> ```
> {code}Exception in thread "main" org.apache.ambari.server.AmbariException: 
> Guice provision errors:
> 
> 1) Tried proxying org.apache.ambari.server.state.ConfigHelper to support a 
> circular dependency, but it is not an interface.
>   at org.apache.ambari.server.state.ConfigHelper.class(ConfigHelper.java:61)
>   while locating org.apache.ambari.server.state.ConfigHelper
> for field at 
> org.apache.ambari.server.state.cluster.ClusterImpl.configHelper(ClusterImpl.java:162)
>   while locating 
> org.apache.ambari.server.state.cluster.ClusterImpl$$EnhancerByGuice$$7fe3f0d9
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.(ClusterImpl.java:315)
>   while locating org.apache.ambari.server.state.Cluster annotated with 
> interface com.google.inject.assistedinject.Assisted
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.loadClustersAndHosts(ClustersImpl.java:102)
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.class(ClustersImpl.java:102)
>   while locating org.apache.ambari.server.state.cluster.ClustersImpl
>   while locating org.apache.ambari.server.state.Clusters
> for parameter 0 at 
> org.apache.ambari.server.state.ConfigHelper.(ConfigHelper.java:103)
>   at org.apache.ambari.server.state.ConfigHelper.class(ConfigHelper.java:61)
>   while locating org.apache.ambari.server.state.ConfigHelper
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  c26ba15 
> 
> Diff: https://reviews.apache.org/r/53300/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

2016-10-31 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53300/#review154258
---


Ship it!




Ship It!

- Sumit Mohanty


On Oct. 31, 2016, 1:04 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53300/
> ---
> 
> (Updated Oct. 31, 2016, 1:04 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-18747
> https://issues.apache.org/jira/browse/AMBARI-18747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari Upgrade from 2.4.1 to 2.5 is failing with a circular dependency 
> problem. This is due to the refactor of ClustersImpl which now loads the data 
> on injection exactly once. The fix is not to reference entity-users before 
> initializing our businless logic framework from JPA.
> 
> ```
> {code}Exception in thread "main" org.apache.ambari.server.AmbariException: 
> Guice provision errors:
> 
> 1) Tried proxying org.apache.ambari.server.state.ConfigHelper to support a 
> circular dependency, but it is not an interface.
>   at org.apache.ambari.server.state.ConfigHelper.class(ConfigHelper.java:61)
>   while locating org.apache.ambari.server.state.ConfigHelper
> for field at 
> org.apache.ambari.server.state.cluster.ClusterImpl.configHelper(ClusterImpl.java:162)
>   while locating 
> org.apache.ambari.server.state.cluster.ClusterImpl$$EnhancerByGuice$$7fe3f0d9
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.(ClusterImpl.java:315)
>   while locating org.apache.ambari.server.state.Cluster annotated with 
> interface com.google.inject.assistedinject.Assisted
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.loadClustersAndHosts(ClustersImpl.java:102)
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.class(ClustersImpl.java:102)
>   while locating org.apache.ambari.server.state.cluster.ClustersImpl
>   while locating org.apache.ambari.server.state.Clusters
> for parameter 0 at 
> org.apache.ambari.server.state.ConfigHelper.(ConfigHelper.java:103)
>   at org.apache.ambari.server.state.ConfigHelper.class(ConfigHelper.java:61)
>   while locating org.apache.ambari.server.state.ConfigHelper
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  c26ba15 
> 
> Diff: https://reviews.apache.org/r/53300/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 53300: Ambari Upgrade Failed from 2.4.1 to 2.5

2016-10-31 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53300/#review154257
---


Ship it!




Ship It!

- Robert Levas


On Oct. 31, 2016, 9:04 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53300/
> ---
> 
> (Updated Oct. 31, 2016, 9:04 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-18747
> https://issues.apache.org/jira/browse/AMBARI-18747
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari Upgrade from 2.4.1 to 2.5 is failing with a circular dependency 
> problem. This is due to the refactor of ClustersImpl which now loads the data 
> on injection exactly once. The fix is not to reference entity-users before 
> initializing our businless logic framework from JPA.
> 
> ```
> {code}Exception in thread "main" org.apache.ambari.server.AmbariException: 
> Guice provision errors:
> 
> 1) Tried proxying org.apache.ambari.server.state.ConfigHelper to support a 
> circular dependency, but it is not an interface.
>   at org.apache.ambari.server.state.ConfigHelper.class(ConfigHelper.java:61)
>   while locating org.apache.ambari.server.state.ConfigHelper
> for field at 
> org.apache.ambari.server.state.cluster.ClusterImpl.configHelper(ClusterImpl.java:162)
>   while locating 
> org.apache.ambari.server.state.cluster.ClusterImpl$$EnhancerByGuice$$7fe3f0d9
>   at 
> org.apache.ambari.server.state.cluster.ClusterImpl.(ClusterImpl.java:315)
>   while locating org.apache.ambari.server.state.Cluster annotated with 
> interface com.google.inject.assistedinject.Assisted
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.loadClustersAndHosts(ClustersImpl.java:102)
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.class(ClustersImpl.java:102)
>   while locating org.apache.ambari.server.state.cluster.ClustersImpl
>   while locating org.apache.ambari.server.state.Clusters
> for parameter 0 at 
> org.apache.ambari.server.state.ConfigHelper.(ConfigHelper.java:103)
>   at org.apache.ambari.server.state.ConfigHelper.class(ConfigHelper.java:61)
>   while locating org.apache.ambari.server.state.ConfigHelper
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  c26ba15 
> 
> Diff: https://reviews.apache.org/r/53300/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>