Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157822
---


Ship it!




Ship It!

- Jonathan Hurley


On Dec. 2, 2016, 3:45 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Dec. 2, 2016, 3:45 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 11c8cbedbf4e3c9d3325090421dc2011a8e56668 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  75bef3027bf00117c1d423c01af936cf8f45ed1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0448b9ff6397e391ddc778f0f3f76bc37190299d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
> [INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:23.315s
> [INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
> [INFO] Final Memory: 327M/1187M
> [INFO] 
> 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Jonathan Hurley]

> On Dec. 2, 2016, 2:41 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
> >  line 335
> > 
> >
> > What if the cluster name is provided, but doesn't exist (due to a 
> > rename) - now we'd lose heartbeats then too, right?
> 
> Nahappan Somasundaram wrote:
> What if the cluster name is provided, but doesn't exist (due to a rename) 
>  
> >> Isn't that a bug by itself?
> 
> Moreover, ClustersImpl.getCluster() and ClusterImpl.getService() throw an 
> exception if the retrieved cluster or service object is null, which is a bad 
> design. Getters/setters should not throw exceptions, just return the object 
> (null or not). Because of this, there is no way of verifying if the cluster 
> or service objects are null, other than to handle the exception and ignoring 
> it (which is bad). 
> 
> Stage.java::addGenericExecutionCommand() could be a better place to put 
> this logic.
> 
> Nahappan Somasundaram wrote:
> AmbariManagementControllerImpl.java::createHostAction() works better for 
> execution commands targeted on a host. The cluster and service exist at this 
> point.

Commands come back scoped by cluster name - so a rename with running ops or 
status commands could cause a loss of heartbeat if the heartbeats can't be 
delivered. It's a yucky problem.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157803
---


On Dec. 2, 2016, 3:45 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Dec. 2, 2016, 3:45 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 11c8cbedbf4e3c9d3325090421dc2011a8e56668 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  75bef3027bf00117c1d423c01af936cf8f45ed1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  0448b9ff6397e391ddc778f0f3f76bc37190299d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Dec. 2, 2016, 12:45 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

Set the value of credential store enabled on the execution command in 
AmbariManagementController::createHostAction() where the cluster and service 
are available for the host.
Please ignore revision 7.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
11c8cbedbf4e3c9d3325090421dc2011a8e56668 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 75bef3027bf00117c1d423c01af936cf8f45ed1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 0448b9ff6397e391ddc778f0f3f76bc37190299d 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

> On Dec. 2, 2016, 11:41 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
> >  line 335
> > 
> >
> > What if the cluster name is provided, but doesn't exist (due to a 
> > rename) - now we'd lose heartbeats then too, right?
> 
> Nahappan Somasundaram wrote:
> What if the cluster name is provided, but doesn't exist (due to a rename) 
>  
> >> Isn't that a bug by itself?
> 
> Moreover, ClustersImpl.getCluster() and ClusterImpl.getService() throw an 
> exception if the retrieved cluster or service object is null, which is a bad 
> design. Getters/setters should not throw exceptions, just return the object 
> (null or not). Because of this, there is no way of verifying if the cluster 
> or service objects are null, other than to handle the exception and ignoring 
> it (which is bad). 
> 
> Stage.java::addGenericExecutionCommand() could be a better place to put 
> this logic.

AmbariManagementControllerImpl.java::createHostAction() works better for 
execution commands targeted on a host. The cluster and service exist at this 
point.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157803
---


On Dec. 2, 2016, 10:18 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Dec. 2, 2016, 10:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 11c8cbedbf4e3c9d3325090421dc2011a8e56668 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  75bef3027bf00117c1d423c01af936cf8f45ed1c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

> On Dec. 2, 2016, 11:41 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
> >  line 335
> > 
> >
> > What if the cluster name is provided, but doesn't exist (due to a 
> > rename) - now we'd lose heartbeats then too, right?

What if the cluster name is provided, but doesn't exist (due to a rename)  
>> Isn't that a bug by itself?

Moreover, ClustersImpl.getCluster() and ClusterImpl.getService() throw an 
exception if the retrieved cluster or service object is null, which is a bad 
design. Getters/setters should not throw exceptions, just return the object 
(null or not). Because of this, there is no way of verifying if the cluster or 
service objects are null, other than to handle the exception and ignoring it 
(which is bad). 

Stage.java::addGenericExecutionCommand() could be a better place to put this 
logic.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157803
---


On Dec. 2, 2016, 10:18 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Dec. 2, 2016, 10:18 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 11c8cbedbf4e3c9d3325090421dc2011a8e56668 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  75bef3027bf00117c1d423c01af936cf8f45ed1c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157803
---




ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 (line 335)


What if the cluster name is provided, but doesn't exist (due to a rename) - 
now we'd lose heartbeats then too, right?


- Jonathan Hurley


On Dec. 2, 2016, 1:18 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Dec. 2, 2016, 1:18 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 11c8cbedbf4e3c9d3325090421dc2011a8e56668 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  75bef3027bf00117c1d423c01af936cf8f45ed1c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
> [INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:23.315s
> [INFO] Finished at: Mon Nov 14 13:44:45 PST 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Dec. 2, 2016, 10:18 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

HeartBeatHandler.java::sendCommands(): Verify that cluster name and service 
name are not null before accessing the cluster and service objects.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
11c8cbedbf4e3c9d3325090421dc2011a8e56668 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 ef1ee4fb4f7480821c78f2149f438ce3fcd249de 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 75bef3027bf00117c1d423c01af936cf8f45ed1c 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.124 sec - in 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Dec. 1, 2016, 1:50 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

1. Use /var/lib/ambari-agent/cred/conf/ to store credential store 
providers instead of /etc//conf and $temp.
2. Moved CredentialShell command to ambari-agent.ini file.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
7d616117bc6294254094429920da23940138cfdf 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 29737ee5a5631b33a41323d3b059ec95fc2804bf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 75bef3027bf00117c1d423c01af936cf8f45ed1c 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.124 sec - in 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

> On Dec. 1, 2016, 11:44 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 226-227
> > 
> >
> > The default password of the keystore file from CredentialShell (well, 
> > technically, AbstractJavaKeyStoreProvider) is 'none' which isn't terribly 
> > secure.  Do we need a way to specify the correct value with Ambari?  Looks 
> > like an environment variable would be necessary.
> > 
> > In addition, I'm thinking this command should be made an 
> > ambari-agent.ini entry, such that if the command ever changes, we don't 
> > need to go hunting through code to find it.

If we changed the password, then the services will not be able to read the 
store since they use the default password.

Yes, the CredentialShell command can be moved to the ini file.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157631
---


On Nov. 30, 2016, 2:09 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 30, 2016, 2:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157631
---


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py (lines 
226 - 227)


The default password of the keystore file from CredentialShell (well, 
technically, AbstractJavaKeyStoreProvider) is 'none' which isn't terribly 
secure.  Do we need a way to specify the correct value with Ambari?  Looks like 
an environment variable would be necessary.

In addition, I'm thinking this command should be made an ambari-agent.ini 
entry, such that if the command ever changes, we don't need to go hunting 
through code to find it.


- Nate Cole


On Nov. 30, 2016, 5:09 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 30, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

> On Dec. 1, 2016, 9:04 a.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 150-154
> > 
> >
> > If you use the temp directory, don't you run the risk of the credential 
> > store being removed?

The stack scripts will move the store to a location the service prefers, but 
the default location is the location got from the conf_dir. Since we put the 
location of the store in the command JSON, the stack scripts can choose to 
leave it if the location is the conf dir otherwise move it to a location it 
prefers. If the location is not the default conf dir, the stack scripts will 
move the store to a desired location. For example, RANGER creates its own JCEKS 
store at a location specified in its config file.


> On Dec. 1, 2016, 9:04 a.m., Jonathan Hurley wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 226-227
> > 
> >
> > Why use a hadoop library here; can't you just use `keytool` directory?

Java keytool cannot store credentials, only PKI pairs. We need to use the 
hadoop CredentialShell class here.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157607
---


On Nov. 30, 2016, 2:09 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 30, 2016, 2:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157607
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py (lines 
150 - 154)


If you use the temp directory, don't you run the risk of the credential 
store being removed?



ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py (lines 
226 - 227)


Why use a hadoop library here; can't you just use `keytool` directory?


- Jonathan Hurley


On Nov. 30, 2016, 5:09 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 30, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
> [INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
> [INFO] 
> 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Nov. 30, 2016, 2:09 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

Fixed the following code reviews:
1. Use credential_lib_dir
2. Use conf_dir from conf_select to get the location of the JCEKS file
3. Check for null in EC::service before setting credentialStoreEnabled
4. Use config.get(section, key, default)


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
ebd350652309f3be2b5b6f54e28f99624607dba0 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 29737ee5a5631b33a41323d3b059ec95fc2804bf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 a25b875cecb6e6b59990e665d6464eb58a1bb352 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0, 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nate Cole]

> On Nov. 30, 2016, 10:13 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 203-204
> > 
> >
> > Would still prefer keytool over a custom class.  What did you find in 
> > your investigation why we couldn't use it?  It feels really really dirty to 
> > required a hadoop library to build the agent.
> 
> Nahappan Somasundaram wrote:
> Unfortunately Java keytool cannot be use for storing credentials, only 
> PKI pairs. We have to use the CredentialShell class for this purpose.

Bummer :(


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157408
---


On Nov. 29, 2016, 11:29 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 29, 2016, 11:29 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Nov. 29, 2016, 8:29 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

Fixed UT failure in TestHeartbeatHandler.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
ebd350652309f3be2b5b6f54e28f99624607dba0 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 29737ee5a5631b33a41323d3b059ec95fc2804bf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 a25b875cecb6e6b59990e665d6464eb58a1bb352 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.124 sec - in 
org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Nov. 29, 2016, 1:40 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

1. Use ambari-agent.ini to specify credential lib path
2. Remove hadoop dependencies from pom.xml and use all.xml to specify the 
dependencies for the tar ball.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
ebd350652309f3be2b5b6f54e28f99624607dba0 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 29737ee5a5631b33a41323d3b059ec95fc2804bf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 a25b875cecb6e6b59990e665d6464eb58a1bb352 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.124 sec - in 
org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nate Cole]

> On Nov. 29, 2016, 1:16 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 165-170
> > 
> >
> > The problem with the Orchestrator doing this is that the stack script 
> > may need the password out of the command file.  This will break that 
> > mechanism when JCEKS is enabled, no?  We can't rely on all components using 
> > JCEKS correctly for access to, say, a DB.
> 
> Nahappan Somasundaram wrote:
> If JCEKS is enabled for the service, it means the service is capable of 
> using JCEKS correctly. Moreover, the requirement is not to put clear text 
> passwords in the command file when JCEKS is enabled.

Ok.


> On Nov. 29, 2016, 1:16 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
> >  lines 335-337
> > 
> >
> > No other command types require this?
> 
> Nahappan Somasundaram wrote:
> Only execution commands require this entry. But it does not harm to put 
> it for all command types.

I'm ok with it being specific, just wanted to make sure (just in case Alerts 
needed this knowledge or something).


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157285
---


On Nov. 29, 2016, 12:07 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 29, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

> On Nov. 29, 2016, 10:16 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 165-170
> > 
> >
> > The problem with the Orchestrator doing this is that the stack script 
> > may need the password out of the command file.  This will break that 
> > mechanism when JCEKS is enabled, no?  We can't rely on all components using 
> > JCEKS correctly for access to, say, a DB.

If JCEKS is enabled for the service, it means the service is capable of using 
JCEKS correctly. Moreover, the requirement is not to put clear text passwords 
in the command file when JCEKS is enabled.


> On Nov. 29, 2016, 10:16 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java,
> >  lines 335-337
> > 
> >
> > No other command types require this?

Only execution commands require this entry. But it does not harm to put it for 
all command types.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157285
---


On Nov. 29, 2016, 9:07 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 29, 2016, 9:07 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157285
---




ambari-agent/pom.xml (lines 671 - 680)


I really don't like this dependency?  Can we invoke keytool directly 
instead of a java class?



ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py (lines 
70 - 71)


Should get this from ambari-agent.ini (and please use a 
default-if-not-found).  This issue should not be Dropped.



ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py (lines 
165 - 170)


The problem with the Orchestrator doing this is that the stack script may 
need the password out of the command file.  This will break that mechanism when 
JCEKS is enabled, no?  We can't rely on all components using JCEKS correctly 
for access to, say, a DB.



ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 (lines 335 - 337)


No other command types require this?


- Nate Cole


On Nov. 29, 2016, 12:07 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 29, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Nov. 29, 2016, 9:07 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

1. Moved affected configs getter to a separate function.
2. Do not store masked password in command JSON.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
ebd350652309f3be2b5b6f54e28f99624607dba0 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 29737ee5a5631b33a41323d3b059ec95fc2804bf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 a25b875cecb6e6b59990e665d6464eb58a1bb352 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.124 sec - in 
org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nahappan Somasundaram]

> On Nov. 29, 2016, 8:42 a.m., Nate Cole wrote:
> > What's the state of this review?

There is a small change to the patch that I'm testing out. Will publish that 
and submit it today. Thank you.


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157271
---


On Nov. 14, 2016, 3:50 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 14, 2016, 3:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> fbc150946a1765d75054b11303e08fcf035c8069 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
> [INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:23.315s
> [INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
> [INFO] Final Memory: 327M/1187M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* 
> **
> 
> ---
>  T E S T S
> 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157271
---



What's the state of this review?

- Nate Cole


On Nov. 14, 2016, 6:50 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 14, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> fbc150946a1765d75054b11303e08fcf035c8069 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
> [INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:23.315s
> [INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
> [INFO] Final Memory: 327M/1187M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* 
> **
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running 

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review156781
---


Ship it!




Ship It!

- Nate Cole


On Nov. 14, 2016, 6:50 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 14, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> fbc150946a1765d75054b11303e08fcf035c8069 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
> [INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:23.315s
> [INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
> [INFO] Final Memory: 327M/1187M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* 
> **
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running