Re: Review Request 54140: Perf: Fix deploy-gce-perf-cluster.py to deploy separate server onto own cluster with different settings for more cores and MySQL DB

2016-11-28 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54140/#review157149
---


Ship it!




Ship It!

- Sid Wagle


On Nov. 28, 2016, 9:55 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54140/
> ---
> 
> (Updated Nov. 28, 2016, 9:55 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19003
> https://issues.apache.org/jira/browse/AMBARI-19003
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now, deploy-gce-perf-cluster.py puts Ambari Server on the same 4 core 
> VM where it puts 50 agents. Instead, we need to create a separate 16-core VM 
> for the server without any agents.
> 
> Next, Ambari Server should be installed with MySQL database instead since it 
> has more configuration options that the default postgres.
> 
> Further, the sorting of the VMs is not numeric since "perf-9" comes after 
> "perf-42". The incorrect sorting means that VM #i isn't getting the agents 
> starting with number (i-1)*50+1
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 95ed98f 
> 
> Diff: https://reviews.apache.org/r/54140/diff/
> 
> 
> Testing
> ---
> 
> Verified manually on Google Cloud
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>



Re: Review Request 54140: Perf: Fix deploy-gce-perf-cluster.py to deploy separate server onto own cluster with different settings for more cores and MySQL DB

2016-11-28 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54140/#review157147
---




contrib/utils/perf/deploy-gce-perf-cluster.py (line 215)


Move this to its own function so easier to comment out when testing.



contrib/utils/perf/deploy-gce-perf-cluster.py (line 220)


This now returns a tuple



contrib/utils/perf/deploy-gce-perf-cluster.py (line 283)


The server is now its own cluster with xxlarge (16 cores)



contrib/utils/perf/deploy-gce-perf-cluster.py (line 342)


Installed MySQL DB instead of default postgres



contrib/utils/perf/deploy-gce-perf-cluster.py (line 480)


Due to the way GCE creates hosts, if we just sort alphabetically, then 
perf-9 comes before perf-42, so it ends up putting the wrong agent #s, which is 
makes it harder to do the math to find which VM has which agent #s.


- Alejandro Fernandez


On Nov. 28, 2016, 9:55 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54140/
> ---
> 
> (Updated Nov. 28, 2016, 9:55 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19003
> https://issues.apache.org/jira/browse/AMBARI-19003
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now, deploy-gce-perf-cluster.py puts Ambari Server on the same 4 core 
> VM where it puts 50 agents. Instead, we need to create a separate 16-core VM 
> for the server without any agents.
> 
> Next, Ambari Server should be installed with MySQL database instead since it 
> has more configuration options that the default postgres.
> 
> Further, the sorting of the VMs is not numeric since "perf-9" comes after 
> "perf-42". The incorrect sorting means that VM #i isn't getting the agents 
> starting with number (i-1)*50+1
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 95ed98f 
> 
> Diff: https://reviews.apache.org/r/54140/diff/
> 
> 
> Testing
> ---
> 
> Verified manually on Google Cloud
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>