Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-24 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162796
---


Ship it!




Ship It!

- Andrew Onischuk


On Jan. 24, 2017, 10:58 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Jan. 24, 2017, 10:58 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-24 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/
---

(Updated Січ. 24, 2017, 10:58 до полудня)


Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19684
https://issues.apache.org/jira/browse/AMBARI-19684


Repository: ambari


Description
---

Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
{code}
ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
because previous action finished with non-zero exit code (1)
ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
closed.

STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
family is debianstretch/sid
Traceback (most recent call last):
  File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 

main()
  File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in main
raise Exception("Local OS is not compatible with cluster primary OS family. 
Please perform manual bootstrap on this host.")
Exception: Local OS is not compatible with cluster primary OS family. Please 
perform manual bootstrap on this host.
{code}


Diffs (updated)
-

  ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
  ambari-server/src/main/assemblies/server.xml 5055d46 
  ambari-server/src/main/python/bootstrap.py e576fc8 
  ambari-server/src/main/python/os_check_type.py f890504 
  ambari-server/src/test/python/TestBootstrap.py 8356f91 

Diff: https://reviews.apache.org/r/55859/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-24 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/
---

(Updated Січ. 24, 2017, 10:08 до полудня)


Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19684
https://issues.apache.org/jira/browse/AMBARI-19684


Repository: ambari


Description
---

Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
{code}
ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
because previous action finished with non-zero exit code (1)
ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
closed.

STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
family is debianstretch/sid
Traceback (most recent call last):
  File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 

main()
  File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in main
raise Exception("Local OS is not compatible with cluster primary OS family. 
Please perform manual bootstrap on this host.")
Exception: Local OS is not compatible with cluster primary OS family. Please 
perform manual bootstrap on this host.
{code}


Diffs (updated)
-

  ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
  ambari-server/src/main/assemblies/server.xml 5055d46 
  ambari-server/src/main/python/bootstrap.py e576fc8 
  ambari-server/src/main/python/os_check_type.py f890504 
  ambari-server/src/test/python/TestBootstrap.py 8356f91 

Diff: https://reviews.apache.org/r/55859/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-24 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162793
---




ambari-server/src/main/assemblies/server.xml (line 245)


This might be a problem on non-root can you please check?


- Andrew Onischuk


On Jan. 24, 2017, 10:02 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Jan. 24, 2017, 10:02 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-24 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/
---

(Updated Січ. 24, 2017, 10:02 до полудня)


Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19684
https://issues.apache.org/jira/browse/AMBARI-19684


Repository: ambari


Description
---

Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
{code}
ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
because previous action finished with non-zero exit code (1)
ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
closed.

STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
family is debianstretch/sid
Traceback (most recent call last):
  File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 

main()
  File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in main
raise Exception("Local OS is not compatible with cluster primary OS family. 
Please perform manual bootstrap on this host.")
Exception: Local OS is not compatible with cluster primary OS family. Please 
perform manual bootstrap on this host.
{code}


Diffs (updated)
-

  ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
  ambari-server/src/main/assemblies/server.xml 5055d46 
  ambari-server/src/main/python/bootstrap.py e576fc8 
  ambari-server/src/main/python/os_check_type.py f890504 
  ambari-server/src/test/python/TestBootstrap.py 8356f91 

Diff: https://reviews.apache.org/r/55859/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-23 Thread Vitalyi Brodetskyi 


> On Січ. 23, 2017, 10:26 після полудня, Alejandro Fernandez wrote:
> > ambari-server/conf/unix/create-python-wrap.sh, line 35
> > 
> >
> > Why is this all of a sudden failing now?
> > Weren't we testing on Ubuntu 16 before?

The problem is that ubuntu16 which we are testing has three versions of python 
(3.5, 2.7.5 and 2.7.12). Python 3.5 is not actual for us. If you will call 
python byt simple "python" command you will get to python with version 2.7.5, 
this is not patched python for ubuntu16, looks like it was installed 
additinally. But if you will call /usr/bin/python you will get correct python 
version with correct behaviour of linux_distribution method. When we are trying 
to get os type from python we are not using python wrapper. So when we are 
creating python wrapper and then call python code which return os type 
everything works fine. Because python wrapper check version of python and 
creates link to /usr/bin/python.


- Vitalyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162718
---


On Січ. 23, 2017, 10:16 після полудня, Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Січ. 23, 2017, 10:16 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-23 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162720
---




ambari-server/conf/unix/create-python-wrap.sh (line 1)


No shebang line? Ommitted on purpose?



ambari-server/conf/unix/create-python-wrap.sh (line 23)


Wy the comma?



ambari-server/conf/unix/create-python-wrap.sh (line 26)


Should there be a try ... catch in to make it more solid?


- Sid Wagle


On Jan. 23, 2017, 10:16 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Jan. 23, 2017, 10:16 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55859: Agent registration fails as local OS is not compatible with primary OS family

2017-01-23 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55859/#review162718
---




ambari-server/conf/unix/create-python-wrap.sh (line 35)


Why is this all of a sudden failing now?
Weren't we testing on Ubuntu 16 before?


- Alejandro Fernandez


On Jan. 23, 2017, 10:16 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55859/
> ---
> 
> (Updated Jan. 23, 2017, 10:16 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19684
> https://issues.apache.org/jira/browse/AMBARI-19684
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent registration/Confirm hosts step on Ubuntu16 fails with the below error
> {code}
> ERROR: Bootstrap of host ctr-e115-1484872830066-0022-01-05.hwx.site fails 
> because previous action finished with non-zero exit code (1)
> ERROR MESSAGE: Connection to ctr-e115-1484872830066-0022-01-05.hwx.site 
> closed.
> 
> STDOUT: Cluster primary/cluster OS family is ubuntu16 and local/current OS 
> family is debianstretch/sid
> Traceback (most recent call last):
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 44, in 
> 
> main()
>   File "/var/lib/ambari-agent/tmp/os_check_type1484891600.py", line 40, in 
> main
> raise Exception("Local OS is not compatible with cluster primary OS 
> family. Please perform manual bootstrap on this host.")
> Exception: Local OS is not compatible with cluster primary OS family. Please 
> perform manual bootstrap on this host.
> {code}
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/create-python-wrap.sh PRE-CREATION 
>   ambari-server/src/main/assemblies/server.xml 5055d46 
>   ambari-server/src/main/python/bootstrap.py e576fc8 
>   ambari-server/src/main/python/os_check_type.py f890504 
>   ambari-server/src/test/python/TestBootstrap.py 8356f91 
> 
> Diff: https://reviews.apache.org/r/55859/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>