Re: Review Request 56871: AMBARI-20090.On submit of bundle, if any coordinator path contains variables, user should be notified about custom variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56871/#review166139 --- Ship it! Ship It! - Gaurav Nagar On Feb. 21, 2017, 9:56 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56871/ > --- > > (Updated Feb. 21, 2017, 9:56 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20090 > https://issues.apache.org/jira/browse/AMBARI-20090 > > > Repository: ambari > > > Description > --- > > Fixed by showing a warning message on the job submit modal if the underlying > coordinator path or workflow path of bundle a contains variables. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 9201d5c > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c7da381 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > e30750f > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 749a173 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs > 2ac56e8 > > Diff: https://reviews.apache.org/r/56871/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
Re: Review Request 56871: AMBARI-20090.On submit of bundle, if any coordinator path contains variables, user should be notified about custom variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56871/#review166138 --- Ship it! Ship It! - belliraj hb On Feb. 21, 2017, 9:56 a.m., Padma Priya N wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56871/ > --- > > (Updated Feb. 21, 2017, 9:56 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20090 > https://issues.apache.org/jira/browse/AMBARI-20090 > > > Repository: ambari > > > Description > --- > > Fixed by showing a warning message on the job submit modal if the underlying > coordinator path or workflow path of bundle a contains variables. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 9201d5c > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > c7da381 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > e30750f > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 749a173 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs > 2ac56e8 > > Diff: https://reviews.apache.org/r/56871/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Padma Priya N > >
