Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

2017-02-24 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/#review166713
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 24, 2017, 2:47 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57035/
> ---
> 
> (Updated Feb. 24, 2017, 2:47 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20170
> https://issues.apache.org/jira/browse/AMBARI-20170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excluded the aws bundled jar from transitive dependency of hadoop-aws and 
> included explicitly only in files view
> 
> 
> Diffs
> -
> 
>   contrib/views/files/pom.xml 410ed1e 
>   contrib/views/pom.xml dda956f 
>   contrib/views/utils/pom.xml 324fb1a 
> 
> Diff: https://reviews.apache.org/r/57035/diff/
> 
> 
> Testing
> ---
> 
> created build and tested the files sizes. The overall decrease in size would 
> be 300 MB.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

2017-02-24 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/
---

(Updated Feb. 24, 2017, 2:47 p.m.)


Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

changed jar from dependencyManagement to dependencies.


Bugs: AMBARI-20170
https://issues.apache.org/jira/browse/AMBARI-20170


Repository: ambari


Description
---

excluded the aws bundled jar from transitive dependency of hadoop-aws and 
included explicitly only in files view


Diffs (updated)
-

  contrib/views/files/pom.xml 410ed1e 
  contrib/views/pom.xml dda956f 
  contrib/views/utils/pom.xml 324fb1a 

Diff: https://reviews.apache.org/r/57035/diff/


Testing
---

created build and tested the files sizes. The overall decrease in size would be 
300 MB.


Thanks,

Nitiraj Rathore

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

2017-02-24 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/#review166696
---


Fix it, then Ship it!





contrib/views/files/pom.xml (line 30)


`` is useful only if there are child POMs inheriting 
from this one.  In other cases it's better to merge with `` below.


- Attila Doroszlai


On Feb. 24, 2017, 1:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57035/
> ---
> 
> (Updated Feb. 24, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20170
> https://issues.apache.org/jira/browse/AMBARI-20170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excluded the aws bundled jar from transitive dependency of hadoop-aws and 
> included explicitly only in files view
> 
> 
> Diffs
> -
> 
>   contrib/views/files/pom.xml 410ed1e 
>   contrib/views/pom.xml dda956f 
>   contrib/views/utils/pom.xml 324fb1a 
> 
> Diff: https://reviews.apache.org/r/57035/diff/
> 
> 
> Testing
> ---
> 
> created build and tested the files sizes. The overall decrease in size would 
> be 300 MB.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57035: ambari-server package size increased from 645MB to 1GB

2017-02-24 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57035/#review166687
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 24, 2017, 12:06 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57035/
> ---
> 
> (Updated Feb. 24, 2017, 12:06 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20170
> https://issues.apache.org/jira/browse/AMBARI-20170
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excluded the aws bundled jar from transitive dependency of hadoop-aws and 
> included explicitly only in files view
> 
> 
> Diffs
> -
> 
>   contrib/views/files/pom.xml 410ed1e 
>   contrib/views/pom.xml dda956f 
>   contrib/views/utils/pom.xml 324fb1a 
> 
> Diff: https://reviews.apache.org/r/57035/diff/
> 
> 
> Testing
> ---
> 
> created build and tested the files sizes. The overall decrease in size would 
> be 300 MB.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>