Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/#review167136 --- Ship it! Ship It! - Jaimin Jetly On Feb. 28, 2017, 7:44 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57062/ > --- > > (Updated Feb. 28, 2017, 7:44 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20194 > https://issues.apache.org/jira/browse/AMBARI-20194 > > > Repository: ambari > > > Description > --- > > Enabled manage alert notification option based on user's privileges > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > f37876f > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > 9b5442d > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5d81281 > > Diff: https://reviews.apache.org/r/57062/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/ --- (Updated Feb. 28, 2017, 7:44 p.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- Add as patch instead of extra file Bugs: AMBARI-20194 https://issues.apache.org/jira/browse/AMBARI-20194 Repository: ambari Description --- Enabled manage alert notification option based on user's privileges Diffs (updated) - ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js f37876f ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs 9b5442d ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 5d81281 Diff: https://reviews.apache.org/r/57062/diff/ Testing --- Manually tested on live cluster. All unit tests passed. Thanks, Richard Zang
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/ --- (Updated Feb. 28, 2017, 3:55 a.m.) Review request for Ambari, Jaimin Jetly and Yusaku Sako. Changes --- A follow up fix to make sure UI shows correctly after logout and login with user with different role. Remove old 'isOperator' based restrictions on modal UI items since we are already enforcing RBAC on the pull down action list. Bugs: AMBARI-20194 https://issues.apache.org/jira/browse/AMBARI-20194 Repository: ambari Description --- Enabled manage alert notification option based on user's privileges Diffs - ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js a397b7b Diff: https://reviews.apache.org/r/57062/diff/ Testing --- Manually tested on live cluster. All unit tests passed. File Attachments (updated) AMBARI-20194-fix1.patch https://reviews.apache.org/media/uploaded/files/2017/02/28/be236f3c-50bd-4f66-a41b-895c0dbba006__AMBARI-20194-fix1.patch Thanks, Richard Zang
Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57062/#review166985 --- Ship it! Ship It! - Jaimin Jetly On Feb. 25, 2017, 4:34 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57062/ > --- > > (Updated Feb. 25, 2017, 4:34 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-20194 > https://issues.apache.org/jira/browse/AMBARI-20194 > > > Repository: ambari > > > Description > --- > > Enabled manage alert notification option based on user's privileges > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > a397b7b > > Diff: https://reviews.apache.org/r/57062/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > > Thanks, > > Richard Zang > >
