Re: Review Request 57096: Remove HDP version check in KAFKA service

[Alejandro Fernandez]

> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 25
> > 
> >
> > This is also needed in HDP 3.0
> 
> Madhuvanthi Radhakrishnan wrote:
> I have added this change in 
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  and attached a trunk patch to the apache jira.
> 
> Jayush Luniya wrote:
> @Alejandro, 
> For HDP-3.0 what is going to be the min HDP version from which we will be 
> upgrading? We should look at all the places where we have stack-version 
> specific logic and do a code cleanup to remove these if-else blocks.

@Jayush, that's yet to be determined. For now, we just need to keep the code 
changes in sync.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166926
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 25)


Can you add this to 
ambari/ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.jsonas
 well?


- Jayush Luniya


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166929
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 25
> > 
> >
> > This is also needed in HDP 3.0
> 
> Madhuvanthi Radhakrishnan wrote:
> I have added this change in 
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  and attached a trunk patch to the apache jira.

@Alejandro, 
For HDP-3.0 what is going to be the min HDP version from which we will be 
upgrading? We should look at all the places where we have stack-version 
specific logic and do a code cleanup to remove these if-else blocks.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166915
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Madhuvanthi Radhakrishnan]

> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 25
> > 
> >
> > This is also needed in HDP 3.0

I have added this change in 
ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
and attached a trunk patch to the apache jira.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---


On Feb. 27, 2017, 6:34 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 25)


This is also needed in HDP 3.0


- Alejandro Fernandez


On Feb. 27, 2017, 6:34 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166904
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
 (line 25)


Can we remove the import too?


- Sumit Mohanty


On Feb. 27, 2017, 6:34 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>