Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-31 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170685
---


Ship it!




Ship It!

- Sebastian Toader


On March 30, 2017, 9:04 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 30, 2017, 9:04 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  8cb1f0c 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py
>  70c81e7 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/params.py
>  3533b35 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/4/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-30 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170635
---


Ship it!




Ship It!

- Robert Levas


On March 30, 2017, 3:04 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 30, 2017, 3:04 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  8cb1f0c 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py
>  70c81e7 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/params.py
>  3533b35 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/4/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-30 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/
---

(Updated March 30, 2017, 7:04 p.m.)


Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Changes
---

Review comments.


Bugs: AMBARI-20586
https://issues.apache.org/jira/browse/AMBARI-20586


Repository: ambari


Description
---

Added master_kdc to kerberos env and the krb5 config template.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 25f2001 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 965ee13 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 8cb1f0c 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
 57f062a 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
 7016437 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py
 70c81e7 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/params.py
 3533b35 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 fa2082b 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
6727b2f 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 


Diff: https://reviews.apache.org/r/57959/diff/4/

Changes: https://reviews.apache.org/r/57959/diff/3-4/


Testing
---

- Tested manually
- Updated Java unit tests
- All ambari-server unit tests pass.


Thanks,

Balázs Bence Sári

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-30 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/
---

(Updated March 30, 2017, 3:25 p.m.)


Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Changes
---

Removed duplicate template definition


Bugs: AMBARI-20586
https://issues.apache.org/jira/browse/AMBARI-20586


Repository: ambari


Description
---

Added master_kdc to kerberos env and the krb5 config template.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 25f2001 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 965ee13 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 8cb1f0c 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
 57f062a 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
 7016437 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 fa2082b 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
6727b2f 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 


Diff: https://reviews.apache.org/r/57959/diff/3/

Changes: https://reviews.apache.org/r/57959/diff/2-3/


Testing
---

- Tested manually
- Updated Java unit tests
- All ambari-server unit tests pass.


Thanks,

Balázs Bence Sári

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Robert Levas 


> On March 27, 2017, 11:18 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 60-63 (original), 60-63 (patched)
> > 
> >
> > This looks to be a duplication of the j2 file. Keep only just the j2 
> > file and reference it from here.
> 
> Balázs Bence Sári wrote:
> I tested this out:
> - In order to the reference the .j2 file from the xml, I need to move it 
> from the *package/templates* folder to the *properties* folder.
> - There is a direct reference to the template from *kerberos-common.py*. 
> If I move the script to the *properties* folder, that reference will be 
> broken. Changing the path in Template constructor to 
> *Template('../../properties/krb5_conf.j2')* will not fix it as the file will 
> not be pushed to the agent.
> 
> There are two ways I can deal with this duplication:
> 1. Keep the .j2 file in both *properties* and *package/templates* (still 
> duplication, but better than pasting it to the xml)
> 2. Move the .j2 file to *properties* and only use *InlineTemplate* in 
> *kerberos-common.py* (remove the if-else construct around line 119). I tested 
> blueprint istallation and *InlineTemplate* is used i that case too, don't 
> know when the else case is triggered.
> 
> Balázs Bence Sári wrote:
> ... I mean "don't know when the **if** case is triggered"

+1 for #2 - Move the .j2 file to properties and only use InlineTemplate in 
kerberos-common.py (remove the if-else construct around line 119.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---


On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Balázs Bence Sári 


> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 60-63 (original), 60-63 (patched)
> > 
> >
> > This looks to be a duplication of the j2 file. Keep only just the j2 
> > file and reference it from here.
> 
> Balázs Bence Sári wrote:
> I tested this out:
> - In order to the reference the .j2 file from the xml, I need to move it 
> from the *package/templates* folder to the *properties* folder.
> - There is a direct reference to the template from *kerberos-common.py*. 
> If I move the script to the *properties* folder, that reference will be 
> broken. Changing the path in Template constructor to 
> *Template('../../properties/krb5_conf.j2')* will not fix it as the file will 
> not be pushed to the agent.
> 
> There are two ways I can deal with this duplication:
> 1. Keep the .j2 file in both *properties* and *package/templates* (still 
> duplication, but better than pasting it to the xml)
> 2. Move the .j2 file to *properties* and only use *InlineTemplate* in 
> *kerberos-common.py* (remove the if-else construct around line 119). I tested 
> blueprint istallation and *InlineTemplate* is used i that case too, don't 
> know when the else case is triggered.

... I mean "don't know when the **if** case is triggered"


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---


On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 2:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Balázs Bence Sári 


> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 60-63 (original), 60-63 (patched)
> > 
> >
> > This looks to be a duplication of the j2 file. Keep only just the j2 
> > file and reference it from here.

I tested this out:
- In order to the reference the .j2 file from the xml, I need to move it from 
the *package/templates* folder to the *properties* folder.
- There is a direct reference to the template from *kerberos-common.py*. If I 
move the script to the *properties* folder, that reference will be broken. 
Changing the path in Template constructor to 
*Template('../../properties/krb5_conf.j2')* will not fix it as the file will 
not be pushed to the agent.

There are two ways I can deal with this duplication:
1. Keep the .j2 file in both *properties* and *package/templates* (still 
duplication, but better than pasting it to the xml)
2. Move the .j2 file to *properties* and only use *InlineTemplate* in 
*kerberos-common.py* (remove the if-else construct around line 119). I tested 
blueprint istallation and *InlineTemplate* is used i that case too, don't know 
when the else case is triggered.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---


On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 2:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-28 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170281
---


Ship it!




Ship It!

- Sebastian Toader


On March 27, 2017, 4:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 4:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-28 Thread Balázs Bence Sári 


> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Line 91 (original), 94 (patched)
> > 
> >
> > I'm not familiar with master - slave KDC setup but if I understand 
> > correctly 
> > ```https://web.mit.edu/kerberos/krb5-1.13/doc/admin/install_kdc.html#start-kdc-daemons```
> >  than the admin server has to be collocated (or not?) with master KDC 
> > server.
> > 
> > Can you perform a test scenario to verify this?

Collocation depends on how the KDC database is stored:

"kadmind starts the Kerberos administration server. kadmind typically runs on 
the master Kerberos server, which stores the KDC database. If the KDC database 
uses the LDAP module, the administration server and the KDC server need not run 
on the same machine."

https://web.mit.edu/kerberos/krb5-1.13/doc/admin/admin_commands/kadmind.html#kadmind-8


> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 93-95 (original), 96-101 (patched)
> > 
> >
> > shouldn't this be an "else if"
> 
> Robert Levas wrote:
> I don't think so.  This looks correct to me.   It appears that the code 
> is adding an additional kdc_host for the master_kdc if it was not manually 
> added to the kdc_hosts list.

Yes, this was the intention


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---


On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 2:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas 


> On March 27, 2017, 11:49 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 97 (patched)
> > 
> >
> > The `master_kdc` value can be a comma-delimited list, so this list will 
> > need to be split else you might wind up with 
> > 
> > ```
> > kdc_host = host1.example.com, host2.example.com,host3.example.com
> > ```

I think this is incorrect and there may only be a single master KDC allowed.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170186
---


On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170186
---




ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
Lines 97 (patched)


The `master_kdc` value can be a comma-delimited list, so this list will 
need to be split else you might wind up with 

```
kdc_host = host1.example.com, host2.example.com,host3.example.com
```


- Robert Levas


On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas 


> On March 27, 2017, 11:18 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
> > Lines 93-95 (original), 96-101 (patched)
> > 
> >
> > shouldn't this be an "else if"

I don't think so.  This looks correct to me.   It appears that the code is 
adding an additional kdc_host for the master_kdc if it was not manually added 
to the kdc_hosts list.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---


On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170182
---




ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
Lines 162 (patched)


I think it's not necessary to set this on a cluster during upgrade, since 
anyway it's optional.


- Sandor Magyari


On March 27, 2017, 2:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 2:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170180
---




ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
Lines 60-63 (original), 60-63 (patched)


This looks to be a duplication of the j2 file. Keep only just the j2 file 
and reference it from here.



ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
Line 91 (original), 94 (patched)


I'm not familiar with master - slave KDC setup but if I understand 
correctly 
```https://web.mit.edu/kerberos/krb5-1.13/doc/admin/install_kdc.html#start-kdc-daemons```
 than the admin server has to be collocated (or not?) with master KDC server.

Can you perform a test scenario to verify this?



ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
Lines 93-95 (original), 96-101 (patched)


shouldn't this be an "else if"


- Sebastian Toader


On March 27, 2017, 4:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 4:54 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/#review170177
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
Lines 152-153 (patched)


Multiple master KDC hosts may be listed as comma-separated values... the 
documention should indicate this.


- Robert Levas


On March 27, 2017, 10:54 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57959/
> ---
> 
> (Updated March 27, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20586
> https://issues.apache.org/jira/browse/AMBARI-20586
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added master_kdc to kerberos env and the krb5 config template.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  25f2001 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  965ee13 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  57f062a 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  7016437 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
>  c692b92 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
>  0191953 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  fa2082b 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 6727b2f 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 
> 
> 
> Diff: https://reviews.apache.org/r/57959/diff/2/
> 
> 
> Testing
> ---
> 
> - Tested manually
> - Updated Java unit tests
> - All ambari-server unit tests pass.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-27 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57959/
---

(Updated March 27, 2017, 2:54 p.m.)


Review request for Ambari, Attila Magyar, Laszlo Puskas, Robert Levas, Sandor 
Magyari, and Sebastian Toader.


Changes
---

small unit test typo fix


Bugs: AMBARI-20586
https://issues.apache.org/jira/browse/AMBARI-20586


Repository: ambari


Description
---

Added master_kdc to kerberos env and the krb5 config template.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 25f2001 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 965ee13 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
 57f062a 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
 7016437 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/krb5-conf.xml
 c692b92 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/templates/krb5_conf.j2
 0191953 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 fa2082b 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
6727b2f 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 17d9f88 


Diff: https://reviews.apache.org/r/57959/diff/2/

Changes: https://reviews.apache.org/r/57959/diff/1-2/


Testing
---

- Tested manually
- Updated Java unit tests
- All ambari-server unit tests pass.


Thanks,

Balázs Bence Sári