Re: Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies

2017-08-23 Thread Jayush Luniya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61813/#review183622
---



This dependency was added in 
https://issues.apache.org/jira/browse/AMBARI-14202. Removing this dependency 
will cause issues when WE is enabled. We need to improve our overall restart 
required logic but that is a larger improvement to be done. Unfortunatel, for 
now though we will need to keep these dependencies.

- Jayush Luniya


On Aug. 22, 2017, 1:42 p.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61813/
> ---
> 
> (Updated Aug. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Juanjo  Marron, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21779
> https://issues.apache.org/jira/browse/AMBARI-21779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm Service should not include the following ""
> 
> ranger-ugsync-site
> ranger-admin-site
> 
> Else making any configuration change in Ranger service (for example: "Ranger 
> User Info") will ask Storm service to be restarted.
> 
> Looks like as part of JIRA "AMBARI-16250"  this dependency was added in bulk 
> by mistake.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> 0c62c1a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/metainfo.xml 
> 1bc23e4 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> 084eac2 
>   ambari-server/src/main/resources/common-services/STORM/1.1.0/metainfo.xml 
> 94f5ca3 
> 
> 
> Diff: https://reviews.apache.org/r/61813/diff/1/
> 
> 
> Testing
> ---
> 
> .
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>



Re: Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies

2017-08-22 Thread Juanjo Marron

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61813/#review183494
---


Ship it!




Ship It!

- Juanjo  Marron


On Aug. 22, 2017, 1:42 p.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61813/
> ---
> 
> (Updated Aug. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Juanjo  Marron, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21779
> https://issues.apache.org/jira/browse/AMBARI-21779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm Service should not include the following ""
> 
> ranger-ugsync-site
> ranger-admin-site
> 
> Else making any configuration change in Ranger service (for example: "Ranger 
> User Info") will ask Storm service to be restarted.
> 
> Looks like as part of JIRA "AMBARI-16250"  this dependency was added in bulk 
> by mistake.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> 0c62c1a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/metainfo.xml 
> 1bc23e4 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> 084eac2 
>   ambari-server/src/main/resources/common-services/STORM/1.1.0/metainfo.xml 
> 94f5ca3 
> 
> 
> Diff: https://reviews.apache.org/r/61813/diff/1/
> 
> 
> Testing
> ---
> 
> .
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>



Re: Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies

2017-08-22 Thread Tim Thorpe

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61813/#review183480
---


Ship it!




Ship It!

- Tim Thorpe


On Aug. 22, 2017, 1:42 p.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61813/
> ---
> 
> (Updated Aug. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Juanjo  Marron, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21779
> https://issues.apache.org/jira/browse/AMBARI-21779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm Service should not include the following ""
> 
> ranger-ugsync-site
> ranger-admin-site
> 
> Else making any configuration change in Ranger service (for example: "Ranger 
> User Info") will ask Storm service to be restarted.
> 
> Looks like as part of JIRA "AMBARI-16250"  this dependency was added in bulk 
> by mistake.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> 0c62c1a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/metainfo.xml 
> 1bc23e4 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> 084eac2 
>   ambari-server/src/main/resources/common-services/STORM/1.1.0/metainfo.xml 
> 94f5ca3 
> 
> 
> Diff: https://reviews.apache.org/r/61813/diff/1/
> 
> 
> Testing
> ---
> 
> .
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>