Re: Review Request 61884: Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS mode

2017-08-24 Thread DIPAYAN BHOWMICK

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61884/#review183727
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Aug. 24, 2017, 10:38 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61884/
> ---
> 
> (Updated Aug. 24, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21802
> https://issues.apache.org/jira/browse/AMBARI-21802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS 
> mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  742f5bedca 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
>  25ea3d04ab 
> 
> 
> Diff: https://reviews.apache.org/r/61884/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61884: Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS mode

2017-08-24 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61884/#review183728
---


Ship it!




Ship It!

- Gaurav Nagar


On Aug. 24, 2017, 10:38 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61884/
> ---
> 
> (Updated Aug. 24, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21802
> https://issues.apache.org/jira/browse/AMBARI-21802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS 
> mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  742f5bedca 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
>  25ea3d04ab 
> 
> 
> Diff: https://reviews.apache.org/r/61884/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>



Re: Review Request 61884: Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS mode

2017-08-24 Thread venkat sairam

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61884/#review183726
---


Ship it!




Ship It!

- venkat sairam


On Aug. 24, 2017, 10:38 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61884/
> ---
> 
> (Updated Aug. 24, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21802
> https://issues.apache.org/jira/browse/AMBARI-21802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin's secure cookie should only be set when zeppelin is running in HTTPS 
> mode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  742f5bedca 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-shiro-ini.xml
>  25ea3d04ab 
> 
> 
> Diff: https://reviews.apache.org/r/61884/diff/1/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>