Re: Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

[Gautam Borad]

> On March 16, 2016, 12:24 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py,
> >  lines 128-131
> > 
> >
> > Do you need to:
> > 
> > - Check for the existance of these links first before removing/creating 
> > them?
> > - Check a specific version of the stack that you are upgrading from/to?

1) No, if it already exists, we delete it. The Link() does not throw error, if 
it does not exists in the first place.
2) /usr/bin/ranger-admin is used from stack 2.3 onwards (Also, please note from 
2.3 stack onwards, Ranger uses setup_ranger_xml.py)


- Gautam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44886/#review123860
---


On March 16, 2016, 9:15 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44886/
> ---
> 
> (Updated March 16, 2016, 9:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan 
> Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-15437
> https://issues.apache.org/jira/browse/AMBARI-15437
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Ambari stacks for Ranger: 
> We need to take care of handling symlinks to point to current version of HDP, 
> to avoid confusion.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  6394f51 
> 
> Diff: https://reviews.apache.org/r/44886/diff/
> 
> 
> Testing
> ---
> 
> Tested EU and RU with Ranger installed.
> Testing steps:
> 1) Installed Ranger with HDP-2.2.x
> 2) Upgrade Ranger to HDP-2.3.x
> 3) Again Upgrade to HDP-2.4.x
> 
> Ran 277 tests in 7.293s
> 
> OK
> --
> Total run:941
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44886/#review123860
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 (lines 126 - 129)


Do you need to:

- Check for the existance of these links first before removing/creating 
them?
- Check a specific version of the stack that you are upgrading from/to?


- Jonathan Hurley


On March 16, 2016, 5:15 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44886/
> ---
> 
> (Updated March 16, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan 
> Hurley, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-15437
> https://issues.apache.org/jira/browse/AMBARI-15437
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For Ambari stacks for Ranger: 
> We need to take care of handling symlinks to point to current version of HDP, 
> to avoid confusion.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  6394f51 
> 
> Diff: https://reviews.apache.org/r/44886/diff/
> 
> 
> Testing
> ---
> 
> Tested EU and RU with Ranger installed.
> Testing steps:
> 1) Installed Ranger with HDP-2.2.x
> 2) Upgrade Ranger to HDP-2.3.x
> 3) Again Upgrade to HDP-2.4.x
> 
> Ran 277 tests in 7.293s
> 
> OK
> --
> Total run:941
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 44886: AMBARI-15437 : Handle changing symlinks of ranger admin binaries for upgrade scenarios

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44886/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, 
Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: AMBARI-15437
https://issues.apache.org/jira/browse/AMBARI-15437


Repository: ambari


Description
---

For Ambari stacks for Ranger: 
We need to take care of handling symlinks to point to current version of HDP, 
to avoid confusion.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 6394f51 

Diff: https://reviews.apache.org/r/44886/diff/


Testing
---

Tested EU and RU with Ranger installed.
Testing steps:
1) Installed Ranger with HDP-2.2.x
2) Upgrade Ranger to HDP-2.3.x
3) Again Upgrade to HDP-2.4.x

Ran 277 tests in 7.293s

OK
--
Total run:941
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad