---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47619/#review134111
---
Ship it!
Ship It!
- Matt
On May 19, 2016, 4:27 p.m., Juanjo Marron wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47619/
> ---
>
> (Updated May 19, 2016, 4:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
>
>
> Bugs: AMBARI-16671
> https://issues.apache.org/jira/browse/AMBARI-16671
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Python code at at common-services level used generic imports form
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be
> more specific, such as:
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service
> scripts in common-services
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py
> f2c3c18
>
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py
> b6fc153
>
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
> 11a85e1
>
> Diff: https://reviews.apache.org/r/47619/diff/
>
>
> Testing
> ---
>
> Pass mvn clean test -DskipSurefireTests
> MAHOUT fresh installation and service check
>
> Hadoop QA added a comment - 2 hours ago
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12804463/AMBARI-16671.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results:
> https://builds.apache.org/job/Ambari-trunk-test-patch/6906//testReport/
> Console output:
> https://builds.apache.org/job/Ambari-trunk-test-patch/6906//console
>
>
> Thanks,
>
> Juanjo Marron
>
>
