Re: Review Request 47705: AMBARI-16731 Should close file object in security.py

2016-06-01 Thread Masahiro Tanaka

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47705/#review135888
---



Could anyone review this? I think this isn't a difficult patch.

- Masahiro Tanaka


On 5月 29, 2016, 2:55 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47705/
> ---
> 
> (Updated 5月 29, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-16731
> https://issues.apache.org/jira/browse/AMBARI-16731
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> reqSignCrt method opens CSR file with open function but that doesn't close it.
> And, loadSrvrCrt method opens a file but this is unclosed too.
> They waste resources and may cause a problem
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 779b85c 
> 
> Diff: https://reviews.apache.org/r/47705/diff/
> 
> 
> Testing
> ---
> 
> mvn -fae clean install
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>



Review Request 47705: AMBARI-16731 Should close file object in security.py

2016-05-22 Thread Masahiro Tanaka

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47705/
---

Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sid Wagle.


Bugs: AMBARI-16731
https://issues.apache.org/jira/browse/AMBARI-16731


Repository: ambari


Description
---

reqSignCrt method opens CSR file with open function but that doesn't close it.
And, loadSrvrCrt method opens a file but this is unclosed too.
They waste resources and may cause a problem


Diffs
-

  ambari-agent/src/main/python/ambari_agent/security.py 779b85c 

Diff: https://reviews.apache.org/r/47705/diff/


Testing
---

mvn -fae clean install


Thanks,

Masahiro Tanaka