Re: Review Request 48545: View config- Allows remote cluster creation using a user having no permissions on the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48545/#review137476 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 10, 2016, 12:15 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48545/ > --- > > (Updated June 10, 2016, 12:15 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17162 > https://issues.apache.org/jira/browse/AMBARI-17162 > > > Repository: ambari > > > Description > --- > > Added permission check for user (ambari/cluster admin) before save/update of > remote cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java > 1135424 > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java > c0c887f > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 90144e2 > > ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java > 2b6e014 > > Diff: https://reviews.apache.org/r/48545/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 48545: View config- Allows remote cluster creation using a user having no permissions on the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48545/#review137262 --- Ship it! Ship It! - Nitiraj Rathore On June 10, 2016, 12:15 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48545/ > --- > > (Updated June 10, 2016, 12:15 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17162 > https://issues.apache.org/jira/browse/AMBARI-17162 > > > Repository: ambari > > > Description > --- > > Added permission check for user (ambari/cluster admin) before save/update of > remote cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java > 1135424 > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java > c0c887f > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 90144e2 > > ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java > 2b6e014 > > Diff: https://reviews.apache.org/r/48545/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Review Request 48545: View config- Allows remote cluster creation using a user having no permissions on the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48545/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Bugs: AMBARI-17162 https://issues.apache.org/jira/browse/AMBARI-17162 Repository: ambari Description --- Added permission check for user (ambari/cluster admin) before save/update of remote cluster. Diffs - ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java 1135424 ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java c0c887f ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 90144e2 ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java 2b6e014 Diff: https://reviews.apache.org/r/48545/diff/ Testing --- Manually Tested Thanks, Gaurav Nagar